GeoRoutesMiddleware::getCountries() - Code Metrics - Inspection of "Global middleware" - LaraCrafts/laravel-geo-routes - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#19)

by Choraimy

created 2019-01-26 18:42 UTC

GeoRoutesMiddleware::getCountries() A

↳ Parent: GeoRoutesMiddleware

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	3
rs	10
c	0
b	0
f	0
ccs	2
cts	2
cp	1
crap	1

<?php

namespace LaraCrafts\GeoRoutes\Http\Middleware;

use Closure;
use Illuminate\Http\Request;
use LaraCrafts\GeoRoutes\DeterminesGeoAccess;

class GeoRoutesMiddleware
{
    use DeterminesGeoAccess;


    protected $countries;
    protected $strategy;

    /**
     * Handle an incoming request.
     *
     * @param \Illuminate\Http\Request $request
     * @param \Closure $next
     * @param string $strategy
     * @param string $countries
     * @param string|null $callback
     * @return mixed
     */
    public function handle(Request $request, Closure $next, string $strategy, string $countries, string $callback = null)
    {
        $this->countries = explode('&', $countries);
        $this->strategy = $strategy;

        if ($this->shouldHaveAccess($request)) {
            return $next($request);
        }

        if ($callback && $callback = unserialize($callback)) {
            return call_user_func_array($callback[0], $callback[1] ?? []);
        }

        return abort(401);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }

    /**
     * Get the countries.
     *
     * @return string[]
     */
    public function getCountries()
    {
        return $this->countries;
    }

    /**
     * Get the strategy.
     *
     * @return string
     */
    public function getStrategy()
    {
        return $this->strategy;
    }
}


1		<?php
2
3		namespace LaraCrafts\GeoRoutes\Http\Middleware;
4
5		use Closure;
6		use Illuminate\Http\Request;
7		use LaraCrafts\GeoRoutes\DeterminesGeoAccess;
8
9		class GeoRoutesMiddleware
10		{
11		use DeterminesGeoAccess;
		0 ignored issues – show Bug introduced 2019-01-26 18:57 UTC by Report Bug Copy Issue Report The trait `LaraCrafts\GeoRoutes\DeterminesGeoAccess` requires the property `$countryCode` which is not provided by `LaraCrafts\GeoRoutes\Htt...are\GeoRoutesMiddleware`. Loading history...
12
13		protected $countries;
14		protected $strategy;
15
16		/**
17		* Handle an incoming request.
18		*
19		* @param \Illuminate\Http\Request $request
20		* @param \Closure $next
21		* @param string $strategy
22		* @param string $countries
23		* @param string\|null $callback
24		* @return mixed
25		*/
26	15	public function handle(Request $request, Closure $next, string $strategy, string $countries, string $callback = null)
27		{
28	15	$this->countries = explode('&', $countries);
29	15	$this->strategy = $strategy;
30
31	15	if ($this->shouldHaveAccess($request)) {
32	3	return $next($request);
33		}
34
35	12	if ($callback && $callback = unserialize($callback)) {
36	7	return call_user_func_array($callback[0], $callback[1] ?? []);
37		}
38
39	5	return abort(401);
		0 ignored issues – show Bug introduced 2019-01-17 22:17 UTC by Report Bug Copy Issue Report Are you sure the usage of `abort(401)` is correct as it seems to always return `null`. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
40		}
41
42		/**
43		* Get the countries.
44		*
45		* @return string[]
46		*/
47	15	public function getCountries()
48		{
49	15	return $this->countries;
50		}
51
52		/**
53		* Get the strategy.
54		*
55		* @return string
56		*/
57	15	public function getStrategy()
58		{
59	15	return $this->strategy;
60		}
61		}
62

LaraCrafts / laravel-geo-routes

Pull Request — master (#19)

GeoRoutesMiddleware::getCountries() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like