LaraCrafts\GeoRoutes\Http\Middleware\GeoRoutesMiddleware

Complexity

Total Complexity

6

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getCountries()	0	3	1
A	handle()	0	14	4
A	getStrategy()	0	3	1

<?php

namespace LaraCrafts\GeoRoutes\Http\Middleware;

use Closure;
use Illuminate\Http\Request;
use LaraCrafts\GeoRoutes\DeterminesGeoAccess;

class GeoRoutesMiddleware
{
    use DeterminesGeoAccess;

The trait LaraCrafts\GeoRoutes\DeterminesGeoAccess requires the property $countryCode which is not provided by LaraCrafts\GeoRoutes\Http\Middleware\GeoRoutesMiddleware.

    protected $countries;
    protected $strategy;

    /**
     * Handle an incoming request.
     *
     * @param \Illuminate\Http\Request $request
     * @param \Closure $next
     * @param string $strategy
     * @param string $countries
     * @param string|null $callback
     * @return mixed
     */
    public function handle(Request $request, Closure $next, string $strategy, string $countries, string $callback = null)
    {
        $this->countries = explode('&', $countries);
        $this->strategy = $strategy;

        if ($this->shouldHaveAccess($request)) {
            return $next($request);
        }

        if ($callback && $callback = unserialize($callback)) {
            return call_user_func_array($callback[0], $callback[1] ?? []);
        }

        return abort(401);

Are you sure the usage of abort(401) is correct as it seems to always return null.

    }

    /**
     * Get the countries.
     *
     * @return string[]
     */
    public function getCountries()
    {
        return $this->countries;
    }

    /**
     * Get the strategy.
     *
     * @return string
     */
    public function getStrategy()
    {
        return $this->strategy;
    }
}