Inspection of "Stop processing when we encounter the end of the s..." - LTD-Beget/dns-zone-tokenizer - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Pull Request — master (#20)

unknown

created 2020-10-19 12:37 UTC

Status

Spacing +37 added lines, -37 removed lines patch added patch discarded remove patch

@@ -100,7 +100,7 @@  discard block
 block discarded – undo
      */
     public function __construct(StringStream $stream, string $type)
     {
-        if (! self::isKnownType($type)) {
+        if (!self::isKnownType($type)) {
             throw new SyntaxErrorException($stream);
         }
 
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
      */
     protected function defaultExtractor(string $tokenName)
     {
-        if($this->multiLineOpened) {
+        if ($this->multiLineOpened) {
             $this->stream->ignoreWhitespace();
         } else {
             $this->stream->ignoreHorizontalSpace();
@@ -152,27 +152,27 @@  discard block
 block discarded – undo
 
         $ord = $this->stream->ord();
 
-        if($ord === AsciiChar::NULL || $this->stream->isEnd()) {
+        if ($ord === AsciiChar::NULL || $this->stream->isEnd()) {
             return;
         }
 
-        if($ord === AsciiChar::OPEN_BRACKET && !$this->commentOpen) {
+        if ($ord === AsciiChar::OPEN_BRACKET && !$this->commentOpen) {
             $this->multiLineOpened = true;
             $this->stream->next();
             goto start;
-        } elseif($this->multiLineOpened && !$this->commentOpen && $ord === AsciiChar::CLOSE_BRACKET) {
+        } elseif ($this->multiLineOpened && !$this->commentOpen && $ord === AsciiChar::CLOSE_BRACKET) {
             $this->multiLineOpened = false;
             $this->stream->next();
             goto start;
-        } elseif($this->multiLineOpened && !$this->commentOpen && $ord === AsciiChar::LINE_FEED) {
+        } elseif ($this->multiLineOpened && !$this->commentOpen && $ord === AsciiChar::LINE_FEED) {
             $this->stream->next();
             goto start;
-        } elseif($ord === AsciiChar::LINE_FEED && !$this->commentOpen) {
+        } elseif ($ord === AsciiChar::LINE_FEED && !$this->commentOpen) {
             return;
         } else {
-            if($ord === AsciiChar::SEMICOLON) {
+            if ($ord === AsciiChar::SEMICOLON) {
                 $this->stream->previous();
-                if($this->stream->currentAscii()->isHorizontalSpace()) {
+                if ($this->stream->currentAscii()->isHorizontalSpace()) {
 
                     $this->commentOpen = true;
                     $this->stream->next();
@@ -183,25 +183,25 @@  discard block
 block discarded – undo
                     $this->stream->next();
                 }
                 goto start;
-            } elseif(($this->stream->currentAscii()->isVerticalSpace() || $ord === AsciiChar::NULL) && $this->commentOpen) {
+            } elseif (($this->stream->currentAscii()->isVerticalSpace() || $ord === AsciiChar::NULL) && $this->commentOpen) {
                 $this->stream->next();
                 $this->stream->ignoreHorizontalSpace();
                 $this->commentOpen = false;
                 goto start;
-            } elseif($this->commentOpen) {
+            } elseif ($this->commentOpen) {
                 $this->commentOpen = true;
                 $this->ignoreComment();
                 goto start;
-            } elseif(!$this->commentOpen) {
-                if($ord === AsciiChar::SPACE && $this->tokens[$tokenName] === '') {
+            } elseif (!$this->commentOpen) {
+                if ($ord === AsciiChar::SPACE && $this->tokens[$tokenName] === '') {
                     $this->stream->next();
                     goto start;
-                } elseif($this->stream->currentAscii()->isWhiteSpace()) {
+                } elseif ($this->stream->currentAscii()->isWhiteSpace()) {
                     return;
                 } else {
                     $this->tokens[$tokenName] .= $this->stream->current();
                     $this->stream->next();
-                    if($this->stream->isEnd()) {
+                    if ($this->stream->isEnd()) {
                         $this->tokens[$tokenName] = trim($this->tokens[$tokenName]);
                     }
                     goto start;
@@ -223,15 +223,15 @@  discard block
 block discarded – undo
     {
         start:
         $ord = $this->stream->ord();
-        if($ord === AsciiChar::NULL) {
+        if ($ord === AsciiChar::NULL) {
             return;
         }
-        if($ord === AsciiChar::SEMICOLON) {
+        if ($ord === AsciiChar::SEMICOLON) {
             $this->stream->next();
             $this->commentOpen = true;
             goto start;
-        } elseif($this->commentOpen) {
-            if($ord === AsciiChar::NULL() || $ord === AsciiChar::LINE_FEED) {
+        } elseif ($this->commentOpen) {
+            if ($ord === AsciiChar::NULL() || $ord === AsciiChar::LINE_FEED) {
                 $this->commentOpen = false;
                 goto start;
             } else {
@@ -239,14 +239,14 @@  discard block
 block discarded – undo
                 $this->commentOpen = true;
                 goto start;
             }
-        } elseif(!$this->commentOpen)  {
-            if($this->multiLineOpened) {
-                if($ord === AsciiChar::CLOSE_BRACKET) {
+        } elseif (!$this->commentOpen) {
+            if ($this->multiLineOpened) {
+                if ($ord === AsciiChar::CLOSE_BRACKET) {
                     $this->multiLineOpened = false;
                 }
                 $this->stream->next();
                 goto start;
-            } elseif($ord === AsciiChar::NULL() || $ord === AsciiChar::LINE_FEED) {
+            } elseif ($ord === AsciiChar::NULL() || $ord === AsciiChar::LINE_FEED) {
                 return;
             }
         }
@@ -265,53 +265,53 @@  discard block
 block discarded – undo
         $ord = $this->stream->ord();
         $this->stream->next();
 
-        if($ord === 0) { // if end of record
+        if ($ord === 0) { // if end of record
             return;
         }
 
         // comment starts
-        if($ord === 59) {
+        if ($ord === 59) {
             $this->commentOpen = true;
             goto start;
-        } elseif($this->commentOpen === true && $ord !== 10) {
+        } elseif ($this->commentOpen === true && $ord !== 10) {
             $this->commentOpen = true;
             goto start;
-        } elseif($this->commentOpen === true && ($ord === 10 || $ord === 0)) {
+        } elseif ($this->commentOpen === true && ($ord === 10 || $ord === 0)) {
             $this->stream->previous();
             $this->commentOpen = false;
             goto start;
         } else {
             // ignore blanck line
-            if($ord === 32) {
+            if ($ord === 32) {
                 goto start;
             }
 
             // Find starts of char set
-            if($ord === 34 && !$this->commentOpen) { // "
+            if ($ord === 34 && !$this->commentOpen) { // "
                 $this->extractCharSet($tokenName);
             }
 
             // multi line opened
-            if($ord === 40 && !$this->commentOpen) {
+            if ($ord === 40 && !$this->commentOpen) {
                 $this->multiLineOpened = true;
                 goto start;
             }
 
             // multi line closed
-            if($this->multiLineOpened && !$this->commentOpen && $ord === 41) {
+            if ($this->multiLineOpened && !$this->commentOpen && $ord === 41) {
                 $this->multiLineOpened = false;
                 goto start;
             }
 
             // comment end in multi line TXT record
-            if($ord === 10 && $this->commentOpen && $this->multiLineOpened) {
+            if ($ord === 10 && $this->commentOpen && $this->multiLineOpened) {
                 goto start;
             }
 
             // is record ends?
-            if(!$this->multiLineOpened && ($ord === 10 || $ord === 0)) {
+            if (!$this->multiLineOpened && ($ord === 10 || $ord === 0)) {
                 return;
-            } elseif($this->multiLineOpened && $ord === 10) {
+            } elseif ($this->multiLineOpened && $ord === 10) {
                 goto start;
             }
         }
@@ -327,14 +327,14 @@  discard block
 block discarded – undo
         $ord = $this->stream->ord();
         $this->stream->next();
 
-        if($ord === AsciiChar::NULL) { // if end of record
+        if ($ord === AsciiChar::NULL) { // if end of record
             throw new SyntaxErrorException($this->stream);
         }
 
-        if(!$escaping_open && $ord === 34) {
+        if (!$escaping_open && $ord === 34) {
             $this->txtExtractor($tokenName);
         } else {
-            if($ord === AsciiChar::LINE_FEED || $ord === AsciiChar::VERTICAL_TAB || $ord === AsciiChar::NULL) {
+            if ($ord === AsciiChar::LINE_FEED || $ord === AsciiChar::VERTICAL_TAB || $ord === AsciiChar::NULL) {
                 $this->stream->previous();
                 throw new SyntaxErrorException($this->stream);
             }

Please login to merge, or discard this patch.

		@@ -100,7 +100,7 @@ discard block
		block discarded – undo
100	100	*/
101	101	public function __construct(StringStream $stream, string $type)
102	102	{
103		- if (! self::isKnownType($type)) {
	103	+ if (!self::isKnownType($type)) {
104	104	throw new SyntaxErrorException($stream);
105	105	}
106	106
		@@ -136,7 +136,7 @@ discard block
		block discarded – undo
136	136	*/
137	137	protected function defaultExtractor(string $tokenName)
138	138	{
139		- if($this->multiLineOpened) {
	139	+ if ($this->multiLineOpened) {
140	140	$this->stream->ignoreWhitespace();
141	141	} else {
142	142	$this->stream->ignoreHorizontalSpace();
		@@ -152,27 +152,27 @@ discard block
		block discarded – undo
152	152
153	153	$ord = $this->stream->ord();
154	154
155		- if($ord === AsciiChar::NULL \|\| $this->stream->isEnd()) {
	155	+ if ($ord === AsciiChar::NULL \|\| $this->stream->isEnd()) {
156	156	return;
157	157	}
158	158
159		- if($ord === AsciiChar::OPEN_BRACKET && !$this->commentOpen) {
	159	+ if ($ord === AsciiChar::OPEN_BRACKET && !$this->commentOpen) {
160	160	$this->multiLineOpened = true;
161	161	$this->stream->next();
162	162	goto start;
163		- } elseif($this->multiLineOpened && !$this->commentOpen && $ord === AsciiChar::CLOSE_BRACKET) {
	163	+ } elseif ($this->multiLineOpened && !$this->commentOpen && $ord === AsciiChar::CLOSE_BRACKET) {
164	164	$this->multiLineOpened = false;
165	165	$this->stream->next();
166	166	goto start;
167		- } elseif($this->multiLineOpened && !$this->commentOpen && $ord === AsciiChar::LINE_FEED) {
	167	+ } elseif ($this->multiLineOpened && !$this->commentOpen && $ord === AsciiChar::LINE_FEED) {
168	168	$this->stream->next();
169	169	goto start;
170		- } elseif($ord === AsciiChar::LINE_FEED && !$this->commentOpen) {
	170	+ } elseif ($ord === AsciiChar::LINE_FEED && !$this->commentOpen) {
171	171	return;
172	172	} else {
173		- if($ord === AsciiChar::SEMICOLON) {
	173	+ if ($ord === AsciiChar::SEMICOLON) {
174	174	$this->stream->previous();
175		- if($this->stream->currentAscii()->isHorizontalSpace()) {
	175	+ if ($this->stream->currentAscii()->isHorizontalSpace()) {
176	176
177	177	$this->commentOpen = true;
178	178	$this->stream->next();
		@@ -183,25 +183,25 @@ discard block
		block discarded – undo
183	183	$this->stream->next();
184	184	}
185	185	goto start;
186		- } elseif(($this->stream->currentAscii()->isVerticalSpace() \|\| $ord === AsciiChar::NULL) && $this->commentOpen) {
	186	+ } elseif (($this->stream->currentAscii()->isVerticalSpace() \|\| $ord === AsciiChar::NULL) && $this->commentOpen) {
187	187	$this->stream->next();
188	188	$this->stream->ignoreHorizontalSpace();
189	189	$this->commentOpen = false;
190	190	goto start;
191		- } elseif($this->commentOpen) {
	191	+ } elseif ($this->commentOpen) {
192	192	$this->commentOpen = true;
193	193	$this->ignoreComment();
194	194	goto start;
195		- } elseif(!$this->commentOpen) {
196		- if($ord === AsciiChar::SPACE && $this->tokens[$tokenName] === '') {
	195	+ } elseif (!$this->commentOpen) {
	196	+ if ($ord === AsciiChar::SPACE && $this->tokens[$tokenName] === '') {
197	197	$this->stream->next();
198	198	goto start;
199		- } elseif($this->stream->currentAscii()->isWhiteSpace()) {
	199	+ } elseif ($this->stream->currentAscii()->isWhiteSpace()) {
200	200	return;
201	201	} else {
202	202	$this->tokens[$tokenName] .= $this->stream->current();
203	203	$this->stream->next();
204		- if($this->stream->isEnd()) {
	204	+ if ($this->stream->isEnd()) {
205	205	$this->tokens[$tokenName] = trim($this->tokens[$tokenName]);
206	206	}
207	207	goto start;
		@@ -223,15 +223,15 @@ discard block
		block discarded – undo
223	223	{
224	224	start:
225	225	$ord = $this->stream->ord();
226		- if($ord === AsciiChar::NULL) {
	226	+ if ($ord === AsciiChar::NULL) {
227	227	return;
228	228	}
229		- if($ord === AsciiChar::SEMICOLON) {
	229	+ if ($ord === AsciiChar::SEMICOLON) {
230	230	$this->stream->next();
231	231	$this->commentOpen = true;
232	232	goto start;
233		- } elseif($this->commentOpen) {
234		- if($ord === AsciiChar::NULL() \|\| $ord === AsciiChar::LINE_FEED) {
	233	+ } elseif ($this->commentOpen) {
	234	+ if ($ord === AsciiChar::NULL() \|\| $ord === AsciiChar::LINE_FEED) {
235	235	$this->commentOpen = false;
236	236	goto start;
237	237	} else {
		@@ -239,14 +239,14 @@ discard block
		block discarded – undo
239	239	$this->commentOpen = true;
240	240	goto start;
241	241	}
242		- } elseif(!$this->commentOpen) {
243		- if($this->multiLineOpened) {
244		- if($ord === AsciiChar::CLOSE_BRACKET) {
	242	+ } elseif (!$this->commentOpen) {
	243	+ if ($this->multiLineOpened) {
	244	+ if ($ord === AsciiChar::CLOSE_BRACKET) {
245	245	$this->multiLineOpened = false;
246	246	}
247	247	$this->stream->next();
248	248	goto start;
249		- } elseif($ord === AsciiChar::NULL() \|\| $ord === AsciiChar::LINE_FEED) {
	249	+ } elseif ($ord === AsciiChar::NULL() \|\| $ord === AsciiChar::LINE_FEED) {
250	250	return;
251	251	}
252	252	}
		@@ -265,53 +265,53 @@ discard block
		block discarded – undo
265	265	$ord = $this->stream->ord();
266	266	$this->stream->next();
267	267
268		- if($ord === 0) { // if end of record
	268	+ if ($ord === 0) { // if end of record
269	269	return;
270	270	}
271	271
272	272	// comment starts
273		- if($ord === 59) {
	273	+ if ($ord === 59) {
274	274	$this->commentOpen = true;
275	275	goto start;
276		- } elseif($this->commentOpen === true && $ord !== 10) {
	276	+ } elseif ($this->commentOpen === true && $ord !== 10) {
277	277	$this->commentOpen = true;
278	278	goto start;
279		- } elseif($this->commentOpen === true && ($ord === 10 \|\| $ord === 0)) {
	279	+ } elseif ($this->commentOpen === true && ($ord === 10 \|\| $ord === 0)) {
280	280	$this->stream->previous();
281	281	$this->commentOpen = false;
282	282	goto start;
283	283	} else {
284	284	// ignore blanck line
285		- if($ord === 32) {
	285	+ if ($ord === 32) {
286	286	goto start;
287	287	}
288	288
289	289	// Find starts of char set
290		- if($ord === 34 && !$this->commentOpen) { // "
	290	+ if ($ord === 34 && !$this->commentOpen) { // "
291	291	$this->extractCharSet($tokenName);
292	292	}
293	293
294	294	// multi line opened
295		- if($ord === 40 && !$this->commentOpen) {
	295	+ if ($ord === 40 && !$this->commentOpen) {
296	296	$this->multiLineOpened = true;
297	297	goto start;
298	298	}
299	299
300	300	// multi line closed
301		- if($this->multiLineOpened && !$this->commentOpen && $ord === 41) {
	301	+ if ($this->multiLineOpened && !$this->commentOpen && $ord === 41) {
302	302	$this->multiLineOpened = false;
303	303	goto start;
304	304	}
305	305
306	306	// comment end in multi line TXT record
307		- if($ord === 10 && $this->commentOpen && $this->multiLineOpened) {
	307	+ if ($ord === 10 && $this->commentOpen && $this->multiLineOpened) {
308	308	goto start;
309	309	}
310	310
311	311	// is record ends?
312		- if(!$this->multiLineOpened && ($ord === 10 \|\| $ord === 0)) {
	312	+ if (!$this->multiLineOpened && ($ord === 10 \|\| $ord === 0)) {
313	313	return;
314		- } elseif($this->multiLineOpened && $ord === 10) {
	314	+ } elseif ($this->multiLineOpened && $ord === 10) {
315	315	goto start;
316	316	}
317	317	}
		@@ -327,14 +327,14 @@ discard block
		block discarded – undo
327	327	$ord = $this->stream->ord();
328	328	$this->stream->next();
329	329
330		- if($ord === AsciiChar::NULL) { // if end of record
	330	+ if ($ord === AsciiChar::NULL) { // if end of record
331	331	throw new SyntaxErrorException($this->stream);
332	332	}
333	333
334		- if(!$escaping_open && $ord === 34) {
	334	+ if (!$escaping_open && $ord === 34) {
335	335	$this->txtExtractor($tokenName);
336	336	} else {
337		- if($ord === AsciiChar::LINE_FEED \|\| $ord === AsciiChar::VERTICAL_TAB \|\| $ord === AsciiChar::NULL) {
	337	+ if ($ord === AsciiChar::LINE_FEED \|\| $ord === AsciiChar::VERTICAL_TAB \|\| $ord === AsciiChar::NULL) {
338	338	$this->stream->previous();
339	339	throw new SyntaxErrorException($this->stream);
340	340	}

LTD-Beget / dns-zone-tokenizer

Pull Request — master (#20)

Status

Category

Spacing +37 added lines, -37 removed lines patch added patch discarded remove patch