Inspection of "fix-7.4" - LTD-Beget/dns-zone-tokenizer - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Pull Request — master (#21)

by Alexandr

created 2020-11-24 12:51 UTC

Status

Spacing +37 added lines, -37 removed lines patch added patch discarded remove patch

@@ -100,7 +100,7 @@  discard block
 block discarded – undo
      */
     public function __construct(StringStream $stream, string $type)
     {
-        if (! self::isKnownType($type)) {
+        if (!self::isKnownType($type)) {
             throw new SyntaxErrorException($stream);
         }
 
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
      */
     protected function defaultExtractor(string $tokenName)
     {
-        if($this->multiLineOpened) {
+        if ($this->multiLineOpened) {
             $this->stream->ignoreWhitespace();
         } else {
             $this->stream->ignoreHorizontalSpace();
@@ -150,28 +150,28 @@  discard block
 block discarded – undo
         
         start:
 
-        if ($this->stream->isEnd()){
+        if ($this->stream->isEnd()) {
             return;
         }
         $ord = $this->stream->ord();
 
-        if($ord === AsciiChar::OPEN_BRACKET && !$this->commentOpen) {
+        if ($ord === AsciiChar::OPEN_BRACKET && !$this->commentOpen) {
             $this->multiLineOpened = true;
             $this->stream->next();
             goto start;
-        } elseif($this->multiLineOpened && !$this->commentOpen && $ord === AsciiChar::CLOSE_BRACKET) {
+        } elseif ($this->multiLineOpened && !$this->commentOpen && $ord === AsciiChar::CLOSE_BRACKET) {
             $this->multiLineOpened = false;
             $this->stream->next();
             goto start;
-        } elseif($this->multiLineOpened && !$this->commentOpen && $ord === AsciiChar::LINE_FEED) {
+        } elseif ($this->multiLineOpened && !$this->commentOpen && $ord === AsciiChar::LINE_FEED) {
             $this->stream->next();
             goto start;
-        } elseif($ord === AsciiChar::LINE_FEED && !$this->commentOpen) {
+        } elseif ($ord === AsciiChar::LINE_FEED && !$this->commentOpen) {
             return;
         } else {
-            if($ord === AsciiChar::SEMICOLON) {
+            if ($ord === AsciiChar::SEMICOLON) {
                 $this->stream->previous();
-                if($this->stream->currentAscii()->isHorizontalSpace()) {
+                if ($this->stream->currentAscii()->isHorizontalSpace()) {
 
                     $this->commentOpen = true;
                     $this->stream->next();
@@ -182,25 +182,25 @@  discard block
 block discarded – undo
                     $this->stream->next();
                 }
                 goto start;
-            } elseif(($this->stream->currentAscii()->isVerticalSpace() || $ord === AsciiChar::NULL) && $this->commentOpen) {
+            } elseif (($this->stream->currentAscii()->isVerticalSpace() || $ord === AsciiChar::NULL) && $this->commentOpen) {
                 $this->stream->next();
                 $this->stream->ignoreHorizontalSpace();
                 $this->commentOpen = false;
                 goto start;
-            } elseif($this->commentOpen) {
+            } elseif ($this->commentOpen) {
                 $this->commentOpen = true;
                 $this->ignoreComment();
                 goto start;
-            } elseif(!$this->commentOpen) {
-                if($ord === AsciiChar::SPACE && $this->tokens[$tokenName] === '') {
+            } elseif (!$this->commentOpen) {
+                if ($ord === AsciiChar::SPACE && $this->tokens[$tokenName] === '') {
                     $this->stream->next();
                     goto start;
-                } elseif($this->stream->currentAscii()->isWhiteSpace()) {
+                } elseif ($this->stream->currentAscii()->isWhiteSpace()) {
                     return;
                 } else {
                     $this->tokens[$tokenName] .= $this->stream->current();
                     $this->stream->next();
-                    if($this->stream->isEnd()) {
+                    if ($this->stream->isEnd()) {
                         $this->tokens[$tokenName] = trim($this->tokens[$tokenName]);
                     }
                     goto start;
@@ -222,15 +222,15 @@  discard block
 block discarded – undo
     {
         start:
         $ord = $this->stream->ord();
-        if($ord === AsciiChar::NULL) {
+        if ($ord === AsciiChar::NULL) {
             return;
         }
-        if($ord === AsciiChar::SEMICOLON) {
+        if ($ord === AsciiChar::SEMICOLON) {
             $this->stream->next();
             $this->commentOpen = true;
             goto start;
-        } elseif($this->commentOpen) {
-            if($ord === AsciiChar::NULL() || $ord === AsciiChar::LINE_FEED) {
+        } elseif ($this->commentOpen) {
+            if ($ord === AsciiChar::NULL() || $ord === AsciiChar::LINE_FEED) {
                 $this->commentOpen = false;
                 goto start;
             } else {
@@ -238,14 +238,14 @@  discard block
 block discarded – undo
                 $this->commentOpen = true;
                 goto start;
             }
-        } elseif(!$this->commentOpen)  {
-            if($this->multiLineOpened) {
-                if($ord === AsciiChar::CLOSE_BRACKET) {
+        } elseif (!$this->commentOpen) {
+            if ($this->multiLineOpened) {
+                if ($ord === AsciiChar::CLOSE_BRACKET) {
                     $this->multiLineOpened = false;
                 }
                 $this->stream->next();
                 goto start;
-            } elseif($ord === AsciiChar::NULL() || $ord === AsciiChar::LINE_FEED) {
+            } elseif ($ord === AsciiChar::NULL() || $ord === AsciiChar::LINE_FEED) {
                 return;
             }
         }
@@ -264,53 +264,53 @@  discard block
 block discarded – undo
         $ord = $this->stream->ord();
         $this->stream->next();
 
-        if($ord === 0) { // if end of record
+        if ($ord === 0) { // if end of record
             return;
         }
 
         // comment starts
-        if($ord === 59) {
+        if ($ord === 59) {
             $this->commentOpen = true;
             goto start;
-        } elseif($this->commentOpen === true && $ord !== 10) {
+        } elseif ($this->commentOpen === true && $ord !== 10) {
             $this->commentOpen = true;
             goto start;
-        } elseif($this->commentOpen === true && ($ord === 10 || $ord === 0)) {
+        } elseif ($this->commentOpen === true && ($ord === 10 || $ord === 0)) {
             $this->stream->previous();
             $this->commentOpen = false;
             goto start;
         } else {
             // ignore blanck line
-            if($ord === 32) {
+            if ($ord === 32) {
                 goto start;
             }
 
             // Find starts of char set
-            if($ord === 34 && !$this->commentOpen) { // "
+            if ($ord === 34 && !$this->commentOpen) { // "
                 $this->extractCharSet($tokenName);
             }
 
             // multi line opened
-            if($ord === 40 && !$this->commentOpen) {
+            if ($ord === 40 && !$this->commentOpen) {
                 $this->multiLineOpened = true;
                 goto start;
             }
 
             // multi line closed
-            if($this->multiLineOpened && !$this->commentOpen && $ord === 41) {
+            if ($this->multiLineOpened && !$this->commentOpen && $ord === 41) {
                 $this->multiLineOpened = false;
                 goto start;
             }
 
             // comment end in multi line TXT record
-            if($ord === 10 && $this->commentOpen && $this->multiLineOpened) {
+            if ($ord === 10 && $this->commentOpen && $this->multiLineOpened) {
                 goto start;
             }
 
             // is record ends?
-            if(!$this->multiLineOpened && ($ord === 10 || $ord === 0)) {
+            if (!$this->multiLineOpened && ($ord === 10 || $ord === 0)) {
                 return;
-            } elseif($this->multiLineOpened && $ord === 10) {
+            } elseif ($this->multiLineOpened && $ord === 10) {
                 goto start;
             }
         }
@@ -326,14 +326,14 @@  discard block
 block discarded – undo
         $ord = $this->stream->ord();
         $this->stream->next();
 
-        if($ord === AsciiChar::NULL) { // if end of record
+        if ($ord === AsciiChar::NULL) { // if end of record
             throw new SyntaxErrorException($this->stream);
         }
 
-        if(!$escaping_open && $ord === 34) {
+        if (!$escaping_open && $ord === 34) {
             $this->txtExtractor($tokenName);
         } else {
-            if($ord === AsciiChar::LINE_FEED || $ord === AsciiChar::VERTICAL_TAB || $ord === AsciiChar::NULL) {
+            if ($ord === AsciiChar::LINE_FEED || $ord === AsciiChar::VERTICAL_TAB || $ord === AsciiChar::NULL) {
                 $this->stream->previous();
                 throw new SyntaxErrorException($this->stream);
             }

Please login to merge, or discard this patch.

		@@ -100,7 +100,7 @@ discard block
		block discarded – undo
100	100	*/
101	101	public function __construct(StringStream $stream, string $type)
102	102	{
103		- if (! self::isKnownType($type)) {
	103	+ if (!self::isKnownType($type)) {
104	104	throw new SyntaxErrorException($stream);
105	105	}
106	106
		@@ -136,7 +136,7 @@ discard block
		block discarded – undo
136	136	*/
137	137	protected function defaultExtractor(string $tokenName)
138	138	{
139		- if($this->multiLineOpened) {
	139	+ if ($this->multiLineOpened) {
140	140	$this->stream->ignoreWhitespace();
141	141	} else {
142	142	$this->stream->ignoreHorizontalSpace();
		@@ -150,28 +150,28 @@ discard block
		block discarded – undo
150	150
151	151	start:
152	152
153		- if ($this->stream->isEnd()){
	153	+ if ($this->stream->isEnd()) {
154	154	return;
155	155	}
156	156	$ord = $this->stream->ord();
157	157
158		- if($ord === AsciiChar::OPEN_BRACKET && !$this->commentOpen) {
	158	+ if ($ord === AsciiChar::OPEN_BRACKET && !$this->commentOpen) {
159	159	$this->multiLineOpened = true;
160	160	$this->stream->next();
161	161	goto start;
162		- } elseif($this->multiLineOpened && !$this->commentOpen && $ord === AsciiChar::CLOSE_BRACKET) {
	162	+ } elseif ($this->multiLineOpened && !$this->commentOpen && $ord === AsciiChar::CLOSE_BRACKET) {
163	163	$this->multiLineOpened = false;
164	164	$this->stream->next();
165	165	goto start;
166		- } elseif($this->multiLineOpened && !$this->commentOpen && $ord === AsciiChar::LINE_FEED) {
	166	+ } elseif ($this->multiLineOpened && !$this->commentOpen && $ord === AsciiChar::LINE_FEED) {
167	167	$this->stream->next();
168	168	goto start;
169		- } elseif($ord === AsciiChar::LINE_FEED && !$this->commentOpen) {
	169	+ } elseif ($ord === AsciiChar::LINE_FEED && !$this->commentOpen) {
170	170	return;
171	171	} else {
172		- if($ord === AsciiChar::SEMICOLON) {
	172	+ if ($ord === AsciiChar::SEMICOLON) {
173	173	$this->stream->previous();
174		- if($this->stream->currentAscii()->isHorizontalSpace()) {
	174	+ if ($this->stream->currentAscii()->isHorizontalSpace()) {
175	175
176	176	$this->commentOpen = true;
177	177	$this->stream->next();
		@@ -182,25 +182,25 @@ discard block
		block discarded – undo
182	182	$this->stream->next();
183	183	}
184	184	goto start;
185		- } elseif(($this->stream->currentAscii()->isVerticalSpace() \|\| $ord === AsciiChar::NULL) && $this->commentOpen) {
	185	+ } elseif (($this->stream->currentAscii()->isVerticalSpace() \|\| $ord === AsciiChar::NULL) && $this->commentOpen) {
186	186	$this->stream->next();
187	187	$this->stream->ignoreHorizontalSpace();
188	188	$this->commentOpen = false;
189	189	goto start;
190		- } elseif($this->commentOpen) {
	190	+ } elseif ($this->commentOpen) {
191	191	$this->commentOpen = true;
192	192	$this->ignoreComment();
193	193	goto start;
194		- } elseif(!$this->commentOpen) {
195		- if($ord === AsciiChar::SPACE && $this->tokens[$tokenName] === '') {
	194	+ } elseif (!$this->commentOpen) {
	195	+ if ($ord === AsciiChar::SPACE && $this->tokens[$tokenName] === '') {
196	196	$this->stream->next();
197	197	goto start;
198		- } elseif($this->stream->currentAscii()->isWhiteSpace()) {
	198	+ } elseif ($this->stream->currentAscii()->isWhiteSpace()) {
199	199	return;
200	200	} else {
201	201	$this->tokens[$tokenName] .= $this->stream->current();
202	202	$this->stream->next();
203		- if($this->stream->isEnd()) {
	203	+ if ($this->stream->isEnd()) {
204	204	$this->tokens[$tokenName] = trim($this->tokens[$tokenName]);
205	205	}
206	206	goto start;
		@@ -222,15 +222,15 @@ discard block
		block discarded – undo
222	222	{
223	223	start:
224	224	$ord = $this->stream->ord();
225		- if($ord === AsciiChar::NULL) {
	225	+ if ($ord === AsciiChar::NULL) {
226	226	return;
227	227	}
228		- if($ord === AsciiChar::SEMICOLON) {
	228	+ if ($ord === AsciiChar::SEMICOLON) {
229	229	$this->stream->next();
230	230	$this->commentOpen = true;
231	231	goto start;
232		- } elseif($this->commentOpen) {
233		- if($ord === AsciiChar::NULL() \|\| $ord === AsciiChar::LINE_FEED) {
	232	+ } elseif ($this->commentOpen) {
	233	+ if ($ord === AsciiChar::NULL() \|\| $ord === AsciiChar::LINE_FEED) {
234	234	$this->commentOpen = false;
235	235	goto start;
236	236	} else {
		@@ -238,14 +238,14 @@ discard block
		block discarded – undo
238	238	$this->commentOpen = true;
239	239	goto start;
240	240	}
241		- } elseif(!$this->commentOpen) {
242		- if($this->multiLineOpened) {
243		- if($ord === AsciiChar::CLOSE_BRACKET) {
	241	+ } elseif (!$this->commentOpen) {
	242	+ if ($this->multiLineOpened) {
	243	+ if ($ord === AsciiChar::CLOSE_BRACKET) {
244	244	$this->multiLineOpened = false;
245	245	}
246	246	$this->stream->next();
247	247	goto start;
248		- } elseif($ord === AsciiChar::NULL() \|\| $ord === AsciiChar::LINE_FEED) {
	248	+ } elseif ($ord === AsciiChar::NULL() \|\| $ord === AsciiChar::LINE_FEED) {
249	249	return;
250	250	}
251	251	}
		@@ -264,53 +264,53 @@ discard block
		block discarded – undo
264	264	$ord = $this->stream->ord();
265	265	$this->stream->next();
266	266
267		- if($ord === 0) { // if end of record
	267	+ if ($ord === 0) { // if end of record
268	268	return;
269	269	}
270	270
271	271	// comment starts
272		- if($ord === 59) {
	272	+ if ($ord === 59) {
273	273	$this->commentOpen = true;
274	274	goto start;
275		- } elseif($this->commentOpen === true && $ord !== 10) {
	275	+ } elseif ($this->commentOpen === true && $ord !== 10) {
276	276	$this->commentOpen = true;
277	277	goto start;
278		- } elseif($this->commentOpen === true && ($ord === 10 \|\| $ord === 0)) {
	278	+ } elseif ($this->commentOpen === true && ($ord === 10 \|\| $ord === 0)) {
279	279	$this->stream->previous();
280	280	$this->commentOpen = false;
281	281	goto start;
282	282	} else {
283	283	// ignore blanck line
284		- if($ord === 32) {
	284	+ if ($ord === 32) {
285	285	goto start;
286	286	}
287	287
288	288	// Find starts of char set
289		- if($ord === 34 && !$this->commentOpen) { // "
	289	+ if ($ord === 34 && !$this->commentOpen) { // "
290	290	$this->extractCharSet($tokenName);
291	291	}
292	292
293	293	// multi line opened
294		- if($ord === 40 && !$this->commentOpen) {
	294	+ if ($ord === 40 && !$this->commentOpen) {
295	295	$this->multiLineOpened = true;
296	296	goto start;
297	297	}
298	298
299	299	// multi line closed
300		- if($this->multiLineOpened && !$this->commentOpen && $ord === 41) {
	300	+ if ($this->multiLineOpened && !$this->commentOpen && $ord === 41) {
301	301	$this->multiLineOpened = false;
302	302	goto start;
303	303	}
304	304
305	305	// comment end in multi line TXT record
306		- if($ord === 10 && $this->commentOpen && $this->multiLineOpened) {
	306	+ if ($ord === 10 && $this->commentOpen && $this->multiLineOpened) {
307	307	goto start;
308	308	}
309	309
310	310	// is record ends?
311		- if(!$this->multiLineOpened && ($ord === 10 \|\| $ord === 0)) {
	311	+ if (!$this->multiLineOpened && ($ord === 10 \|\| $ord === 0)) {
312	312	return;
313		- } elseif($this->multiLineOpened && $ord === 10) {
	313	+ } elseif ($this->multiLineOpened && $ord === 10) {
314	314	goto start;
315	315	}
316	316	}
		@@ -326,14 +326,14 @@ discard block
		block discarded – undo
326	326	$ord = $this->stream->ord();
327	327	$this->stream->next();
328	328
329		- if($ord === AsciiChar::NULL) { // if end of record
	329	+ if ($ord === AsciiChar::NULL) { // if end of record
330	330	throw new SyntaxErrorException($this->stream);
331	331	}
332	332
333		- if(!$escaping_open && $ord === 34) {
	333	+ if (!$escaping_open && $ord === 34) {
334	334	$this->txtExtractor($tokenName);
335	335	} else {
336		- if($ord === AsciiChar::LINE_FEED \|\| $ord === AsciiChar::VERTICAL_TAB \|\| $ord === AsciiChar::NULL) {
	336	+ if ($ord === AsciiChar::LINE_FEED \|\| $ord === AsciiChar::VERTICAL_TAB \|\| $ord === AsciiChar::NULL) {
337	337	$this->stream->previous();
338	338	throw new SyntaxErrorException($this->stream);
339	339	}

LTD-Beget / dns-zone-tokenizer

Pull Request — master (#21)

Status

Category

Spacing +37 added lines, -37 removed lines patch added patch discarded remove patch