Issues in PageTemplateConfigurationParserTest.php - All Issues - Inspection of "[MediaBundle] Code improvement found by static cod..." - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( aba493...5356ed )

by Ruud

created 2019-06-11 15:20 UTC

PageTemplateConfigurationParserTest.php (2 issues)

Labels

Documentation 2

Severity

Minor 2

Peter Zentjens 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\PagePartBundle\Tests\PagePartConfigurationReader;

use Kunstmaan\PagePartBundle\PageTemplate\PageTemplate;
use Kunstmaan\PagePartBundle\PageTemplate\PageTemplateConfigurationParser;
use PHPUnit\Framework\TestCase;
use Symfony\Component\HttpKernel\KernelInterface;

class PageTemplateConfigurationParserTest extends TestCase
{
    public function testParseSf4Flow()
    {
        $kernel = $this->createMock(KernelInterface::class);
        $pageTemplateConfigurationParser = new PageTemplateConfigurationParser($kernel, [
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            'contentpage' => [
                'name' => 'Content page',
                'rows' => [
                    ['regions' => [['name' => 'main', 'span' => 12]]],
                ],
                'template' => 'Pages\\ContentPage\\pagetemplate.html.twig',
            ],
        ]);

        $result = $pageTemplateConfigurationParser->parse('contentpage');
        $this->assertInstanceOf(PageTemplate::class, $result);
        $this->assertEquals('Content page', $result->getName());
    }

    public function testParseSf3Flow()
    {
        $kernel = $this->createMock(KernelInterface::class);
        $kernel->method('locateResource')->willReturn(__DIR__ . '/Resources/config/pagetemplates/test.yml');

        $pageTemplateConfigurationParser = new PageTemplateConfigurationParser($kernel, []);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $result = $pageTemplateConfigurationParser->parse('MyWebsiteBundle:test');
        $this->assertInstanceOf(PageTemplate::class, $result);
        $this->assertEquals('Test page', $result->getName());
    }
}


1		<?php
2
3		namespace Kunstmaan\PagePartBundle\Tests\PagePartConfigurationReader;
4
5		use Kunstmaan\PagePartBundle\PageTemplate\PageTemplate;
6		use Kunstmaan\PagePartBundle\PageTemplate\PageTemplateConfigurationParser;
7		use PHPUnit\Framework\TestCase;
8		use Symfony\Component\HttpKernel\KernelInterface;
9
10		class PageTemplateConfigurationParserTest extends TestCase
11		{
12		public function testParseSf4Flow()
13		{
14		$kernel = $this->createMock(KernelInterface::class);
15		$pageTemplateConfigurationParser = new PageTemplateConfigurationParser($kernel, [
		0 ignored issues – show Documentation introduced 2019-03-03 18:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$kernel` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Symfony\Component...Kernel\KernelInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
16		'contentpage' => [
17		'name' => 'Content page',
18		'rows' => [
19		['regions' => [['name' => 'main', 'span' => 12]]],
20		],
21		'template' => 'Pages\\ContentPage\\pagetemplate.html.twig',
22		],
23		]);
24
25		$result = $pageTemplateConfigurationParser->parse('contentpage');
26		$this->assertInstanceOf(PageTemplate::class, $result);
27		$this->assertEquals('Content page', $result->getName());
28		}
29
30	View Code Duplication	public function testParseSf3Flow()
31		{
32		$kernel = $this->createMock(KernelInterface::class);
33		$kernel->method('locateResource')->willReturn(__DIR__ . '/Resources/config/pagetemplates/test.yml');
34
35		$pageTemplateConfigurationParser = new PageTemplateConfigurationParser($kernel, []);
		0 ignored issues – show Documentation introduced 2019-03-03 18:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$kernel` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Symfony\Component...Kernel\KernelInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
36
37		$result = $pageTemplateConfigurationParser->parse('MyWebsiteBundle:test');
38		$this->assertInstanceOf(PageTemplate::class, $result);
39		$this->assertEquals('Test page', $result->getName());
40		}
41		}
42

Kunstmaan / KunstmaanBundlesCMS

Push — master ( aba493...5356ed )

PageTemplateConfigurationParserTest.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like