PageTemplateConfigurationParserTest::testParseSf4Flow() - Code Metrics - Inspection of "[MediaBundle] Code improvement found by static cod..." - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( aba493...5356ed )

by Ruud

created 2019-06-11 15:20 UTC

testParseSf4Flow() A

↳ Parent: PageTemplateConfigurationParserTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	17
rs	9.7
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace Kunstmaan\PagePartBundle\Tests\PagePartConfigurationReader;

use Kunstmaan\PagePartBundle\PageTemplate\PageTemplate;
use Kunstmaan\PagePartBundle\PageTemplate\PageTemplateConfigurationParser;
use PHPUnit\Framework\TestCase;
use Symfony\Component\HttpKernel\KernelInterface;

class PageTemplateConfigurationParserTest extends TestCase
{
    public function testParseSf4Flow()
    {
        $kernel = $this->createMock(KernelInterface::class);
        $pageTemplateConfigurationParser = new PageTemplateConfigurationParser($kernel, [
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            'contentpage' => [
                'name' => 'Content page',
                'rows' => [
                    ['regions' => [['name' => 'main', 'span' => 12]]],
                ],
                'template' => 'Pages\\ContentPage\\pagetemplate.html.twig',
            ],
        ]);

        $result = $pageTemplateConfigurationParser->parse('contentpage');
        $this->assertInstanceOf(PageTemplate::class, $result);
        $this->assertEquals('Content page', $result->getName());
    }

    public function testParseSf3Flow()

    {
        $kernel = $this->createMock(KernelInterface::class);
        $kernel->method('locateResource')->willReturn(__DIR__ . '/Resources/config/pagetemplates/test.yml');

        $pageTemplateConfigurationParser = new PageTemplateConfigurationParser($kernel, []);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $result = $pageTemplateConfigurationParser->parse('MyWebsiteBundle:test');
        $this->assertInstanceOf(PageTemplate::class, $result);
        $this->assertEquals('Test page', $result->getName());
    }
}


1		<?php
2
3		namespace Kunstmaan\PagePartBundle\Tests\PagePartConfigurationReader;
4
5		use Kunstmaan\PagePartBundle\PageTemplate\PageTemplate;
6		use Kunstmaan\PagePartBundle\PageTemplate\PageTemplateConfigurationParser;
7		use PHPUnit\Framework\TestCase;
8		use Symfony\Component\HttpKernel\KernelInterface;
9
10		class PageTemplateConfigurationParserTest extends TestCase
11		{
12		public function testParseSf4Flow()
13		{
14		$kernel = $this->createMock(KernelInterface::class);
15		$pageTemplateConfigurationParser = new PageTemplateConfigurationParser($kernel, [
		0 ignored issues – show Documentation introduced 2019-03-03 18:46 UTC by Report Bug Copy Issue Report `$kernel` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Symfony\Component...Kernel\KernelInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
16		'contentpage' => [
17		'name' => 'Content page',
18		'rows' => [
19		['regions' => [['name' => 'main', 'span' => 12]]],
20		],
21		'template' => 'Pages\\ContentPage\\pagetemplate.html.twig',
22		],
23		]);
24
25		$result = $pageTemplateConfigurationParser->parse('contentpage');
26		$this->assertInstanceOf(PageTemplate::class, $result);
27		$this->assertEquals('Content page', $result->getName());
28		}
29
30	View Code Duplication	public function testParseSf3Flow()
		0 ignored issues – show Duplication introduced 2019-01-21 13:52 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
31		{
32		$kernel = $this->createMock(KernelInterface::class);
33		$kernel->method('locateResource')->willReturn(__DIR__ . '/Resources/config/pagetemplates/test.yml');
34
35		$pageTemplateConfigurationParser = new PageTemplateConfigurationParser($kernel, []);
		0 ignored issues – show Documentation introduced 2019-03-03 18:46 UTC by Report Bug Copy Issue Report `$kernel` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Symfony\Component...Kernel\KernelInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
36
37		$result = $pageTemplateConfigurationParser->parse('MyWebsiteBundle:test');
38		$this->assertInstanceOf(PageTemplate::class, $result);
39		$this->assertEquals('Test page', $result->getName());
40		}
41		}
42

Kunstmaan / KunstmaanBundlesCMS

Push — master ( aba493...5356ed )

testParseSf4Flow() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like