Issues in MenuBuilderTest.php - All Issues - Inspection of "Merge pull request #2335 from acrobat/fixed-remain..." - Kunstmaan/KunstmaanBundlesCMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1de9b7...830752 )

by Kristof

created 2019-02-06 14:09 UTC

Tests/unit/Helper/Menu/MenuBuilderTest.php (2 issues)

Labels

Duplication 2

Severity

Ruud Denivel 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Kunstmaan\AdminBundle\Tests\Helper\Menu;

use Kunstmaan\AdminBundle\Helper\Menu\MenuBuilder;
use Kunstmaan\AdminBundle\Helper\Menu\ModulesMenuAdaptor;
use Kunstmaan\AdminBundle\Helper\Menu\SettingsMenuAdaptor;
use Kunstmaan\AdminBundle\Helper\Menu\SimpleMenuAdaptor;
use Kunstmaan\AdminBundle\Helper\Menu\TopMenuItem;
use Kunstmaan\MenuBundle\Entity\MenuItem;
use Kunstmaan\AdminBundle\Helper\Menu\MenuItem as MenuItemHelper;
use PHPUnit\Framework\TestCase;
use ReflectionClass;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\RequestStack;
use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;

class MenuBuilderTest extends TestCase
{
    /**
     * @var MenuBuilder
     */
    protected $object;

    /**
     * @var ContainerInterface (mock)
     */
    protected $container;

    /**
     * @var AuthorizationCheckerInterface (mock)
     */
    protected $authCheck;

    /**
     * @var RequestStack (mock)
     */
    protected $stack;

    protected function setUp()
    {
        $storage = $this->createMock(TokenStorageInterface::class);
        $authCheck = $this->createMock(AuthorizationCheckerInterface::class);
        $authCheck->tokenStorage = $storage;
        $this->authCheck = $authCheck;
        $container = $this->createMock(ContainerInterface::class);
        $stack = $this->createMock(RequestStack::class);
        $this->stack = $stack;

        $container->expects($this->any())->method('getParameter')->willReturn(true);
        $container->expects($this->any())->method('get')->will($this->onConsecutiveCalls(
            $stack, $stack, $authCheck
        ));

        $this->container = $container;
        $this->object = new MenuBuilder($container);
    }

    /**
     * @throws \ReflectionException
     */
    public function testGetCurrent()
    {
        $this->stack->expects($this->atLeastOnce())
            ->method('getCurrentRequest')
            ->willReturn(new Request([], [], ['_route' => 'KunstmaanAdminBundle_settings']));
        $this->authCheck->expects($this->any())->method('isGranted')->willReturn(true);
        $adapter = new SettingsMenuAdaptor($this->authCheck, true);
        $this->object->addAdaptMenu($adapter);
        $current = $this->object->getCurrent();
        $this->assertInstanceOf(TopMenuItem::class, $current);

        $mirror = new ReflectionClass(MenuBuilder::class);
        $property = $mirror->getProperty('currentCache');
        $property->setAccessible(true);
        $property->setValue($this->object, new MenuItem());
        $current = $this->object->getCurrent();
        $this->assertInstanceOf(MenuItem::class, $current);
    }

    public function testGetBreadcrumbs()
    {
        $this->stack->expects($this->atLeastOnce())
        ->method('getCurrentRequest')
        ->willReturn(new Request([], [], ['_route' => 'KunstmaanAdminBundle_settings']));
        $this->authCheck->expects($this->any())->method('isGranted')->willReturn(true);
        $adapter = new SettingsMenuAdaptor($this->authCheck, true);
        $this->object->addAdaptMenu($adapter);
        $crumb = $this->object->getBreadCrumb();
        $this->assertTrue(is_array($crumb));
        $this->assertCount(1, $crumb);
        $this->assertInstanceOf(TopMenuItem::class, $crumb[0]);
    }

    public function testGetLowestTopChild()

    {
        $this->stack->expects($this->atLeastOnce())
            ->method('getCurrentRequest')
            ->willReturn(new Request([], [], ['_route' => 'KunstmaanAdminBundle_settings']));
        $this->authCheck->expects($this->any())->method('isGranted')->willReturn(true);
        $adapter = new SettingsMenuAdaptor($this->authCheck, true);
        $this->object->addAdaptMenu($adapter);
        $lowest = $this->object->getLowestTopChild();
        $this->assertInstanceOf(TopMenuItem::class, $lowest);
    }

    /**
     * @throws \ReflectionException
     */
    public function testGetLowestTopChildNonTop()
    {
        $parent = new MenuItem();
        $child = new MenuItem();
        $child->setParent($parent);

        $mirror = new ReflectionClass(MenuBuilder::class);
        $property = $mirror->getProperty('currentCache');
        $property->setAccessible(true);
        $property->setValue($this->object, $child);

        $lowest = $this->object->getLowestTopChild();
        $this->assertNull($lowest);
    }

    /**
     * @throws \ReflectionException
     */
    public function testAdaptChildren()
    {
        $this->authCheck->expects($this->any())->method('isGranted')->willReturn(true);

        $parent = $this->createMock(MenuItemHelper::class);
        $parent->expects($this->exactly(2))->method('getRoute')->willReturn('KunstmaanAdminBundle_settings');

        $container = $this->createMock(ContainerInterface::class);
        $container->expects($this->any())->method('getParameter')->willReturn(true);
        $container->expects($this->any())->method('get')->willReturn($this->authCheck);

        $this->container = $container;
        $this->object = new MenuBuilder($container);

        $adapter = new SettingsMenuAdaptor($this->authCheck, true);
        $array = [];
        $adapter->adaptChildren($this->object, $array, $parent, new Request([], [], ['_route' => 'KunstmaanAdminBundle_settings_bundle_version']));
    }

    public function testModulesMenuAdaptor()

    {
        $this->stack->expects($this->atLeastOnce())
            ->method('getCurrentRequest')
            ->willReturn(new Request([], [], ['_route' => 'KunstmaanAdminBundle_modules']));

        $this->authCheck->expects($this->any())->method('isGranted')->willReturn(true);
        $adapter = new ModulesMenuAdaptor();
        $this->object->addAdaptMenu($adapter);
        $current = $this->object->getCurrent();
        $this->assertInstanceOf(TopMenuItem::class, $current);
    }

    /**
     * @throws \ReflectionException
     */
    public function testSimpleMenuAdaptor()
    {
        $this->stack->expects($this->atLeastOnce())
            ->method('getCurrentRequest')
            ->willReturn(new Request([], [], ['_route' => 'KunstmaanAdminBundle_modules']));

        $this->authCheck->expects($this->any())->method('isGranted')->willReturn(true);
        $adapter = new SimpleMenuAdaptor($this->authCheck, [[
            'label' => 'label',
            'parent' => null,
            'role' => 'ADMIN',
            'route' => 'KunstmaanAdminBundle_modules',
            'params' => ['x' => 'y'],
        ]]);
        $this->object->addAdaptMenu($adapter);

        $mirror = new ReflectionClass(MenuBuilder::class);
        $property = $mirror->getProperty('topMenuItems');
        $property->setAccessible(true);

        $helper = new MenuItemHelper($this->object);
        $helper->setActive(true);
        $property->setValue($this->object, [$helper]);

        $current = $this->object->getCurrent();
        $this->assertInstanceOf(TopMenuItem::class, $current);

        $mirror = new ReflectionClass(SimpleMenuAdaptor::class);
        $method = $mirror->getMethod('parentMatches');
        $method->setAccessible(true);
        $bool = $method->invoke($adapter, null, ['parent' => null]);
        $this->assertTrue($bool);

        $authCheck = $this->createMock(AuthorizationCheckerInterface::class);
        $authCheck->expects($this->any())->method('isGranted')->willReturn(false);
        $adapter = new SimpleMenuAdaptor($authCheck, [[
            'label' => 'label',
            'parent' => null,
            'role' => 'ADMIN',
            'route' => 'KunstmaanAdminBundle_modules',
            'params' => ['x' => 'y'],
        ]]);
        $array = [];
        $adapter->adaptChildren($this->object, $array, null, new Request());
        $this->assertEmpty($array);
    }
}


1		<?php
2
3		namespace Kunstmaan\AdminBundle\Tests\Helper\Menu;
4
5		use Kunstmaan\AdminBundle\Helper\Menu\MenuBuilder;
6		use Kunstmaan\AdminBundle\Helper\Menu\ModulesMenuAdaptor;
7		use Kunstmaan\AdminBundle\Helper\Menu\SettingsMenuAdaptor;
8		use Kunstmaan\AdminBundle\Helper\Menu\SimpleMenuAdaptor;
9		use Kunstmaan\AdminBundle\Helper\Menu\TopMenuItem;
10		use Kunstmaan\MenuBundle\Entity\MenuItem;
11		use Kunstmaan\AdminBundle\Helper\Menu\MenuItem as MenuItemHelper;
12		use PHPUnit\Framework\TestCase;
13		use ReflectionClass;
14		use Symfony\Component\DependencyInjection\ContainerInterface;
15		use Symfony\Component\HttpFoundation\Request;
16		use Symfony\Component\HttpFoundation\RequestStack;
17		use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
18		use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
19
20		class MenuBuilderTest extends TestCase
21		{
22		/**
23		* @var MenuBuilder
24		*/
25		protected $object;
26
27		/**
28		* @var ContainerInterface (mock)
29		*/
30		protected $container;
31
32		/**
33		* @var AuthorizationCheckerInterface (mock)
34		*/
35		protected $authCheck;
36
37		/**
38		* @var RequestStack (mock)
39		*/
40		protected $stack;
41
42		protected function setUp()
43		{
44		$storage = $this->createMock(TokenStorageInterface::class);
45		$authCheck = $this->createMock(AuthorizationCheckerInterface::class);
46		$authCheck->tokenStorage = $storage;
47		$this->authCheck = $authCheck;
48		$container = $this->createMock(ContainerInterface::class);
49		$stack = $this->createMock(RequestStack::class);
50		$this->stack = $stack;
51
52		$container->expects($this->any())->method('getParameter')->willReturn(true);
53		$container->expects($this->any())->method('get')->will($this->onConsecutiveCalls(
54		$stack, $stack, $authCheck
55		));
56
57		$this->container = $container;
58		$this->object = new MenuBuilder($container);
59		}
60
61		/**
62		* @throws \ReflectionException
63		*/
64		public function testGetCurrent()
65		{
66		$this->stack->expects($this->atLeastOnce())
67		->method('getCurrentRequest')
68		->willReturn(new Request([], [], ['_route' => 'KunstmaanAdminBundle_settings']));
69		$this->authCheck->expects($this->any())->method('isGranted')->willReturn(true);
70		$adapter = new SettingsMenuAdaptor($this->authCheck, true);
71		$this->object->addAdaptMenu($adapter);
72		$current = $this->object->getCurrent();
73		$this->assertInstanceOf(TopMenuItem::class, $current);
74
75		$mirror = new ReflectionClass(MenuBuilder::class);
76		$property = $mirror->getProperty('currentCache');
77		$property->setAccessible(true);
78		$property->setValue($this->object, new MenuItem());
79		$current = $this->object->getCurrent();
80		$this->assertInstanceOf(MenuItem::class, $current);
81		}
82
83		public function testGetBreadcrumbs()
84		{
85		$this->stack->expects($this->atLeastOnce())
86		->method('getCurrentRequest')
87		->willReturn(new Request([], [], ['_route' => 'KunstmaanAdminBundle_settings']));
88		$this->authCheck->expects($this->any())->method('isGranted')->willReturn(true);
89		$adapter = new SettingsMenuAdaptor($this->authCheck, true);
90		$this->object->addAdaptMenu($adapter);
91		$crumb = $this->object->getBreadCrumb();
92		$this->assertTrue(is_array($crumb));
93		$this->assertCount(1, $crumb);
94		$this->assertInstanceOf(TopMenuItem::class, $crumb[0]);
95		}
96
97	View Code Duplication	public function testGetLowestTopChild()
		0 ignored issues – show Duplication introduced 2018-04-18 14:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
98		{
99		$this->stack->expects($this->atLeastOnce())
100		->method('getCurrentRequest')
101		->willReturn(new Request([], [], ['_route' => 'KunstmaanAdminBundle_settings']));
102		$this->authCheck->expects($this->any())->method('isGranted')->willReturn(true);
103		$adapter = new SettingsMenuAdaptor($this->authCheck, true);
104		$this->object->addAdaptMenu($adapter);
105		$lowest = $this->object->getLowestTopChild();
106		$this->assertInstanceOf(TopMenuItem::class, $lowest);
107		}
108
109		/**
110		* @throws \ReflectionException
111		*/
112		public function testGetLowestTopChildNonTop()
113		{
114		$parent = new MenuItem();
115		$child = new MenuItem();
116		$child->setParent($parent);
117
118		$mirror = new ReflectionClass(MenuBuilder::class);
119		$property = $mirror->getProperty('currentCache');
120		$property->setAccessible(true);
121		$property->setValue($this->object, $child);
122
123		$lowest = $this->object->getLowestTopChild();
124		$this->assertNull($lowest);
125		}
126
127		/**
128		* @throws \ReflectionException
129		*/
130		public function testAdaptChildren()
131		{
132		$this->authCheck->expects($this->any())->method('isGranted')->willReturn(true);
133
134		$parent = $this->createMock(MenuItemHelper::class);
135		$parent->expects($this->exactly(2))->method('getRoute')->willReturn('KunstmaanAdminBundle_settings');
136
137		$container = $this->createMock(ContainerInterface::class);
138		$container->expects($this->any())->method('getParameter')->willReturn(true);
139		$container->expects($this->any())->method('get')->willReturn($this->authCheck);
140
141		$this->container = $container;
142		$this->object = new MenuBuilder($container);
143
144		$adapter = new SettingsMenuAdaptor($this->authCheck, true);
145		$array = [];
146		$adapter->adaptChildren($this->object, $array, $parent, new Request([], [], ['_route' => 'KunstmaanAdminBundle_settings_bundle_version']));
147		}
148
149	View Code Duplication	public function testModulesMenuAdaptor()
		0 ignored issues – show Duplication introduced 2018-04-18 14:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
150		{
151		$this->stack->expects($this->atLeastOnce())
152		->method('getCurrentRequest')
153		->willReturn(new Request([], [], ['_route' => 'KunstmaanAdminBundle_modules']));
154
155		$this->authCheck->expects($this->any())->method('isGranted')->willReturn(true);
156		$adapter = new ModulesMenuAdaptor();
157		$this->object->addAdaptMenu($adapter);
158		$current = $this->object->getCurrent();
159		$this->assertInstanceOf(TopMenuItem::class, $current);
160		}
161
162		/**
163		* @throws \ReflectionException
164		*/
165		public function testSimpleMenuAdaptor()
166		{
167		$this->stack->expects($this->atLeastOnce())
168		->method('getCurrentRequest')
169		->willReturn(new Request([], [], ['_route' => 'KunstmaanAdminBundle_modules']));
170
171		$this->authCheck->expects($this->any())->method('isGranted')->willReturn(true);
172		$adapter = new SimpleMenuAdaptor($this->authCheck, [[
173		'label' => 'label',
174		'parent' => null,
175		'role' => 'ADMIN',
176		'route' => 'KunstmaanAdminBundle_modules',
177		'params' => ['x' => 'y'],
178		]]);
179		$this->object->addAdaptMenu($adapter);
180
181		$mirror = new ReflectionClass(MenuBuilder::class);
182		$property = $mirror->getProperty('topMenuItems');
183		$property->setAccessible(true);
184
185		$helper = new MenuItemHelper($this->object);
186		$helper->setActive(true);
187		$property->setValue($this->object, [$helper]);
188
189		$current = $this->object->getCurrent();
190		$this->assertInstanceOf(TopMenuItem::class, $current);
191
192		$mirror = new ReflectionClass(SimpleMenuAdaptor::class);
193		$method = $mirror->getMethod('parentMatches');
194		$method->setAccessible(true);
195		$bool = $method->invoke($adapter, null, ['parent' => null]);
196		$this->assertTrue($bool);
197
198		$authCheck = $this->createMock(AuthorizationCheckerInterface::class);
199		$authCheck->expects($this->any())->method('isGranted')->willReturn(false);
200		$adapter = new SimpleMenuAdaptor($authCheck, [[
201		'label' => 'label',
202		'parent' => null,
203		'role' => 'ADMIN',
204		'route' => 'KunstmaanAdminBundle_modules',
205		'params' => ['x' => 'y'],
206		]]);
207		$array = [];
208		$adapter->adaptChildren($this->object, $array, null, new Request());
209		$this->assertEmpty($array);
210		}
211		}
212

Kunstmaan / KunstmaanBundlesCMS

Push — master ( 1de9b7...830752 )

Tests/unit/Helper/Menu/MenuBuilderTest.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like