Kunstmaan\AdminBundle\Tests\Helper\Menu\MenuBuilderTest

Complexity

Total Complexity

8

Size/Duplication

Total Lines	192
Duplicated Lines	11.98 %

Coupling/Cohesion

Components	1
Dependencies	10

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	18	1
A	testGetCurrent()	0	18	1
A	testGetBreadcrumbs()	0	13	1
A	testGetLowestTopChild()	11	11	1
A	testGetLowestTopChildNonTop()	0	14	1
A	testAdaptChildren()	0	18	1
A	testModulesMenuAdaptor()	12	12	1
A	testSimpleMenuAdaptor()	0	46	1

<?php

namespace Kunstmaan\AdminBundle\Tests\Helper\Menu;

use Kunstmaan\AdminBundle\Helper\Menu\MenuBuilder;
use Kunstmaan\AdminBundle\Helper\Menu\ModulesMenuAdaptor;
use Kunstmaan\AdminBundle\Helper\Menu\SettingsMenuAdaptor;
use Kunstmaan\AdminBundle\Helper\Menu\SimpleMenuAdaptor;
use Kunstmaan\AdminBundle\Helper\Menu\TopMenuItem;
use Kunstmaan\MenuBundle\Entity\MenuItem;
use Kunstmaan\AdminBundle\Helper\Menu\MenuItem as MenuItemHelper;
use PHPUnit\Framework\TestCase;
use ReflectionClass;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\RequestStack;
use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;

class MenuBuilderTest extends TestCase
{
    /**
     * @var MenuBuilder
     */
    protected $object;

    /**
     * @var ContainerInterface (mock)
     */
    protected $container;

    /**
     * @var AuthorizationCheckerInterface (mock)
     */
    protected $authCheck;

    /**
     * @var RequestStack (mock)
     */
    protected $stack;

    protected function setUp()
    {
        $storage = $this->createMock(TokenStorageInterface::class);
        $authCheck = $this->createMock(AuthorizationCheckerInterface::class);
        $authCheck->tokenStorage = $storage;

Accessing tokenStorage on the interface PHPUnit\Framework\MockObject\MockObject suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->authCheck = $authCheck;

It seems like $authCheck of type object<PHPUnit\Framework\MockObject\MockObject> is incompatible with the declared type object<Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface> of property $authCheck.

        $container = $this->createMock(ContainerInterface::class);
        $stack = $this->createMock(RequestStack::class);
        $this->stack = $stack;

It seems like $stack of type object<PHPUnit\Framework\MockObject\MockObject> is incompatible with the declared type object<Symfony\Component\HttpFoundation\RequestStack> of property $stack.

        $container->expects($this->any())->method('getParameter')->willReturn(true);
        $container->expects($this->any())->method('get')->will($this->onConsecutiveCalls(
            $stack, $stack, $authCheck
        ));

        $this->container = $container;

It seems like $container of type object<PHPUnit\Framework\MockObject\MockObject> is incompatible with the declared type object<Symfony\Component\DependencyInjection\ContainerInterface> of property $container.

        $this->object = new MenuBuilder($container);

$container is of type object<PHPUnit\Framework\MockObject\MockObject>, but the function expects a object<Symfony\Component\DependencyInjection\ContainerInterface>.

    }

    /**
     * @throws \ReflectionException
     */
    public function testGetCurrent()
    {
        $this->stack->expects($this->atLeastOnce())

The method expects() does not seem to exist on object<Symfony\Component\HttpFoundation\RequestStack>.

            ->method('getCurrentRequest')
            ->willReturn(new Request([], [], ['_route' => 'KunstmaanAdminBundle_settings']));
        $this->authCheck->expects($this->any())->method('isGranted')->willReturn(true);

The method expects() does not seem to exist on object<Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface>.

        $adapter = new SettingsMenuAdaptor($this->authCheck, true);
        $this->object->addAdaptMenu($adapter);
        $current = $this->object->getCurrent();
        $this->assertInstanceOf(TopMenuItem::class, $current);

        $mirror = new ReflectionClass(MenuBuilder::class);
        $property = $mirror->getProperty('currentCache');
        $property->setAccessible(true);
        $property->setValue($this->object, new MenuItem());
        $current = $this->object->getCurrent();
        $this->assertInstanceOf(MenuItem::class, $current);
    }

    public function testGetBreadcrumbs()
    {
        $this->stack->expects($this->atLeastOnce())

The method expects() does not seem to exist on object<Symfony\Component\HttpFoundation\RequestStack>.

        ->method('getCurrentRequest')
        ->willReturn(new Request([], [], ['_route' => 'KunstmaanAdminBundle_settings']));
        $this->authCheck->expects($this->any())->method('isGranted')->willReturn(true);

The method expects() does not seem to exist on object<Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface>.

        $adapter = new SettingsMenuAdaptor($this->authCheck, true);
        $this->object->addAdaptMenu($adapter);
        $crumb = $this->object->getBreadCrumb();
        $this->assertTrue(is_array($crumb));
        $this->assertCount(1, $crumb);

$crumb is of type array<integer,object<Kunstmaan\AdminBundle\Helper\Menu\MenuItem>>, but the function expects a object<Countable>|object<PHPUnit\Framework\iterable>.

        $this->assertInstanceOf(TopMenuItem::class, $crumb[0]);
    }

    public function testGetLowestTopChild()

This method seems to be duplicated in your project.

    {
        $this->stack->expects($this->atLeastOnce())

The method expects() does not seem to exist on object<Symfony\Component\HttpFoundation\RequestStack>.

            ->method('getCurrentRequest')
            ->willReturn(new Request([], [], ['_route' => 'KunstmaanAdminBundle_settings']));
        $this->authCheck->expects($this->any())->method('isGranted')->willReturn(true);

The method expects() does not seem to exist on object<Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface>.

        $adapter = new SettingsMenuAdaptor($this->authCheck, true);
        $this->object->addAdaptMenu($adapter);
        $lowest = $this->object->getLowestTopChild();
        $this->assertInstanceOf(TopMenuItem::class, $lowest);
    }

    /**
     * @throws \ReflectionException
     */
    public function testGetLowestTopChildNonTop()
    {
        $parent = new MenuItem();
        $child = new MenuItem();
        $child->setParent($parent);

        $mirror = new ReflectionClass(MenuBuilder::class);
        $property = $mirror->getProperty('currentCache');
        $property->setAccessible(true);
        $property->setValue($this->object, $child);

        $lowest = $this->object->getLowestTopChild();
        $this->assertNull($lowest);
    }

    /**
     * @throws \ReflectionException
     */
    public function testAdaptChildren()
    {
        $this->authCheck->expects($this->any())->method('isGranted')->willReturn(true);

The method expects() does not seem to exist on object<Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface>.

        $parent = $this->createMock(MenuItemHelper::class);
        $parent->expects($this->exactly(2))->method('getRoute')->willReturn('KunstmaanAdminBundle_settings');

        $container = $this->createMock(ContainerInterface::class);
        $container->expects($this->any())->method('getParameter')->willReturn(true);
        $container->expects($this->any())->method('get')->willReturn($this->authCheck);

        $this->container = $container;

It seems like $container of type object<PHPUnit\Framework\MockObject\MockObject> is incompatible with the declared type object<Symfony\Component\DependencyInjection\ContainerInterface> of property $container.

        $this->object = new MenuBuilder($container);

$container is of type object<PHPUnit\Framework\MockObject\MockObject>, but the function expects a object<Symfony\Component\DependencyInjection\ContainerInterface>.

        $adapter = new SettingsMenuAdaptor($this->authCheck, true);
        $array = [];
        $adapter->adaptChildren($this->object, $array, $parent, new Request([], [], ['_route' => 'KunstmaanAdminBundle_settings_bundle_version']));

$parent is of type object<PHPUnit\Framework\MockObject\MockObject>, but the function expects a null|object<Kunstmaan\AdminBundle\Helper\Menu\MenuItem>.

    }

    public function testModulesMenuAdaptor()

This method seems to be duplicated in your project.

    {
        $this->stack->expects($this->atLeastOnce())

The method expects() does not seem to exist on object<Symfony\Component\HttpFoundation\RequestStack>.

            ->method('getCurrentRequest')
            ->willReturn(new Request([], [], ['_route' => 'KunstmaanAdminBundle_modules']));

        $this->authCheck->expects($this->any())->method('isGranted')->willReturn(true);

The method expects() does not seem to exist on object<Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface>.

        $adapter = new ModulesMenuAdaptor();
        $this->object->addAdaptMenu($adapter);
        $current = $this->object->getCurrent();
        $this->assertInstanceOf(TopMenuItem::class, $current);
    }

    /**
     * @throws \ReflectionException
     */
    public function testSimpleMenuAdaptor()
    {
        $this->stack->expects($this->atLeastOnce())

The method expects() does not seem to exist on object<Symfony\Component\HttpFoundation\RequestStack>.

            ->method('getCurrentRequest')
            ->willReturn(new Request([], [], ['_route' => 'KunstmaanAdminBundle_modules']));

        $this->authCheck->expects($this->any())->method('isGranted')->willReturn(true);

The method expects() does not seem to exist on object<Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface>.

        $adapter = new SimpleMenuAdaptor($this->authCheck, [[
            'label' => 'label',
            'parent' => null,
            'role' => 'ADMIN',
            'route' => 'KunstmaanAdminBundle_modules',
            'params' => ['x' => 'y'],
        ]]);
        $this->object->addAdaptMenu($adapter);

        $mirror = new ReflectionClass(MenuBuilder::class);
        $property = $mirror->getProperty('topMenuItems');
        $property->setAccessible(true);

        $helper = new MenuItemHelper($this->object);
        $helper->setActive(true);
        $property->setValue($this->object, [$helper]);

        $current = $this->object->getCurrent();
        $this->assertInstanceOf(TopMenuItem::class, $current);

        $mirror = new ReflectionClass(SimpleMenuAdaptor::class);
        $method = $mirror->getMethod('parentMatches');
        $method->setAccessible(true);
        $bool = $method->invoke($adapter, null, ['parent' => null]);
        $this->assertTrue($bool);

        $authCheck = $this->createMock(AuthorizationCheckerInterface::class);
        $authCheck->expects($this->any())->method('isGranted')->willReturn(false);
        $adapter = new SimpleMenuAdaptor($authCheck, [[

$authCheck is of type object<PHPUnit\Framework\MockObject\MockObject>, but the function expects a object<Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface>.

            'label' => 'label',
            'parent' => null,
            'role' => 'ADMIN',
            'route' => 'KunstmaanAdminBundle_modules',
            'params' => ['x' => 'y'],
        ]]);
        $array = [];
        $adapter->adaptChildren($this->object, $array, null, new Request());
        $this->assertEmpty($array);
    }
}