Constant::supports() - Code Metrics - Inspection of "release" - KnpLabs/DictionaryBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#180)

by Pierre

created 2022-11-07 15:02 UTC

Constant::supports() A

↳ Parent: Constant

Complexity

Conditions	5
Paths	4

Size

Total Lines	21
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	5

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
cc	5
eloc	10
c	3
b	0
f	0
nc	4
nop	1
dl	0
loc	21
ccs	10
cts	10
cp	1
crap	5
rs	9.6111

<?php

declare(strict_types=1);

namespace Knp\DictionaryBundle\ValueTransformer;

use Exception;
use Knp\DictionaryBundle\ValueTransformer;
use ReflectionClass;

final class Constant implements ValueTransformer
{
    private const PATTERN = '/^(?P<class>.*)::(?P<constant>.*)$/';

    public function supports($value): bool
    {
        if (!\is_string($value)) {
            return false;
        }

        $matches = [];


        if (null === $matches = $this->extract($value)) {
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
            return false;
        }

        if (!class_exists($matches['class']) && !interface_exists($matches['class'])) {
            return false;
        }

        $constants = (new ReflectionClass($matches['class']))
            ->getConstants()
        ;

        return \array_key_exists($matches['constant'], $constants);
    }

    public function transform($value)
    {
        if (null === $matches = $this->extract($value)) {
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
            throw new Exception("Unable to resolve constant {$value}.");
        }

        return (new ReflectionClass($matches['class']))
            ->getConstant($matches['constant'])
        ;
    }

    /**
     * @return ?array{class: class-string, constant: string}

     */
    private function extract(string $value): ?array
    {
        if (preg_match(self::PATTERN, $value, $matches)) {
            /**
             * @var array{class: class-string, constant: string} $matches
             */
            return $matches;
        }

        return null;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Knp\DictionaryBundle\ValueTransformer;
6
7		use Exception;
8		use Knp\DictionaryBundle\ValueTransformer;
9		use ReflectionClass;
10
11		final class Constant implements ValueTransformer
12		{
13		private const PATTERN = '/^(?P<class>.)::(?P<constant>.)$/';
14
15		public function supports($value): bool
16		{
17	5	if (!\is_string($value)) {
18		return false;
19	5	}
20	1
21		$matches = [];
		0 ignored issues – show Unused Code introduced 2022-11-07 09:14 UTC by Report Bug Copy Issue Report The assignment to `$matches` is dead and can be removed. Loading history...
22
23	4	if (null === $matches = $this->extract($value)) {
		0 ignored issues – show Bug introduced 2022-11-07 09:14 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$matches` is correct as `$this->extract($value)` targeting `Knp\DictionaryBundle\Val...mer\Constant::extract()` seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history... introduced 2022-11-07 09:14 UTC by Report Bug Copy Issue Report The condition `null === $matches = $this->extract($value)` is always `true`. Loading history...
24		return false;
25	4	}
26	1
27		if (!class_exists($matches['class']) && !interface_exists($matches['class'])) {
28		return false;
29	3	}
30	1
31		$constants = (new ReflectionClass($matches['class']))
32		->getConstants()
33	2	;
34	2
35		return \array_key_exists($matches['constant'], $constants);
36		}
37	2
38		public function transform($value)
39		{
40	1	if (null === $matches = $this->extract($value)) {
		0 ignored issues – show Bug introduced 2022-11-07 09:14 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$matches` is correct as `$this->extract($value)` targeting `Knp\DictionaryBundle\Val...mer\Constant::extract()` seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history... introduced 2022-11-07 09:14 UTC by Report Bug Copy Issue Report The condition `null === $matches = $this->extract($value)` is always `true`. Loading history...
41		throw new Exception("Unable to resolve constant {$value}.");
42	1	}
43
44	1	return (new ReflectionClass($matches['class']))
45		->getConstant($matches['constant'])
46	1	;
47	1	}
48
49		/**
50		* @return ?array{class: class-string, constant: string}
		0 ignored issues – show Documentation Bug introduced 2022-11-07 09:14 UTC by Report Bug Copy Issue Report The doc comment `?array{class: class-string, constant: string}` at position `4` could not be parsed: Unknown type name 'class-string' at position 4 in ?array{class: class-string, constant: string}. Loading history...
51		*/
52		private function extract(string $value): ?array
53		{
54		if (preg_match(self::PATTERN, $value, $matches)) {
55		/**
56		* @var array{class: class-string, constant: string} $matches
57		*/
58		return $matches;
59		}
60
61		return null;
62		}
63		}
64

KnpLabs / DictionaryBundle

Pull Request — master (#180)

Constant::supports() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like