Knp\DictionaryBundle\ValueTransformer\Constant

Complexity

Total Complexity

9

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	5
Bugs	2	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	transform()	0	8	2
A	extract()	0	10	2
A	supports()	0	21	5

<?php

declare(strict_types=1);

namespace Knp\DictionaryBundle\ValueTransformer;

use Exception;
use Knp\DictionaryBundle\ValueTransformer;
use ReflectionClass;

final class Constant implements ValueTransformer
{
    private const PATTERN = '/^(?P<class>.*)::(?P<constant>.*)$/';

    public function supports($value): bool
    {
        if (!\is_string($value)) {
            return false;
        }

        $matches = [];

The assignment to $matches is dead and can be removed.

        if (null === $matches = $this->extract($value)) {

Are you sure the assignment to $matches is correct as $this->extract($value) targeting Knp\DictionaryBundle\ValueTransformer\Constant::extract() seems to always return null.

The condition null === $matches = $this->extract($value) is always true.

            return false;
        }

        if (!class_exists($matches['class']) && !interface_exists($matches['class'])) {
            return false;
        }

        $constants = (new ReflectionClass($matches['class']))
            ->getConstants()
        ;

        return \array_key_exists($matches['constant'], $constants);
    }

    public function transform($value)
    {
        if (null === $matches = $this->extract($value)) {

Are you sure the assignment to $matches is correct as $this->extract($value) targeting Knp\DictionaryBundle\ValueTransformer\Constant::extract() seems to always return null.

The condition null === $matches = $this->extract($value) is always true.

            throw new Exception("Unable to resolve constant {$value}.");
        }

        return (new ReflectionClass($matches['class']))
            ->getConstant($matches['constant'])
        ;
    }

    /**
     * @return ?array{class: class-string, constant: string}

The doc comment ?array{class: class-string, constant: string} at position 4 could not be parsed: Unknown type name 'class-string' at position 4 in ?array{class: class-string, constant: string}.

     */
    private function extract(string $value): ?array
    {
        if (preg_match(self::PATTERN, $value, $matches)) {
            /**
             * @var array{class: class-string, constant: string} $matches
             */
            return $matches;
        }

        return null;
    }
}