Kilix / php-abac

src/Manager/ComparisonManager.php

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use PhpAbac\Manager\PolicyRuleManager;
 use PhpAbac\Manager\ConfigurationManager;
 use PhpAbac\Manager\CacheManager;
-
 use Symfony\Component\Config\FileLocator;
 
 class Abac

Spacing +5 added lines, -5 removed lines

@@ -51,21 +51,21 @@ 
             : $pra->getValue()
         ;
         // Checking that the configured comparison type is available
-        if(!isset($this->comparisons[$pra->getComparisonType()])) {
+        if (!isset($this->comparisons[$pra->getComparisonType()])) {
             throw new \InvalidArgumentException('The requested comparison class does not exist');
         }
         // The comparison class will perform the attribute check with the configured method
         // For more complex comparisons, the comparison manager is injected
         $comparison = new $this->comparisons[$pra->getComparisonType()]($this);
-        if(!method_exists($comparison, $pra->getComparison())) {
+        if (!method_exists($comparison, $pra->getComparison())) {
             throw new \InvalidArgumentException('The requested comparison method does not exist');
         }
         // Then the comparison is performed with needed
         $result = $comparison->{$pra->getComparison()}($praValue, $attribute->getValue(), $pra->getExtraData());
         // If the checked attribute is not valid, the attribute slug is marked as rejected
         // The rejected attributes will be returned instead of the expected true boolean
-        if($result !== true) {
-            if(!in_array($attribute->getSlug(), $this->rejectedAttributes)) {
+        if ($result !== true) {
+            if (!in_array($attribute->getSlug(), $this->rejectedAttributes)) {
                 $this->rejectedAttributes[] = $attribute->getSlug();
             }
             return false;
@@ -92,7 +92,7 @@ 
      * @throws \InvalidArgumentException
      */
     public function getDynamicAttribute($attributeSlug) {
-        if(!isset($this->dynamicAttributes[$attributeSlug])) {
+        if (!isset($this->dynamicAttributes[$attributeSlug])) {
             throw new \InvalidArgumentException("The dynamic value for attribute $attributeSlug was not given");
         }
         return $this->dynamicAttributes[$attributeSlug];

src/Abac.php

Spacing +9 added lines, -9 removed lines

@@ -70,18 +70,18 @@ 
     public function enforce($ruleName, $user, $resource = null, $options = []) {
         // If there is dynamic attributes, we pass them to the comparison manager
         // When a comparison will be performed, the passed values will be retrieved and used
-        if(isset($options['dynamic_attributes'])) {
+        if (isset($options['dynamic_attributes'])) {
             $this->comparisonManager->setDynamicAttributes($options['dynamic_attributes']);
         }
         // Retrieve cache value for the current rule and values if cache item is valid
-        if(($cacheResult = isset($options['cache_result']) && $options['cache_result'] === true) === true) {
+        if (($cacheResult = isset($options['cache_result']) && $options['cache_result'] === true) === true) {
             $cacheItem = $this->cacheManager->getItem(
-                "$ruleName-{$user->getId()}-" . (($resource !== null) ? $resource->getId() : ''),
+                "$ruleName-{$user->getId()}-".(($resource !== null) ? $resource->getId() : ''),
                 (isset($options['cache_driver'])) ? $options['cache_driver'] : null,
                 (isset($options['cache_ttl'])) ? $options['cache_ttl'] : null
             );
             // We check if the cache value s valid before returning it
-            if(($cacheValue = $cacheItem->get()) !== null) {
+            if (($cacheValue = $cacheItem->get()) !== null) {
                 return $cacheValue;
             }
         }
@@ -90,7 +90,7 @@ 
         foreach ($policyRule->getPolicyRuleAttributes() as $pra) {
             $attribute = $pra->getAttribute();
             $attribute->setValue($this->attributeManager->retrieveAttribute($attribute, $user, $resource));
-            if(count($pra->getExtraData()) > 0) {
+            if (count($pra->getExtraData()) > 0) {
                 $this->processExtraData($pra, $user, $resource);
             }
             $this->comparisonManager->compare($pra);
@@ -98,7 +98,7 @@ 
         // The given result could be an array of rejected attributes or true
         // True means that the rule is correctly enforced for the given user and resource
         $result = $this->comparisonManager->getResult();
-        if($cacheResult) {
+        if ($cacheResult) {
             $cacheItem->set($result);
             $this->cacheManager->save($cacheItem);
         }
@@ -111,8 +111,8 @@ 
      * @param object $resource
      */
     public function processExtraData(PolicyRuleAttribute $pra, $user, $resource) {
-        foreach($pra->getExtraData() as $key => $data) {
-            switch($key) {
+        foreach ($pra->getExtraData() as $key => $data) {
+            switch ($key) {
                 case 'with':
                     // This data has to be removed for it will be stored elsewhere
                     // in the policy rule attribute
@@ -120,7 +120,7 @@ 
                     // The "with" extra data is an array of attributes, which are objects
                     // Once we process it as policy rule attributes, we set it as the main policy rule attribute value
                     $subPolicyRuleAttributes = [];
-                    foreach($this->policyRuleManager->processRuleAttributes($data) as $subPolicyRuleAttribute) {
+                    foreach ($this->policyRuleManager->processRuleAttributes($data) as $subPolicyRuleAttribute) {
                         $subPolicyRuleAttributes[] = $subPolicyRuleAttribute;
                     }
                     $pra->setValue($subPolicyRuleAttributes);

src/Comparison/ArrayComparison.php

Spacing +4 added lines, -4 removed lines

@@ -54,19 +54,19 @@
      * @return boolean
      */
     public function contains($policyRuleAttributes, $attributes, $extraData = []) {
-        foreach($extraData['attribute']->getValue() as $attribute) {
+        foreach ($extraData['attribute']->getValue() as $attribute) {
             $result = true;
-            foreach($policyRuleAttributes as $pra) {
+            foreach ($policyRuleAttributes as $pra) {
                 $attributeData = $pra->getAttribute();
                 $attributeData->setValue(
                     $this->comparisonManager->getAttributeManager()->retrieveAttribute($attributeData, $extraData['user'], $attribute)
                 );
-                if(!$this->comparisonManager->compare($pra)) {
+                if (!$this->comparisonManager->compare($pra)) {
                     $result = false;
                     break;
                 }
             }
-            if($result === true) {
+            if ($result === true) {
                 return true;
             }
         }