Kilix / php-abac

src/Cache/Pool/MemoryCacheItemPool.php

Spacing +8 added lines, -8 removed lines

@@ -16,10 +16,10 @@ 
      * {@inheritdoc}
      */
     public function deleteItem($key) {
-        if(isset($this->items[$key])) {
+        if (isset($this->items[$key])) {
             unset($this->items[$key]);
         }
-        if(isset($this->deferredItems[$key])) {
+        if (isset($this->deferredItems[$key])) {
             unset($this->deferredItems[$key]);
         }
         return true;
@@ -29,8 +29,8 @@ 
      * {@inheritdoc}
      */
     public function deleteItems(array $keys) {
-        foreach($keys as $key) {
-            if(!$this->deleteItem($key)) {
+        foreach ($keys as $key) {
+            if (!$this->deleteItem($key)) {
                 return false;
             }
         }
@@ -59,7 +59,7 @@ 
      * {@inheritdoc}
      */
     public function commit() {
-        foreach($this->deferredItems as $key => $item) {
+        foreach ($this->deferredItems as $key => $item) {
             $this->items[$key] = $item;
             unset($this->deferredItems[$key]);
         }
@@ -77,7 +77,7 @@ 
      * {@inheritdoc}
      */
     public function getItem($key) {
-        if(!$this->hasItem($key)) {
+        if (!$this->hasItem($key)) {
             return new MemoryCacheItem($key);
         }
         return $this->items[$key];
@@ -88,8 +88,8 @@ 
      */
     public function getItems(array $keys = array()) {
         $items = [];
-        foreach($keys as $key) {
-            if($this->hasItem($key)) {
+        foreach ($keys as $key) {
+            if ($this->hasItem($key)) {
                 $items[$key] = $this->getItem($key);
             }
         }

src/Cache/Item/MemoryCacheItem.php

Spacing +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
      * {@inheritdoc}
      */
     public function get() {
-        if(!$this->isHit()) {
+        if (!$this->isHit()) {
             throw new ExpiredCacheException('Cache item is expired');
         }
         return $this->value;

src/Manager/CacheManager.php

Spacing +3 added lines, -3 removed lines

@@ -30,7 +30,7 @@ 
         $item = $pool->getItem($key);
         
         // In this case, the pool returned a new CacheItem
-        if($item->get() === null) {
+        if ($item->get() === null) {
             $item->expiresAfter($ttl);
         }
         return $item;
@@ -42,8 +42,8 @@ 
      * @return Psr\Cache\CacheItemPoolInterface
      */
     public function getItemPool($driver) {
-        if(!isset($this->pools[$driver])) {
-            $poolClass = 'PhpAbac\\Cache\\Pool\\' . ucfirst($driver) . 'CacheItemPool';
+        if (!isset($this->pools[$driver])) {
+            $poolClass = 'PhpAbac\\Cache\\Pool\\'.ucfirst($driver).'CacheItemPool';
             $this->pools[$driver] = new $poolClass();
         }
         return $this->pools[$driver];

src/Manager/AttributeManager.php

Doc Comments +1 added lines, -2 removed lines

@@ -69,7 +69,6 @@ 
 
     /**
      * @param AbstractAttribute $attribute
-     * @param string $attributeType
      * @param object $user
      * @param object $object
      * @return mixed
@@ -108,7 +107,7 @@ 
     /**
      * 
      * @param \PhpAbac\Model\EnvironmentAttribute $attribute
-     * @return mixed
+     * @return string
      */
     private function retrieveEnvironmentAttribute(EnvironmentAttribute $attribute) {
         return getenv($attribute->getVariableName());

Spacing +3 added lines, -3 removed lines

@@ -76,7 +76,7 @@ 
      */
     public function retrieveAttribute(AbstractAttribute $attribute, $user, $object = null)
     {
-        switch($attribute->getType()) {
+        switch ($attribute->getType()) {
             case 'user':
                 return $this->retrieveClassicAttribute($attribute, $user);
             case 'resource':
@@ -95,9 +95,9 @@ 
     {
         $propertyPath = explode('.', $attribute->getProperty());
         $propertyValue = $object;
-        foreach($propertyPath as $property) {
+        foreach ($propertyPath as $property) {
             $getter = 'get'.ucfirst($property);
-            if(!method_exists($propertyValue, $getter)) {
+            if (!method_exists($propertyValue, $getter)) {
                 throw new \InvalidArgumentException('There is no getter for the "'.$attribute->getProperty().'" attribute for object "'.get_class($propertyValue).'"');
             }
             $propertyValue = $propertyValue->{$getter}();

src/Manager/ConfigurationManager.php

Spacing +3 added lines, -3 removed lines

@@ -34,12 +34,12 @@
      * @param array $configurationFiles
      */
     public function parseConfigurationFile($configurationFiles) {
-        foreach($configurationFiles as $configurationFile) {
+        foreach ($configurationFiles as $configurationFile) {
             $config = $this->loaders[$this->format]->load($configurationFile);
-            if(isset($config['attributes'])) {
+            if (isset($config['attributes'])) {
                 $this->attributes = array_merge($this->attributes, $config['attributes']);
             }
-            if(isset($config['rules'])) {
+            if (isset($config['rules'])) {
                 $this->rules = array_merge($this->rules, $config['rules']);
             }
         }

src/Abac.php

Unused Use Statements -2 removed lines

@@ -7,9 +7,7 @@
 use PhpAbac\Manager\ConfigurationManager;
 use PhpAbac\Manager\CacheManager;
 use PhpAbac\Manager\ComparisonManager;
-
 use Symfony\Component\Config\FileLocator;
-
 use PhpAbac\Model\PolicyRuleAttribute;
 
 class Abac

Spacing +9 added lines, -9 removed lines

@@ -71,18 +71,18 @@ 
     public function enforce($ruleName, $user, $resource = null, $options = []) {
         // If there is dynamic attributes, we pass them to the comparison manager
         // When a comparison will be performed, the passed values will be retrieved and used
-        if(isset($options['dynamic_attributes'])) {
+        if (isset($options['dynamic_attributes'])) {
             $this->comparisonManager->setDynamicAttributes($options['dynamic_attributes']);
         }
         // Retrieve cache value for the current rule and values if cache item is valid
-        if(($cacheResult = isset($options['cache_result']) && $options['cache_result'] === true) === true) {
+        if (($cacheResult = isset($options['cache_result']) && $options['cache_result'] === true) === true) {
             $cacheItem = $this->cacheManager->getItem(
-                "$ruleName-{$user->getId()}-" . (($resource !== null) ? $resource->getId() : ''),
+                "$ruleName-{$user->getId()}-".(($resource !== null) ? $resource->getId() : ''),
                 (isset($options['cache_driver'])) ? $options['cache_driver'] : null,
                 (isset($options['cache_ttl'])) ? $options['cache_ttl'] : null
             );
             // We check if the cache value s valid before returning it
-            if(($cacheValue = $cacheItem->get()) !== null) {
+            if (($cacheValue = $cacheItem->get()) !== null) {
                 return $cacheValue;
             }
         }
@@ -91,7 +91,7 @@ 
         foreach ($policyRule->getPolicyRuleAttributes() as $pra) {
             $attribute = $pra->getAttribute();
             $attribute->setValue($this->attributeManager->retrieveAttribute($attribute, $user, $resource));
-            if(count($pra->getExtraData()) > 0) {
+            if (count($pra->getExtraData()) > 0) {
                 $this->processExtraData($pra, $user, $resource);
             }
             $this->comparisonManager->compare($pra);
@@ -99,7 +99,7 @@ 
         // The given result could be an array of rejected attributes or true
         // True means that the rule is correctly enforced for the given user and resource
         $result = $this->comparisonManager->getResult();
-        if($cacheResult) {
+        if ($cacheResult) {
             $cacheItem->set($result);
             $this->cacheManager->save($cacheItem);
         }
@@ -112,8 +112,8 @@ 
      * @param object $resource
      */
     public function processExtraData(PolicyRuleAttribute $pra, $user, $resource) {
-        foreach($pra->getExtraData() as $key => $data) {
-            switch($key) {
+        foreach ($pra->getExtraData() as $key => $data) {
+            switch ($key) {
                 case 'with':
                     // This data has to be removed for it will be stored elsewhere
                     // in the policy rule attribute
@@ -123,7 +123,7 @@ 
                     $subPolicyRuleAttributes = [];
                     $extraData = [];
 
-                    foreach($this->policyRuleManager->processRuleAttributes($data, $user, $resource) as $subPolicyRuleAttribute) {
+                    foreach ($this->policyRuleManager->processRuleAttributes($data, $user, $resource) as $subPolicyRuleAttribute) {
                         $subPolicyRuleAttributes[] = $subPolicyRuleAttribute;
                     }
                     $pra->setValue($subPolicyRuleAttributes);

src/Model/PolicyRuleAttribute.php

Doc Comments +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
     }
 
     /**
-     * @return \PhpAbac\Model\AbstractAttribute
+     * @return string
      */
     public function getAttribute()
     {

Spacing +1 added lines, -1 removed lines

@@ -121,7 +121,7 @@
      * @return \PhpAbac\Model\PolicyRuleAttribute
      */
     public function removeExtraData($key) {
-        if(isset($this->extraData[$key])) {
+        if (isset($this->extraData[$key])) {
             unset($this->extraData[$key]);
         }
         return $this;

example.php

Spacing +6 added lines, -6 removed lines

@@ -34,7 +34,7 @@ 
     $user1Vehicle = $abac->enforce('vehicle-homologation', $users[0], $vehicles[0], [
         'dynamic_attributes' => ['proprietaire' => 1]
     ]);
-    if($user1Vehicle === true) {
+    if ($user1Vehicle === true) {
         echo("GRANTED : The vehicle 1 is able to be approved for the user 1\n");
     } else {
         echo("FAIL : The system didn't grant access\n");
@@ -42,7 +42,7 @@ 
     $user3Vehicle = $abac->enforce('vehicle-homologation', $users[2], $vehicles[1], [
         'dynamic_attributes' => ['proprietaire' => 3]
     ]);
-    if(!$user3Vehicle !== true) {
+    if (!$user3Vehicle !== true) {
         echo("DENIED : The vehicle 2 is not approved for the user 3 because its last technical review is too old\n");
     } else {
         echo("FAIL : The system didn't deny access\n");
@@ -50,7 +50,7 @@ 
     $user4Vehicle = $abac->enforce('vehicle-homologation', $users[3], $vehicles[3], [
         'dynamic_attributes' => ['proprietaire' => 4]
     ]);
-    if($user4Vehicle !== true) {
+    if ($user4Vehicle !== true) {
         echo("DENIED : The vehicle 4 is not able to be approved for the user 4 because he has no driving license\n");
     } else {
         echo("FAIL : The system didn't deny access\n");
@@ -58,19 +58,19 @@ 
     $user5Vehicle = $abac->enforce('vehicle-homologation', $users[3], $vehicles[3], [
         'dynamic_attributes' => ['proprietaire' => 1]
     ]);
-    if($user5Vehicle !== true) {
+    if ($user5Vehicle !== true) {
         echo("DENIED : The vehicle 4 is not able to be approved for the user 2 because he doesn't own the vehicle\n");
     } else {
         echo("FAIL : The system didn't deny access\n");
     }
     $userTravel1 = $abac->enforce('travel-to-usa', $users[0]);
-    if($userTravel1 !== true) {
+    if ($userTravel1 !== true) {
         echo("DENIED: The user 1 is not allowed to travel to the USA because he doesn't have an US visa\n");
     } else {
         echo('FAIL: The system didn\'t deny access');
     }
     $userTravel2 = $abac->enforce('travel-to-usa', $users[1]);
-    if($userTravel2 === true) {
+    if ($userTravel2 === true) {
         echo("GRANTED: The user 2 is allowed to travel to the USA\n");
     } else {
         echo('FAIL: The system didn\'t deny access');

example/User.php

Spacing +1 added lines, -1 removed lines

@@ -101,7 +101,7 @@
      * @return \PhpAbac\Example\User
      */
     public function removeVisa(Visa $visa) {
-        if(isset($this->visas[$visa->getId()])) {
+        if (isset($this->visas[$visa->getId()])) {
             unset($this->visas[$visa->getId()]);
         }
         return $this;