Kilix / php-abac

src/Manager/PolicyRuleManager.php

Spacing +7 added lines, -7 removed lines

@@ -31,15 +31,15 @@ 
      */
     public function getRule($ruleName, $user, $resource)
     {
-        if(!isset($this->rules[$ruleName])) {
-            throw new \InvalidArgumentException('The given rule "' . $ruleName . '" is not configured');
+        if (!isset($this->rules[$ruleName])) {
+            throw new \InvalidArgumentException('The given rule "'.$ruleName.'" is not configured');
         }
         $rule =
             (new PolicyRule())
             ->setName($ruleName)
         ;
         // For each policy rule attribute, the data is formatted
-        foreach($this->processRuleAttributes($this->rules[$ruleName]['attributes'], $user, $resource) as $pra) {
+        foreach ($this->processRuleAttributes($this->rules[$ruleName]['attributes'], $user, $resource) as $pra) {
             $rule->addPolicyRuleAttribute($pra);
         }
         return $rule;
@@ -53,7 +53,7 @@ 
      * @param object $resource
      */
     public function processRuleAttributes($attributes, $user, $resource) {
-        foreach($attributes as $attributeName => $attribute) {
+        foreach ($attributes as $attributeName => $attribute) {
             $pra = (new PolicyRuleAttribute())
                 ->setAttribute($this->attributeManager->getAttribute($attributeName))
                 ->setComparison($attribute['comparison'])
@@ -63,8 +63,8 @@ 
             $this->processRuleAttributeComparisonType($pra, $user, $resource);
             // In the case the user configured more keys than the basic ones
             // it will be stored as extra data
-            foreach($attribute as $key => $value) {
-                if(!in_array($key, ['comparison', 'comparison_type', 'value'])) {
+            foreach ($attribute as $key => $value) {
+                if (!in_array($key, ['comparison', 'comparison_type', 'value'])) {
                     $pra->addExtraData($key, $value);
                 }
             }
@@ -81,7 +81,7 @@ 
      * @param object $resource
      */
     public function processRuleAttributeComparisonType(PolicyRuleAttribute $pra, $user, $resource) {
-        switch($pra->getComparisonType()) {
+        switch ($pra->getComparisonType()) {
             case 'user': $pra->setExtraData(['user' => $user]); break;
             case 'object': $pra->setExtraData(['resource' => $resource]); break;
         }

src/Manager/ComparisonManager.php

Spacing +5 added lines, -5 removed lines

@@ -60,22 +60,22 @@ 
             : $pra->getValue()
         ;
         // Checking that the configured comparison type is available
-        if(!isset($this->comparisons[$pra->getComparisonType()])) {
+        if (!isset($this->comparisons[$pra->getComparisonType()])) {
             throw new \InvalidArgumentException('The requested comparison class does not exist');
         }
         // The comparison class will perform the attribute check with the configured method
         // For more complex comparisons, the comparison manager is injected
         $comparison = new $this->comparisons[$pra->getComparisonType()]($this);
-        if(!method_exists($comparison, $pra->getComparison())) {
+        if (!method_exists($comparison, $pra->getComparison())) {
             throw new \InvalidArgumentException('The requested comparison method does not exist');
         }
         // Then the comparison is performed with needed
         $result = $comparison->{$pra->getComparison()}($praValue, $attribute->getValue(), $pra->getExtraData());
         // If the checked attribute is not valid, the attribute slug is marked as rejected
         // The rejected attributes will be returned instead of the expected true boolean
-        if($result !== true) {
+        if ($result !== true) {
             // In case of sub comparing, the error reporting is disabled
-            if(!in_array($attribute->getSlug(), $this->rejectedAttributes) && $subComparing === false) {
+            if (!in_array($attribute->getSlug(), $this->rejectedAttributes) && $subComparing === false) {
                 $this->rejectedAttributes[] = $attribute->getSlug();
             }
             return false;
@@ -102,7 +102,7 @@ 
      * @throws \InvalidArgumentException
      */
     public function getDynamicAttribute($attributeSlug) {
-        if(!isset($this->dynamicAttributes[$attributeSlug])) {
+        if (!isset($this->dynamicAttributes[$attributeSlug])) {
             throw new \InvalidArgumentException("The dynamic value for attribute $attributeSlug was not given");
         }
         return $this->dynamicAttributes[$attributeSlug];

src/Comparison/ArrayComparison.php

Spacing +4 added lines, -4 removed lines

@@ -55,23 +55,23 @@
      * @return boolean
      */
     public function contains($policyRuleAttributes, $attributes, $extraData = []) {
-        foreach($extraData['attribute']->getValue() as $attribute) {
+        foreach ($extraData['attribute']->getValue() as $attribute) {
             $result = true;
             // For each attribute, we check the whole rules set
-            foreach($policyRuleAttributes as $pra) {
+            foreach ($policyRuleAttributes as $pra) {
                 $attributeData = $pra->getAttribute();
                 $attributeData->setValue(
                     $this->comparisonManager->getAttributeManager()->retrieveAttribute($attributeData, $extraData['user'], $attribute)
                 );
                 // If one field is not matched, the whole attribute is rejected
-                if(!$this->comparisonManager->compare($pra, true)) {
+                if (!$this->comparisonManager->compare($pra, true)) {
                     //var_dump($attributeData->getName(), $attributeData->getValue(), $pra->getValue());
                     $result = false;
                     break;
                 }
             }
             // If the result is still true at the end of the attribute check, the rule is enforced
-            if($result === true) {
+            if ($result === true) {
                 return true;
             }
         }

src/Abac.php

Spacing +9 added lines, -9 removed lines

@@ -71,18 +71,18 @@ 
     public function enforce($ruleName, $user, $resource = null, $options = []) {
         // If there is dynamic attributes, we pass them to the comparison manager
         // When a comparison will be performed, the passed values will be retrieved and used
-        if(isset($options['dynamic_attributes'])) {
+        if (isset($options['dynamic_attributes'])) {
             $this->comparisonManager->setDynamicAttributes($options['dynamic_attributes']);
         }
         // Retrieve cache value for the current rule and values if cache item is valid
-        if(($cacheResult = isset($options['cache_result']) && $options['cache_result'] === true) === true) {
+        if (($cacheResult = isset($options['cache_result']) && $options['cache_result'] === true) === true) {
             $cacheItem = $this->cacheManager->getItem(
-                "$ruleName-{$user->getId()}-" . (($resource !== null) ? $resource->getId() : ''),
+                "$ruleName-{$user->getId()}-".(($resource !== null) ? $resource->getId() : ''),
                 (isset($options['cache_driver'])) ? $options['cache_driver'] : null,
                 (isset($options['cache_ttl'])) ? $options['cache_ttl'] : null
             );
             // We check if the cache value s valid before returning it
-            if(($cacheValue = $cacheItem->get()) !== null) {
+            if (($cacheValue = $cacheItem->get()) !== null) {
                 return $cacheValue;
             }
         }
@@ -91,7 +91,7 @@ 
         foreach ($policyRule->getPolicyRuleAttributes() as $pra) {
             $attribute = $pra->getAttribute();
             $attribute->setValue($this->attributeManager->retrieveAttribute($attribute, $user, $resource));
-            if(count($pra->getExtraData()) > 0) {
+            if (count($pra->getExtraData()) > 0) {
                 $this->processExtraData($pra, $user, $resource);
             }
             $this->comparisonManager->compare($pra);
@@ -99,7 +99,7 @@ 
         // The given result could be an array of rejected attributes or true
         // True means that the rule is correctly enforced for the given user and resource
         $result = $this->comparisonManager->getResult();
-        if($cacheResult) {
+        if ($cacheResult) {
             $cacheItem->set($result);
             $this->cacheManager->save($cacheItem);
         }
@@ -112,8 +112,8 @@ 
      * @param object $resource
      */
     public function processExtraData(PolicyRuleAttribute $pra, $user, $resource) {
-        foreach($pra->getExtraData() as $key => $data) {
-            switch($key) {
+        foreach ($pra->getExtraData() as $key => $data) {
+            switch ($key) {
                 case 'with':
                     // This data has to be removed for it will be stored elsewhere
                     // in the policy rule attribute
@@ -123,7 +123,7 @@ 
                     $subPolicyRuleAttributes = [];
                     $extraData = [];
 
-                    foreach($this->policyRuleManager->processRuleAttributes($data, $user, $resource) as $subPolicyRuleAttribute) {
+                    foreach ($this->policyRuleManager->processRuleAttributes($data, $user, $resource) as $subPolicyRuleAttribute) {
                         $subPolicyRuleAttributes[] = $subPolicyRuleAttribute;
                     }
                     $pra->setValue($subPolicyRuleAttributes);

src/Cache/Pool/TextCacheItemPool.php

Indentation +1 added lines, -1 removed lines

@@ -128,7 +128,7 @@
     public function clear() {
         $items = glob("{$this->cacheFolder}/*.txt"); // get all file names
         foreach($items as $item){ // iterate files
-          if(is_file($item))
+            if(is_file($item))
             unlink($item); // delete file
         }
         $this->deferredItems = [];

Spacing +12 added lines, -12 removed lines

@@ -27,7 +27,7 @@ 
         $this->cacheFolder =
             (isset($options['cache_folder']))
             ? "{$options['cache_folder']}/text"
-            : __DIR__ . '/../../../data/cache/text'
+            : __DIR__.'/../../../data/cache/text'
         ;
     }
 
@@ -35,10 +35,10 @@ 
      * {@inheritdoc}
      */
     public function deleteItem($key) {
-        if(is_file("{$this->cacheFolder}/$key.txt")) {
+        if (is_file("{$this->cacheFolder}/$key.txt")) {
             unlink("{$this->cacheFolder}/$key.txt");
         }
-        if(isset($this->deferredItems[$key])) {
+        if (isset($this->deferredItems[$key])) {
             unset($this->deferredItems[$key]);
         }
         return true;
@@ -48,8 +48,8 @@ 
      * {@inheritdoc}
      */
     public function deleteItems(array $keys) {
-        foreach($keys as $key) {
-            if(!$this->deleteItem($key)) {
+        foreach ($keys as $key) {
+            if (!$this->deleteItem($key)) {
                 return false;
             }
         }
@@ -80,7 +80,7 @@ 
      * {@inheritdoc}
      */
     public function commit() {
-        foreach($this->deferredItems as $key => $item) {
+        foreach ($this->deferredItems as $key => $item) {
             $this->save($item);
             unset($this->deferredItems[$key]);
         }
@@ -99,10 +99,10 @@ 
      */
     public function getItem($key) {
         $item = new TextCacheItem($key);
-        if(!$this->hasItem($key)) {
+        if (!$this->hasItem($key)) {
             return $item;
         }
-        $data = explode(';',file_get_contents("{$this->cacheFolder}/{$key}.txt"));
+        $data = explode(';', file_get_contents("{$this->cacheFolder}/{$key}.txt"));
         return $item
             ->set($data[0])
             ->expiresAt((new \DateTime($data[1])))
@@ -114,8 +114,8 @@ 
      */
     public function getItems(array $keys = array()) {
         $items = [];
-        foreach($keys as $key) {
-            if($this->hasItem($key)) {
+        foreach ($keys as $key) {
+            if ($this->hasItem($key)) {
                 $items[$key] = $this->getItem($key);
             }
         }
@@ -127,8 +127,8 @@ 
      */
     public function clear() {
         $items = glob("{$this->cacheFolder}/*.txt"); // get all file names
-        foreach($items as $item){ // iterate files
-          if(is_file($item))
+        foreach ($items as $item) { // iterate files
+          if (is_file($item))
             unlink($item); // delete file
         }
         $this->deferredItems = [];

Braces +4 added lines, -2 removed lines

@@ -128,8 +128,10 @@
     public function clear() {
         $items = glob("{$this->cacheFolder}/*.txt"); // get all file names
         foreach($items as $item){ // iterate files
-          if(is_file($item))
-            unlink($item); // delete file
+          if(is_file($item)) {
+                      unlink($item);
+          }
+          // delete file
         }
         $this->deferredItems = [];
         return true;