Issues in TargetRouteTest.php (master) - Issues in master - KSST/KF - Measure and Improve Code Quality continuously with Scrutinizer

Issues (3098)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tests/KochTest/Router/TargetRouteTest.php (15 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace KochTest\Router;

use Koch\Router\TargetRoute;

class TargetRouteTest extends \PHPUnit_Framework_TestCase
{
    /**
     * @var TargetRoute
     */
    protected $object;

    /**
     * Sets up the fixture, for example, opens a network connection.
     * This method is called before a test is executed.
     */
    protected function setUp()
    {
        $this->object = TargetRoute::instantiate();
    }

    /**
     * Tears down the fixture, for example, closes a network connection.
     * This method is called after a test is executed.
     */
    protected function tearDown()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        // static instance
        $this->object->reset();
        unset($_SESSION);
    }

    /**
     * @covers Koch\Router\TargetRoute::instantiate
     */
    public function testInstantiate()
    {
        // Note: phpunit BUG
        // $this->assertInstanceOf() autoloads the class, leading to redeclaration error

        $tr = TargetRoute::instantiate();
        $this->assertTrue($tr instanceof TargetRoute);
    }

    /**
     * @covers Koch\Router\TargetRoute::setFilename
     * @covers Koch\Router\TargetRoute::getFilename
     */
    public function testSetFilename()
    {
        //$this->object->setApplicationNamespace('KochTest/Fixtures/Application');

        // test filename construction, if empty filename
        $file1 = '';
        $this->object->setFilename($file1);
        $this->assertEquals(
            realpath(APPLICATION_MODULES_PATH . 'Index/Controller/IndexController.php'),
            $this->object->getFilename()
        );

        // setter test
        $file2 = 'abc';
        $this->object->setFilename($file2);
        $this->assertEquals($file2, $this->object->getFilename());
    }

    /**
     * @covers Koch\Router\TargetRoute::setClassname
     * @covers Koch\Router\TargetRoute::getClassname
     */
    public function testSetClassname()
    {
        $this->object->setApplicationNamespace('\KochTest\Fixtures\Application');

        // test filename construction, if empty filename
        $class1 = '';
        $this->object->setClassname($class1);
        $this->assertEquals(
            '\KochTest\Fixtures\Application\Modules\Index\Controller\IndexController',
            $this->object->getClassname()
        );

        $class2 = 'abc';
        $this->object->setClassname($class2);
        $this->assertEquals($class2, $this->object->getClassname());
    }

    /**
     * @covers Koch\Router\TargetRoute::getController
     * @covers Koch\Router\TargetRoute::setController
     */
    public function testGetController()
    {
        $class = '';
        $this->object->setController($class);
        // if controller not set, it will be the default module name
        $this->assertEquals('Index', $this->object->getController());

        $this->object->setController('aController');
        $this->assertEquals('AController', $this->object->getController());
    }

    /**
     * @covers Koch\Router\TargetRoute::setModule
     * @covers Koch\Router\TargetRoute::getModule
     */
    public function testSetModule()
    {
        $module = 'ABCModule';
        $this->object->setModule($module);
        $this->assertEquals($module, $this->object->getModule());
    }

    /**
     * @covers Koch\Router\TargetRoute::setAction
     * @covers Koch\Router\TargetRoute::getAction
     */
    public function testSetAction()
    {
        $e = 'abc';
        $this->object->setAction($e);
        $this->assertEquals($e, $this->object->getAction());
    }

    /**
     * @covers Koch\Router\TargetRoute::getActionNameWithoutPrefix
     */
    public function testGetActionNameWithoutPrefix()
    {
        $this->object->setAction('myAction');
        $er = $this->object->getActionNameWithoutPrefix();
        $this->assertEquals($er, 'myAction');
    }

    /**
     * @covers Koch\Router\TargetRoute::setId
     * @covers Koch\Router\TargetRoute::getId
     */
    public function testSetId()
    {
        $id = '1';
        $this->object->setId($id);
        $this->assertEquals($id, $this->object->getId());
    }

    /**
     * @covers Koch\Router\TargetRoute::setAction
     * @covers Koch\Router\TargetRoute::getActionName
     * @covers Koch\Router\TargetRoute::getMethod
     */
    public function testGetActionName()
    {
        $this->object->setAction('MyAction');

        $this->assertEquals('actionMyAction', $this->object->getMethod());
        $this->assertEquals('actionMyAction', $this->object->getActionName());
    }

    /**
     * @covers Koch\Router\TargetRoute::setMethod
     * @covers Koch\Router\TargetRoute::getMethod
     * @covers Koch\Router\TargetRoute::getActionName
     */
    public function testSetMethod()
    {
        $this->assertEquals('actionList', $this->object->getMethod());

        $this->object->setMethod('a-method');
        $this->assertEquals('a-method', $this->object->getActionName());
    }

    /**
     * @covers Koch\Router\TargetRoute::setParameters
     * @covers Koch\Router\TargetRoute::getParameters
     */
    public function testSetParameters()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $_SERVER['REQUEST_METHOD'] = 'GET';

        $this->object->setParameters(['param1' => 'p1-value']);

        $this->assertArrayHasKey('param1', $this->object->getParameters());

        unset($_SERVER['REQUEST_METHOD']);
    }

    /**
     * @covers Koch\Router\TargetRoute::getParameters
     */
    public function testGetParameters()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $_SERVER['REQUEST_METHOD'] = 'GET';

        // test for default array

        $er = $this->object->getParameters();
        $this->assertTrue(is_array($er));

        // test if values from $_POST array are automatically populated
        // POST array is not populated on linux???
        /* $_SERVER['REQUEST_METHOD'] = 'POST';

          $_POST['KEY1'] = 'VALUE1';

          $er = $this->object->getParameters();
          $this->assertTrue(is_array($er));
          $this->assertArrayHasKey('KEY1', $er);

          unset($_SERVER['REQUEST_METHOD']);
          unset($_POST['KEY1']); */
    }

    /**
     * @covers Koch\Router\TargetRoute::getFormat
     */
    public function testGetFormat()
    {
        $er = $this->object->getFormat();
        $this->assertEquals($er, 'html');
    }

    /**
     * @covers Koch\Router\TargetRoute::getRequestMethod
     */
    public function testGetRequestMethod()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $_SERVER['REQUEST_METHOD'] = 'GET';

        $er = $this->object->getRequestMethod();
        $this->assertEquals($er, 'GET');

        unset($_SERVER['REQUEST_METHOD']);
    }

    /**
     * @covers Koch\Router\TargetRoute::getLayoutMode
     */
    public function testGetLayoutMode()
    {
        $this->object->setParameters(['layout' => true]);
        $this->assertTrue($this->object->getLayoutMode());
    }

    /**
     * @covers Koch\Router\TargetRoute::getAjaxMode
     * @depend Koch\Http\HttpRequest::isAjax
     */
    public function testGetAjaxMode()
    {
        $this->assertFalse($this->object->getAjaxMode());
    }

    /**
     * @covers Koch\Router\TargetRoute::setRenderEngine
     * @covers Koch\Router\TargetRoute::getRenderEngine
     */
    public function testSetRenderEngine()
    {
        $renderEngine = 'CopyCat';
        $this->object->setRenderEngine($renderEngine);
        $this->assertEquals($renderEngine, $this->object->getRenderEngine());
    }

    /**
     * @covers Koch\Router\TargetRoute::getBackendTheme
     */
    public function testGetBackendTheme()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $this->assertEquals('default', $this->object->getBackendTheme());

        $theme                             = 'A-Backend-Theme';
        $_SESSION['user']['backend_theme'] = $theme;
        $this->assertEquals($theme, $this->object->getBackendTheme());
    }

    /**
     * @covers Koch\Router\TargetRoute::getFrontendTheme
     */
    public function testGetFrontendTheme()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $this->assertEquals('default', $this->object->getFrontendTheme());

        $theme                              = 'A-Frontend-Theme';
        $_SESSION['user']['frontend_theme'] = $theme;
        $this->assertEquals($theme, $this->object->getFrontendTheme());
    }

    /**
     * @covers Koch\Router\TargetRoute::getThemeName
     * @covers Koch\Router\TargetRoute::setThemeName
     */
    public function testGetThemeName()
    {
        // default
        // NOTICE! this assertion needs a TargetRoute and a $_Session reset
        $this->assertEquals('default', $this->object->getThemeName());

        // explicitly set
        $theme = 'MyTheme';
        $this->object->setThemeName($theme);
        $this->assertEquals($theme, $this->object->getThemeName());
        $this->object->reset();

        $this->object->setModule('controlcenter');
        $this->assertEquals('default', $this->object->getThemeName());

        $this->object->setController('NewsAdminController');
        $this->assertEquals('default', $this->object->getThemeName());
    }

    /**
     * @covers Koch\Router\TargetRoute::getModRewriteStatus
     */
    public function testGetModRewriteStatus()
    {
        $er = $this->object->getModRewriteStatus();
        $this->assertFalse($er);
    }

    /**
     * @covers Koch\Router\TargetRoute::dispatchable
     */
    public function testDispatchable()
    {
        $this->object->setApplicationNamespace('\KochTest\Fixtures\Application');

        $this->assertTrue($this->object->dispatchable());
    }

    /**
     * @covers Koch\Router\TargetRoute::setSegmentsToTargetRoute
     */
    public function testSetSegmentsToTargetRoute()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $_SERVER['REQUEST_METHOD'] = 'GET';

        $segments = [];
        $er       = $this->object->setSegmentsToTargetRoute($segments);

        $this->assertTrue(is_object($er));

        unset($_SERVER['REQUEST_METHOD']);
    }

    /**
     * @covers Koch\Router\TargetRoute::reset
     */
    public function testReset()
    {
        $targetRouteParameters_BEFORE = $this->object->getRoute();

        $this->object->setID('1');
        $targetRouteParameters_MODDED = $this->object->getRoute();

        $this->assertNotEquals($targetRouteParameters_MODDED, $targetRouteParameters_BEFORE);

        $this->object->reset();
        $targetRouteParameters_AFTER = $this->object->getRoute();

        $this->assertEquals($targetRouteParameters_AFTER, $targetRouteParameters_BEFORE);

    }

    /**
     * @covers Koch\Router\TargetRoute::getRoute
     */
    public function testGetRoute()
    {
        // this fetches the parameters array
        $er = $this->object->getRoute();
        $this->assertTrue(is_array($er));
    }
}


1			<?php
2
3			namespace KochTest\Router;
4
5			use Koch\Router\TargetRoute;
6
7			class TargetRouteTest extends \PHPUnit_Framework_TestCase
8			{
9			/**
10			* @var TargetRoute
11			*/
12			protected $object;
13
14			/**
15			* Sets up the fixture, for example, opens a network connection.
16			* This method is called before a test is executed.
17			*/
18			protected function setUp()
19			{
20			$this->object = TargetRoute::instantiate();
21			}
22
23			/**
24			* Tears down the fixture, for example, closes a network connection.
25			* This method is called after a test is executed.
26			*/
27			protected function tearDown()
			0 ignored issues – show Coding Style introduced 2015-12-23 17:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this `tearDown` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
28			{
29			// static instance
30			$this->object->reset();
31			unset($_SESSION);
32			}
33
34			/**
35			* @covers Koch\Router\TargetRoute::instantiate
36			*/
37			public function testInstantiate()
38			{
39			// Note: phpunit BUG

KSST / KF

Issues (3098)

Security Analysis not enabled

tests/KochTest/Router/TargetRouteTest.php (15 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like