TargetRouteTest - Code Metrics - KSST/KF - Measure and Improve Code Quality continuously with Scrutinizer

TargetRouteTest A
last analyzed 2017-04-11 14:32 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	360
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
dl	0
loc	360
rs	10
c	0
b	0
f	0
wmc	27
lcom	1
cbo	2

27 Methods

Rating	Name	Size	Complexity
A	setUp()	4	1
A	tearDown()	6	1
A	testInstantiate()	8	1
A	testSetFilename()	16	1
A	testSetClassname()	16	1
A	testGetController()	10	1
A	testSetModule()	6	1
A	testSetAction()	6	1
A	testGetActionNameWithoutPrefix()	6	1
A	testSetId()	6	1
A	testGetActionName()	7	1
A	testSetMethod()	7	1
A	testSetParameters()	10	1
A	testGetParameters()	20	1
A	testGetFormat()	5	1
A	testGetRequestMethod()	9	1
A	testGetLayoutMode()	5	1
A	testGetAjaxMode()	4	1
A	testSetRenderEngine()	6	1
A	testGetBackendTheme()	8	1
A	testGetFrontendTheme()	8	1
A	testGetThemeName()	18	1
A	testGetModRewriteStatus()	5	1
A	testDispatchable()	6	1
A	testSetSegmentsToTargetRoute()	11	1
A	testReset()	10	1
A	testGetRoute()	6	1

<?php

namespace KochTest\Router;

use Koch\Router\TargetRoute;

class TargetRouteTest extends \PHPUnit_Framework_TestCase
{
    /**
     * @var TargetRoute
     */
    protected $object;

    /**
     * Sets up the fixture, for example, opens a network connection.
     * This method is called before a test is executed.
     */
    protected function setUp()
    {
        $this->object = TargetRoute::instantiate();
    }

    /**
     * Tears down the fixture, for example, closes a network connection.
     * This method is called after a test is executed.
     */
    protected function tearDown()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        // static instance
        $this->object->reset();
        unset($_SESSION);
    }

    /**
     * @covers Koch\Router\TargetRoute::instantiate
     */
    public function testInstantiate()
    {
        // Note: phpunit BUG
        // $this->assertInstanceOf() autoloads the class, leading to redeclaration error

        $tr = TargetRoute::instantiate();
        $this->assertTrue($tr instanceof TargetRoute);
    }

    /**
     * @covers Koch\Router\TargetRoute::setFilename
     * @covers Koch\Router\TargetRoute::getFilename
     */
    public function testSetFilename()
    {
        //$this->object->setApplicationNamespace('KochTest/Fixtures/Application');

        // test filename construction, if empty filename
        $file1 = '';
        $this->object->setFilename($file1);
        $this->assertEquals(
            realpath(APPLICATION_MODULES_PATH . 'Index/Controller/IndexController.php'),
            $this->object->getFilename()
        );

        // setter test
        $file2 = 'abc';
        $this->object->setFilename($file2);
        $this->assertEquals($file2, $this->object->getFilename());
    }

    /**
     * @covers Koch\Router\TargetRoute::setClassname
     * @covers Koch\Router\TargetRoute::getClassname
     */
    public function testSetClassname()
    {
        $this->object->setApplicationNamespace('\KochTest\Fixtures\Application');

        // test filename construction, if empty filename
        $class1 = '';
        $this->object->setClassname($class1);
        $this->assertEquals(
            '\KochTest\Fixtures\Application\Modules\Index\Controller\IndexController',
            $this->object->getClassname()
        );

        $class2 = 'abc';
        $this->object->setClassname($class2);
        $this->assertEquals($class2, $this->object->getClassname());
    }

    /**
     * @covers Koch\Router\TargetRoute::getController
     * @covers Koch\Router\TargetRoute::setController
     */
    public function testGetController()
    {
        $class = '';
        $this->object->setController($class);
        // if controller not set, it will be the default module name
        $this->assertEquals('Index', $this->object->getController());

        $this->object->setController('aController');
        $this->assertEquals('AController', $this->object->getController());
    }

    /**
     * @covers Koch\Router\TargetRoute::setModule
     * @covers Koch\Router\TargetRoute::getModule
     */
    public function testSetModule()
    {
        $module = 'ABCModule';
        $this->object->setModule($module);
        $this->assertEquals($module, $this->object->getModule());
    }

    /**
     * @covers Koch\Router\TargetRoute::setAction
     * @covers Koch\Router\TargetRoute::getAction
     */
    public function testSetAction()
    {
        $e = 'abc';
        $this->object->setAction($e);
        $this->assertEquals($e, $this->object->getAction());
    }

    /**
     * @covers Koch\Router\TargetRoute::getActionNameWithoutPrefix
     */
    public function testGetActionNameWithoutPrefix()
    {
        $this->object->setAction('myAction');
        $er = $this->object->getActionNameWithoutPrefix();
        $this->assertEquals($er, 'myAction');
    }

    /**
     * @covers Koch\Router\TargetRoute::setId
     * @covers Koch\Router\TargetRoute::getId
     */
    public function testSetId()
    {
        $id = '1';
        $this->object->setId($id);
        $this->assertEquals($id, $this->object->getId());
    }

    /**
     * @covers Koch\Router\TargetRoute::setAction
     * @covers Koch\Router\TargetRoute::getActionName
     * @covers Koch\Router\TargetRoute::getMethod
     */
    public function testGetActionName()
    {
        $this->object->setAction('MyAction');

        $this->assertEquals('actionMyAction', $this->object->getMethod());
        $this->assertEquals('actionMyAction', $this->object->getActionName());
    }

    /**
     * @covers Koch\Router\TargetRoute::setMethod
     * @covers Koch\Router\TargetRoute::getMethod
     * @covers Koch\Router\TargetRoute::getActionName
     */
    public function testSetMethod()
    {
        $this->assertEquals('actionList', $this->object->getMethod());

        $this->object->setMethod('a-method');
        $this->assertEquals('a-method', $this->object->getActionName());
    }

    /**
     * @covers Koch\Router\TargetRoute::setParameters
     * @covers Koch\Router\TargetRoute::getParameters
     */
    public function testSetParameters()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $_SERVER['REQUEST_METHOD'] = 'GET';

        $this->object->setParameters(['param1' => 'p1-value']);

        $this->assertArrayHasKey('param1', $this->object->getParameters());

        unset($_SERVER['REQUEST_METHOD']);
    }

    /**
     * @covers Koch\Router\TargetRoute::getParameters
     */
    public function testGetParameters()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $_SERVER['REQUEST_METHOD'] = 'GET';

        // test for default array

        $er = $this->object->getParameters();
        $this->assertTrue(is_array($er));

        // test if values from $_POST array are automatically populated
        // POST array is not populated on linux???
        /* $_SERVER['REQUEST_METHOD'] = 'POST';

          $_POST['KEY1'] = 'VALUE1';

          $er = $this->object->getParameters();
          $this->assertTrue(is_array($er));
          $this->assertArrayHasKey('KEY1', $er);

          unset($_SERVER['REQUEST_METHOD']);
          unset($_POST['KEY1']); */
    }

    /**
     * @covers Koch\Router\TargetRoute::getFormat
     */
    public function testGetFormat()
    {
        $er = $this->object->getFormat();
        $this->assertEquals($er, 'html');
    }

    /**
     * @covers Koch\Router\TargetRoute::getRequestMethod
     */
    public function testGetRequestMethod()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $_SERVER['REQUEST_METHOD'] = 'GET';

        $er = $this->object->getRequestMethod();
        $this->assertEquals($er, 'GET');

        unset($_SERVER['REQUEST_METHOD']);
    }

    /**
     * @covers Koch\Router\TargetRoute::getLayoutMode
     */
    public function testGetLayoutMode()
    {
        $this->object->setParameters(['layout' => true]);
        $this->assertTrue($this->object->getLayoutMode());
    }

    /**
     * @covers Koch\Router\TargetRoute::getAjaxMode
     * @depend Koch\Http\HttpRequest::isAjax
     */
    public function testGetAjaxMode()
    {
        $this->assertFalse($this->object->getAjaxMode());
    }

    /**
     * @covers Koch\Router\TargetRoute::setRenderEngine
     * @covers Koch\Router\TargetRoute::getRenderEngine
     */
    public function testSetRenderEngine()
    {
        $renderEngine = 'CopyCat';
        $this->object->setRenderEngine($renderEngine);
        $this->assertEquals($renderEngine, $this->object->getRenderEngine());
    }

    /**
     * @covers Koch\Router\TargetRoute::getBackendTheme
     */
    public function testGetBackendTheme()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $this->assertEquals('default', $this->object->getBackendTheme());

        $theme                             = 'A-Backend-Theme';
        $_SESSION['user']['backend_theme'] = $theme;
        $this->assertEquals($theme, $this->object->getBackendTheme());
    }

    /**
     * @covers Koch\Router\TargetRoute::getFrontendTheme
     */
    public function testGetFrontendTheme()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $this->assertEquals('default', $this->object->getFrontendTheme());

        $theme                              = 'A-Frontend-Theme';
        $_SESSION['user']['frontend_theme'] = $theme;
        $this->assertEquals($theme, $this->object->getFrontendTheme());
    }

    /**
     * @covers Koch\Router\TargetRoute::getThemeName
     * @covers Koch\Router\TargetRoute::setThemeName
     */
    public function testGetThemeName()
    {
        // default
        // NOTICE! this assertion needs a TargetRoute and a $_Session reset
        $this->assertEquals('default', $this->object->getThemeName());

        // explicitly set
        $theme = 'MyTheme';
        $this->object->setThemeName($theme);
        $this->assertEquals($theme, $this->object->getThemeName());
        $this->object->reset();

        $this->object->setModule('controlcenter');
        $this->assertEquals('default', $this->object->getThemeName());

        $this->object->setController('NewsAdminController');
        $this->assertEquals('default', $this->object->getThemeName());
    }

    /**
     * @covers Koch\Router\TargetRoute::getModRewriteStatus
     */
    public function testGetModRewriteStatus()
    {
        $er = $this->object->getModRewriteStatus();
        $this->assertFalse($er);
    }

    /**
     * @covers Koch\Router\TargetRoute::dispatchable
     */
    public function testDispatchable()
    {
        $this->object->setApplicationNamespace('\KochTest\Fixtures\Application');

        $this->assertTrue($this->object->dispatchable());
    }

    /**
     * @covers Koch\Router\TargetRoute::setSegmentsToTargetRoute
     */
    public function testSetSegmentsToTargetRoute()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $_SERVER['REQUEST_METHOD'] = 'GET';

        $segments = [];
        $er       = $this->object->setSegmentsToTargetRoute($segments);

        $this->assertTrue(is_object($er));

        unset($_SERVER['REQUEST_METHOD']);
    }

    /**
     * @covers Koch\Router\TargetRoute::reset
     */
    public function testReset()
    {
        $targetRouteParameters_BEFORE = $this->object->getRoute();

        $this->object->setID('1');
        $targetRouteParameters_MODDED = $this->object->getRoute();

        $this->assertNotEquals($targetRouteParameters_MODDED, $targetRouteParameters_BEFORE);

        $this->object->reset();
        $targetRouteParameters_AFTER = $this->object->getRoute();

        $this->assertEquals($targetRouteParameters_AFTER, $targetRouteParameters_BEFORE);

    }

    /**
     * @covers Koch\Router\TargetRoute::getRoute
     */
    public function testGetRoute()
    {
        // this fetches the parameters array
        $er = $this->object->getRoute();
        $this->assertTrue(is_array($er));
    }
}


1			<?php
2
3			namespace KochTest\Router;
4
5			use Koch\Router\TargetRoute;
6
7			class TargetRouteTest extends \PHPUnit_Framework_TestCase
8			{
9			/**
10			* @var TargetRoute
11			*/
12			protected $object;
13
14			/**
15			* Sets up the fixture, for example, opens a network connection.
16			* This method is called before a test is executed.
17			*/
18			protected function setUp()
19			{
20			$this->object = TargetRoute::instantiate();
21			}
22
23			/**
24			* Tears down the fixture, for example, closes a network connection.
25			* This method is called after a test is executed.
26			*/
27			protected function tearDown()
			0 ignored issues – show Coding Style introduced 2015-12-23 17:35 UTC by Report Bug Copy Issue Report `tearDown` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
28			{
29			// static instance
30			$this->object->reset();
31			unset($_SESSION);
32			}
33
34			/**
35			* @covers Koch\Router\TargetRoute::instantiate
36			*/
37			public function testInstantiate()
38			{
39			// Note: phpunit BUG

KSST / KF

TargetRouteTest A last analyzed 2017-04-11 14:32 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

27 Methods

Duplication Side-by-Side

Filter issues like

TargetRouteTest A
last analyzed 2017-04-11 14:32 UTC