Issues in ACL.php (master) - Issues in master - KSST/KF - Measure and Improve Code Quality continuously with Scrutinizer

Issues (3098)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tests/KochTest/Permissions/ACL.php (9 issues)

Labels

Severity

Major 9

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace KochTest\Permissions;

use Koch\Permissions\Acl;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

class ACL extends \PHPUnit_Framework_TestCase
{
    /**
     * @var Acl
     */
    protected $acl;

    /**
     * Sets up the fixture, for example, opens a network connection.
     * This method is called before a test is executed.
     */
    protected function setUp()
    {
        $this->acl = new self();

    }

    /**
     * Tears down the fixture, for example, closes a network connection.
     * This method is called after a test is executed.
     */
    protected function tearDown()
    {
        unset($this->acl);
    }

    /**
     * @covers Koch\Permissions\Acl::addRole
     */
    public function testAddRole()
    {
        $this->acl->addRole('Hausbewohner');

        $this->acl->addRole('Hausbewohner', 'Mieter1');
        $this->acl->addRole('Hausbewohner', 'Mieter2');
        $this->acl->addRole('Hausverwalter');

    }

    /**
     * @covers Koch\Permissions\Acl::addResource
     */
    public function testAddResource()
    {
        $this->acl->addResource('Haus');

        $this->acl->addResource('Haus', 'Wohnung1');
        $this->acl->addResource('Haus', 'Wohnung2');
    }

    /**
     * @covers Koch\Permissions\Acl::addRuleAllow
     */
    public function testRuleAllow()
    {
        $this->acl->ruleAllow('Hausverwalter', 'view', 'Haus');
        $this->acl->ruleAllow('Mieter1', 'view', 'Wohnung1');
        $this->acl->ruleAllow('Mieter2', 'view', 'Wohnung2');
    }

    /**
     * @covers Koch\Permissions\Acl::addRuleDeny
     */
    public function testRuleDeny()
    {
        $this->acl->ruleDeny('Mieter1', 'view', 'Wohnung2');
        $this->acl->ruleDeny('Mieter2', 'view', 'Wohnung1');
    }

    /**
     * @covers Koch\Permissions\Acl::isAllowed
     */
    public function testIsAllowed()
    {
        // the shorthand in the user object is $user->isAllowed($action, $resource);
        // the Role is incomming via the user object (user_id -> roles table)
        // action and resource are identified by the router and exist in the TargetRoute object
        $this->acl->isAllowed($role, $action, $resource);

    }
}


1			<?php
2
3			namespace KochTest\Permissions;
4
5			use Koch\Permissions\Acl;
			0 ignored issues – show Bug introduced 2015-12-23 17:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this This use statement conflicts with another class in this namespace, `KochTest\Permissions\Acl`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
6
7			class ACL extends \PHPUnit_Framework_TestCase
8			{
9			/**
10			* @var Acl
11			*/
12			protected $acl;
13
14			/**
15			* Sets up the fixture, for example, opens a network connection.
16			* This method is called before a test is executed.
17			*/
18			protected function setUp()
19			{
20			$this->acl = new self();
			0 ignored issues – show Documentation Bug introduced 2016-06-24 13:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `new self()` of type `object<KochTest\Permissions\ACL>` is incompatible with the declared type `object<Koch\Permissions\Acl>` of property `$acl`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
21			}
22
23			/**
24			* Tears down the fixture, for example, closes a network connection.
25			* This method is called after a test is executed.
26			*/
27			protected function tearDown()
28			{
29			unset($this->acl);
30			}
31
32			/**
33			* @covers Koch\Permissions\Acl::addRole
34			*/
35			public function testAddRole()
36			{
37			$this->acl->addRole('Hausbewohner');
			0 ignored issues – show Bug introduced 2015-12-23 17:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this The call to `addRole()` misses a required argument `$role`. This check looks for function calls that miss required arguments. Loading history...
38			$this->acl->addRole('Hausbewohner', 'Mieter1');
39			$this->acl->addRole('Hausbewohner', 'Mieter2');
40			$this->acl->addRole('Hausverwalter');
			0 ignored issues – show Bug introduced 2015-12-23 17:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this The call to `addRole()` misses a required argument `$role`. This check looks for function calls that miss required arguments. Loading history...
41			}
42
43			/**
44			* @covers Koch\Permissions\Acl::addResource
45			*/
46			public function testAddResource()
47			{
48			$this->acl->addResource('Haus');
			0 ignored issues – show Bug introduced 2015-12-23 17:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this The call to `addResource()` misses a required argument `$resource`. This check looks for function calls that miss required arguments. Loading history...
49			$this->acl->addResource('Haus', 'Wohnung1');
50			$this->acl->addResource('Haus', 'Wohnung2');
51			}
52
53			/**
54			* @covers Koch\Permissions\Acl::addRuleAllow
55			*/
56			public function testRuleAllow()
57			{
58			$this->acl->ruleAllow('Hausverwalter', 'view', 'Haus');
59			$this->acl->ruleAllow('Mieter1', 'view', 'Wohnung1');
60			$this->acl->ruleAllow('Mieter2', 'view', 'Wohnung2');
61			}
62
63			/**
64			* @covers Koch\Permissions\Acl::addRuleDeny
65			*/
66			public function testRuleDeny()
67			{
68			$this->acl->ruleDeny('Mieter1', 'view', 'Wohnung2');
69			$this->acl->ruleDeny('Mieter2', 'view', 'Wohnung1');
70			}
71
72			/**
73			* @covers Koch\Permissions\Acl::isAllowed
74			*/
75			public function testIsAllowed()
76			{
77			// the shorthand in the user object is $user->isAllowed($action, $resource);
78			// the Role is incomming via the user object (user_id -> roles table)
79			// action and resource are identified by the router and exist in the TargetRoute object
80			$this->acl->isAllowed($role, $action, $resource);
			0 ignored issues – show Bug introduced 2015-12-23 17:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$role` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history... Bug introduced 2015-12-23 17:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$action` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history... Bug introduced 2015-12-23 17:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$resource` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history... Bug introduced 2015-12-23 17:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `isAllowed()` does not seem to exist on `object<Koch\Permissions\Acl>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
81			}
82			}
83

KSST / KF

Issues (3098)

Security Analysis not enabled

tests/KochTest/Permissions/ACL.php (9 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like