KochTest\Permissions\ACL

Complexity

Total Complexity

7

Size/Duplication

Total Lines	76
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	testRuleDeny()	0	5	1
A	testIsAllowed()	0	7	1
A	setUp()	0	4	1
A	tearDown()	0	4	1
A	testAddRole()	0	7	1
A	testAddResource()	0	6	1
A	testRuleAllow()	0	6	1

<?php

namespace KochTest\Permissions;

use Koch\Permissions\Acl;

This use statement conflicts with another class in this namespace, KochTest\Permissions\Acl.

class ACL extends \PHPUnit_Framework_TestCase
{
    /**
     * @var Acl
     */
    protected $acl;

    /**
     * Sets up the fixture, for example, opens a network connection.
     * This method is called before a test is executed.
     */
    protected function setUp()
    {
        $this->acl = new self();

It seems like new self() of type object<KochTest\Permissions\ACL> is incompatible with the declared type object<Koch\Permissions\Acl> of property $acl.

    }

    /**
     * Tears down the fixture, for example, closes a network connection.
     * This method is called after a test is executed.
     */
    protected function tearDown()
    {
        unset($this->acl);
    }

    /**
     * @covers Koch\Permissions\Acl::addRole
     */
    public function testAddRole()
    {
        $this->acl->addRole('Hausbewohner');

The call to addRole() misses a required argument $role.

        $this->acl->addRole('Hausbewohner', 'Mieter1');
        $this->acl->addRole('Hausbewohner', 'Mieter2');
        $this->acl->addRole('Hausverwalter');

The call to addRole() misses a required argument $role.

    }

    /**
     * @covers Koch\Permissions\Acl::addResource
     */
    public function testAddResource()
    {
        $this->acl->addResource('Haus');

The call to addResource() misses a required argument $resource.

        $this->acl->addResource('Haus', 'Wohnung1');
        $this->acl->addResource('Haus', 'Wohnung2');
    }

    /**
     * @covers Koch\Permissions\Acl::addRuleAllow
     */
    public function testRuleAllow()
    {
        $this->acl->ruleAllow('Hausverwalter', 'view', 'Haus');
        $this->acl->ruleAllow('Mieter1', 'view', 'Wohnung1');
        $this->acl->ruleAllow('Mieter2', 'view', 'Wohnung2');
    }

    /**
     * @covers Koch\Permissions\Acl::addRuleDeny
     */
    public function testRuleDeny()
    {
        $this->acl->ruleDeny('Mieter1', 'view', 'Wohnung2');
        $this->acl->ruleDeny('Mieter2', 'view', 'Wohnung1');
    }

    /**
     * @covers Koch\Permissions\Acl::isAllowed
     */
    public function testIsAllowed()
    {
        // the shorthand in the user object is $user->isAllowed($action, $resource);
        // the Role is incomming via the user object (user_id -> roles table)
        // action and resource are identified by the router and exist in the TargetRoute object
        $this->acl->isAllowed($role, $action, $resource);

The variable $role does not exist. Did you forget to declare it?

The variable $action does not exist. Did you forget to declare it?

The variable $resource does not exist. Did you forget to declare it?

The method isAllowed() does not seem to exist on object<Koch\Permissions\Acl>.

    }
}