GenericSqlDefinitions::create() - Code Metrics - Inspection of "Fixes a bug where you cannot use a runtime operato..." - K-Phoen/rulerz - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#82)

unknown

created 2018-05-16 08:15 UTC

GenericSqlDefinitions::create() A

↳ Parent: GenericSqlDefinitions

Complexity

Conditions	2
Paths	1

Size

Total Lines	51
Code Lines	33

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	51
rs	9.4109
c	0
b	0
f	0
cc	2
eloc	33
nc	1
nop	1

How to fix Long Method

<?php

declare(strict_types=1);

namespace RulerZ\Target\Operators;

class GenericSqlDefinitions
{
    public static function create(Definitions $customOperators): Definitions
    {
        $defaultInlineOperators = [
            'and' => function ($a, $b) {
                return sprintf('(%s)', OperatorTools::inlineMixedInstructions([$a, $b], 'AND'));
            },
            'or' => function ($a, $b) {
                return sprintf('(%s)', OperatorTools::inlineMixedInstructions([$a, $b], 'OR'));
            },
            'not' => function ($a) {
                return sprintf('NOT (%s)', OperatorTools::inlineMixedInstructions([$a]));
            },
            '=' => function ($a, $b) {
                return OperatorTools::inlineMixedInstructions([$a, $b], '=');
            },
            '!=' => function ($a, $b) {
                return OperatorTools::inlineMixedInstructions([$a, $b], '!=');
            },
            '>' => function ($a, $b) {
                return OperatorTools::inlineMixedInstructions([$a, $b], '>');
            },
            '>=' => function ($a, $b) {
                return OperatorTools::inlineMixedInstructions([$a, $b], '>=');
            },
            '<' => function ($a, $b) {
                return OperatorTools::inlineMixedInstructions([$a, $b], '<');
            },
            '<=' => function ($a, $b) {
                return OperatorTools::inlineMixedInstructions([$a, $b], '<=');
            },
            'in' => function ($a, $b) {
                if ($b[0] === '(') {
                    return OperatorTools::inlineMixedInstructions([$a, $b], 'IN');
                } else {
                    return sprintf(
                        '%s IN (%s)',
                        OperatorTools::inlineMixedInstructions([$a]),
                        OperatorTools::inlineMixedInstructions([$b])
                    );
                }
            },
            'like' => function ($a, $b) {
                return OperatorTools::inlineMixedInstructions([$a, $b], 'LIKE');
            },
        ];

        $definitions = new Definitions();
        $definitions->defineInlineOperators($defaultInlineOperators);

        return $definitions->mergeWith($customOperators);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace RulerZ\Target\Operators;
6
7			class GenericSqlDefinitions
8			{
9			public static function create(Definitions $customOperators): Definitions
10			{
11			$defaultInlineOperators = [
12			'and' => function ($a, $b) {
13			return sprintf('(%s)', OperatorTools::inlineMixedInstructions([$a, $b], 'AND'));
14			},
15			'or' => function ($a, $b) {
16			return sprintf('(%s)', OperatorTools::inlineMixedInstructions([$a, $b], 'OR'));
17			},
18			'not' => function ($a) {
19			return sprintf('NOT (%s)', OperatorTools::inlineMixedInstructions([$a]));
20			},
21			'=' => function ($a, $b) {
22			return OperatorTools::inlineMixedInstructions([$a, $b], '=');
23			},
24			'!=' => function ($a, $b) {
25			return OperatorTools::inlineMixedInstructions([$a, $b], '!=');
26			},
27			'>' => function ($a, $b) {
28			return OperatorTools::inlineMixedInstructions([$a, $b], '>');
29			},
30			'>=' => function ($a, $b) {
31			return OperatorTools::inlineMixedInstructions([$a, $b], '>=');
32			},
33			'<' => function ($a, $b) {
34			return OperatorTools::inlineMixedInstructions([$a, $b], '<');
35			},
36			'<=' => function ($a, $b) {
37			return OperatorTools::inlineMixedInstructions([$a, $b], '<=');
38			},
39			'in' => function ($a, $b) {
40			if ($b[0] === '(') {
41			return OperatorTools::inlineMixedInstructions([$a, $b], 'IN');
42			} else {
43			return sprintf(
44			'%s IN (%s)',
45			OperatorTools::inlineMixedInstructions([$a]),
46			OperatorTools::inlineMixedInstructions([$b])
47			);
48			}
49			},
50			'like' => function ($a, $b) {
51			return OperatorTools::inlineMixedInstructions([$a, $b], 'LIKE');
52			},
53			];
54
55			$definitions = new Definitions();
56			$definitions->defineInlineOperators($defaultInlineOperators);
57
58			return $definitions->mergeWith($customOperators);
			0 ignored issues – show Documentation introduced 2017-12-29 17:40 UTC by Report Bug Copy Issue Report `$customOperators` is of type `object<RulerZ\Target\Operators\Definitions>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
59			}
60			}
61

K-Phoen / rulerz

Pull Request — master (#82)

GenericSqlDefinitions::create() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like