Completed
Pull Request — master (#82)
by
unknown
02:06
created

GenericSqlDefinitions   A

Complexity

Total Complexity 2

Size/Duplication

Total Lines 54
Duplicated Lines 0 %

Coupling/Cohesion

Components 0
Dependencies 2

Importance

Changes 0
Metric Value
wmc 2
lcom 0
cbo 2
dl 0
loc 54
rs 10
c 0
b 0
f 0

1 Method

Rating   Name   Duplication   Size   Complexity  
A create() 0 51 2
1
<?php
2
3
declare(strict_types=1);
4
5
namespace RulerZ\Target\Operators;
6
7
class GenericSqlDefinitions
8
{
9
    public static function create(Definitions $customOperators): Definitions
10
    {
11
        $defaultInlineOperators = [
12
            'and' => function ($a, $b) {
13
                return sprintf('(%s)', OperatorTools::inlineMixedInstructions([$a, $b], 'AND'));
14
            },
15
            'or' => function ($a, $b) {
16
                return sprintf('(%s)', OperatorTools::inlineMixedInstructions([$a, $b], 'OR'));
17
            },
18
            'not' => function ($a) {
19
                return sprintf('NOT (%s)', OperatorTools::inlineMixedInstructions([$a]));
20
            },
21
            '=' => function ($a, $b) {
22
                return OperatorTools::inlineMixedInstructions([$a, $b], '=');
23
            },
24
            '!=' => function ($a, $b) {
25
                return OperatorTools::inlineMixedInstructions([$a, $b], '!=');
26
            },
27
            '>' => function ($a, $b) {
28
                return OperatorTools::inlineMixedInstructions([$a, $b], '>');
29
            },
30
            '>=' => function ($a, $b) {
31
                return OperatorTools::inlineMixedInstructions([$a, $b], '>=');
32
            },
33
            '<' => function ($a, $b) {
34
                return OperatorTools::inlineMixedInstructions([$a, $b], '<');
35
            },
36
            '<=' => function ($a, $b) {
37
                return OperatorTools::inlineMixedInstructions([$a, $b], '<=');
38
            },
39
            'in' => function ($a, $b) {
40
                if ($b[0] === '(') {
41
                    return OperatorTools::inlineMixedInstructions([$a, $b], 'IN');
42
                } else {
43
                    return sprintf(
44
                        '%s IN (%s)',
45
                        OperatorTools::inlineMixedInstructions([$a]),
46
                        OperatorTools::inlineMixedInstructions([$b])
47
                    );
48
                }
49
            },
50
            'like' => function ($a, $b) {
51
                return OperatorTools::inlineMixedInstructions([$a, $b], 'LIKE');
52
            },
53
        ];
54
55
        $definitions = new Definitions();
56
        $definitions->defineInlineOperators($defaultInlineOperators);
57
58
        return $definitions->mergeWith($customOperators);
0 ignored issues
show
Documentation introduced by
$customOperators is of type object<RulerZ\Target\Operators\Definitions>, but the function expects a object<self>.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
59
    }
60
}
61