Inspection of "Sequence Collections" - JordanRL/Fermat - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — dev (#49)

by Jordan

created 2020-05-11 20:38 UTC

Status

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

@@ -28,15 +28,15 @@  discard block
 block discarded – undo
 
         $answer = SeriesProvider::maclaurinSeries(
             $modulo,
-            function ($n) {
+            function($n) {
                 $negOne = Numbers::make(Numbers::IMMUTABLE, -1, 100);
 
                 return $negOne->pow($n);
             },
-            function ($n) {
+            function($n) {
                 return SequenceProvider::nthOddNumber($n);
             },
-            function ($n) {
+            function($n) {
                 return SequenceProvider::nthOddNumber($n)->factorial();
             },
             0,
@@ -73,13 +73,13 @@  discard block
 block discarded – undo
 
         $answer = SeriesProvider::maclaurinSeries(
             $modulo,
-            function ($n) {
+            function($n) {
                 return SequenceProvider::nthPowerNegativeOne($n);
             },
-            function ($n) {
+            function($n) {
                 return SequenceProvider::nthEvenNumber($n);
             },
-            function ($n) {
+            function($n) {
                 return SequenceProvider::nthEvenNumber($n)->factorial();
             },
             0,
@@ -158,20 +158,20 @@  discard block
 block discarded – undo
         } else {
             $answer = SeriesProvider::maclaurinSeries(
                 $modulo,
-                function ($n) {
+                function($n) {
                     $nthOddNumber = SequenceProvider::nthOddNumber($n);
 
                     return SequenceProvider::nthEulerZigzag($nthOddNumber->asInt());
                 },
-                function ($n) {
+                function($n) {
 
                     return SequenceProvider::nthOddNumber($n);
                 },
-                function ($n) {
+                function($n) {
                     return SequenceProvider::nthOddNumber($n)->factorial();
                 },
                 0,
-                $precision + 1
+                $precision+1
             );
         }
 
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
 
         if ($mod2Pi->isEqual(0)) {
             return $this->setValue(static::INFINITY);
-        } elseif($modPi->isEqual(0)) {
+        } elseif ($modPi->isEqual(0)) {
             return $this->setValue(static::NEG_INFINITY);
         }
 

Please login to merge, or discard this patch.

src/Samsara/Fermat/Types/Traits/ComparisonTrait.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -220,7 +220,7 @@
 block discarded – undo
 
         if ($check === 1) {
             $checkVal = $this->getDecimalPart();
-            $checkVal = trim($checkVal,'0');
+            $checkVal = trim($checkVal, '0');
 
             return !($checkVal !== '');
         }

Please login to merge, or discard this patch.

src/Samsara/Fermat/Provider/StatsProvider.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -38,13 +38,13 @@  discard block
 block discarded – undo
                 ->multiply($e->pow($eExponent))
                 ->multiply(SeriesProvider::maclaurinSeries(
                     $x,
-                    function ($n) {
+                    function($n) {
                         return Numbers::makeOne();
                     },
-                    function ($n) {
+                    function($n) {
                         return SequenceProvider::nthOddNumber($n);
                     },
-                    function ($n) {
+                    function($n) {
                         return SequenceProvider::nthOddNumber($n)->doubleFactorial();
                     }
                 ))
@@ -88,15 +88,15 @@  discard block
 block discarded – undo
         $answer = $answer->multiply(
             SeriesProvider::maclaurinSeries(
                 $x,
-                function ($n) {
+                function($n) {
                     $negOne = Numbers::make(Numbers::IMMUTABLE, -1);
 
                     return $negOne->pow($n);
                 },
-                function ($n) {
+                function($n) {
                     return SequenceProvider::nthOddNumber($n);
                 },
-                function ($n) {
+                function($n) {
                     $n = Numbers::makeOrDont(Numbers::IMMUTABLE, $n);
 
                     return $n->factorial()->multiply(SequenceProvider::nthOddNumber($n->asInt()));

Please login to merge, or discard this patch.

src/Samsara/Fermat/Provider/SequenceProvider.php 1 patch

Spacing +60 added lines, -60 removed lines patch added patch discarded remove patch

		@@ -14,57 +14,57 @@ discard block
		block discarded – undo
14	14	{
15	15
16	16	const EULER_ZIGZAG = [
17		- '1', // 0
18		- '1', // 1
19		- '1', // 2
20		- '2', // 3
21		- '5', // 4
22		- '16', // 5
23		- '61', // 6
24		- '272', // 7
25		- '1385', // 8
26		- '7936', // 9
27		- '50521', // 10
28		- '353792', // 11
29		- '2702765', // 12
30		- '22368256', // 13
31		- '199360981', // 14
32		- '1903757312', // 15
33		- '19391512145', // 16
34		- '209865342976', // 17
35		- '2404879675441', // 18
36		- '29088885112832', // 19
37		- '370371188237525', // 20
38		- '4951498053124096', // 21
39		- '69348874393137901', // 22
40		- '1015423886506852352', // 23
41		- '15514534163557086905', // 24
42		- '246921480190207983616', // 25
43		- '4087072509293123892361', // 26
44		- '70251601603943959887872', // 27
45		- '1252259641403629865468285', // 28
46		- '23119184187809597841473536', // 29
47		- '441543893249023104553682821', // 30
48		- '8713962757125169296170811392', // 31
49		- '177519391579539289436664789665', // 32
50		- '3729407703720529571097509625856', // 33
51		- '80723299235887898062168247453281', // 34
52		- '1798651693450888780071750349094912', // 35
53		- '41222060339517702122347079671259045', // 36
54		- '970982810785059112379399707952152576', // 37
55		- '23489580527043108252017828576198947741', // 38
56		- '583203324917310043943191641625494290432', // 39
57		- '14851150718114980017877156781405826684425', // 40
58		- '387635983772083031828014624002175135645696', // 41
59		- '10364622733519612119397957304745185976310201', // 42
60		- '283727921907431909304183316295787837183229952', // 43
61		- '7947579422597592703608040510088070619519273805', // 44
62		- '227681379129930886488600284336316164603920777216', // 45
63		- '6667537516685544977435028474773748197524107684661', // 46
64		- '199500252157859031027160499643195658166340757225472', // 47
65		- '6096278645568542158691685742876843153976539044435185', // 48
66		- '190169564657928428175235445073924928592047775873499136', // 49
67		- '6053285248188621896314383785111649088103498225146815121', // 50
	17	+ '1', // 0
	18	+ '1', // 1
	19	+ '1', // 2
	20	+ '2', // 3
	21	+ '5', // 4
	22	+ '16', // 5
	23	+ '61', // 6
	24	+ '272', // 7
	25	+ '1385', // 8
	26	+ '7936', // 9
	27	+ '50521', // 10
	28	+ '353792', // 11
	29	+ '2702765', // 12
	30	+ '22368256', // 13
	31	+ '199360981', // 14
	32	+ '1903757312', // 15
	33	+ '19391512145', // 16
	34	+ '209865342976', // 17
	35	+ '2404879675441', // 18
	36	+ '29088885112832', // 19
	37	+ '370371188237525', // 20
	38	+ '4951498053124096', // 21
	39	+ '69348874393137901', // 22
	40	+ '1015423886506852352', // 23
	41	+ '15514534163557086905', // 24
	42	+ '246921480190207983616', // 25
	43	+ '4087072509293123892361', // 26
	44	+ '70251601603943959887872', // 27
	45	+ '1252259641403629865468285', // 28
	46	+ '23119184187809597841473536', // 29
	47	+ '441543893249023104553682821', // 30
	48	+ '8713962757125169296170811392', // 31
	49	+ '177519391579539289436664789665', // 32
	50	+ '3729407703720529571097509625856', // 33
	51	+ '80723299235887898062168247453281', // 34
	52	+ '1798651693450888780071750349094912', // 35
	53	+ '41222060339517702122347079671259045', // 36
	54	+ '970982810785059112379399707952152576', // 37
	55	+ '23489580527043108252017828576198947741', // 38
	56	+ '583203324917310043943191641625494290432', // 39
	57	+ '14851150718114980017877156781405826684425', // 40
	58	+ '387635983772083031828014624002175135645696', // 41
	59	+ '10364622733519612119397957304745185976310201', // 42
	60	+ '283727921907431909304183316295787837183229952', // 43
	61	+ '7947579422597592703608040510088070619519273805', // 44
	62	+ '227681379129930886488600284336316164603920777216', // 45
	63	+ '6667537516685544977435028474773748197524107684661', // 46
	64	+ '199500252157859031027160499643195658166340757225472', // 47
	65	+ '6096278645568542158691685742876843153976539044435185', // 48
	66	+ '190169564657928428175235445073924928592047775873499136', // 49
	67	+ '6053285248188621896314383785111649088103498225146815121', // 50
68	68	];
69	69
70	70	/**
		@@ -82,8 +82,8 @@ discard block
		block discarded – undo
82	82	if ($asCollection) {
83	83	$sequence = new NumberCollection();
84	84
85		- for ($i = 0;$i < $collectionSize;$i++) {
86		- $sequence->push(self::nthOddNumber($n + $i));
	85	+ for ($i = 0; $i < $collectionSize; $i++) {
	86	+ $sequence->push(self::nthOddNumber($n+$i));
87	87	}
88	88
89	89	return $sequence;
		@@ -111,8 +111,8 @@ discard block
		block discarded – undo
111	111	if ($asCollection) {
112	112	$sequence = new NumberCollection();
113	113
114		- for ($i = 0;$i < $collectionSize;$i++) {
115		- $sequence->push(self::nthEvenNumber($n + $i));
	114	+ for ($i = 0; $i < $collectionSize; $i++) {
	115	+ $sequence->push(self::nthEvenNumber($n+$i));
116	116	}
117	117
118	118	return $sequence;
		@@ -140,8 +140,8 @@ discard block
		block discarded – undo
140	140	if ($asCollection) {
141	141	$sequence = new NumberCollection();
142	142
143		- for ($i = 0;$i < $collectionSize;$i++) {
144		- $sequence->push(self::nthPowerNegativeOne($n + $i));
	143	+ for ($i = 0; $i < $collectionSize; $i++) {
	144	+ $sequence->push(self::nthPowerNegativeOne($n+$i));
145	145	}
146	146
147	147	return $sequence;
		@@ -174,8 +174,8 @@ discard block
		block discarded – undo
174	174	if ($asCollection) {
175	175	$sequence = new NumberCollection();
176	176
177		- for ($i = 0;$i < $collectionSize;$i++) {
178		- $sequence->push(self::nthEulerZigzag($n + $i));
	177	+ for ($i = 0; $i < $collectionSize; $i++) {
	178	+ $sequence->push(self::nthEulerZigzag($n+$i));
179	179	}
180	180
181	181	return $sequence;
		@@ -262,7 +262,7 @@ discard block
		block discarded – undo
262	262	$sequence = new NumberCollection();
263	263	$sequence->push($fastFib[0]);
264	264	$sequence->push($fastFib[1]);
265		- for ($i = 0;$i < ($collectionSize-2);$i++) {
	265	+ for ($i = 0; $i < ($collectionSize-2); $i++) {
266	266	$sequence->push($sequence->get($i)->add($sequence[$i+1]));
267	267	}
268	268

Please login to merge, or discard this patch.

		@@ -28,15 +28,15 @@ discard block
		block discarded – undo
28	28
29	29	$answer = SeriesProvider::maclaurinSeries(
30	30	$modulo,
31		- function ($n) {
	31	+ function($n) {
32	32	$negOne = Numbers::make(Numbers::IMMUTABLE, -1, 100);
33	33
34	34	return $negOne->pow($n);
35	35	},
36		- function ($n) {
	36	+ function($n) {
37	37	return SequenceProvider::nthOddNumber($n);
38	38	},
39		- function ($n) {
	39	+ function($n) {
40	40	return SequenceProvider::nthOddNumber($n)->factorial();
41	41	},
42	42	0,
		@@ -73,13 +73,13 @@ discard block
		block discarded – undo
73	73
74	74	$answer = SeriesProvider::maclaurinSeries(
75	75	$modulo,
76		- function ($n) {
	76	+ function($n) {
77	77	return SequenceProvider::nthPowerNegativeOne($n);
78	78	},
79		- function ($n) {
	79	+ function($n) {
80	80	return SequenceProvider::nthEvenNumber($n);
81	81	},
82		- function ($n) {
	82	+ function($n) {
83	83	return SequenceProvider::nthEvenNumber($n)->factorial();
84	84	},
85	85	0,
		@@ -158,20 +158,20 @@ discard block
		block discarded – undo
158	158	} else {
159	159	$answer = SeriesProvider::maclaurinSeries(
160	160	$modulo,
161		- function ($n) {
	161	+ function($n) {
162	162	$nthOddNumber = SequenceProvider::nthOddNumber($n);
163	163
164	164	return SequenceProvider::nthEulerZigzag($nthOddNumber->asInt());
165	165	},
166		- function ($n) {
	166	+ function($n) {
167	167
168	168	return SequenceProvider::nthOddNumber($n);
169	169	},
170		- function ($n) {
	170	+ function($n) {
171	171	return SequenceProvider::nthOddNumber($n)->factorial();
172	172	},
173	173	0,
174		- $precision + 1
	174	+ $precision+1
175	175	);
176	176	}
177	177
		@@ -204,7 +204,7 @@ discard block
		block discarded – undo
204	204
205	205	if ($mod2Pi->isEqual(0)) {
206	206	return $this->setValue(static::INFINITY);
207		- } elseif($modPi->isEqual(0)) {
	207	+ } elseif ($modPi->isEqual(0)) {
208	208	return $this->setValue(static::NEG_INFINITY);
209	209	}
210	210

		@@ -220,7 +220,7 @@
		block discarded – undo
220	220
221	221	if ($check === 1) {
222	222	$checkVal = $this->getDecimalPart();
223		- $checkVal = trim($checkVal,'0');
	223	+ $checkVal = trim($checkVal, '0');
224	224
225	225	return !($checkVal !== '');
226	226	}

		@@ -38,13 +38,13 @@ discard block
		block discarded – undo
38	38	->multiply($e->pow($eExponent))
39	39	->multiply(SeriesProvider::maclaurinSeries(
40	40	$x,
41		- function ($n) {
	41	+ function($n) {
42	42	return Numbers::makeOne();
43	43	},
44		- function ($n) {
	44	+ function($n) {
45	45	return SequenceProvider::nthOddNumber($n);
46	46	},
47		- function ($n) {
	47	+ function($n) {
48	48	return SequenceProvider::nthOddNumber($n)->doubleFactorial();
49	49	}
50	50	))
		@@ -88,15 +88,15 @@ discard block
		block discarded – undo
88	88	$answer = $answer->multiply(
89	89	SeriesProvider::maclaurinSeries(
90	90	$x,
91		- function ($n) {
	91	+ function($n) {
92	92	$negOne = Numbers::make(Numbers::IMMUTABLE, -1);
93	93
94	94	return $negOne->pow($n);
95	95	},
96		- function ($n) {
	96	+ function($n) {
97	97	return SequenceProvider::nthOddNumber($n);
98	98	},
99		- function ($n) {
	99	+ function($n) {
100	100	$n = Numbers::makeOrDont(Numbers::IMMUTABLE, $n);
101	101
102	102	return $n->factorial()->multiply(SequenceProvider::nthOddNumber($n->asInt()));

JordanRL / Fermat

Pull Request — dev (#49)

Status

Category

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +60 added lines, -60 removed lines patch added patch discarded remove patch