Inspection of "Do not reuse varible for something else" - JeroenDeDauw/Maps - Measure and Improve Code Quality continuously with Scrutinizer

Maps

Completed

Push — naming ( a37702 )

by Jeroen De

created 2016-05-25 13:47 UTC

Status

All Patches
20
New
1

Doc Comments +5 added lines patch added patch discarded remove patch

@@ -83,6 +83,11 @@
 block discarded – undo
 		$location->setLink( $this->getExpandedLink( $link ) );
 	}
 
+	/**
+	 * @param string $link
+	 *
+	 * @return string
+	 */
 	private function getExpandedLink( $link ) {
 		if ( filter_var( $link , FILTER_VALIDATE_URL , FILTER_FLAG_SCHEME_REQUIRED ) ) {
 			return $link;

Please login to merge, or discard this patch.

		@@ -83,6 +83,11 @@
		block discarded – undo
83	83	$location->setLink( $this->getExpandedLink( $link ) );
84	84	}
85	85
	86	+ /**
	87	+ * @param string $link
	88	+ *
	89	+ * @return string
	90	+ */
86	91	private function getExpandedLink( $link ) {
87	92	if ( filter_var( $link , FILTER_VALIDATE_URL , FILTER_FLAG_SCHEME_REQUIRED ) ) {
88	93	return $link;

JeroenDeDauw / Maps

Push — naming ( a37702 )

Status

Category

Doc Comments +5 added lines patch added patch discarded remove patch