JeroenDeDauw / Maps

includes/Maps_DistanceParser.php

Doc Comments +1 added lines, -1 removed lines

@@ -152,7 +152,7 @@
 	 * 
 	 * @since 0.6.5
 	 * 
-	 * @param $distance String
+	 * @param string $distance String
 	 * 
 	 * @return string
 	 */

includes/parsers/ImageOverlayParser.php

Doc Comments +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
 	 *
 	 * @param string $value
 	 *
-	 * @return WmsOverlay
+	 * @return ImageOverlay
 	 * @throws ParseException
 	 */
 	protected function stringParse( $value ) {

includes/ServiceParam.php

Doc Comments +1 added lines, -1 removed lines

@@ -51,7 +51,7 @@
 	 * @param IParamDefinition[] $definitions
 	 * @param IParam[] $params
 	 *
-	 * @return mixed
+	 * @return string
 	 */
 	protected function formatValue( $value, IParam $param, array &$definitions, array $params ) {
 		// Make sure the service is valid.

includes/parsers/LocationParser.php

Doc Comments +5 added lines

@@ -83,6 +83,11 @@
 		$location->setLink( $this->getExpandedLink( $link ) );
 	}
 
+	/**
+	 * @param string $link
+	 *
+	 * @return string
+	 */
 	private function getExpandedLink( $link ) {
 		if ( filter_var( $link , FILTER_VALIDATE_URL , FILTER_FLAG_SCHEME_REQUIRED ) ) {
 			return $link;

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use DataValues\Geo\Parsers\GeoCoordinateParser;
 use DataValues\Geo\Values\LatLongValue;
 use Maps\Elements\Location;
-use MWException;
 use Title;
 use ValueParsers\ParserOptions;
 use ValueParsers\ParseException;

src/Elements/Location.php

Doc Comments +1 added lines, -1 removed lines

@@ -232,7 +232,7 @@
 	 *
 	 * @since 2.0
 	 *
-	 * @return string
+	 * @return boolean
 	 */
 	public function hasGroup() {
 		return $this->group !== '';

tests/Unit/Elements/PolygonTest.php

Doc Comments +4 added lines

@@ -50,6 +50,10 @@
 		$this->assertHasJsonKeyWithValue( $polygon, 'fillOpacity', '0.42' );
 	}
 
+	/**
+	 * @param string $key
+	 * @param string $value
+	 */
 	protected function assertHasJsonKeyWithValue( Polygon $polygon, $key, $value ) {
 		$json = $polygon->getJSONObject();
 

includes/Maps_Mapper.php

Doc Comments +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
 	/**
 	 * This function returns the definitions for the parameters used by every map feature.
 	 *
-	 * @return array
+	 * @return ParamProcessor\IParamDefinition[]
 	 */
 	public static function getCommonParameters() {
 		global $egMapsAvailableGeoServices, $egMapsDefaultGeoService, $egMapsMapWidth, $egMapsMapHeight, $egMapsDefaultService;

includes/geocoders/Maps_GoogleGeocoder.php

Doc Comments +1 added lines, -1 removed lines

@@ -75,7 +75,7 @@
 	 * 
 	 * @since 0.7
 	 * 
-	 * @return array
+	 * @return string[]
 	 */
 	public static function getOverrides() {
 		return [ 'googlemaps3' ];

includes/Maps_DisplayMapRenderer.php

Doc Comments +4 added lines

@@ -148,6 +148,10 @@
 		return $locationJsonObjects;
 	}
 
+	/**
+	 * @param string $iconUrl
+	 * @param string $visitedIconUrl
+	 */
 	private function getLocationJsonObject( Location $location, array $params, $iconUrl, $visitedIconUrl, Parser $parserClone ) {
 		$jsonObj = $location->getJSONObject( $params['title'], $params['label'], $iconUrl, '', '', $visitedIconUrl );