View GitHub Repository GuestPass

Schedule Inspection
Subscribe
Completed
Push — master ( 8b3347...eb39ec )
by Jeroen
01:42
created
Status
Category
Toggle Patches
src/GuestPassService.php 2 patches
Doc Comments   +7 added lines, -7 removed lines patch added patch discarded remove patch 
@@ -26,8 +26,8 @@  discard block
 
 block discarded – undo
26 26
27 27 
     /**
28 28 
      * Create a new Guest Pass.
29 
-     * @param  lluminate\Database\Eloquent\Model $owner
30 
-     * @param  lluminate\Database\Eloquent\Model $object
29 
+     * @param  Model $owner
30 
+     * @param  Model $object
31 31 
      * @param  string|null                       $view   Leave out the .blade.php extension.
32 32 
      * @return bool|Exception
33 33 
      */
 
@@ -51,8 +51,8 @@  discard block
 
 block discarded – undo
51 51
52 52 
     /**
53 53 
      * Check if the given user created the Guest Pass.
54 
-     * @param  lluminate\Database\Eloquent\Model $owner
55 
-     * @param  lluminate\Database\Eloquent\Model $guestpass
54 
+     * @param  Model $owner
55 
+     * @param  Model $guestpass
56 56 
      * @return bool
57 57 
      */
58 58 
     public function isOwner(Model $owner, Model $guestpass)
 
@@ -62,7 +62,7 @@  discard block
 
 block discarded – undo
62 62
63 63 
     /**
64 64 
      * Get all keys belonging to the owner.
65 
-     * @param  lluminate\Database\Eloquent\Model  $owner
65 
+     * @param  Model  $owner
66 66 
      * @return array
67 67 
      */
68 68 
     public function getKeysOf(Model $owner)
 
@@ -75,8 +75,8 @@  discard block
 
 block discarded – undo
75 75
76 76 
     /**
77 77 
      * Find (or fail) the Guest Pass belonging to an owner-object pairing.
78 
-     * @param  lluminate\Database\Eloquent\Model                $owner
79 
-     * @param  lluminate\Database\Eloquent\Model                $object
78 
+     * @param  Model                $owner
79 
+     * @param  Model                $object
80 80 
      * @return lluminate\Database\Eloquent\Collection|Exception
81 81 
      */
82 82 
     public function findGuestPass(Model $owner, Model $object)
Please login to merge, or discard this patch.
Braces   +7 added lines, -14 removed lines patch added patch discarded remove patch 
@@ -9,8 +9,7 @@  discard block
 
 block discarded – undo
9 9 
     /**
10 10 
      * Create a new instance.
11 11 
      */
12 
-    public function __construct()
13 
-    {
12 
+    public function __construct() {
14 13 
         // constructor body
15 14 
     }
16 15 
 
@@ -18,8 +17,7 @@  discard block
 
 block discarded – undo
18 17 
      * Register the routes.
19 18 
      * @return void
20 19 
      */
21 
-    public function routes()
22 
-    {
20 
+    public function routes() {
23 21 
         $router = app('router');
24 22 
         $router->get('gp/{owner}/{key}', 'JeroenG\GuestPass\Controllers\Access');
25 23 
     }
 
@@ -31,8 +29,7 @@  discard block
 
 block discarded – undo
31 29 
      * @param  string|null                       $view   Leave out the .blade.php extension.
32 30 
      * @return bool|Exception
33 31 
      */
34 
-    public function create(Model $owner, Model $object, $view = null)
35 
-    {
32 
+    public function create(Model $owner, Model $object, $view = null) {
36 33 
         try {
37 34 
             GuestPass::create([
38 35 
                 'key' => str_random(10),
 
@@ -55,8 +52,7 @@  discard block
 
 block discarded – undo
55 52 
      * @param  lluminate\Database\Eloquent\Model $guestpass
56 53 
      * @return bool
57 54 
      */
58 
-    public function isOwner(Model $owner, Model $guestpass)
59 
-    {
55 
+    public function isOwner(Model $owner, Model $guestpass) {
60 56 
         return $owner->id == $guestpass->owner_id;
61 57 
     }
62 58 
 
@@ -65,8 +61,7 @@  discard block
 
 block discarded – undo
65 61 
      * @param  lluminate\Database\Eloquent\Model  $owner
66 62 
      * @return array
67 63 
      */
68 
-    public function getKeysOf(Model $owner)
69 
-    {
64 
+    public function getKeysOf(Model $owner) {
70 65 
         return GuestPass::where([
71 66 
             'owner_id' => $owner->id,
72 67 
             'owner_model' => get_class($owner),
 
@@ -79,8 +74,7 @@  discard block
 
 block discarded – undo
79 74 
      * @param  lluminate\Database\Eloquent\Model                $object
80 75 
      * @return lluminate\Database\Eloquent\Collection|Exception
81 76 
      */
82 
-    public function findGuestPass(Model $owner, Model $object)
83 
-    {
77 
+    public function findGuestPass(Model $owner, Model $object) {
84 78 
         return GuestPass::where([
85 79 
             'owner_id' => $owner->id,
86 80 
             'owner_model' => get_class($owner),
 
@@ -94,8 +88,7 @@  discard block
 
 block discarded – undo
94 88 
      * @param  string                                      $key
95 89 
      * @return lluminate\Database\Eloquent\Model|Exception
96 90 
      */
97 
-    public function getGuestPass($key)
98 
-    {
91 
+    public function getGuestPass($key) {
99 92 
         return GuestPass::where('key', $key)->firstOrFail();
100 93 
     }
101 94 
 }
Please login to merge, or discard this patch.