UserAgentTest::testDevices() - Code Metrics - Inspection of "Add regex collision test" - JayBizzle/Crawler-Detect - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d89a54...db6c5d )

by Mark

created 2016-04-04 09:14 UTC

UserAgentTest::testDevices() A

↳ Parent: UserAgentTest

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	9
Ratio	100 %

Metric	Value
dl	9
loc	9
rs	9.6666
cc	2
eloc	5
nc	2
nop	0

<?php

class UserAgentTest extends PHPUnit_Framework_TestCase
namespace YourVendor;

class YourClass { }
{
    protected $CrawlerDetect;

    public function setUp()
    {
        $this->CrawlerDetect = new Jaybizzle\CrawlerDetect\CrawlerDetect();
    }

    public function testBots()

    {
        $lines = file(__DIR__.'/crawlers.txt', FILE_IGNORE_NEW_LINES | FILE_SKIP_EMPTY_LINES);

        foreach ($lines as $line) {
            $test = $this->CrawlerDetect->isCrawler($line);
            $this->assertEquals($test, true, $line);
        }
    }

    public function testDevices()

    {
        $lines = file(__DIR__.'/devices.txt', FILE_IGNORE_NEW_LINES | FILE_SKIP_EMPTY_LINES);

        foreach ($lines as $line) {
            $test = $this->CrawlerDetect->isCrawler($line);
            $this->assertEquals($test, false, $line);
        }
    }

    public function testReturnsCorrectMatchedBotName()
    {
        $test = $this->CrawlerDetect->isCrawler('Mozilla/5.0 (iPhone; CPU iPhone OS 7_1 like Mac OS X) AppleWebKit (KHTML, like Gecko) Mobile (compatible; Yahoo Ad monitoring; https://help.yahoo.com/kb/yahoo-ad-monitoring-SLN24857.html)');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $matches = $this->CrawlerDetect->getMatches();

        $this->assertEquals($this->CrawlerDetect->getMatches(), 'Yahoo Ad monitoring', $matches);
    }

    public function testForRegexCollision()
    {
        $crawlers = $this->CrawlerDetect->getCrawlers();

        foreach ($crawlers as $regex) {
            foreach ($crawlers as $compare) {
                // Dont check this regex against itself
                if ($regex != $compare) {
                    preg_match('/'.$regex.'/i', stripslashes($compare), $matches);

                    $this->assertEmpty($matches, $regex.' collided with '.$compare);
                }
            }
        }
    }
}


1		<?php
2
3		class UserAgentTest extends PHPUnit_Framework_TestCase
		0 ignored issues – show Coding Style Compatibility introduced 2015-11-25 13:32 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4		{
5		protected $CrawlerDetect;
6
7		public function setUp()
8		{
9		$this->CrawlerDetect = new Jaybizzle\CrawlerDetect\CrawlerDetect();
10		}
11
12	View Code Duplication	public function testBots()
		0 ignored issues – show Duplication introduced 2015-11-25 13:32 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
13		{
14		$lines = file(__DIR__.'/crawlers.txt', FILE_IGNORE_NEW_LINES \| FILE_SKIP_EMPTY_LINES);
15
16		foreach ($lines as $line) {
17		$test = $this->CrawlerDetect->isCrawler($line);
18		$this->assertEquals($test, true, $line);
19		}
20		}
21
22	View Code Duplication	public function testDevices()
		0 ignored issues – show Duplication introduced 2015-11-25 13:32 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
23		{
24		$lines = file(__DIR__.'/devices.txt', FILE_IGNORE_NEW_LINES \| FILE_SKIP_EMPTY_LINES);
25
26		foreach ($lines as $line) {
27		$test = $this->CrawlerDetect->isCrawler($line);
28		$this->assertEquals($test, false, $line);
29		}
30		}
31
32		public function testReturnsCorrectMatchedBotName()
33		{
34		$test = $this->CrawlerDetect->isCrawler('Mozilla/5.0 (iPhone; CPU iPhone OS 7_1 like Mac OS X) AppleWebKit (KHTML, like Gecko) Mobile (compatible; Yahoo Ad monitoring; https://help.yahoo.com/kb/yahoo-ad-monitoring-SLN24857.html)');
		0 ignored issues – show Unused Code introduced 2016-01-14 12:35 UTC by Report Bug Copy Issue Report `$test` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
35
36		$matches = $this->CrawlerDetect->getMatches();
37
38		$this->assertEquals($this->CrawlerDetect->getMatches(), 'Yahoo Ad monitoring', $matches);
39		}
40
41		public function testForRegexCollision()
42		{
43		$crawlers = $this->CrawlerDetect->getCrawlers();
44
45		foreach ($crawlers as $regex) {
46		foreach ($crawlers as $compare) {
47		// Dont check this regex against itself
48		if ($regex != $compare) {
49		preg_match('/'.$regex.'/i', stripslashes($compare), $matches);
50
51		$this->assertEmpty($matches, $regex.' collided with '.$compare);
52		}
53		}
54		}
55		}
56		}
57

JayBizzle / Crawler-Detect

Push — master ( d89a54...db6c5d )

UserAgentTest::testDevices() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like