UserAgentTest

Complexity

Total Complexity

10

Size/Duplication

Total Lines	54
Duplicated Lines	33.33 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	1

5 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	4	1
A	testBots()	9	9	2
A	testDevices()	9	9	2
A	testReturnsCorrectMatchedBotName()	0	8	1
A	testForRegexCollision()	0	15	4

<?php

class UserAgentTest extends PHPUnit_Framework_TestCase

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    protected $CrawlerDetect;

    public function setUp()
    {
        $this->CrawlerDetect = new Jaybizzle\CrawlerDetect\CrawlerDetect();
    }

    public function testBots()

This method seems to be duplicated in your project.

    {
        $lines = file(__DIR__.'/crawlers.txt', FILE_IGNORE_NEW_LINES | FILE_SKIP_EMPTY_LINES);

        foreach ($lines as $line) {
            $test = $this->CrawlerDetect->isCrawler($line);
            $this->assertEquals($test, true, $line);
        }
    }

    public function testDevices()

This method seems to be duplicated in your project.

    {
        $lines = file(__DIR__.'/devices.txt', FILE_IGNORE_NEW_LINES | FILE_SKIP_EMPTY_LINES);

        foreach ($lines as $line) {
            $test = $this->CrawlerDetect->isCrawler($line);
            $this->assertEquals($test, false, $line);
        }
    }

    public function testReturnsCorrectMatchedBotName()
    {
        $test = $this->CrawlerDetect->isCrawler('Mozilla/5.0 (iPhone; CPU iPhone OS 7_1 like Mac OS X) AppleWebKit (KHTML, like Gecko) Mobile (compatible; Yahoo Ad monitoring; https://help.yahoo.com/kb/yahoo-ad-monitoring-SLN24857.html)');

$test is not used, you could remove the assignment.

        $matches = $this->CrawlerDetect->getMatches();

        $this->assertEquals($this->CrawlerDetect->getMatches(), 'Yahoo Ad monitoring', $matches);
    }

    public function testForRegexCollision()
    {
        $crawlers = $this->CrawlerDetect->getCrawlers();

        foreach ($crawlers as $regex) {
            foreach ($crawlers as $compare) {
                // Dont check this regex against itself
                if ($regex != $compare) {
                    preg_match('/'.$regex.'/i', stripslashes($compare), $matches);

                    $this->assertEmpty($matches, $regex.' collided with '.$compare);
                }
            }
        }
    }
}