InvoicePlane / InvoicePlane

application/config/config.php

Spacing +1 added lines, -1 removed lines

@@ -1,4 +1,4 @@
-<?php if (!defined('BASEPATH')) exit('No direct script access allowed');
+<?php if ( ! defined('BASEPATH')) exit('No direct script access allowed');
 /*
 | -------------------------------------------------------------------
 | MIME TYPES

application/modules/quotes/views/modal_create_quote.php

Spacing +2 added lines, -2 removed lines

@@ -59,9 +59,9 @@
                 <select name="client_name" id="client_name" class="form-control" autofocus="autofocus">
                     <?php
                     foreach ($clients as $client) {
-                        echo "<option value=\"" . htmlspecialchars($client->client_name) . "\" ";
+                        echo "<option value=\"".htmlspecialchars($client->client_name)."\" ";
                         if ($client_name == $client->client_name) echo 'selected';
-                        echo ">" . htmlspecialchars($client->client_name) . "</option>";
+                        echo ">".htmlspecialchars($client->client_name)."</option>";
                     }
                     ?>
                 </select>

application/modules/sessions/controllers/sessions.php

Spacing +6 added lines, -6 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-if (!defined('BASEPATH'))
+if ( ! defined('BASEPATH'))
     exit('No direct script access allowed');
 
 /*
@@ -148,7 +148,7 @@ 
             if ($this->db->where('user_email', $email)) {
                 // Create a passwordreset token
                 $email = $this->input->post('email');
-                $token = md5(time() . $email);
+                $token = md5(time().$email);
 
                 // Save the token to the database and set the user to inactive
                 $db_array = array(
@@ -162,18 +162,18 @@ 
                 $this->load->helper('mailer');
 
                 // Preprare some variables for the email
-                $email_resetlink = site_url('sessions/passwordreset/' . $token);
+                $email_resetlink = site_url('sessions/passwordreset/'.$token);
                 $email_message = $this->load->view('emails/passwordreset', array(
                     'resetlink' => $email_resetlink
                 ), true);
-                $email_from = 'system@' . preg_replace("/^[\w]{2,6}:\/\/([\w\d\.\-]+).*$/", "$1", base_url());
+                $email_from = 'system@'.preg_replace("/^[\w]{2,6}:\/\/([\w\d\.\-]+).*$/", "$1", base_url());
 
                 // Mail the invoice with the pre-configured mailer if possible
                 if (mailer_configured()) {
 
                     $this->load->helper('mailer/phpmailer');
 
-                    if (!phpmail_send($email_from, $email, trans('password_reset'), $email_message)) {
+                    if ( ! phpmail_send($email_from, $email, trans('password_reset'), $email_message)) {
                         $email_failed = true;
                         log_message('error', $this->email->print_debugger());
                     }
@@ -193,7 +193,7 @@ 
                     $this->email->message($email_message);
 
                     // Send the reset email
-                    if (!$this->email->send()) {
+                    if ( ! $this->email->send()) {
                         $email_failed = true;
                         log_message('error', $this->email->print_debugger());
                     }

application/modules/invoices/views/modal_create_invoice.php

Spacing +2 added lines, -2 removed lines

@@ -59,9 +59,9 @@
                 <select name="client_name" id="client_name" class="form-control" autofocus="autofocus">
                     <?php
                     foreach ($clients as $client) {
-                        echo "<option value=\"" . htmlspecialchars($client->client_name) . "\" ";
+                        echo "<option value=\"".htmlspecialchars($client->client_name)."\" ";
                         if ($client_name == $client->client_name) echo 'selected';
-                        echo ">" . htmlspecialchars($client->client_name) . "</option>";
+                        echo ">".htmlspecialchars($client->client_name)."</option>";
                     }
                     ?>
                 </select>

application/helpers/mpdf_helper.php

Doc Comments +3 added lines

@@ -16,6 +16,9 @@
  *
  */
 
+/**
+ * @param boolean $isInvoice
+ */
 function pdf_create($html, $filename, $stream = true, $password = null, $isInvoice = null, $isGuest = null, $zugferd_invoice = false, $associatedFiles = null)
 {
     $CI = &get_instance();

Spacing +18 added lines, -18 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-if (!defined('BASEPATH'))
+if ( ! defined('BASEPATH'))
     exit('No direct script access allowed');
 
 /*
@@ -24,10 +24,10 @@ 
     $invoice_array = array();
 
     // mPDF loading
-    define('_MPDF_TEMP_PATH', FCPATH . 'uploads/temp/mpdf/');
-    define('_MPDF_TTFONTDATAPATH', FCPATH . 'uploads/temp/mpdf/');
+    define('_MPDF_TEMP_PATH', FCPATH.'uploads/temp/mpdf/');
+    define('_MPDF_TTFONTDATAPATH', FCPATH.'uploads/temp/mpdf/');
 
-    require_once(FCPATH . 'vendor/mpdf/mpdf/mpdf.php');
+    require_once(FCPATH.'vendor/mpdf/mpdf/mpdf.php');
     $mpdf = new mPDF();
 
     // mPDF configuration
@@ -49,44 +49,44 @@ 
     }
 
     // Set a password if set for the voucher
-    if (!empty($password)) {
+    if ( ! empty($password)) {
         $mpdf->SetProtection(array('copy', 'print'), $password, $password);
     }
 
     // Check if the archive folder is available
-    if (!(is_dir('./uploads/archive/') || is_link('./uploads/archive/'))) {
+    if ( ! (is_dir('./uploads/archive/') || is_link('./uploads/archive/'))) {
         mkdir('./uploads/archive/', '0777');
     }
 
     // Set the footer if voucher is invoice and if set in settings
-    if ($isInvoice && !empty($CI->mdl_settings->settings['pdf_invoice_footer'])) {
+    if ($isInvoice && ! empty($CI->mdl_settings->settings['pdf_invoice_footer'])) {
         $mpdf->setAutoBottomMargin = 'stretch';
-        $mpdf->SetHTMLFooter('<div id="footer">' . $CI->mdl_settings->settings['pdf_invoice_footer'] . '</div>');
+        $mpdf->SetHTMLFooter('<div id="footer">'.$CI->mdl_settings->settings['pdf_invoice_footer'].'</div>');
     }
 
     $mpdf->WriteHTML($html);
 
     if ($isInvoice) {
 
-        foreach (glob(UPLOADS_FOLDER . 'archive/*' . $filename . '.pdf') as $file) {
+        foreach (glob(UPLOADS_FOLDER.'archive/*'.$filename.'.pdf') as $file) {
             array_push($invoice_array, $file);
         }
 
-        if (!empty($invoice_array) && !is_null($isGuest)) {
+        if ( ! empty($invoice_array) && ! is_null($isGuest)) {
             rsort($invoice_array);
 
             if ($stream) {
-                return $mpdf->Output($filename . '.pdf', 'I');
+                return $mpdf->Output($filename.'.pdf', 'I');
             } else {
                 return $invoice_array[0];
             }
         }
 
-        $archived_file = UPLOADS_FOLDER . 'archive/' . date('Y-m-d') . '_' . $filename . '.pdf';
+        $archived_file = UPLOADS_FOLDER.'archive/'.date('Y-m-d').'_'.$filename.'.pdf';
         $mpdf->Output($archived_file, 'F');
 
         if ($stream) {
-            return $mpdf->Output($filename . '.pdf', 'I');
+            return $mpdf->Output($filename.'.pdf', 'I');
         } else {
             return $archived_file;
         }
@@ -95,24 +95,24 @@ 
     // If $stream is true (default) the PDF will be displayed directly in the browser
     // otherwise will be returned as a download
     if ($stream) {
-        return $mpdf->Output($filename . '.pdf', 'I');
+        return $mpdf->Output($filename.'.pdf', 'I');
     } else {
 
-        $mpdf->Output(UPLOADS_FOLDER . 'temp/' . $filename . '.pdf', 'F');
+        $mpdf->Output(UPLOADS_FOLDER.'temp/'.$filename.'.pdf', 'F');
 
         // Housekeeping
         // Delete any files in temp/ directory that are >1 hrs old
         $interval = 3600;
         if ($handle = @opendir(preg_replace('/\/$/', '', './uploads/temp/'))) {
             while (false !== ($file = readdir($handle))) {
-                if (($file != '..') && ($file != '.') && !is_dir($file) && ((filemtime('./uploads/temp/' . $file) + $interval) < time()) && (substr($file, 0, 1) !== '.') && ($file != 'remove.txt')) { // mPDF 5.7.3
-                    unlink(UPLOADS_FOLDER . 'temp/' . $file);
+                if (($file != '..') && ($file != '.') && ! is_dir($file) && ((filemtime('./uploads/temp/'.$file) + $interval) < time()) && (substr($file, 0, 1) !== '.') && ($file != 'remove.txt')) { // mPDF 5.7.3
+                    unlink(UPLOADS_FOLDER.'temp/'.$file);
                 }
             }
             closedir($handle);
         }
 
-        return UPLOADS_FOLDER . 'temp/' . $filename . '.pdf';
+        return UPLOADS_FOLDER.'temp/'.$filename.'.pdf';
 
     }
 }

index.php

Spacing +11 added lines, -11 removed lines

@@ -46,7 +46,7 @@ 
  *
  */
 
-if (is_dir(__DIR__ . "/application/config/development")) {
+if (is_dir(__DIR__."/application/config/development")) {
     define('ENVIRONMENT', 'development');
 } else {
     define('ENVIRONMENT', 'production');
@@ -170,15 +170,15 @@ 
 }
 
 if (realpath($system_path) !== FALSE) {
-    $system_path = realpath($system_path) . '/';
+    $system_path = realpath($system_path).'/';
 }
 
 // ensure there's a trailing slash
-$system_path = rtrim($system_path, '/') . '/';
+$system_path = rtrim($system_path, '/').'/';
 
 // Is the system path correct?
-if (!is_dir($system_path)) {
-    exit("Your system folder path does not appear to be set correctly. Please open the following file and correct this: " . pathinfo(__FILE__, PATHINFO_BASENAME));
+if ( ! is_dir($system_path)) {
+    exit("Your system folder path does not appear to be set correctly. Please open the following file and correct this: ".pathinfo(__FILE__, PATHINFO_BASENAME));
 }
 
 /*
@@ -205,17 +205,17 @@ 
 
 // The path to the "application" folder
 if (is_dir($application_folder)) {
-    define('APPPATH', $application_folder . '/');
+    define('APPPATH', $application_folder.'/');
 } else {
-    if (!is_dir(BASEPATH . $application_folder . '/')) {
-        exit("Your application folder path does not appear to be set correctly. Please open the following file and correct this: " . SELF);
+    if ( ! is_dir(BASEPATH.$application_folder.'/')) {
+        exit("Your application folder path does not appear to be set correctly. Please open the following file and correct this: ".SELF);
     }
 
-    define('APPPATH', BASEPATH . $application_folder . '/');
+    define('APPPATH', BASEPATH.$application_folder.'/');
 }
 
 // Set the uploads folder
-define('UPLOADS_FOLDER', FCPATH . 'uploads/');
+define('UPLOADS_FOLDER', FCPATH.'uploads/');
 
 /*
  * --------------------------------------------------------------------
@@ -225,7 +225,7 @@ 
  * And away we go...
  *
  */
-require_once BASEPATH . 'core/CodeIgniter.php';
+require_once BASEPATH.'core/CodeIgniter.php';
 
 /* End of file index.php */
 /* Location: ./index.php */

application/modules/invoices/controllers/cron.php

Spacing +8 added lines, -10 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-if (!defined('BASEPATH'))
+if ( ! defined('BASEPATH'))
     exit('No direct script access allowed');
 
 /*
@@ -70,7 +70,7 @@ 
                 $this->load->model('email_templates/mdl_email_templates');
 
                 $email_template_id = $this->mdl_settings->setting('email_invoice_template');
-                if (!$email_template_id) {
+                if ( ! $email_template_id) {
                     return;
                 }
 
@@ -93,13 +93,11 @@ 
                     $body = htmlspecialchars_decode(nl2br($body));
                 }
 
-                $from = !empty($tpl->email_template_from_email) ?
-                    array($tpl->email_template_from_email, $tpl->email_template_from_name) :
-                    array($invoice->user_email, "");
+                $from = ! empty($tpl->email_template_from_email) ?
+                    array($tpl->email_template_from_email, $tpl->email_template_from_name) : array($invoice->user_email, "");
 
-                $subject = !empty($tpl->email_template_subject) ?
-                    $tpl->email_template_subject :
-                    trans('invoice') . ' #' . $new_invoice->invoice_number;
+                $subject = ! empty($tpl->email_template_subject) ?
+                    $tpl->email_template_subject : trans('invoice').' #'.$new_invoice->invoice_number;
 
                 $pdf_template = $tpl->email_template_pdf_template;
                 $to = $invoice->client_email;
@@ -110,11 +108,11 @@ 
                     $this->mdl_invoices->mark_sent($target_id);
                     $this->mdl_invoice_amounts->calculate($target_id);
                 } else {
-                    log_message('error', 'Invoice ' . $target_id . 'could not be sent. Please review your Email settings.');
+                    log_message('error', 'Invoice '.$target_id.'could not be sent. Please review your Email settings.');
                 }
             }
         }
 
-        log_message('debug', '[Recurring Invoices] ' . count($invoices_recurring) . ' recurring invoices processed');
+        log_message('debug', '[Recurring Invoices] '.count($invoices_recurring).' recurring invoices processed');
     }
 }

Braces +5 added lines, -2 removed lines

@@ -1,7 +1,8 @@ 
 <?php
 
-if (!defined('BASEPATH'))
+if (!defined('BASEPATH')) {
     exit('No direct script access allowed');
+}
 
 /*
  * InvoicePlane
@@ -22,7 +23,9 @@ 
     {
         // Check the provided cron key
         if ($cron_key != $this->mdl_settings->setting('cron_key')) {
-            if (IP_DEBUG) log_message('error', 'Wrong cron key provided!');
+            if (IP_DEBUG) {
+                log_message('error', 'Wrong cron key provided!');
+            }
             exit('Wrong cron key!');
         }
 

application/modules/invoices/views/partial_item_table.php

Spacing +7 added lines, -7 removed lines

@@ -45,7 +45,7 @@ 
                     <span class="input-group-addon"><?php echo trans('item_discount'); ?></span>
                     <input type="text" name="item_discount_amount" class="input-sm form-control amount"
                            value="" data-toggle="tooltip" data-placement="bottom"
-                           title="<?php echo $this->mdl_settings->setting('currency_symbol') . ' ' . trans('per_item'); ?>">
+                           title="<?php echo $this->mdl_settings->setting('currency_symbol').' '.trans('per_item'); ?>">
                 </div>
             </td>
             <td class="td-amount">
@@ -56,7 +56,7 @@ 
                         <option value="0"><?php echo trans('none'); ?></option>
                         <?php foreach ($tax_rates as $tax_rate) { ?>
                             <option value="<?php echo $tax_rate->tax_rate_id; ?>">
-                                <?php echo format_amount($tax_rate->tax_rate_percent) . '% - ' . $tax_rate->tax_rate_name; ?>
+                                <?php echo format_amount($tax_rate->tax_rate_percent).'% - '.$tax_rate->tax_rate_name; ?>
                             </option>
                         <?php } ?>
                     </select>
@@ -137,7 +137,7 @@ 
                         <input type="text" name="item_discount_amount" class="input-sm form-control amount"
                                value="<?php echo format_amount($item->item_discount_amount); ?>"
                                data-toggle="tooltip" data-placement="bottom"
-                               title="<?php echo $this->mdl_settings->setting('currency_symbol') . ' ' . trans('per_item'); ?>"
+                               title="<?php echo $this->mdl_settings->setting('currency_symbol').' '.trans('per_item'); ?>"
                             <?php if ($invoice->is_read_only == 1) {
                                 echo 'disabled="disabled"';
                             } ?>>
@@ -155,7 +155,7 @@ 
                             <?php foreach ($tax_rates as $tax_rate) { ?>
                                 <option value="<?php echo $tax_rate->tax_rate_id; ?>"
                                         <?php if ($item->item_tax_rate_id == $tax_rate->tax_rate_id) { ?>selected="selected"<?php } ?>>
-                                    <?php echo format_amount($tax_rate->tax_rate_percent) . '% - ' . $tax_rate->tax_rate_name; ?>
+                                    <?php echo format_amount($tax_rate->tax_rate_percent).'% - '.$tax_rate->tax_rate_name; ?>
                                 </option>
                             <?php } ?>
                         </select>
@@ -163,7 +163,7 @@ 
                 </td>
                 <td class="td-icon text-right td-vert-middle">
                     <?php if ($invoice->is_read_only != 1): ?>
-                        <a href="<?php echo site_url('invoices/delete_item/' . $invoice->invoice_id . '/' . $item->item_id); ?>"
+                        <a href="<?php echo site_url('invoices/delete_item/'.$invoice->invoice_id.'/'.$item->item_id); ?>"
                            title="<?php echo trans('delete'); ?>">
                             <i class="fa fa-trash-o text-danger"></i>
                         </a>
@@ -246,8 +246,8 @@ 
                     <?php if ($invoice_tax_rates) {
                         foreach ($invoice_tax_rates as $invoice_tax_rate) { ?>
                             <span class="text-muted">
-                            <?php echo anchor('invoices/delete_invoice_tax/' . $invoice->invoice_id . '/' . $invoice_tax_rate->invoice_tax_rate_id, '<i class="fa fa-trash-o"></i>');
-                            echo ' ' . $invoice_tax_rate->invoice_tax_rate_name . ' ' . format_amount($invoice_tax_rate->invoice_tax_rate_percent); ?>
+                            <?php echo anchor('invoices/delete_invoice_tax/'.$invoice->invoice_id.'/'.$invoice_tax_rate->invoice_tax_rate_id, '<i class="fa fa-trash-o"></i>');
+                            echo ' '.$invoice_tax_rate->invoice_tax_rate_name.' '.format_amount($invoice_tax_rate->invoice_tax_rate_percent); ?>
                                 %</span>&nbsp;
                             <span class="amount">
                                 <?php echo format_currency($invoice_tax_rate->invoice_tax_rate_amount); ?>

application/modules/invoices/views/modal_add_invoice_tax.php

Spacing +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
                         <option value="0"><?php echo trans('none'); ?></option>
                         <?php foreach ($tax_rates as $tax_rate) { ?>
                             <option
-                                value="<?php echo $tax_rate->tax_rate_id; ?>"><?php echo format_amount($tax_rate->tax_rate_percent) . '% - ' . $tax_rate->tax_rate_name; ?></option>
+                                value="<?php echo $tax_rate->tax_rate_id; ?>"><?php echo format_amount($tax_rate->tax_rate_percent).'% - '.$tax_rate->tax_rate_name; ?></option>
                         <?php } ?>
                     </select>
                 </div>