Icybee / module-files

lib/Block/EditBlock.php

Unused Use Statements -3 removed lines

@@ -11,13 +11,10 @@
 
 namespace Icybee\Modules\Files\Block;
 
-use ICanBoogie\I18n;
 use ICanBoogie\Operation;
-
 use Brickrouge\Element;
 use Brickrouge\Document;
 use Brickrouge\Form;
-
 use Icybee\Modules\Files as Root;
 use Icybee\Modules\Files\File;
 

Spacing +1 added lines, -1 removed lines

@@ -60,7 +60,7 @@
 
 				Element::CHILDREN => [
 
-					$this->t('The folder %folder is not writable !', [ '%folder' => $folder ])
+					$this->t('The folder %folder is not writable !', ['%folder' => $folder])
 
 				]
 			];

Braces +1 added lines, -2 removed lines

@@ -75,8 +75,7 @@
 			try
 			{
 				$path = $this->record->pathname->relative;
-			}
-			catch (\Exception $e)
+			} catch (\Exception $e)
 			{
 				#
 				# the associated file might have disappeared

lib/Hooks.php

Doc Comments +2 added lines, -2 removed lines

@@ -19,7 +19,7 @@ 
 class Hooks
 {
 	/**
-	 * @param Core|Binding\CoreBindings $app
+	 * @param Core $app
 	 *
 	 * @return FileStorageIndex
 	 */
@@ -31,7 +31,7 @@ 
 	}
 
 	/**
-	 * @param Core|Binding\CoreBindings $app
+	 * @param Core $app
 	 *
 	 * @return FileStorage
 	 */

Unused Use Statements -1 removed lines

@@ -12,7 +12,6 @@
 namespace Icybee\Modules\Files;
 
 use ICanBoogie\Core;
-
 use Icybee\Modules\Files\Storage\FileStorage;
 use Icybee\Modules\Files\Storage\FileStorageIndex;
 

lib/Operation/SaveOperation.php

Unused Use Statements -1 removed lines

@@ -14,7 +14,6 @@
 use ICanBoogie\Errors;
 use ICanBoogie\HTTP\Request;
 use ICanBoogie\HTTP\File as HTTPFile;
-
 use Icybee\Modules\Files\File;
 use Icybee\Modules\Files\Module;
 

Spacing +3 added lines, -3 removed lines

@@ -121,7 +121,7 @@ 
 
 			if (!$file)
 			{
-				$this->response->errors->add(File::HTTP_FILE, "Invalid or deleted file: %pathname", [ 'pathname' => $path ]);
+				$this->response->errors->add(File::HTTP_FILE, "Invalid or deleted file: %pathname", ['pathname' => $path]);
 			}
 		}
 
@@ -158,12 +158,12 @@ 
 
 			if ($max_file_size && $max_file_size < $file->size)
 			{
-				$error_message = $errors->format("Maximum file size is :size Mb", [ ':size' => round($max_file_size / 1024) ]);
+				$error_message = $errors->format("Maximum file size is :size Mb", [':size' => round($max_file_size / 1024)]);
 			}
 
 			if ($this->accept && !$file->match($this->accept))
 			{
-				$error_message = $errors->format("Only the following file types are accepted: %accepted.", [ '%accepted' => implode(', ', $this->accept) ]);
+				$error_message = $errors->format("Only the following file types are accepted: %accepted.", ['%accepted' => implode(', ', $this->accept)]);
 			}
 
 			if ($error_message)

Braces +2 added lines, -4 removed lines

@@ -114,8 +114,7 @@ 
 			$pathname = \ICanBoogie\REPOSITORY . 'tmp' . DIRECTORY_SEPARATOR . $filename;
 
 			$file->move($pathname);
-		}
-		else if ($path && strpos($path, \ICanBoogie\strip_root(\ICanBoogie\REPOSITORY . "files")) !== 0)
+		} else if ($path && strpos($path, \ICanBoogie\strip_root(\ICanBoogie\REPOSITORY . "files")) !== 0)
 		{
 			$file = $this->resolve_request_file_from_pathname($path);
 
@@ -175,8 +174,7 @@ 
 
 				]);
 			}
-		}
-		else if (!$this->key)
+		} else if (!$this->key)
 		{
 			$errors->add(File::HTTP_FILE, "File is required.");
 		}

lib/Routing/FilesAdminController.php

Unused Use Statements -2 removed lines

@@ -12,8 +12,6 @@
 namespace Icybee\Modules\Files\Routing;
 
 use ICanBoogie\HTTP\FileResponse;
-use ICanBoogie\HTTP\Request;
-
 use Icybee\Modules\Files\Binding\CoreBindings;
 use Icybee\Modules\Files\File;
 use Icybee\Modules\Files\FileModel;

lib/Routing/FilesController.php

Unused Use Statements -2 removed lines

@@ -12,12 +12,10 @@
 namespace Icybee\Modules\Files\Routing;
 
 use ICanBoogie\HTTP\FileResponse;
-use ICanBoogie\HTTP\Request;
 use ICanBoogie\Routing\Controller;
 use ICanBoogie\Binding\Routing\ControllerBindings;
 use ICanBoogie\Binding\Routing\ForwardUndefinedPropertiesToApplication;
 use ICanBoogie\Module\ControllerBindings as ModuleBindings;
-
 use Icybee\Modules\Files\Binding\CoreBindings;
 use Icybee\Modules\Files\File;
 

lib/Storage/FileStorage.php

Doc Comments +1 added lines, -1 removed lines

@@ -105,7 +105,7 @@
 	 *
 	 * If a file has no reference left it is deleted.
 	 *
-	 * @param $key_or_id_or_uuid_or_hash
+	 * @param string $key_or_id_or_uuid_or_hash
 	 */
 	public function release($key_or_id_or_uuid_or_hash)
 	{

Spacing +2 added lines, -2 removed lines

@@ -69,7 +69,7 @@ 
 	{
 		$this->assert_hash_is_used($hash);
 
-		$key = IndexKey::from([ $nid, $uuid, $hash ]);
+		$key = IndexKey::from([$nid, $uuid, $hash]);
 
 		$this->index->add($key);
 
@@ -204,7 +204,7 @@ 
 	{
 		$hash = $hash ?: $this->hash($pathname);
 
-		return Pathname::from([ $this->root, $hash ]);
+		return Pathname::from([$this->root, $hash]);
 	}
 
 	/**

lib/Storage/FileStorageIndex.php

Doc Comments +1 added lines, -1 removed lines

@@ -118,7 +118,7 @@
 	/**
 	 * Deletes key(s) from the index.
 	 *
-	 * @param IndexKey|int|string $key_or_id_or_uuid_or_hash
+	 * @param IndexKey $key_or_id_or_uuid_or_hash
 	 *
 	 * @throws \InvalidArgumentException if `$key_or_id_or_uuid_or_hash` is not of the expected type.
 	 */

Spacing +1 added lines, -1 removed lines

@@ -173,7 +173,7 @@
 	{
 		$pathname = $this->root . $key;
 
-		return file_exists($pathname) ? [ $key ] : null;
+		return file_exists($pathname) ? [$key] : null;
 	}
 
 	/**

lib/Storage/IndexKey.php

Doc Comments +1 added lines, -1 removed lines

@@ -69,7 +69,7 @@
 	 *
 	 * @param string $key
 	 *
-	 * @return array
+	 * @return string[]
 	 */
 	static private function parse_key($key)
 	{

Spacing +2 added lines, -2 removed lines

@@ -77,7 +77,7 @@ 
 		$encoded_uuid = substr($key, self::ENCODED_ID_LENGTH + 1, self::ENCODED_UUID_LENGTH);
 		$hash = substr($key, self::ENCODED_ID_LENGTH + 1 + self::ENCODED_UUID_LENGTH + 1);
 
-		return [ $encoded_id, $encoded_uuid, $hash ];
+		return [$encoded_id, $encoded_uuid, $hash];
 	}
 
 	/**
@@ -132,7 +132,7 @@ 
 			throw new \LogicException("Invalid UUID: $uuid.");
 		}
 
-		return Base64::encode_unpadded(hex2bin(strtr($uuid, [ '-' => '' ])));
+		return Base64::encode_unpadded(hex2bin(strtr($uuid, ['-' => ''])));
 	}
 
 	/**

descriptor.php

Spacing +3 added lines, -3 removed lines

@@ -27,9 +27,9 @@
 			Model::EXTENDING => 'nodes',
 			Model::SCHEMA => [
 
-				'size' => [ 'integer', 'unsigned' => true ],
-				'mime' => [ 'varchar', 'charset' => 'ascii/general_ci' ],
-				'extension' => [ 'varchar', 16, 'charset' => 'ascii/general_ci' ],
+				'size' => ['integer', 'unsigned' => true],
+				'mime' => ['varchar', 'charset' => 'ascii/general_ci'],
+				'extension' => ['varchar', 16, 'charset' => 'ascii/general_ci'],
 				'description' => 'text'
 
 			]