Inspection of "Improved invalid arguments detection" - ICanBoogie/Errors - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 2.0 ( 9a9bd1...98f64c )

by Olivier

created 2016-06-21 20:15 UTC

Status

Spacing +44 added lines, -44 removed lines patch added patch discarded remove patch

@@ -30,7 +30,7 @@  discard block
 block discarded – undo
 	{
 		$attribute = uniqid();
 		$format = uniqid();
-		$args = [ uniqid() => uniqid() ];
+		$args = [uniqid() => uniqid()];
 		$this->errors->add($attribute, $format, $args);
 		$this->assertEquals(1, $this->errors->count());
 
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
 	public function test_add_with_true()
 	{
 		$attribute = uniqid();
-		$args = [ uniqid() => uniqid() ];
+		$args = [uniqid() => uniqid()];
 		$this->errors->add($attribute, true, $args);
 		$this->assertEquals(1, $this->errors->count());
 
@@ -59,9 +59,9 @@  discard block
 block discarded – undo
 
 	public function test_add_with_error()
 	{
-		$error = new Error(uniqid(), [ uniqid() => uniqid() ]);
+		$error = new Error(uniqid(), [uniqid() => uniqid()]);
 		$attribute = uniqid();
-		$this->errors->add($attribute, $error, [ uniqid() => uniqid() ]);
+		$this->errors->add($attribute, $error, [uniqid() => uniqid()]);
 		$this->assertEquals(1, $this->errors->count());
 
 		$errors = $this->errors[$attribute];
@@ -84,12 +84,12 @@  discard block
 block discarded – undo
 	{
 		return [
 
-			[ null ],
-			[ false ],
-			[ true ],
-			[ 123 ],
-			[ [] ],
-			[ new \stdClass ]
+			[null],
+			[false],
+			[true],
+			[123],
+			[[]],
+			[new \stdClass]
 
 		];
 	}
@@ -109,17 +109,17 @@  discard block
 block discarded – undo
 	{
 		return [
 
-			[ false ],
-			[ [ uniqid() => uniqid() ] ],
-			[ 1234 ],
-			[ new \stdClass ]
+			[false],
+			[[uniqid() => uniqid()]],
+			[1234],
+			[new \stdClass]
 
 		];
 	}
 
 	public function test_add_generic()
 	{
-		$error = new Error(uniqid(), [ uniqid() => uniqid() ]);
+		$error = new Error(uniqid(), [uniqid() => uniqid()]);
 		$this->errors->add_generic($error);
 		$errors = $this->errors[null];
 		$this->assertSame($error, reset($errors));
@@ -128,10 +128,10 @@  discard block
 block discarded – undo
 	public function test_array_access_interface()
 	{
 		$errors = $this->errors;
-		$err1 = new Error(uniqid(), [ uniqid() => uniqid() ]);
-		$err2 = new Error(uniqid(), [ uniqid() => uniqid() ]);
-		$err3 = new Error(uniqid(), [ uniqid() => uniqid() ]);
-		$err4 = new Error(uniqid(), [ uniqid() => uniqid() ]);
+		$err1 = new Error(uniqid(), [uniqid() => uniqid()]);
+		$err2 = new Error(uniqid(), [uniqid() => uniqid()]);
+		$err3 = new Error(uniqid(), [uniqid() => uniqid()]);
+		$err4 = new Error(uniqid(), [uniqid() => uniqid()]);
 		$attribute = uniqid();
 		$errors[] = $err1;
 		$errors[] = $err2;
@@ -140,8 +140,8 @@  discard block
 block discarded – undo
 
 		$this->assertTrue(isset($errors[null]));
 		$this->assertTrue(isset($errors[$attribute]));
-		$this->assertSame([ $err1, $err2 ], $errors[null]);
-		$this->assertSame([ $err3, $err4 ], $errors[$attribute]);
+		$this->assertSame([$err1, $err2], $errors[null]);
+		$this->assertSame([$err3, $err4], $errors[$attribute]);
 
 		unset($errors[null]);
 		$this->assertSame([], $errors[null]);
@@ -152,10 +152,10 @@  discard block
 block discarded – undo
 	public function test_iterator()
 	{
 		$errors = $this->errors;
-		$err1 = new Error('err1-' . uniqid());
-		$err2 = new Error('err2-' . uniqid());
-		$err3 = new Error('err3-' . uniqid());
-		$err4 = new Error('err4-' . uniqid());
+		$err1 = new Error('err1-'.uniqid());
+		$err2 = new Error('err2-'.uniqid());
+		$err3 = new Error('err3-'.uniqid());
+		$err4 = new Error('err4-'.uniqid());
 		$attribute = uniqid();
 		$errors[$attribute] = $err3;
 		$errors[] = $err1;
@@ -166,15 +166,15 @@  discard block
 block discarded – undo
 
 		foreach ($errors as $a => $e)
 		{
-			$iterator_errors[] = [ $a => $e ];
+			$iterator_errors[] = [$a => $e];
 		}
 
 		$this->assertSame([
 
-			[ ErrorCollection::GENERIC => $err1 ],
-			[ ErrorCollection::GENERIC => $err2 ],
-			[ $attribute => $err3 ],
-			[ $attribute => $err4 ],
+			[ErrorCollection::GENERIC => $err1],
+			[ErrorCollection::GENERIC => $err2],
+			[$attribute => $err3],
+			[$attribute => $err4],
 
 		], $iterator_errors);
 	}
@@ -182,10 +182,10 @@  discard block
 block discarded – undo
 	public function test_each()
 	{
 		$errors = $this->errors;
-		$err1 = new Error('err1-' . uniqid());
-		$err2 = new Error('err2-' . uniqid());
-		$err3 = new Error('err3-' . uniqid());
-		$err4 = new Error('err4-' . uniqid());
+		$err1 = new Error('err1-'.uniqid());
+		$err2 = new Error('err2-'.uniqid());
+		$err3 = new Error('err3-'.uniqid());
+		$err4 = new Error('err4-'.uniqid());
 		$attribute = uniqid();
 		$errors[$attribute] = $err3;
 		$errors[] = $err1;
@@ -194,19 +194,19 @@  discard block
 block discarded – undo
 
 		$iterator_errors = [];
 
-		$errors->each(function ($error, $attribute, $collection) use (&$iterator_errors, $errors) {
+		$errors->each(function($error, $attribute, $collection) use (&$iterator_errors, $errors) {
 
 			$this->assertSame($errors, $collection);
-			$iterator_errors[] = [ $attribute => $error ];
+			$iterator_errors[] = [$attribute => $error];
 
 		});
 
 		$this->assertSame([
 
-			[ ErrorCollection::GENERIC => $err1 ],
-			[ ErrorCollection::GENERIC => $err2 ],
-			[ $attribute => $err3 ],
-			[ $attribute => $err4 ],
+			[ErrorCollection::GENERIC => $err1],
+			[ErrorCollection::GENERIC => $err2],
+			[$attribute => $err3],
+			[$attribute => $err4],
 
 		], $iterator_errors);
 	}
@@ -250,10 +250,10 @@  discard block
 block discarded – undo
 		$arg4 = uniqid();
 		$attribute = uniqid();
 		$errors = $this->errors;
-		$errors->add($attribute, $format, [ 'arg' => $arg3 ]);
-		$errors->add_generic($format, [ 'arg' => $arg1 ]);
-		$errors->add($attribute, $format, [ 'arg' => $arg4 ]);
-		$errors->add_generic($format, [ 'arg' => $arg2 ]);
+		$errors->add($attribute, $format, ['arg' => $arg3]);
+		$errors->add_generic($format, ['arg' => $arg1]);
+		$errors->add($attribute, $format, ['arg' => $arg4]);
+		$errors->add_generic($format, ['arg' => $arg2]);
 
 		$this->assertSame(json_encode([
 

Please login to merge, or discard this patch.

		@@ -30,7 +30,7 @@ discard block
		block discarded – undo
30	30	{
31	31	$attribute = uniqid();
32	32	$format = uniqid();
33		- $args = [ uniqid() => uniqid() ];
	33	+ $args = [uniqid() => uniqid()];
34	34	$this->errors->add($attribute, $format, $args);
35	35	$this->assertEquals(1, $this->errors->count());
36	36
		@@ -45,7 +45,7 @@ discard block
		block discarded – undo
45	45	public function test_add_with_true()
46	46	{
47	47	$attribute = uniqid();
48		- $args = [ uniqid() => uniqid() ];
	48	+ $args = [uniqid() => uniqid()];
49	49	$this->errors->add($attribute, true, $args);
50	50	$this->assertEquals(1, $this->errors->count());
51	51
		@@ -59,9 +59,9 @@ discard block
		block discarded – undo
59	59
60	60	public function test_add_with_error()
61	61	{
62		- $error = new Error(uniqid(), [ uniqid() => uniqid() ]);
	62	+ $error = new Error(uniqid(), [uniqid() => uniqid()]);
63	63	$attribute = uniqid();
64		- $this->errors->add($attribute, $error, [ uniqid() => uniqid() ]);
	64	+ $this->errors->add($attribute, $error, [uniqid() => uniqid()]);
65	65	$this->assertEquals(1, $this->errors->count());
66	66
67	67	$errors = $this->errors[$attribute];
		@@ -84,12 +84,12 @@ discard block
		block discarded – undo
84	84	{
85	85	return [
86	86
87		- [ null ],
88		- [ false ],
89		- [ true ],
90		- [ 123 ],
91		- [ [] ],
92		- [ new \stdClass ]
	87	+ [null],
	88	+ [false],
	89	+ [true],
	90	+ [123],
	91	+ [[]],
	92	+ [new \stdClass]
93	93
94	94	];
95	95	}
		@@ -109,17 +109,17 @@ discard block
		block discarded – undo
109	109	{
110	110	return [
111	111
112		- [ false ],
113		- [ [ uniqid() => uniqid() ] ],
114		- [ 1234 ],
115		- [ new \stdClass ]
	112	+ [false],
	113	+ [[uniqid() => uniqid()]],
	114	+ [1234],
	115	+ [new \stdClass]
116	116
117	117	];
118	118	}
119	119
120	120	public function test_add_generic()
121	121	{
122		- $error = new Error(uniqid(), [ uniqid() => uniqid() ]);
	122	+ $error = new Error(uniqid(), [uniqid() => uniqid()]);
123	123	$this->errors->add_generic($error);
124	124	$errors = $this->errors[null];
125	125	$this->assertSame($error, reset($errors));
		@@ -128,10 +128,10 @@ discard block
		block discarded – undo
128	128	public function test_array_access_interface()
129	129	{
130	130	$errors = $this->errors;
131		- $err1 = new Error(uniqid(), [ uniqid() => uniqid() ]);
132		- $err2 = new Error(uniqid(), [ uniqid() => uniqid() ]);
133		- $err3 = new Error(uniqid(), [ uniqid() => uniqid() ]);
134		- $err4 = new Error(uniqid(), [ uniqid() => uniqid() ]);
	131	+ $err1 = new Error(uniqid(), [uniqid() => uniqid()]);
	132	+ $err2 = new Error(uniqid(), [uniqid() => uniqid()]);
	133	+ $err3 = new Error(uniqid(), [uniqid() => uniqid()]);
	134	+ $err4 = new Error(uniqid(), [uniqid() => uniqid()]);
135	135	$attribute = uniqid();
136	136	$errors[] = $err1;
137	137	$errors[] = $err2;
		@@ -140,8 +140,8 @@ discard block
		block discarded – undo
140	140
141	141	$this->assertTrue(isset($errors[null]));
142	142	$this->assertTrue(isset($errors[$attribute]));
143		- $this->assertSame([ $err1, $err2 ], $errors[null]);
144		- $this->assertSame([ $err3, $err4 ], $errors[$attribute]);
	143	+ $this->assertSame([$err1, $err2], $errors[null]);
	144	+ $this->assertSame([$err3, $err4], $errors[$attribute]);
145	145
146	146	unset($errors[null]);
147	147	$this->assertSame([], $errors[null]);
		@@ -152,10 +152,10 @@ discard block
		block discarded – undo
152	152	public function test_iterator()
153	153	{
154	154	$errors = $this->errors;
155		- $err1 = new Error('err1-' . uniqid());
156		- $err2 = new Error('err2-' . uniqid());
157		- $err3 = new Error('err3-' . uniqid());
158		- $err4 = new Error('err4-' . uniqid());
	155	+ $err1 = new Error('err1-'.uniqid());
	156	+ $err2 = new Error('err2-'.uniqid());
	157	+ $err3 = new Error('err3-'.uniqid());
	158	+ $err4 = new Error('err4-'.uniqid());
159	159	$attribute = uniqid();
160	160	$errors[$attribute] = $err3;
161	161	$errors[] = $err1;
		@@ -166,15 +166,15 @@ discard block
		block discarded – undo
166	166
167	167	foreach ($errors as $a => $e)
168	168	{
169		- $iterator_errors[] = [ $a => $e ];
	169	+ $iterator_errors[] = [$a => $e];
170	170	}
171	171
172	172	$this->assertSame([
173	173
174		- [ ErrorCollection::GENERIC => $err1 ],
175		- [ ErrorCollection::GENERIC => $err2 ],
176		- [ $attribute => $err3 ],
177		- [ $attribute => $err4 ],
	174	+ [ErrorCollection::GENERIC => $err1],
	175	+ [ErrorCollection::GENERIC => $err2],
	176	+ [$attribute => $err3],
	177	+ [$attribute => $err4],
178	178
179	179	], $iterator_errors);
180	180	}
		@@ -182,10 +182,10 @@ discard block
		block discarded – undo
182	182	public function test_each()
183	183	{
184	184	$errors = $this->errors;
185		- $err1 = new Error('err1-' . uniqid());
186		- $err2 = new Error('err2-' . uniqid());
187		- $err3 = new Error('err3-' . uniqid());
188		- $err4 = new Error('err4-' . uniqid());
	185	+ $err1 = new Error('err1-'.uniqid());
	186	+ $err2 = new Error('err2-'.uniqid());
	187	+ $err3 = new Error('err3-'.uniqid());
	188	+ $err4 = new Error('err4-'.uniqid());
189	189	$attribute = uniqid();
190	190	$errors[$attribute] = $err3;
191	191	$errors[] = $err1;
		@@ -194,19 +194,19 @@ discard block
		block discarded – undo
194	194
195	195	$iterator_errors = [];
196	196
197		- $errors->each(function ($error, $attribute, $collection) use (&$iterator_errors, $errors) {
	197	+ $errors->each(function($error, $attribute, $collection) use (&$iterator_errors, $errors) {
198	198
199	199	$this->assertSame($errors, $collection);
200		- $iterator_errors[] = [ $attribute => $error ];
	200	+ $iterator_errors[] = [$attribute => $error];
201	201
202	202	});
203	203
204	204	$this->assertSame([
205	205
206		- [ ErrorCollection::GENERIC => $err1 ],
207		- [ ErrorCollection::GENERIC => $err2 ],
208		- [ $attribute => $err3 ],
209		- [ $attribute => $err4 ],
	206	+ [ErrorCollection::GENERIC => $err1],
	207	+ [ErrorCollection::GENERIC => $err2],
	208	+ [$attribute => $err3],
	209	+ [$attribute => $err4],
210	210
211	211	], $iterator_errors);
212	212	}
		@@ -250,10 +250,10 @@ discard block
		block discarded – undo
250	250	$arg4 = uniqid();
251	251	$attribute = uniqid();
252	252	$errors = $this->errors;
253		- $errors->add($attribute, $format, [ 'arg' => $arg3 ]);
254		- $errors->add_generic($format, [ 'arg' => $arg1 ]);
255		- $errors->add($attribute, $format, [ 'arg' => $arg4 ]);
256		- $errors->add_generic($format, [ 'arg' => $arg2 ]);
	253	+ $errors->add($attribute, $format, ['arg' => $arg3]);
	254	+ $errors->add_generic($format, ['arg' => $arg1]);
	255	+ $errors->add($attribute, $format, ['arg' => $arg4]);
	256	+ $errors->add_generic($format, ['arg' => $arg2]);
257	257
258	258	$this->assertSame(json_encode([
259	259

ICanBoogie / Errors

Push — 2.0 ( 9a9bd1...98f64c )

Status

Category

Spacing +44 added lines, -44 removed lines patch added patch discarded remove patch