DiffTest::generateSecond() - Code Metrics - Inspection of "Split testDifference" - Horat1us/php-xml-convertible - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 87312f...78171c )

by Alexander

created 2017-05-11 16:34 UTC

DiffTest::generateSecond() A

↳ Parent: DiffTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	5
nc	1
nop	0

<?php
/**
 * Created by PhpStorm.
 * User: horat1us
 * Date: 5/4/17
 * Time: 12:10 PM
 */

namespace Horat1us\Tests;


use Horat1us\Examples\Head;
use Horat1us\Examples\Person;
use Horat1us\XmlConvertibleObject;
use SebastianBergmann\PHPLOC\Log\XML;

class DiffTest extends \PHPUnit_Framework_TestCase
{
    public function testDifferenceWithEmpty()
    {
        $first = new Person('Alex', 'Jobs');
        $second = new Person('Alex', 'Jobs', [
            new XmlConvertibleObject()
        ]);
        $diff = $first->xmlDiff($second);
        $this->assertInstanceOf(get_class($first), $diff);
    }

    public function testDifferenceWithAdditional()
    {
        $first = new Person('Alex', 'Jobs', [
            new XmlConvertibleObject('a'),
            new XmlConvertibleObject('b'),
        ]);
        $second = new Person('Alex', 'Jobs', [
            new XmlConvertibleObject('b'),
        ]);

        $diff = $first->xmlDiff($second);
        $this->assertInstanceOf(get_class($first), $diff);
        $this->assertNotNull($diff->xmlChildren);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $this->assertEquals(1, count($diff->xmlChildren ?? []));
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $this->assertEquals('a', $diff->xmlChildren[0]->getXmlElementName());
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }

    public function testDifferenceWithNoProperty()
    {
        $a = new XmlConvertibleObject('undefined');
        $b = new XmlConvertibleObject('undefined');
        $a->{'property'} = mt_rand();
        $diff = $a->xmlDiff($b);
        $this->assertInstanceOf(get_class($a), $diff);
    }

    public function testDifference()
    {
        $xml = $this->generateFirst();
        $compared = $this->generateSecond();

        $result = $xml->xmlDiff($compared);

        $this->assertInstanceOf(Person::class, $result);

        $this->assertNotNull($result->xmlChildren);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $this->assertCount(1, $result->xmlChildren);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        $this->assertInstanceOf(Head::class, $result->xmlChildren[0]);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $this->assertNotNull($result->xmlChildren[0]->xmlChildren);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $this->assertCount(1, $result->xmlChildren[0]->xmlChildren);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        $this->assertInstanceOf(
            XmlConvertibleObject::class,
            $result->xmlChildren[0]->xmlChildren[0]
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        );
        $this->assertNull($result->xmlChildren[0]->xmlChildren[0]->xmlChildren);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }

    protected function generateFirst()
    {
        return new Person("Alex", "Letni", [
            new Head("small", 'cool', [
                new XmlConvertibleObject('Eye'),
                new XmlConvertibleObject('Eye', [
                    new Person('Adam', 'Morgan'),
                ]),
            ])
        ]);
    }

    protected function generateSecond()
    {
        return new Person("Alex", "Letni", [
            new Head('small', 'cool', [
                new XmlConvertibleObject('Eye', [
                    new Person('Adam', 'Morgan'),
                ]),
            ])
        ]);
    }
}

Push — master ( 87312f...78171c )

DiffTest::generateSecond() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2			/**
3			* Created by PhpStorm.
4			* User: horat1us
5			* Date: 5/4/17
6			* Time: 12:10 PM
7			*/
8
9			namespace Horat1us\Tests;
10
11
12			use Horat1us\Examples\Head;
13			use Horat1us\Examples\Person;
14			use Horat1us\XmlConvertibleObject;
15			use SebastianBergmann\PHPLOC\Log\XML;
16
17			class DiffTest extends \PHPUnit_Framework_TestCase
18			{
19			public function testDifferenceWithEmpty()
20			{
21			$first = new Person('Alex', 'Jobs');
22			$second = new Person('Alex', 'Jobs', [
23			new XmlConvertibleObject()
24			]);
25			$diff = $first->xmlDiff($second);
26			$this->assertInstanceOf(get_class($first), $diff);
27			}
28
29			public function testDifferenceWithAdditional()
30			{
31			$first = new Person('Alex', 'Jobs', [
32			new XmlConvertibleObject('a'),
33			new XmlConvertibleObject('b'),
34			]);
35			$second = new Person('Alex', 'Jobs', [
36			new XmlConvertibleObject('b'),
37			]);
38
39			$diff = $first->xmlDiff($second);
40			$this->assertInstanceOf(get_class($first), $diff);
41			$this->assertNotNull($diff->xmlChildren);
			0 ignored issues – show Bug introduced 2017-05-11 15:47 UTC by Report Bug Copy Issue Report Accessing `xmlChildren` on the interface `Horat1us\XmlConvertibleInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
42			$this->assertEquals(1, count($diff->xmlChildren ?? []));
			0 ignored issues – show Bug introduced 2017-05-11 15:47 UTC by Report Bug Copy Issue Report Accessing `xmlChildren` on the interface `Horat1us\XmlConvertibleInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
43			$this->assertEquals('a', $diff->xmlChildren[0]->getXmlElementName());
			0 ignored issues – show Bug introduced 2017-05-11 15:47 UTC by Report Bug Copy Issue Report Accessing `xmlChildren` on the interface `Horat1us\XmlConvertibleInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
44			}
45
46			public function testDifferenceWithNoProperty()
47			{
48			$a = new XmlConvertibleObject('undefined');
49			$b = new XmlConvertibleObject('undefined');
50			$a->{'property'} = mt_rand();
51			$diff = $a->xmlDiff($b);
52			$this->assertInstanceOf(get_class($a), $diff);
53			}
54
55			public function testDifference()
56			{
57			$xml = $this->generateFirst();
58			$compared = $this->generateSecond();
59
60			$result = $xml->xmlDiff($compared);
61
62			$this->assertInstanceOf(Person::class, $result);
63
64			$this->assertNotNull($result->xmlChildren);
			0 ignored issues – show Bug introduced 2017-05-11 15:47 UTC by Report Bug Copy Issue Report Accessing `xmlChildren` on the interface `Horat1us\XmlConvertibleInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
65			$this->assertCount(1, $result->xmlChildren);
			0 ignored issues – show Bug introduced 2017-05-11 15:47 UTC by Report Bug Copy Issue Report Accessing `xmlChildren` on the interface `Horat1us\XmlConvertibleInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
66
67			$this->assertInstanceOf(Head::class, $result->xmlChildren[0]);
			0 ignored issues – show Bug introduced 2017-05-11 15:47 UTC by Report Bug Copy Issue Report Accessing `xmlChildren` on the interface `Horat1us\XmlConvertibleInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
68			$this->assertNotNull($result->xmlChildren[0]->xmlChildren);
			0 ignored issues – show Bug introduced 2017-05-11 15:47 UTC by Report Bug Copy Issue Report Accessing `xmlChildren` on the interface `Horat1us\XmlConvertibleInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
69			$this->assertCount(1, $result->xmlChildren[0]->xmlChildren);
			0 ignored issues – show Bug introduced 2017-05-11 15:47 UTC by Report Bug Copy Issue Report Accessing `xmlChildren` on the interface `Horat1us\XmlConvertibleInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
70
71			$this->assertInstanceOf(
72			XmlConvertibleObject::class,
73			$result->xmlChildren[0]->xmlChildren[0]
			0 ignored issues – show Bug introduced 2017-05-11 15:47 UTC by Report Bug Copy Issue Report Accessing `xmlChildren` on the interface `Horat1us\XmlConvertibleInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
74			);
75			$this->assertNull($result->xmlChildren[0]->xmlChildren[0]->xmlChildren);
			0 ignored issues – show Bug introduced 2017-05-11 15:47 UTC by Report Bug Copy Issue Report Accessing `xmlChildren` on the interface `Horat1us\XmlConvertibleInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
76			}
77
78			protected function generateFirst()
79			{
80			return new Person("Alex", "Letni", [
81			new Head("small", 'cool', [
82			new XmlConvertibleObject('Eye'),
83			new XmlConvertibleObject('Eye', [
84			new Person('Adam', 'Morgan'),
85			]),
86			])
87			]);
88			}
89
90			protected function generateSecond()
91			{
92			return new Person("Alex", "Letni", [
93			new Head('small', 'cool', [
94			new XmlConvertibleObject('Eye', [
95			new Person('Adam', 'Morgan'),
96			]),
97			])
98			]);
99			}
100			}

Horat1us / php-xml-convertible

Push — master ( 87312f...78171c )

DiffTest::generateSecond() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like