Horat1us\Tests\DiffTest

Complexity

Total Complexity

6

Size/Duplication

Total Lines	84
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	testDifferenceWithEmpty()	0	9	1
A	testDifferenceWithAdditional()	0	16	1
A	testDifferenceWithNoProperty()	0	8	1
A	testDifference()	0	22	1
A	generateFirst()	0	11	1
A	generateSecond()	0	10	1

<?php
/**
 * Created by PhpStorm.
 * User: horat1us
 * Date: 5/4/17
 * Time: 12:10 PM
 */

namespace Horat1us\Tests;


use Horat1us\Examples\Head;
use Horat1us\Examples\Person;
use Horat1us\XmlConvertibleObject;
use SebastianBergmann\PHPLOC\Log\XML;

class DiffTest extends \PHPUnit_Framework_TestCase
{
    public function testDifferenceWithEmpty()
    {
        $first = new Person('Alex', 'Jobs');
        $second = new Person('Alex', 'Jobs', [
            new XmlConvertibleObject()
        ]);
        $diff = $first->xmlDiff($second);
        $this->assertInstanceOf(get_class($first), $diff);
    }

    public function testDifferenceWithAdditional()
    {
        $first = new Person('Alex', 'Jobs', [
            new XmlConvertibleObject('a'),
            new XmlConvertibleObject('b'),
        ]);
        $second = new Person('Alex', 'Jobs', [
            new XmlConvertibleObject('b'),
        ]);

        $diff = $first->xmlDiff($second);
        $this->assertInstanceOf(get_class($first), $diff);
        $this->assertNotNull($diff->xmlChildren);

Accessing xmlChildren on the interface Horat1us\XmlConvertibleInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->assertEquals(1, count($diff->xmlChildren ?? []));

Accessing xmlChildren on the interface Horat1us\XmlConvertibleInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->assertEquals('a', $diff->xmlChildren[0]->getXmlElementName());

Accessing xmlChildren on the interface Horat1us\XmlConvertibleInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

    }

    public function testDifferenceWithNoProperty()
    {
        $a = new XmlConvertibleObject('undefined');
        $b = new XmlConvertibleObject('undefined');
        $a->{'property'} = mt_rand();
        $diff = $a->xmlDiff($b);
        $this->assertInstanceOf(get_class($a), $diff);
    }

    public function testDifference()
    {
        $xml = $this->generateFirst();
        $compared = $this->generateSecond();

        $result = $xml->xmlDiff($compared);

        $this->assertInstanceOf(Person::class, $result);

        $this->assertNotNull($result->xmlChildren);

Accessing xmlChildren on the interface Horat1us\XmlConvertibleInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->assertCount(1, $result->xmlChildren);

Accessing xmlChildren on the interface Horat1us\XmlConvertibleInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->assertInstanceOf(Head::class, $result->xmlChildren[0]);

Accessing xmlChildren on the interface Horat1us\XmlConvertibleInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->assertNotNull($result->xmlChildren[0]->xmlChildren);

Accessing xmlChildren on the interface Horat1us\XmlConvertibleInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->assertCount(1, $result->xmlChildren[0]->xmlChildren);

Accessing xmlChildren on the interface Horat1us\XmlConvertibleInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->assertInstanceOf(
            XmlConvertibleObject::class,
            $result->xmlChildren[0]->xmlChildren[0]

Accessing xmlChildren on the interface Horat1us\XmlConvertibleInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        );
        $this->assertNull($result->xmlChildren[0]->xmlChildren[0]->xmlChildren);

Accessing xmlChildren on the interface Horat1us\XmlConvertibleInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

    }

    protected function generateFirst()
    {
        return new Person("Alex", "Letni", [
            new Head("small", 'cool', [
                new XmlConvertibleObject('Eye'),
                new XmlConvertibleObject('Eye', [
                    new Person('Adam', 'Morgan'),
                ]),
            ])
        ]);
    }

    protected function generateSecond()
    {
        return new Person("Alex", "Letni", [
            new Head('small', 'cool', [
                new XmlConvertibleObject('Eye', [
                    new Person('Adam', 'Morgan'),
                ]),
            ])
        ]);
    }
}