Heroyt / tournament-generator

src/classes/class_round.php

Spacing +12 added lines, -12 removed lines

@@ -23,7 +23,7 @@ 
 		return $this->name;
 	}
 
-	public function addGroup(Group ...$groups){
+	public function addGroup(Group ...$groups) {
 		foreach ($groups as $group) {
 			if ($group instanceof Group) $this->groups[] = $group;
 			else throw new \Exception('Trying to add group which is not an instance of Group class.');
@@ -35,7 +35,7 @@ 
 		$this->groups[] = $g->setSkip($this->allowSkip);
 		return $g;
 	}
-	public function getGroups(){
+	public function getGroups() {
 		$this->orderGroups();
 		return $this->groups;
 	}
@@ -44,16 +44,16 @@ 
 		return array_map(function($a) { return $a->id; }, $this->groups);
 	}
 	public function orderGroups() {
-		usort($this->groups, function($a, $b){
-			return $a->order - $b->order;
+		usort($this->groups, function($a, $b) {
+			return $a->order-$b->order;
 		});
 	}
 
-	public function allowSkip(){
+	public function allowSkip() {
 		$this->allowSkip = true;
 		return $this;
 	}
-	public function disallowSkip(){
+	public function disallowSkip() {
 		$this->allowSkip = false;
 		return $this;
 	}
@@ -65,7 +65,7 @@ 
 		return $this->allowSkip;
 	}
 
-	public function genGames(){
+	public function genGames() {
 		foreach ($this->groups as $group) {
 			$group->genGames();
 			$this->games = array_merge($this->games, $group->orderGames());
@@ -75,7 +75,7 @@ 
 	public function getGames() {
 		return $this->games;
 	}
-	public function isPlayed(){
+	public function isPlayed() {
 		foreach ($this->groups as $group) {
 			if (!$group->isPlayed()) return false;
 		}
@@ -84,7 +84,7 @@ 
 
 	public function addTeam(...$teams) {
 		foreach ($teams as $team) {
-			if ($team instanceof Team)  {
+			if ($team instanceof Team) {
 				$this->teams[] = $team;
 			}
 			elseif (gettype($team) === 'array') {
@@ -133,13 +133,13 @@ 
 					if ($a->sumPoints($groupsIds) === $b->sumPoints($groupsIds)) return ($a->sumScore($groupsIds) > $b->sumScore($groupsIds) ? -1 : 1);
 					return ($a->sumPoints($groupsIds) > $b->sumPoints($groupsIds) ? -1 : 1);
 				});
-				break;}
+				break; }
 			case SCORE:{
 				uasort($this->teams, function($a, $b) use ($groupsIds) {
 					if ($a->sumScore($groupsIds) === $b->sumScore($groupsIds)) return 0;
 					return ($a->sumScore($groupsIds) > $b->sumScore($groupsIds) ? -1 : 1);
 				});
-				break;}
+				break; }
 		}
 		return $this->teams;
 	}
@@ -168,7 +168,7 @@ 
 		return $this;
 	}
 
-	public function progress(bool $blank = false){
+	public function progress(bool $blank = false) {
 		foreach ($this->groups as $group) {
 			$group->progress($blank);
 		}

src/classes/tournament_presets/class_2R2G.php

Spacing +1 added lines, -1 removed lines

@@ -50,7 +50,7 @@
 
 		$this->splitTeams($round1);
 
-		if (count($this->getTeams()) % 4 == 2) {
+		if (count($this->getTeams())%4 == 2) {
 			$group_top = $round2->group([
 				'name' => 'TOP',
 				'type' => \TournamentGenerator\TWO_TWO

src/classes/class_generator.php

Spacing +11 added lines, -11 removed lines

@@ -19,11 +19,11 @@ 
 		$this->group = $group;
 	}
 
-	public function allowSkip(){
+	public function allowSkip() {
 		$this->allowSkip = true;
 		return $this;
 	}
-	public function disallowSkip(){
+	public function disallowSkip() {
 		$this->allowSkip = false;
 		return $this;
 	}
@@ -46,7 +46,7 @@ 
 	}
 
 	public function setInGame(int $inGame) {
-		if ($inGame < 2 ||  $inGame > 4) throw new \Exception('Expected 2,3 or 4 as inGame '.$inGame.' given');
+		if ($inGame < 2 || $inGame > 4) throw new \Exception('Expected 2,3 or 4 as inGame '.$inGame.' given');
 		$this->inGame = $inGame;
 		return $this;
 	}
@@ -67,17 +67,17 @@ 
 		switch ($this->type) {
 			case \TournamentGenerator\R_R:{
 					$this->group->addGame($this->r_rGames());
-				break;}
+				break; }
 			case \TournamentGenerator\TWO_TWO:
 				$teams = $this->group->getTeams();
 				$discard = [];
 				shuffle($teams);
 				$count = count($teams);
-				while (count($teams) % $this->inGame !== 0) { $discard[] = array_shift($teams); }
+				while (count($teams)%$this->inGame !== 0) { $discard[] = array_shift($teams); }
 
 				while (count($teams) > 0) {
 					$tInGame = [];
-					for ($i=0; $i < $this->inGame; $i++) { $tInGame[] = array_shift($teams); }
+					for ($i = 0; $i < $this->inGame; $i++) { $tInGame[] = array_shift($teams); }
 					$this->group->game($tInGame);
 				}
 
@@ -123,7 +123,7 @@ 
 					}
 					$games = array_merge($games, $gamesTemp);
 				}
-				break;}
+				break; }
 			case 4:{
 				$teamsB = $teams;
 				$lockedTeam1 = array_shift($teamsB);
@@ -140,7 +140,7 @@ 
 					$lockedTeam1 = array_shift($teamsB);
 				}
 				$games[] = new \TournamentGenerator\Game(array_merge([$lockedTeam1], $teamsB), $this->group);
-				break;}
+				break; }
 		}
 		return $games;
 	}
@@ -155,11 +155,11 @@ 
 	public static function circle_genGames2(array $teams = [], Group $group) {
 		$bracket = []; // ARRAY OF GAMES
 
-		if (count($teams) % 2 != 0) $teams[] = \TournamentGenerator\DUMMY_TEAM; // IF NOT EVEN NUMBER OF TEAMS, ADD DUMMY
+		if (count($teams)%2 != 0) $teams[] = \TournamentGenerator\DUMMY_TEAM; // IF NOT EVEN NUMBER OF TEAMS, ADD DUMMY
 
 		shuffle($teams); // SHUFFLE TEAMS FOR MORE RANDOMNESS
 
-		for ($i=0; $i < count($teams)-1; $i++) {
+		for ($i = 0; $i < count($teams)-1; $i++) {
 			$bracket = array_merge($bracket, Generator::circle_saveBracket($teams, $group)); // SAVE CURRENT ROUND
 
 			$teams = Generator::circle_rotateBracket($teams); // ROTATE TEAMS IN BRACKET
@@ -173,7 +173,7 @@ 
 
 		$bracket = [];
 
-		for ($i=0; $i < count($teams)/2; $i++) { // GO THROUGH HALF OF THE TEAMS
+		for ($i = 0; $i < count($teams)/2; $i++) { // GO THROUGH HALF OF THE TEAMS
 
 			$home = $teams[$i];
 			$reverse = array_reverse($teams);

Braces +30 added lines, -10 removed lines

@@ -37,8 +37,11 @@ 
 
 
 	public function setType(/** @scrutinizer ignore-all */ string $type = \TournamentGenerator\R_R) {
-		if (in_array($type, \TournamentGenerator\groupTypes)) $this->type = $type;
-		else throw new \Exception('Unknown group type: '.$type);
+		if (in_array($type, \TournamentGenerator\groupTypes)) {
+			$this->type = $type;
+		} else {
+			throw new \Exception('Unknown group type: '.$type);
+		}
 		return $this;
 	}
 	public function getType() {
@@ -46,7 +49,9 @@ 
 	}
 
 	public function setInGame(int $inGame) {
-		if ($inGame < 2 ||  $inGame > 4) throw new \Exception('Expected 2,3 or 4 as inGame '.$inGame.' given');
+		if ($inGame < 2 ||  $inGame > 4) {
+			throw new \Exception('Expected 2,3 or 4 as inGame '.$inGame.' given');
+		}
 		$this->inGame = $inGame;
 		return $this;
 	}
@@ -55,7 +60,9 @@ 
 	}
 
 	public function setMaxSize(int $maxSize) {
-		if ($maxSize < 2) throw new \Exception('Max group size has to be at least 2, '.$maxSize.' given');
+		if ($maxSize < 2) {
+			throw new \Exception('Max group size has to be at least 2, '.$maxSize.' given');
+		}
 		$this->maxSize = $maxSize;
 		return $this;
 	}
@@ -81,7 +88,9 @@ 
 					$this->group->game($tInGame);
 				}
 
-				if (count($discard) > 0 && !$this->allowSkip) throw new \Exception('Couldn\'t make games with all teams. Expected k*'.$this->inGame.' teams '.$count.' teams given - discarting '.count($discard).' teams ('.implode(', ', $discard).') in group '.$this->group.' - allow skip '.($this->allowSkip ? 'True' : 'False'));
+				if (count($discard) > 0 && !$this->allowSkip) {
+					throw new \Exception('Couldn\'t make games with all teams. Expected k*'.$this->inGame.' teams '.$count.' teams given - discarting '.count($discard).' teams ('.implode(', ', $discard).') in group '.$this->group.' - allow skip '.($this->allowSkip ? 'True' : 'False'));
+				}
 				break;
 			case \TournamentGenerator\COND_SPLIT:
 				$games = [];
@@ -96,19 +105,24 @@ 
 					while ($g > 0) {
 						foreach ($games as $key => $group) {
 							$this->group->addGame(array_shift($games[$key]));
-							if (count($games[$key]) === 0) unset($games[$key]);
+							if (count($games[$key]) === 0) {
+								unset($games[$key]);
+							}
 							$g--;
 						}
 					}
+				} else {
+					$this->group->addGame($this->r_rGames());
 				}
-				else $this->group->addGame($this->r_rGames());
 				break;
 		}
 		return $this->group->getGames();
 	}
 	public function r_rGames(array $teams = []) {
 		$games = [];
-		if (count($teams) === 0) $teams = $this->group->getTeams();
+		if (count($teams) === 0) {
+			$teams = $this->group->getTeams();
+		}
 		switch ($this->inGame) {
 			case 2:
 				$games = Generator::circle_genGames2($teams, $this->group);
@@ -155,7 +169,10 @@ 
 	public static function circle_genGames2(array $teams = [], Group $group) {
 		$bracket = []; // ARRAY OF GAMES
 
-		if (count($teams) % 2 != 0) $teams[] = \TournamentGenerator\DUMMY_TEAM; // IF NOT EVEN NUMBER OF TEAMS, ADD DUMMY
+		if (count($teams) % 2 != 0) {
+			$teams[] = \TournamentGenerator\DUMMY_TEAM;
+		}
+		// IF NOT EVEN NUMBER OF TEAMS, ADD DUMMY
 
 		shuffle($teams); // SHUFFLE TEAMS FOR MORE RANDOMNESS
 
@@ -179,7 +196,10 @@ 
 			$reverse = array_reverse($teams);
 			$away = $reverse[$i];
 
-			if (($home == \TournamentGenerator\DUMMY_TEAM || $away == \TournamentGenerator\DUMMY_TEAM)) continue; // SKIP WHEN DUMMY_TEAM IS PRESENT
+			if (($home == \TournamentGenerator\DUMMY_TEAM || $away == \TournamentGenerator\DUMMY_TEAM)) {
+				continue;
+			}
+			// SKIP WHEN DUMMY_TEAM IS PRESENT
 
 			$bracket[] = new \TournamentGenerator\Game([$home, $away], $group);
 

src/classes/class_sorter_games.php

Spacing +10 added lines, -10 removed lines

@@ -69,7 +69,7 @@ 
 
 			// CYCLE 6
 			// FIRST AVAILABLE GAME
-			$this->moveCalculatedGames(array_shift($games),$teams);
+			$this->moveCalculatedGames(array_shift($games), $teams);
 		}
 
 		return $this->games;
@@ -79,8 +79,8 @@ 
 	private function cycle1(array &$games, array &$teams) {
 		$found = false;
 		foreach ($games as $key => $game) {
-			if ($this->orderCheckTeamsVal($game, $teams, [4,5,6,7])) {
-				$this->moveCalculatedGames($game,$teams);
+			if ($this->orderCheckTeamsVal($game, $teams, [4, 5, 6, 7])) {
+				$this->moveCalculatedGames($game, $teams);
 				unset($games[$key]);
 				$found = true;
 				break;
@@ -92,8 +92,8 @@ 
 	private function cycle2(array &$games, array &$teams) {
 		$found = false;
 		foreach ($games as $key => $game) {
-			if ($this->orderCheckTeamsVal($game, $teams, [6,7])) {
-				$this->moveCalculatedGames($game,$teams);
+			if ($this->orderCheckTeamsVal($game, $teams, [6, 7])) {
+				$this->moveCalculatedGames($game, $teams);
 				unset($games[$key]);
 				$found = true;
 				break;
@@ -106,8 +106,8 @@ 
 	private function cycle3(array &$games, array &$teams) {
 		$found = false;
 		foreach ($games as $key => $game) {
-			if ($this->orderCheckTeamsVal($game, $teams, [7], [1,2,3])) {
-				$this->moveCalculatedGames($game,$teams);
+			if ($this->orderCheckTeamsVal($game, $teams, [7], [1, 2, 3])) {
+				$this->moveCalculatedGames($game, $teams);
 				unset($games[$key]);
 				$found = true;
 				break;
@@ -120,7 +120,7 @@ 
 		$found = false;
 		foreach ($games as $key => $game) {
 			if ($this->orderCheckTeamsVal($game, $teams, [7])) {
-				$this->moveCalculatedGames($game,$teams);
+				$this->moveCalculatedGames($game, $teams);
 				unset($games[$key]);
 				$found = true;
 				break;
@@ -132,8 +132,8 @@ 
 	private function cycle5(array &$games, array &$teams) {
 		$found = false;
 		foreach ($games as $key => $game) {
-			if ($this->orderCheckTeamsVal($game, $teams, [], [1,2,3])) {
-				$this->moveCalculatedGames($game,$teams);
+			if ($this->orderCheckTeamsVal($game, $teams, [], [1, 2, 3])) {
+				$this->moveCalculatedGames($game, $teams);
 				unset($games[$key]);
 				$found = true;
 				break;

Braces +27 added lines, -9 removed lines

@@ -36,7 +36,9 @@ 
 
 		$games = $this->group->getGames();
 
-		if (count($games) <= 4) return $games;
+		if (count($games) <= 4) {
+			return $games;
+		}
 
 		$this->games = [];
 
@@ -48,24 +50,34 @@ 
 		while (count($games) > 0) {
 			// CYCLE 1
 			// TEAM WHICH DIDN'T PLAY IN LAST GAME (< 4)
-			if ($this->cycle1($games, $teams)) continue;
+			if ($this->cycle1($games, $teams)) {
+				continue;
+			}
 
 			// CYCLE 2
 			// NOT TEAM WHICH PLAYED IN LAST TWO GAMES (NOT 6 or 7)
-			if ($this->cycle2($games, $teams)) continue;
+			if ($this->cycle2($games, $teams)) {
+				continue;
+			}
 
 			// CYCLE 3
 			// NOT TEAM WHICH PLAYED IN LAST THREE GAMES (NOT 7)
 			// TEAMS THAT DIDN'T PLAY IN LAST GAME WILL PLAY THIS GAME (< 4)
-			if ($this->cycle3($games, $teams)) continue;
+			if ($this->cycle3($games, $teams)) {
+				continue;
+			}
 
 			// CYCLE 4
 			// NOT TEAM WHICH PLAYED IN LAST THREE GAMES (NOT 7)
-			if ($this->cycle4($games, $teams)) continue;
+			if ($this->cycle4($games, $teams)) {
+				continue;
+			}
 
 			// CYCLE 5
 			// TEAMS THAT DIDN'T PLAY IN LAST GAME WILL PLAY THIS GAME (< 4)
-			if ($this->cycle5($games, $teams)) continue;
+			if ($this->cycle5($games, $teams)) {
+				continue;
+			}
 
 			// CYCLE 6
 			// FIRST AVAILABLE GAME
@@ -174,11 +186,17 @@ 
 		$requiredTeams = array_filter($teams, function($a) use ($required) { return in_array($a, $required); });
 
 		foreach ($game->getTeamsIds() as $tid) {
-			if (in_array($teams[$tid], $checkVals)) return false;
-			if (isset($requiredTeams[$tid])) unset($requiredTeams[$tid]);
+			if (in_array($teams[$tid], $checkVals)) {
+				return false;
+			}
+			if (isset($requiredTeams[$tid])) {
+				unset($requiredTeams[$tid]);
+			}
 		}
 
-		if (count($requiredTeams) > 0) return false;
+		if (count($requiredTeams) > 0) {
+			return false;
+		}
 
 		return true;