DynamicObject::get() - Code Metrics - Inspection of "revert test" - HalalSoft/laravel-dynamic-column - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( 8348d9...257cec )

by Muhammad Dyas

created 2021-02-21 08:26 UTC

DynamicObject::get() A

↳ Parent: DynamicObject

Complexity

Conditions	4
Paths	4

Size

Total Lines	18
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
eloc	10
c	1
b	0
f	0
nc	4
nop	4
dl	0
loc	18
rs	9.9332

<?php

namespace Halalsoft\LaravelDynamicColumn;

use Illuminate\Contracts\Database\Eloquent\CastsAttributes;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Support\Facades\DB;

class DynamicObject implements CastsAttributes
{
    /**
     * Cast the given value.
     *
     * @param  Model  $model
     * @param  string  $key
     * @param  mixed  $value
     * @param  array  $attributes
     *
     * @return array
     */
    public function get($model, $key, $value, $attributes)
    {
        if (gettype($value) == 'object') {
            preg_match('#\((.*?)\)#', (string)$value, $match);

            if (isset($match[1])) {
                $match[1] = str_replace('\'', '', $match[1]);
                $arr      = explode(',', $match[1]);
                $values   = [];
                for ($i = 1; $i < count($arr); $i += 2) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
                    $values[$arr[$i - 1]] = $arr[$i];
                }

                return $values;
            }
        }

        return json_decode($value);
        return json_decode(/** @scrutinizer ignore-type */ $value);
    }

    /**
     * Prepare the given value for storage.
     *
     * @param  Model  $model
     * @param  string  $key
     * @param  array  $value
     * @param  array  $attributes
     *
     * @return string
     */
    public function set($model, $key, $value, $attributes)
    {

        if (is_array($value)) {

            $values = '';
            foreach ($value as $k => $v) {
                $values .= ($values ? ',' : '')."'$k','$v'";
            }

            return DB::raw("column_create($values)");
        }
//        elseif(object)
        else {
            return $value;
        }
    }
}

HalalSoft / laravel-dynamic-column

Push — main ( 8348d9...257cec )

DynamicObject::get() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like