Halalsoft\LaravelDynamicColumn\DynamicObject

Complexity

Total Complexity

8

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	get()	0	18	4
A	set()	0	14	4

<?php

namespace Halalsoft\LaravelDynamicColumn;

use Illuminate\Contracts\Database\Eloquent\CastsAttributes;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Support\Facades\DB;

class DynamicObject implements CastsAttributes
{
    /**
     * Cast the given value.
     *
     * @param  Model  $model
     * @param  string  $key
     * @param  mixed  $value
     * @param  array  $attributes
     *
     * @return array
     */
    public function get($model, $key, $value, $attributes)
    {
        if (gettype($value) == 'object') {
            preg_match('#\((.*?)\)#', (string)$value, $match);

            if (isset($match[1])) {
                $match[1] = str_replace('\'', '', $match[1]);
                $arr      = explode(',', $match[1]);
                $values   = [];
                for ($i = 1; $i < count($arr); $i += 2) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

                    $values[$arr[$i - 1]] = $arr[$i];
                }

                return $values;
            }
        }

        return json_decode($value);

It seems like $value can also be of type object; however, parameter $json of json_decode() does only seem to accept string, maybe add an additional type check?

    }

    /**
     * Prepare the given value for storage.
     *
     * @param  Model  $model
     * @param  string  $key
     * @param  array  $value
     * @param  array  $attributes
     *
     * @return string
     */
    public function set($model, $key, $value, $attributes)
    {

        if (is_array($value)) {

The condition is_array($value) is always true.

            $values = '';
            foreach ($value as $k => $v) {
                $values .= ($values ? ',' : '')."'$k','$v'";
            }

            return DB::raw("column_create($values)");
        }
//        elseif(object)
        else {
            return $value;
        }
    }
}