HaaseIT / HCSF

src/Controller/Admin/Shop/Itemadmin.php

Unused Use Statements -1 removed lines

@@ -21,7 +21,6 @@
 namespace HaaseIT\HCSF\Controller\Admin\Shop;
 
 
-use HaaseIT\HCSF\HelperConfig;
 use HaaseIT\Toolbox\Tools;
 use Zend\ServiceManager\ServiceManager;
 

src/Customer/Helper.php

Doc Comments +1 added lines, -1 removed lines

@@ -158,7 +158,7 @@
     /**
      * @param string $sKeyConfig
      * @param string $sKeyForm
-     * @param array|bool $aUserData
+     * @param boolean $aUserData
      * @return bool
      */
     public function getCustomerFormDefaultValue($sKeyConfig, $sKeyForm, $aUserData) {

Spacing +1 added lines, -1 removed lines

@@ -118,7 +118,7 @@
             $aErr['fax'] = true;
         }
         $postcountry = filter_input(INPUT_POST, 'country', FILTER_SANITIZE_STRING, FILTER_FLAG_STRIP_LOW);
-        if ($this->customer['validate_country'] && (empty($postcountry) || !isset($this->countries['countries_' .$sLang][$postcountry]))) {
+        if ($this->customer['validate_country'] && (empty($postcountry) || !isset($this->countries['countries_'.$sLang][$postcountry]))) {
             $aErr['country'] = true;
         }
         $posttos = filter_input(INPUT_POST, 'tos');

src/HCSF.php

Spacing +13 added lines, -13 removed lines

@@ -65,25 +65,25 @@ 
             $this->setupRequest();
         }
 
-        $this->serviceManager->setFactory('config', function () {
+        $this->serviceManager->setFactory('config', function() {
             return new HelperConfig();
         });
         $this->config = $this->serviceManager->get('config');
 
-        $this->serviceManager->setFactory('helper', function (ServiceManager $serviceManager) {
+        $this->serviceManager->setFactory('helper', function(ServiceManager $serviceManager) {
             return new \HaaseIT\HCSF\Helper($serviceManager);
         });
         $this->helper = $this->serviceManager->get('helper');
 
         if ($this->config->getCore('enable_module_customer')) {
-            $this->serviceManager->setFactory('helpercustomer', function (ServiceManager $serviceManager) {
+            $this->serviceManager->setFactory('helpercustomer', function(ServiceManager $serviceManager) {
                 return new \HaaseIT\HCSF\Customer\Helper($serviceManager);
             });
             $this->helperCustomer = $this->serviceManager->get('helpercustomer');
         }
 
         if ($this->config->getCore('enable_module_shop')) {
-            $this->serviceManager->setFactory('helpershop', function (ServiceManager $serviceManager) {
+            $this->serviceManager->setFactory('helpershop', function(ServiceManager $serviceManager) {
                 return new \HaaseIT\HCSF\Shop\Helper($serviceManager);
             });
             $this->helperShop = $this->serviceManager->get('helpershop');
@@ -100,11 +100,11 @@ 
 
         date_default_timezone_set($this->config->getCore('defaulttimezone'));
 
-        $this->serviceManager->setFactory('hardcodedtextcats', function () {
+        $this->serviceManager->setFactory('hardcodedtextcats', function() {
             return $this->setupHardcodedTextcats();
         });
 
-        $this->serviceManager->setFactory('db', function () {
+        $this->serviceManager->setFactory('db', function() {
             return null;
         });
 
@@ -119,7 +119,7 @@ 
         }
 
         if ($this->config->getCore('enable_module_shop')) {
-            $this->serviceManager->setFactory('oItem', function (ServiceManager $serviceManager) {
+            $this->serviceManager->setFactory('oItem', function(ServiceManager $serviceManager) {
                 return new \HaaseIT\HCSF\Shop\Items($serviceManager);
             });
         }
@@ -136,7 +136,7 @@ 
     {
         // PSR-7 Stuff
         // Init request object
-        $this->serviceManager->setFactory('request', function () {
+        $this->serviceManager->setFactory('request', function() {
             $request = \Zend\Diactoros\ServerRequestFactory::fromGlobals();
 
             // cleanup request
@@ -200,7 +200,7 @@ 
 
     protected function setupDB()
     {
-        $this->serviceManager->setFactory('dbal', function () {
+        $this->serviceManager->setFactory('dbal', function() {
             $config = new \Doctrine\DBAL\Configuration();
 
             $connectionParams = [
@@ -221,14 +221,14 @@ 
             return \Doctrine\DBAL\DriverManager::getConnection($connectionParams, $config);
         });
 
-        $this->serviceManager->setFactory('db', function (ServiceManager $serviceManager) {
+        $this->serviceManager->setFactory('db', function(ServiceManager $serviceManager) {
             return $serviceManager->get('dbal')->getWrappedConnection();
         });
     }
 
     protected function setupTextcats()
     {
-        $this->serviceManager->setFactory('textcats', function (ServiceManager $serviceManager) {
+        $this->serviceManager->setFactory('textcats', function(ServiceManager $serviceManager) {
             $langavailable = $this->config->getCore('lang_available');
             $textcats = new \HaaseIT\Toolbox\Textcat(
                 $this->config->getLang(),
@@ -245,7 +245,7 @@ 
 
     protected function setupTwig()
     {
-        $this->serviceManager->setFactory('twig', function (ServiceManager $serviceManager) {
+        $this->serviceManager->setFactory('twig', function(ServiceManager $serviceManager) {
             $loader = new \Twig_Loader_Filesystem([PATH_BASEDIR.'customviews', HCSF_BASEDIR.'src/views/']);
 
             $twig_options = [
@@ -368,7 +368,7 @@ 
         }
 
         $aP['countrylist'][] = ' | ';
-        $configcountries = $this->config->getCountries('countries_' .$this->config->getLang());
+        $configcountries = $this->config->getCountries('countries_'.$this->config->getLang());
         foreach ($configcountries as $sKey => $sValue) {
             $aP['countrylist'][] = $sKey.'|'.$sValue;
         }

src/Controller/Shop/Paypalnotify.php

Spacing +19 added lines, -19 removed lines

@@ -74,7 +74,7 @@ 
             $postdata = '';
 
             foreach ($_POST as $i => $v) {
-                $postdata .= $i . '=' . urlencode($v) . '&';
+                $postdata .= $i.'='.urlencode($v).'&';
             }
             $postdata .= 'cmd=_notify-validate';
             $web = parse_url($this->config->getShop('paypal')['url']);
@@ -86,15 +86,15 @@ 
                 $web['port'] = 80;
                 $ssl = '';
             }
-            $fp = @fsockopen($ssl . $web['host'], $web['port'], $errnum, $errstr, 30);
+            $fp = @fsockopen($ssl.$web['host'], $web['port'], $errnum, $errstr, 30);
 
             if ($fp) {
-                fwrite($fp, 'POST ' . $web['path'] . " HTTP/1.1\r\n");
-                fwrite($fp, 'Host: ' . $web['host'] . "\r\n");
+                fwrite($fp, 'POST '.$web['path']." HTTP/1.1\r\n");
+                fwrite($fp, 'Host: '.$web['host']."\r\n");
                 fwrite($fp, "Content-type: application/x-www-form-urlencoded\r\n");
-                fwrite($fp, 'Content-length: ' . strlen($postdata) . "\r\n");
+                fwrite($fp, 'Content-length: '.strlen($postdata)."\r\n");
                 fwrite($fp, "Connection: close\r\n\r\n");
-                fwrite($fp, $postdata . "\r\n\r\n");
+                fwrite($fp, $postdata."\r\n\r\n");
 
                 $info = [];
                 while (!feof($fp)) {
@@ -104,9 +104,9 @@ 
                 $info = implode(',', $info);
                 if (!(strpos($info, 'VERIFIED') === false)) {
 
-                    $sLogData .= '-- new entry - '.date($this->config->getCore('locale_format_date_time')) . " --\n\n";
+                    $sLogData .= '-- new entry - '.date($this->config->getCore('locale_format_date_time'))." --\n\n";
                     $sLogData .= "W00T!\n\n";
-                    $sLogData .= \HaaseIT\Toolbox\Tools::debug($_REQUEST, '', true, true) . "\n\n";
+                    $sLogData .= \HaaseIT\Toolbox\Tools::debug($_REQUEST, '', true, true)."\n\n";
 
                     // Check if the transaction id has been used before
                     $queryBuilder = $this->dbal->createQueryBuilder();
@@ -135,27 +135,27 @@ 
                                 ->setParameter(1, $iId);
                             $queryBuilder->execute();
 
-                            $sLogData .= '-- Alles ok. Zahlung erfolgreich. TXNID: ' . $_REQUEST['txn_id'] . " --\n\n";
+                            $sLogData .= '-- Alles ok. Zahlung erfolgreich. TXNID: '.$_REQUEST['txn_id']." --\n\n";
                         } else {
                             $sLogData .= "-- In my country we have problem; Problem is evaluation. Throw the data down the log!\n";
-                            $sLogData .= 'mc_gross: ' . $_REQUEST['mc_gross'] . ' - number_format($fGesamtbrutto, 2, \'.\', \'\'): ' . number_format($fGesamtbrutto,
-                                    2, '.', '') . "\n";
-                            $sLogData .= 'custom: ' . $_REQUEST['custom'] . ' - $aOrder[\'o_id\']: ' . $aOrder['o_id'] . "\n";
-                            $sLogData .= 'payment_status: ' . $_REQUEST['payment_status'] . "\n";
-                            $sLogData .= 'mc_currency: ' . $_REQUEST['mc_currency'] . ' - HelperConfig::$shop["paypal"]["currency_id"]: ' . $this->config->getShop('paypal')['currency_id'] . "\n";
-                            $sLogData .= 'business: ' . $_REQUEST['receiver_email'] . ' - HelperConfig::$shop["paypal"]["business"]: ' . $this->config->getShop('paypal')['business'] . "\n\n";
+                            $sLogData .= 'mc_gross: '.$_REQUEST['mc_gross'].' - number_format($fGesamtbrutto, 2, \'.\', \'\'): '.number_format($fGesamtbrutto,
+                                    2, '.', '')."\n";
+                            $sLogData .= 'custom: '.$_REQUEST['custom'].' - $aOrder[\'o_id\']: '.$aOrder['o_id']."\n";
+                            $sLogData .= 'payment_status: '.$_REQUEST['payment_status']."\n";
+                            $sLogData .= 'mc_currency: '.$_REQUEST['mc_currency'].' - HelperConfig::$shop["paypal"]["currency_id"]: '.$this->config->getShop('paypal')['currency_id']."\n";
+                            $sLogData .= 'business: '.$_REQUEST['receiver_email'].' - HelperConfig::$shop["paypal"]["business"]: '.$this->config->getShop('paypal')['business']."\n\n";
                         }
                     } else {
                         // INVALID LOGGING ERROR
-                        $sLogData .= '-- new entry - ' . date($this->config->getCore('locale_format_date_time')) . " --\n\nPHAIL\n\n";
-                        $sLogData .= '!!! JEMAND HAT EINE ALTE TXN_ID BENUTZT: ' . $_REQUEST['txn_id'] . " !!!\n\n";
+                        $sLogData .= '-- new entry - '.date($this->config->getCore('locale_format_date_time'))." --\n\nPHAIL\n\n";
+                        $sLogData .= '!!! JEMAND HAT EINE ALTE TXN_ID BENUTZT: '.$_REQUEST['txn_id']." !!!\n\n";
                         $sLogData .= "!!! INVALID !!!\n\n";
                     }
                 } else {
-                    $sLogData .= '-- new entry - ' . date($this->config->getCore('locale_format_date_time')) . " --\n\nPHAIL - Transaktion fehlgeschlagen. TXNID: " . $_REQUEST['txn_id'] . "\n" . $info . "\n\n";
+                    $sLogData .= '-- new entry - '.date($this->config->getCore('locale_format_date_time'))." --\n\nPHAIL - Transaktion fehlgeschlagen. TXNID: ".$_REQUEST['txn_id']."\n".$info."\n\n";
                 }
 
-                file_put_contents(PATH_LOGS . FILE_PAYPALLOG, $sLogData, FILE_APPEND);
+                file_put_contents(PATH_LOGS.FILE_PAYPALLOG, $sLogData, FILE_APPEND);
             }
         }
 

src/Controller/Shop/Shoppingcart.php

Spacing +2 added lines, -2 removed lines

@@ -396,7 +396,7 @@ 
             'paymentmethod' => $this->getPostValue('paymentmethod'),
             'shippingcost' => empty($_SESSION['shippingcost']) ? false : $_SESSION['shippingcost'],
             'paypallink' => $postpaymentmethod === 'paypal' ? $serverservername.'/_misc/paypal.html?id='.$iId : '',
-            'sofortueberweisunglink' => $postpaymentmethod === 'sofortueberweisung' ?  $serverservername.'/_misc/sofortueberweisung.html?id='.$iId : '',
+            'sofortueberweisunglink' => $postpaymentmethod === 'sofortueberweisung' ? $serverservername.'/_misc/sofortueberweisung.html?id='.$iId : '',
             'SESSION' => !$bCust ? Tools::debug($_SESSION, '$_SESSION', true, true) : '',
             'POST' => !$bCust ? Tools::debug($_POST, '$_POST', true, true) : '',
             'orderid' => $iId,
@@ -437,7 +437,7 @@ 
                 } else {
                     $return .= $getcartkey;
                 }
-                $return.= ' '.$this->textcats->T('shoppingcart_msg_'.$getmsg.'_2');
+                $return .= ' '.$this->textcats->T('shoppingcart_msg_'.$getmsg.'_2');
                 if ($getmsg === 'updated') {
                     $return .= ' '.$getamount;
                 }

src/Controller/Shop/Myorders.php

Spacing +9 added lines, -9 removed lines

@@ -60,7 +60,7 @@ 
             if (filter_input(INPUT_GET, 'id') !== null && filter_input(INPUT_GET, 'action') === 'show') {
                 $iId = \filter_input(INPUT_GET, 'id', FILTER_SANITIZE_NUMBER_INT);
 
-                $sql = 'SELECT * FROM ' . 'orders WHERE o_id = :id AND o_custno = \'' . $_SESSION['user']['cust_no'] . '\' AND o_ordercompleted != \'d\'';
+                $sql = 'SELECT * FROM '.'orders WHERE o_id = :id AND o_custno = \''.$_SESSION['user']['cust_no'].'\' AND o_ordercompleted != \'d\'';
                 $hResult = $this->db->prepare($sql);
                 $hResult->bindValue(':id', $iId);
                 $hResult->execute();
@@ -73,7 +73,7 @@ 
                         $aOrder['o_ordertimestamp']
                     );
                     $this->P->cb_customdata['orderdata']['orderremarks'] = $aOrder['o_remarks'];
-                    $this->P->cb_customdata['orderdata']['paymentmethod'] = $this->textcats->T('order_paymentmethod_' . $aOrder['o_paymentmethod']);
+                    $this->P->cb_customdata['orderdata']['paymentmethod'] = $this->textcats->T('order_paymentmethod_'.$aOrder['o_paymentmethod']);
                     $this->P->cb_customdata['orderdata']['paymentcompleted'] = (($aOrder['o_paymentcompleted'] === 'y') ? $this->textcats->T('myorders_paymentstatus_completed') : $this->textcats->T('myorders_paymentstatus_open'));
                     $this->P->cb_customdata['orderdata']['orderstatus'] = $this->helperShop->showOrderStatusText($this->textcats, $aOrder['o_ordercompleted']);
                     $this->P->cb_customdata['orderdata']['shippingservice'] = $aOrder['o_shipping_service'];
@@ -115,12 +115,12 @@ 
                 }
             } else {
                 $COList = [
-                    ['title' => $this->textcats->T('order_head_orderdate'), 'key' => 'o_ordertime', 'width' => 110, 'linked' => false,],
-                    ['title' => $this->textcats->T('order_head_paymenthethod'), 'key' => 'o_paymentmethod', 'width' => 125, 'linked' => false,],
-                    ['title' => $this->textcats->T('order_head_paid'), 'key' => 'o_paymentcompleted', 'width' => 60, 'linked' => false,],
-                    ['title' => $this->textcats->T('order_head_status'), 'key' => 'o_order_status', 'width' => 80, 'linked' => false,],
-                    ['title' => $this->textcats->T('order_head_shipping_service'), 'key' => 'o_shipping_service', 'width' => 90, 'linked' => false,],
-                    ['title' => $this->textcats->T('order_head_shipping_trackingno'), 'key' => 'o_shipping_trackingno', 'width' => 130, 'linked' => false,],
+                    ['title' => $this->textcats->T('order_head_orderdate'), 'key' => 'o_ordertime', 'width' => 110, 'linked' => false, ],
+                    ['title' => $this->textcats->T('order_head_paymenthethod'), 'key' => 'o_paymentmethod', 'width' => 125, 'linked' => false, ],
+                    ['title' => $this->textcats->T('order_head_paid'), 'key' => 'o_paymentcompleted', 'width' => 60, 'linked' => false, ],
+                    ['title' => $this->textcats->T('order_head_status'), 'key' => 'o_order_status', 'width' => 80, 'linked' => false, ],
+                    ['title' => $this->textcats->T('order_head_shipping_service'), 'key' => 'o_shipping_service', 'width' => 90, 'linked' => false, ],
+                    ['title' => $this->textcats->T('order_head_shipping_trackingno'), 'key' => 'o_shipping_trackingno', 'width' => 130, 'linked' => false, ],
                     [
                         'title' => $this->textcats->T('order_show'),
                         'key' => 'o_id',
@@ -128,7 +128,7 @@ 
                         'linked' => true,
                         'ltarget' => '/_misc/myorders.html',
                         'lkeyname' => 'id',
-                        'lgetvars' => ['action' => 'show',],
+                        'lgetvars' => ['action' => 'show', ],
                     ],
                 ];
 

src/Shop/Items.php

Indentation +3 added lines, -3 removed lines

@@ -207,9 +207,9 @@
     public function getGroupdata($sGroup)
     {
         $sql = 'SELECT '.DB_ITEMGROUPFIELDS.' FROM itemgroups_base'
-           .' LEFT OUTER JOIN itemgroups_text ON itemgroups_base.itmg_id = itemgroups_text.itmgt_pid'
-           .' AND itmgt_lang = :lang'
-           .' WHERE itmg_id = :group';
+            .' LEFT OUTER JOIN itemgroups_text ON itemgroups_base.itmg_id = itemgroups_text.itmgt_pid'
+            .' AND itmgt_lang = :lang'
+            .' WHERE itmg_id = :group';
 
         $hResult = $this->db->prepare($sql);
         $hResult->bindValue(':lang', $this->config->getLang(), \PDO::PARAM_STR);

Spacing +8 added lines, -8 removed lines

@@ -182,12 +182,12 @@ 
             if (!$bEnableItemGroups || \trim($aRow['itm_group']) == 0) {
                 $aAssembly['item'][$aRow['itm_no']] = $aRow;
             } else {
-                if (isset($aAssembly['groups']['ITEMGROUP-' .$aRow['itm_group']])) {
-                    $aAssembly['groups']['ITEMGROUP-' .$aRow['itm_group']][$aRow['itm_no']] = $aRow;
+                if (isset($aAssembly['groups']['ITEMGROUP-'.$aRow['itm_group']])) {
+                    $aAssembly['groups']['ITEMGROUP-'.$aRow['itm_group']][$aRow['itm_no']] = $aRow;
                 } else {
-                    $aAssembly['item']['ITEMGROUP-' .$aRow['itm_group']]['group'] = 'ITEMGROUP-' .$aRow['itm_group'];
-                    $aAssembly['groups']['ITEMGROUP-' .$aRow['itm_group']]['ITEMGROUP-DATA'] = $this->getGroupdata($aRow['itm_group']);
-                    $aAssembly['groups']['ITEMGROUP-' .$aRow['itm_group']][$aRow['itm_no']] = $aRow;
+                    $aAssembly['item']['ITEMGROUP-'.$aRow['itm_group']]['group'] = 'ITEMGROUP-'.$aRow['itm_group'];
+                    $aAssembly['groups']['ITEMGROUP-'.$aRow['itm_group']]['ITEMGROUP-DATA'] = $this->getGroupdata($aRow['itm_group']);
+                    $aAssembly['groups']['ITEMGROUP-'.$aRow['itm_group']][$aRow['itm_no']] = $aRow;
                 }
             }
         }
@@ -228,7 +228,7 @@ 
             $aData['itm_vatid'] = 'full';
         }
 
-        if(is_numeric($aData['itm_price']) && (float) $aData['itm_price'] > 0) {
+        if (is_numeric($aData['itm_price']) && (float) $aData['itm_price'] > 0) {
             $aPrice['netto_list'] = $aData['itm_price'];
             $aPrice['brutto_list'] = $this->addVat($aPrice['netto_list'], $this->config->getShop('vat')[$aData['itm_vatid']]);
             if (
@@ -250,7 +250,7 @@ 
                         bcdiv(
                             bcsub(
                                 '100',
-                                (string)$this->config->getShop('rebate_groups')[$aData['itm_rg']][$this->helperCustomer->getUserData('cust_group')]
+                                (string) $this->config->getShop('rebate_groups')[$aData['itm_rg']][$this->helperCustomer->getUserData('cust_group')]
                             ),
                             '100'
                         )
@@ -282,7 +282,7 @@ 
                 bcdiv(
                     bcmul(
                         $price,
-                        (string)$vat
+                        (string) $vat
                     ),
                     '100'
                 ),