Base::requireAdminAuth() - Code Metrics - Inspection of "fixed tests for new instanced helpers" - HaaseIT/HCSF - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 60b053...61ce86 )

by Marcus

created 2017-06-29 16:31 UTC

Base::requireAdminAuth() D

↳ Parent: Project

Complexity

Conditions	10
Paths	14

Size

Total Lines	37
Code Lines	26

Duplication

Lines	10
Ratio	27.03 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	10
loc	37
rs	4.8196
cc	10
eloc	26
nc	14
nop	0

How to fix Complexity

<?php

/*
    HCSF - A multilingual CMS and Shopsystem
    Copyright (C) 2014  Marcus Haase - [email protected]

    This program is free software: you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation, either version 3 of the License, or
    (at your option) any later version.

    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.

    You should have received a copy of the GNU General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */

namespace HaaseIT\HCSF\Controller;


use Zend\ServiceManager\ServiceManager;

class Base
{
    /**
     * @var \HaaseIT\HCSF\Page
     */
    protected $P;

    /**
     * @var ServiceManager
     */
    protected $serviceManager;

    /**
     * @var bool
     */
    protected $requireAdminAuth = false;

    /**
     * @var bool
     */
    protected $requireAdminAuthAdminHome = false;

    /**
     * @var bool
     */
    protected $requireModuleCustomer = false;

    /**
     * @var bool
     */
    protected $requireModuleShop = false;

    /**
     * @var \HaaseIT\HCSF\HelperConfig
     */
    protected $config;

    /**
     * @var \HaaseIT\HCSF\Helper
     */
    protected $helper;

    /**
     * Base constructor.
     * @param ServiceManager $serviceManager
     */
    public function __construct(ServiceManager $serviceManager)
    {
        $this->serviceManager = $serviceManager;
        $this->config = $serviceManager->get('config');
        $this->helper = $serviceManager->get('helper');
    }

    /**
     * @return \HaaseIT\HCSF\Page
     * @throws \Exception
     */
    public function getPage()
    {
        if ($this->requireAdminAuth) {
            $this->requireAdminAuth();
        }
        if ($this->requireModuleCustomer && !$this->config->getCore('enable_module_customer')) {
            throw new \Exception(404);
        }
        if ($this->requireModuleShop && !$this->config->getCore('enable_module_shop')) {
            throw new \Exception(404);
        }
        $this->preparePage();
        return $this->P;
    }

    public function preparePage()
    {

    }

    /**
     * @return bool
     */
    private function requireAdminAuth() {
        $adminusers = $this->config->getSecret('admin_users');
        if ($this->requireAdminAuthAdminHome && (empty($adminusers) || !count($adminusers))) {
            return true;
        } elseif (count($adminusers) {

            $user = filter_input(INPUT_SERVER, 'PHP_AUTH_USER');

            $pass = filter_input(INPUT_SERVER, 'PHP_AUTH_PW');
            if (filter_input(INPUT_SERVER, 'REDIRECT_HTTP_AUTHORIZATION') !== null) { // fix for php cgi mode
                list($user, $pass) = explode(':' , base64_decode(substr(filter_input(INPUT_SERVER, 'REDIRECT_HTTP_AUTHORIZATION'), 6)));
            }

            if (!empty($user) && !empty($pass)) {
                $validated = !empty(
                    $adminusers[$user])
                    && password_verify($pass, $adminusers[$user]
                );
            } else {
                $validated = false;
            }

            if (!$validated) {
                header('WWW-Authenticate: Basic realm="'.$this->config->getSecret('admin_authrealm').'"');
                header('HTTP/1.0 401 Unauthorized');
                $this->helper->terminateScript('Not authorized');
            }

        } else {
            header('WWW-Authenticate: Basic realm="'.$this->config->getSecret('admin_authrealm').'"');
            header('HTTP/1.0 401 Unauthorized');
            $this->helper->terminateScript('Not authorized');
        }
    }
}


1			<?php
2
3			/*
4			HCSF - A multilingual CMS and Shopsystem
5			Copyright (C) 2014 Marcus Haase - [email protected]
6
7			This program is free software: you can redistribute it and/or modify
8			it under the terms of the GNU General Public License as published by
9			the Free Software Foundation, either version 3 of the License, or
10			(at your option) any later version.
11
12			This program is distributed in the hope that it will be useful,
13			but WITHOUT ANY WARRANTY; without even the implied warranty of
14			MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15			GNU General Public License for more details.
16
17			You should have received a copy of the GNU General Public License
18			along with this program. If not, see <http://www.gnu.org/licenses/>.
19			*/
20
21			namespace HaaseIT\HCSF\Controller;
22
23
24			use Zend\ServiceManager\ServiceManager;
25
26			class Base
27			{
28			/**
29			* @var \HaaseIT\HCSF\Page
30			*/
31			protected $P;
32
33			/**
34			* @var ServiceManager
35			*/
36			protected $serviceManager;
37
38			/**
39			* @var bool
40			*/
41			protected $requireAdminAuth = false;
42
43			/**
44			* @var bool
45			*/
46			protected $requireAdminAuthAdminHome = false;
47
48			/**
49			* @var bool
50			*/
51			protected $requireModuleCustomer = false;
52
53			/**
54			* @var bool
55			*/
56			protected $requireModuleShop = false;
57
58			/**
59			* @var \HaaseIT\HCSF\HelperConfig
60			*/
61			protected $config;
62
63			/**
64			* @var \HaaseIT\HCSF\Helper
65			*/
66			protected $helper;
67
68			/**
69			* Base constructor.
70			* @param ServiceManager $serviceManager
71			*/
72			public function __construct(ServiceManager $serviceManager)
73			{
74			$this->serviceManager = $serviceManager;
75			$this->config = $serviceManager->get('config');
76			$this->helper = $serviceManager->get('helper');
77			}
78
79			/**
80			* @return \HaaseIT\HCSF\Page
81			* @throws \Exception
82			*/
83			public function getPage()
84			{
85			if ($this->requireAdminAuth) {
86			$this->requireAdminAuth();
87			}
88			if ($this->requireModuleCustomer && !$this->config->getCore('enable_module_customer')) {
89			throw new \Exception(404);
90			}
91			if ($this->requireModuleShop && !$this->config->getCore('enable_module_shop')) {
92			throw new \Exception(404);
93			}
94			$this->preparePage();
95			return $this->P;
96			}
97
98			public function preparePage()
99			{
100
101			}
102
103			/**
104			* @return bool
105			*/
106			private function requireAdminAuth() {
107			$adminusers = $this->config->getSecret('admin_users');
108			if ($this->requireAdminAuthAdminHome && (empty($adminusers) \|\| !count($adminusers))) {
109			return true;
110			} elseif (count($adminusers) {
			0 ignored issues – show Bug introduced 2017-06-29 16:33 UTC by Report Bug Copy Issue Report Avoid IF statements that are always true or false Loading history...
111			$user = filter_input(INPUT_SERVER, 'PHP_AUTH_USER');
			0 ignored issues – show Bug introduced 2017-06-29 16:33 UTC by Report Bug Copy Issue Report This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected ';' Loading history...
112			$pass = filter_input(INPUT_SERVER, 'PHP_AUTH_PW');
113			if (filter_input(INPUT_SERVER, 'REDIRECT_HTTP_AUTHORIZATION') !== null) { // fix for php cgi mode
114			list($user, $pass) = explode(':' , base64_decode(substr(filter_input(INPUT_SERVER, 'REDIRECT_HTTP_AUTHORIZATION'), 6)));
115			}
116
117			if (!empty($user) && !empty($pass)) {
118			$validated = !empty(
119			$adminusers[$user])
120			&& password_verify($pass, $adminusers[$user]
121			);
122			} else {
123			$validated = false;
124			}
125
126			if (!$validated) {
127			header('WWW-Authenticate: Basic realm="'.$this->config->getSecret('admin_authrealm').'"');
128			header('HTTP/1.0 401 Unauthorized');
129			$this->helper->terminateScript('Not authorized');
130			}
131
132			} else {
133			header('WWW-Authenticate: Basic realm="'.$this->config->getSecret('admin_authrealm').'"');
134			header('HTTP/1.0 401 Unauthorized');
135			$this->helper->terminateScript('Not authorized');
136			}
137			}
138			}
139

HaaseIT / HCSF

Push — master ( 60b053...61ce86 )

Base::requireAdminAuth() D

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like