Inspection of "Added DoublyLinkedList" - HOWZ1T/Ptypes - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — development (cfa996)

by Dylan David

created 2018-03-27 01:50 UTC

Status

Spacing +17 added lines, -17 removed lines patch added patch discarded remove patch

@@ -12,7 +12,7 @@  discard block
 block discarded – undo
 	public $next = null, $prev = null; //A reference to the next and previous node
 	public $data = null; //Data or a reference to data
 	
-	public function __construct(){}
+	public function __construct() {}
 }
 
 class DoublyLinkedList implements Countable
@@ -21,16 +21,16 @@  discard block
 block discarded – undo
 	
 	private $size = 0;
 	
-	public function __construct(){}
+	public function __construct() {}
 	
 	public function insert_after($node, $newNode)
 	{
 		//type checks
-		if(get_class($node) != "DLNode"){throw new InvalidArgument("Expected a DLNode, got: ".get_class($node));}
-		if(get_class($newNode) != "DLNode"){throw new InvalidArgument("Expected a DLNode, got: ".get_class($newNode));}
+		if (get_class($node) != "DLNode") {throw new InvalidArgument("Expected a DLNode, got: " . get_class($node)); }
+		if (get_class($newNode) != "DLNode") {throw new InvalidArgument("Expected a DLNode, got: " . get_class($newNode)); }
 		
 		$newNode->prev = $node;
-		if($node->next == null)
+		if ($node->next == null)
 		{
 			$newNode->next = null;
 			$this->lastNode = $newNode;
@@ -47,11 +47,11 @@  discard block
 block discarded – undo
 	public function insert_before($node, $newNode)
 	{
 		//type checks
-		if(get_class($node) != "DLNode"){throw new InvalidArgument("Expected a DLNode, got: ".get_class($node));}
-		if(get_class($newNode) != "DLNode"){throw new InvalidArgument("Expected a DLNode, got: ".get_class($newNode));}
+		if (get_class($node) != "DLNode") {throw new InvalidArgument("Expected a DLNode, got: " . get_class($node)); }
+		if (get_class($newNode) != "DLNode") {throw new InvalidArgument("Expected a DLNode, got: " . get_class($newNode)); }
 		
 		$newNode->next = $node;
-		if($node->prev == null)
+		if ($node->prev == null)
 		{
 			$newNode->prev = null;
 			$this->firstNode = $newNode;
@@ -68,9 +68,9 @@  discard block
 block discarded – undo
 	public function insert_beginning($newNode)
 	{	
 		//type checks
-		if(get_class($newNode) != "DLNode"){throw new InvalidArgument("Expected a DLNode, got: ".get_class($newNode));}
+		if (get_class($newNode) != "DLNode") {throw new InvalidArgument("Expected a DLNode, got: " . get_class($newNode)); }
 		
-		if($this->firstNode == null)
+		if ($this->firstNode == null)
 		{
 			$this->firstNode = $newNode;
 			$this->lastNode = $newNode;
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
 	
 	public function insert_end($newNode)
 	{
-		if($this->lastNode == null)
+		if ($this->lastNode == null)
 		{
 			$this->insert_beginning($newNode);
 		}
@@ -100,13 +100,13 @@  discard block
 block discarded – undo
 	public function contains($node)
 	{
 		//check this so we could possibly avoid list traversal
-		if($node == $this->firstNode || $node == $this->lastNode) {return true;}
+		if ($node == $this->firstNode || $node == $this->lastNode) {return true; }
 		
 		//traverse the list and try to find the node
 		$n = $this->firstNode->next; //we can start one node ahead as we already checked the firstNode
-		while($n != null)
+		while ($n != null)
 		{
-			if($n == $node) {return true;}
+			if ($n == $node) {return true; }
 			$n = $n->next;
 		}
 		
@@ -116,9 +116,9 @@  discard block
 block discarded – undo
 	public function remove($node)
 	{
 		//check if the node exists
-		if($this->contains($node) == false){throw new InvalidArgument("The node given does not exist in this list!");}
+		if ($this->contains($node) == false) {throw new InvalidArgument("The node given does not exist in this list!"); }
 		
-		if($node->prev == null)
+		if ($node->prev == null)
 		{
 			$this->firstNode = $node->next;
 		}
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
 			$node->prev->next = $node->next;
 		}
 		
-		if($node->next == null)
+		if ($node->next == null)
 		{
 			$this->lastNode = $node->prev;
 		}

Please login to merge, or discard this patch.

Braces +31 added lines, -11 removed lines patch added patch discarded remove patch

@@ -12,7 +12,9 @@  discard block
 block discarded – undo
 	public $next = null, $prev = null; //A reference to the next and previous node
 	public $data = null; //Data or a reference to data
 	
-	public function __construct(){}
+	public function __construct()
+	{
+}
 }
 
 class DoublyLinkedList implements Countable
@@ -21,13 +23,19 @@  discard block
 block discarded – undo
 	
 	private $size = 0;
 	
-	public function __construct(){}
+	public function __construct()
+	{
+}
 	
 	public function insert_after($node, $newNode)
 	{
 		//type checks
-		if(get_class($node) != "DLNode"){throw new InvalidArgument("Expected a DLNode, got: ".get_class($node));}
-		if(get_class($newNode) != "DLNode"){throw new InvalidArgument("Expected a DLNode, got: ".get_class($newNode));}
+		if(get_class($node) != "DLNode")
+		{
+throw new InvalidArgument("Expected a DLNode, got: ".get_class($node));}
+		if(get_class($newNode) != "DLNode")
+		{
+throw new InvalidArgument("Expected a DLNode, got: ".get_class($newNode));}
 		
 		$newNode->prev = $node;
 		if($node->next == null)
@@ -47,8 +55,12 @@  discard block
 block discarded – undo
 	public function insert_before($node, $newNode)
 	{
 		//type checks
-		if(get_class($node) != "DLNode"){throw new InvalidArgument("Expected a DLNode, got: ".get_class($node));}
-		if(get_class($newNode) != "DLNode"){throw new InvalidArgument("Expected a DLNode, got: ".get_class($newNode));}
+		if(get_class($node) != "DLNode")
+		{
+throw new InvalidArgument("Expected a DLNode, got: ".get_class($node));}
+		if(get_class($newNode) != "DLNode")
+		{
+throw new InvalidArgument("Expected a DLNode, got: ".get_class($newNode));}
 		
 		$newNode->next = $node;
 		if($node->prev == null)
@@ -66,9 +78,11 @@  discard block
 block discarded – undo
 	}
 	
 	public function insert_beginning($newNode)
-	{	
+	{
 		//type checks
-		if(get_class($newNode) != "DLNode"){throw new InvalidArgument("Expected a DLNode, got: ".get_class($newNode));}
+		if(get_class($newNode) != "DLNode")
+		{
+throw new InvalidArgument("Expected a DLNode, got: ".get_class($newNode));}
 		
 		if($this->firstNode == null)
 		{
@@ -100,13 +114,17 @@  discard block
 block discarded – undo
 	public function contains($node)
 	{
 		//check this so we could possibly avoid list traversal
-		if($node == $this->firstNode || $node == $this->lastNode) {return true;}
+		if($node == $this->firstNode || $node == $this->lastNode)
+		{
+return true;}
 		
 		//traverse the list and try to find the node
 		$n = $this->firstNode->next; //we can start one node ahead as we already checked the firstNode
 		while($n != null)
 		{
-			if($n == $node) {return true;}
+			if($n == $node)
+			{
+return true;}
 			$n = $n->next;
 		}
 		
@@ -116,7 +134,9 @@  discard block
 block discarded – undo
 	public function remove($node)
 	{
 		//check if the node exists
-		if($this->contains($node) == false){throw new InvalidArgument("The node given does not exist in this list!");}
+		if($this->contains($node) == false)
+		{
+throw new InvalidArgument("The node given does not exist in this list!");}
 		
 		if($node->prev == null)
 		{

Please login to merge, or discard this patch.

		@@ -12,7 +12,7 @@ discard block
		block discarded – undo
12	12	public $next = null, $prev = null; //A reference to the next and previous node
13	13	public $data = null; //Data or a reference to data
14	14
15		- public function __construct(){}
	15	+ public function __construct() {}
16	16	}
17	17
18	18	class DoublyLinkedList implements Countable
		@@ -21,16 +21,16 @@ discard block
		block discarded – undo
21	21
22	22	private $size = 0;
23	23
24		- public function __construct(){}
	24	+ public function __construct() {}
25	25
26	26	public function insert_after($node, $newNode)
27	27	{
28	28	//type checks
29		- if(get_class($node) != "DLNode"){throw new InvalidArgument("Expected a DLNode, got: ".get_class($node));}
30		- if(get_class($newNode) != "DLNode"){throw new InvalidArgument("Expected a DLNode, got: ".get_class($newNode));}
	29	+ if (get_class($node) != "DLNode") {throw new InvalidArgument("Expected a DLNode, got: " . get_class($node)); }
	30	+ if (get_class($newNode) != "DLNode") {throw new InvalidArgument("Expected a DLNode, got: " . get_class($newNode)); }
31	31
32	32	$newNode->prev = $node;
33		- if($node->next == null)
	33	+ if ($node->next == null)
34	34	{
35	35	$newNode->next = null;
36	36	$this->lastNode = $newNode;
		@@ -47,11 +47,11 @@ discard block
		block discarded – undo
47	47	public function insert_before($node, $newNode)
48	48	{
49	49	//type checks
50		- if(get_class($node) != "DLNode"){throw new InvalidArgument("Expected a DLNode, got: ".get_class($node));}
51		- if(get_class($newNode) != "DLNode"){throw new InvalidArgument("Expected a DLNode, got: ".get_class($newNode));}
	50	+ if (get_class($node) != "DLNode") {throw new InvalidArgument("Expected a DLNode, got: " . get_class($node)); }
	51	+ if (get_class($newNode) != "DLNode") {throw new InvalidArgument("Expected a DLNode, got: " . get_class($newNode)); }
52	52
53	53	$newNode->next = $node;
54		- if($node->prev == null)
	54	+ if ($node->prev == null)
55	55	{
56	56	$newNode->prev = null;
57	57	$this->firstNode = $newNode;
		@@ -68,9 +68,9 @@ discard block
		block discarded – undo
68	68	public function insert_beginning($newNode)
69	69	{
70	70	//type checks
71		- if(get_class($newNode) != "DLNode"){throw new InvalidArgument("Expected a DLNode, got: ".get_class($newNode));}
	71	+ if (get_class($newNode) != "DLNode") {throw new InvalidArgument("Expected a DLNode, got: " . get_class($newNode)); }
72	72
73		- if($this->firstNode == null)
	73	+ if ($this->firstNode == null)
74	74	{
75	75	$this->firstNode = $newNode;
76	76	$this->lastNode = $newNode;
		@@ -86,7 +86,7 @@ discard block
		block discarded – undo
86	86
87	87	public function insert_end($newNode)
88	88	{
89		- if($this->lastNode == null)
	89	+ if ($this->lastNode == null)
90	90	{
91	91	$this->insert_beginning($newNode);
92	92	}
		@@ -100,13 +100,13 @@ discard block
		block discarded – undo
100	100	public function contains($node)
101	101	{
102	102	//check this so we could possibly avoid list traversal
103		- if($node == $this->firstNode \|\| $node == $this->lastNode) {return true;}
	103	+ if ($node == $this->firstNode \|\| $node == $this->lastNode) {return true; }
104	104
105	105	//traverse the list and try to find the node
106	106	$n = $this->firstNode->next; //we can start one node ahead as we already checked the firstNode
107		- while($n != null)
	107	+ while ($n != null)
108	108	{
109		- if($n == $node) {return true;}
	109	+ if ($n == $node) {return true; }
110	110	$n = $n->next;
111	111	}
112	112
		@@ -116,9 +116,9 @@ discard block
		block discarded – undo
116	116	public function remove($node)
117	117	{
118	118	//check if the node exists
119		- if($this->contains($node) == false){throw new InvalidArgument("The node given does not exist in this list!");}
	119	+ if ($this->contains($node) == false) {throw new InvalidArgument("The node given does not exist in this list!"); }
120	120
121		- if($node->prev == null)
	121	+ if ($node->prev == null)
122	122	{
123	123	$this->firstNode = $node->next;
124	124	}
		@@ -127,7 +127,7 @@ discard block
		block discarded – undo
127	127	$node->prev->next = $node->next;
128	128	}
129	129
130		- if($node->next == null)
	130	+ if ($node->next == null)
131	131	{
132	132	$this->lastNode = $node->prev;
133	133	}

		@@ -12,7 +12,9 @@ discard block
		block discarded – undo
12	12	public $next = null, $prev = null; //A reference to the next and previous node
13	13	public $data = null; //Data or a reference to data
14	14
15		- public function __construct(){}
	15	+ public function __construct()
	16	+ {
	17	+}
16	18	}
17	19
18	20	class DoublyLinkedList implements Countable
		@@ -21,13 +23,19 @@ discard block
		block discarded – undo
21	23
22	24	private $size = 0;
23	25
24		- public function __construct(){}
	26	+ public function __construct()
	27	+ {
	28	+}
25	29
26	30	public function insert_after($node, $newNode)
27	31	{
28	32	//type checks
29		- if(get_class($node) != "DLNode"){throw new InvalidArgument("Expected a DLNode, got: ".get_class($node));}
30		- if(get_class($newNode) != "DLNode"){throw new InvalidArgument("Expected a DLNode, got: ".get_class($newNode));}
	33	+ if(get_class($node) != "DLNode")
	34	+ {
	35	+throw new InvalidArgument("Expected a DLNode, got: ".get_class($node));}
	36	+ if(get_class($newNode) != "DLNode")
	37	+ {
	38	+throw new InvalidArgument("Expected a DLNode, got: ".get_class($newNode));}
31	39
32	40	$newNode->prev = $node;
33	41	if($node->next == null)
		@@ -47,8 +55,12 @@ discard block
		block discarded – undo
47	55	public function insert_before($node, $newNode)
48	56	{
49	57	//type checks
50		- if(get_class($node) != "DLNode"){throw new InvalidArgument("Expected a DLNode, got: ".get_class($node));}
51		- if(get_class($newNode) != "DLNode"){throw new InvalidArgument("Expected a DLNode, got: ".get_class($newNode));}
	58	+ if(get_class($node) != "DLNode")
	59	+ {
	60	+throw new InvalidArgument("Expected a DLNode, got: ".get_class($node));}
	61	+ if(get_class($newNode) != "DLNode")
	62	+ {
	63	+throw new InvalidArgument("Expected a DLNode, got: ".get_class($newNode));}
52	64
53	65	$newNode->next = $node;
54	66	if($node->prev == null)
		@@ -66,9 +78,11 @@ discard block
		block discarded – undo
66	78	}
67	79
68	80	public function insert_beginning($newNode)
69		- {
	81	+ {
70	82	//type checks
71		- if(get_class($newNode) != "DLNode"){throw new InvalidArgument("Expected a DLNode, got: ".get_class($newNode));}
	83	+ if(get_class($newNode) != "DLNode")
	84	+ {
	85	+throw new InvalidArgument("Expected a DLNode, got: ".get_class($newNode));}
72	86
73	87	if($this->firstNode == null)
74	88	{
		@@ -100,13 +114,17 @@ discard block
		block discarded – undo
100	114	public function contains($node)
101	115	{
102	116	//check this so we could possibly avoid list traversal
103		- if($node == $this->firstNode \|\| $node == $this->lastNode) {return true;}
	117	+ if($node == $this->firstNode \|\| $node == $this->lastNode)
	118	+ {
	119	+return true;}
104	120
105	121	//traverse the list and try to find the node
106	122	$n = $this->firstNode->next; //we can start one node ahead as we already checked the firstNode
107	123	while($n != null)
108	124	{
109		- if($n == $node) {return true;}
	125	+ if($n == $node)
	126	+ {
	127	+return true;}
110	128	$n = $n->next;
111	129	}
112	130
		@@ -116,7 +134,9 @@ discard block
		block discarded – undo
116	134	public function remove($node)
117	135	{
118	136	//check if the node exists
119		- if($this->contains($node) == false){throw new InvalidArgument("The node given does not exist in this list!");}
	137	+ if($this->contains($node) == false)
	138	+ {
	139	+throw new InvalidArgument("The node given does not exist in this list!");}
120	140
121	141	if($node->prev == null)
122	142	{

HOWZ1T / Ptypes

Branch — development (cfa996)

Status

Category

Spacing +17 added lines, -17 removed lines patch added patch discarded remove patch

Braces +31 added lines, -11 removed lines patch added patch discarded remove patch