ApiResultLoader::__construct() - Code Metrics - HDNET/onpage_integration - Measure and Improve Code Quality continuously with Scrutinizer

ApiResultLoader::__construct() A
last analyzed 2017-01-20 16:10 UTC

↳ Parent: ApiResultLoader

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	5
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	2

<?php
/**
 * Class ApiResultLoader
 */
namespace HDNET\OnpageIntegration\Loader;

use HDNET\OnpageIntegration\Exception\ApiErrorException;
use HDNET\OnpageIntegration\Persister\ApiResultToCachePersister;
use HDNET\OnpageIntegration\Service\DataService;
use TYPO3\CMS\Core\Cache\CacheManager;
use TYPO3\CMS\Core\Utility\GeneralUtility;

/**
 * Class ApiResultLoader
 */
class ApiResultLoader
{

    /**
     * @var \HDNET\OnpageIntegration\Service\DataService
     */
    protected $dataService;

    /**
     * @var \HDNET\OnpageIntegration\Persister\ApiResultToCachePersister
     */
    protected $persister;

    /**
     * ApiResultLoader constructor.
     *
     * @param \HDNET\OnpageIntegration\Service\DataService               $dataService
     * @param \HDNET\OnpageIntegration\Persister\ApiResultToCachePersister $apiResultToCachePersister
     */
    public function __construct(DataService $dataService, ApiResultToCachePersister $apiResultToCachePersister)
    {
        $this->dataService = $dataService;
        $this->persister = $apiResultToCachePersister;
    }

    /**
     * @param string $key
     *
     * @return array
     */
    public function load($key)
    {
        $cacheId = $this->persister->getIdentifier($key);
        $entry = GeneralUtility::makeInstance(CacheManager::class)
            ->getCache('onpage_extension')
            ->get($cacheId);

        if ($entry === false) {
            try {
                $entry = $this->dataService->getApiResult($key);
            } catch (ApiErrorException $e) {

            }
            $this->persister->persist($entry, $key);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }
        return json_decode($entry, true);
    }
}


1			<?php
2			/**
3			* Class ApiResultLoader
4			*/
5			namespace HDNET\OnpageIntegration\Loader;
6
7			use HDNET\OnpageIntegration\Exception\ApiErrorException;
8			use HDNET\OnpageIntegration\Persister\ApiResultToCachePersister;
9			use HDNET\OnpageIntegration\Service\DataService;
10			use TYPO3\CMS\Core\Cache\CacheManager;
11			use TYPO3\CMS\Core\Utility\GeneralUtility;
12
13			/**
14			* Class ApiResultLoader
15			*/
16			class ApiResultLoader
17			{
18
19			/**
20			* @var \HDNET\OnpageIntegration\Service\DataService
21			*/
22			protected $dataService;
23
24			/**
25			* @var \HDNET\OnpageIntegration\Persister\ApiResultToCachePersister
26			*/
27			protected $persister;
28
29			/**
30			* ApiResultLoader constructor.
31			*
32			* @param \HDNET\OnpageIntegration\Service\DataService $dataService
33			* @param \HDNET\OnpageIntegration\Persister\ApiResultToCachePersister $apiResultToCachePersister
34			*/
35			public function __construct(DataService $dataService, ApiResultToCachePersister $apiResultToCachePersister)
36			{
37			$this->dataService = $dataService;
38			$this->persister = $apiResultToCachePersister;
39			}
40
41			/**
42			* @param string $key
43			*
44			* @return array
45			*/
46			public function load($key)
47			{
48			$cacheId = $this->persister->getIdentifier($key);
49			$entry = GeneralUtility::makeInstance(CacheManager::class)
50			->getCache('onpage_extension')
51			->get($cacheId);
52
53			if ($entry === false) {
54			try {
55			$entry = $this->dataService->getApiResult($key);
56			} catch (ApiErrorException $e) {
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-07-20 09:45 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
57			}
58			$this->persister->persist($entry, $key);
			0 ignored issues – show Documentation introduced 2016-06-23 15:58 UTC by Report Bug Copy Issue Report `$entry` is of type `array`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
59			}
60			return json_decode($entry, true);
61			}
62			}
63

HDNET / onpage_integration

ApiResultLoader::__construct() A last analyzed 2017-01-20 16:10 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

ApiResultLoader::__construct() A
last analyzed 2017-01-20 16:10 UTC