HDNET\OnpageIntegration\Loader\ApiResultLoader

Complexity

Total Complexity

4

Size/Duplication

Total Lines	47
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	2
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	load()	0	16	3

<?php
/**
 * Class ApiResultLoader
 */
namespace HDNET\OnpageIntegration\Loader;

use HDNET\OnpageIntegration\Exception\ApiErrorException;
use HDNET\OnpageIntegration\Persister\ApiResultToCachePersister;
use HDNET\OnpageIntegration\Service\DataService;
use TYPO3\CMS\Core\Cache\CacheManager;
use TYPO3\CMS\Core\Utility\GeneralUtility;

/**
 * Class ApiResultLoader
 */
class ApiResultLoader
{

    /**
     * @var \HDNET\OnpageIntegration\Service\DataService
     */
    protected $dataService;

    /**
     * @var \HDNET\OnpageIntegration\Persister\ApiResultToCachePersister
     */
    protected $persister;

    /**
     * ApiResultLoader constructor.
     *
     * @param \HDNET\OnpageIntegration\Service\DataService               $dataService
     * @param \HDNET\OnpageIntegration\Persister\ApiResultToCachePersister $apiResultToCachePersister
     */
    public function __construct(DataService $dataService, ApiResultToCachePersister $apiResultToCachePersister)
    {
        $this->dataService = $dataService;
        $this->persister = $apiResultToCachePersister;
    }

    /**
     * @param string $key
     *
     * @return array
     */
    public function load($key)
    {
        $cacheId = $this->persister->getIdentifier($key);
        $entry = GeneralUtility::makeInstance(CacheManager::class)
            ->getCache('onpage_extension')
            ->get($cacheId);

        if ($entry === false) {
            try {
                $entry = $this->dataService->getApiResult($key);
            } catch (ApiErrorException $e) {

Consider adding a comment why this CATCH block is empty.

            }
            $this->persister->persist($entry, $key);

$entry is of type array, but the function expects a string.

        }
        return json_decode($entry, true);
    }
}