GuilleGF / SecretSantaPHP

src/PlayersCollection.php

Spacing +1 added lines, -1 removed lines

@@ -70,7 +70,7 @@
     {
         foreach ($players as $mainPlayer) {
             foreach ($players as $player) {
-                if ($mainPlayer->id() == $player->id()){
+                if ($mainPlayer->id() == $player->id()) {
                     continue;
                 }
                 $this->excludePlayers[$mainPlayer->id()][] = $player->id();

Doc Comments +2 added lines, -1 removed lines

@@ -73,6 +73,7 @@ 
 
     /**
      * @param Player[] ...$players
+     * @param Player $players
      */
     private function excludePlayers(...$players)
     {
@@ -126,7 +127,7 @@ 
     }
 
     /**
-     * @param array $list
+     * @param Player[] $list
      * @return array
      */
     private function shuffleAssoc($list)

Braces +6 added lines, -2 removed lines

@@ -131,7 +131,9 @@ 
      */
     private function shuffleAssoc($list)
     {
-        if (!is_array($list)) return $list;
+        if (!is_array($list)) {
+            return $list;
+        }
 
         $keys = $this->forceShuffle(array_keys($list));
         $random = [];
@@ -148,7 +150,9 @@ 
      */
     private function forceShuffle($list)
     {
-        if (!is_array($list) || count($list) < 2) return $list;
+        if (!is_array($list) || count($list) < 2) {
+            return $list;
+        }
 
         $shuffleList = $list;
         while ($shuffleList == $list) {

src/SecretSanta.php

Spacing +1 added lines, -1 removed lines

@@ -84,7 +84,7 @@
 
         $retry = count($this->players) + $this->players->countExcludePlayers();
 
-        while (!$this->isValidCombination() && $retry > 0 ) {
+        while (!$this->isValidCombination() && $retry > 0) {
             $this->combination = [];
             $secretPlayers = $this->players->shufflePlayers();
             foreach ($this->players as $playerId => $player) {