GlobalTradingTechnologies / workflow-extensions-bundle

Entity/Repository/ScheduledJobRepository.php

Unused Use Statements -1 removed lines

@@ -14,7 +14,6 @@
 use Doctrine\ORM\EntityRepository;
 use Gtt\Bundle\WorkflowExtensionsBundle\Entity\ScheduledJob;
 use Gtt\Bundle\WorkflowExtensionsBundle\Exception\NonUniqueReschedulabeJobFoundException;
-use Gtt\Bundle\WorkflowExtensionsBundle\Schedule\Action\ScheduledAction;
 use JMS\JobQueueBundle\Entity\Job;
 
 /**

Tests/Action/ExecutorTest.php

Unused Use Statements -1 removed lines

@@ -17,7 +17,6 @@
 use Gtt\Bundle\WorkflowExtensionsBundle\Action\Registry;
 use Gtt\Bundle\WorkflowExtensionsBundle\Tests\Action\Reference\ContainerAwareActionReferenceInterface;
 use Gtt\Bundle\WorkflowExtensionsBundle\WorkflowContext;
-use Symfony\Component\DependencyInjection\ContainerAwareInterface;
 use Symfony\Component\DependencyInjection\ContainerInterface;
 use Symfony\Component\Workflow\Workflow;
 

Tests/Guard/ExpressionGuardTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -135,7 +135,7 @@
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|Registry
+     * @return Registry
      */
     private function prepareValidWorkflowRegistryMock()
     {

Tests/Trigger/Event/AbstractListenerTest.php

Unused Use Statements -4 removed lines

@@ -11,13 +11,9 @@
 
 namespace Gtt\Bundle\WorkflowExtensionsBundle\Tests\Trigger\Event;
 
-use Gtt\Bundle\WorkflowExtensionsBundle\Schedule\ScheduledTransition;
-use Gtt\Bundle\WorkflowExtensionsBundle\Schedule\TransitionScheduler;
-use Gtt\Bundle\WorkflowExtensionsBundle\Tests\TestCase;
 use Gtt\Bundle\WorkflowExtensionsBundle\Trigger\Event\AbstractListener;
 use Gtt\Bundle\WorkflowExtensionsBundle\WorkflowContext;
 use Gtt\Bundle\WorkflowExtensionsBundle\WorkflowSubject\SubjectManipulator;
-use Gtt\Bundle\WorkflowExtensionsBundle\TransitionApplier;
 use PHPUnit_Framework_MockObject_MockObject;
 use PHPUnit_Framework_TestCase;
 use Psr\Log\LoggerInterface;

Trigger/Event/SchedulerListener.php

Doc Comments -1 removed lines

@@ -57,7 +57,6 @@
     /**
      * {@inheritdoc}
      *
-     * @param string $expression expression to be executed by event
      */
     public function registerEvent(
         $eventName,

Spacing +1 added lines, -1 removed lines

@@ -81,7 +81,7 @@
 
         foreach ($actions as $scheduledAction) {
             $this->executeSafely(
-                function () use ($workflowContext, $scheduledAction) {
+                function() use ($workflowContext, $scheduledAction) {
                     $this->actionScheduler->scheduleAction($workflowContext, $scheduledAction);
                 },
                 $eventName,

Schedule/ActionScheduler.php

Spacing +5 added lines, -5 removed lines

@@ -66,11 +66,11 @@
 
         $jobToSchedule = new Job(ExecuteActionCommand::COMMAND_NAME,
             [
-                '--action='       . $scheduledAction->getName(),
-                '--arguments='    . json_encode($scheduledAction->getArguments()),
-                '--workflow='     . $workflowContext->getWorkflow()->getName(),
-                '--subjectClass=' . get_class($workflowContext->getSubject()),
-                '--subjectId='    . $workflowContext->getSubjectId(),
+                '--action='.$scheduledAction->getName(),
+                '--arguments='.json_encode($scheduledAction->getArguments()),
+                '--workflow='.$workflowContext->getWorkflow()->getName(),
+                '--subjectClass='.get_class($workflowContext->getSubject()),
+                '--subjectId='.$workflowContext->getSubjectId(),
             ]
         );
 

DependencyInjection/Configuration.php

Indentation +1 added lines, -1 removed lines

@@ -363,7 +363,7 @@
             ->isRequired()
             ->cannotBeEmpty()
             ->info('Holds period defines offset from time of event catching for transition scheduling. '.
-             'See https://en.wikipedia.org/wiki/ISO_8601#Durations for format description')
+                'See https://en.wikipedia.org/wiki/ISO_8601#Durations for format description')
             ->validate()
                 ->always()
                 ->then(function ($v) {

Spacing +13 added lines, -13 removed lines

@@ -94,7 +94,7 @@ 
             ->end()
             ->validate()
                 ->always()
-                ->then(function ($v) {
+                ->then(function($v) {
                     foreach ($v as $actionName => $actionConfig) {
                         if (!preg_match('/^[a-z0-9_]+$/i', $actionName)) {
                             throw new InvalidConfigurationException(
@@ -192,7 +192,7 @@ 
                                 ->defaultValue([])
                                 ->beforeNormalization()
                                     ->ifString()
-                                    ->then(function ($v) { return array($v); })
+                                    ->then(function($v) { return array($v); })
                                 ->end()
                                 ->useAttributeAsKey('name')
                                 ->prototype('array')
@@ -202,16 +202,16 @@ 
                                         ->end()
                                         ->beforeNormalization()
                                             ->ifString()
-                                            ->then(function ($v) {
+                                            ->then(function($v) {
                                                 return ['arguments' => [$v]];
                                             })
                                         ->end()
                                         ->beforeNormalization()
-                                            ->ifTrue(function ($v) {
+                                            ->ifTrue(function($v) {
                                                 // place arguments under 'arguments' key in order to validate it in common way
                                                 return is_array($v) && !(count($v) == 1 && array_key_exists('arguments', $v));
                                             })
-                                            ->then(function ($v) {
+                                            ->then(function($v) {
                                                 return ['arguments' => $v];
                                             })
                                         ->end()
@@ -290,10 +290,10 @@ 
                     ->end()
                 ->end()
                 ->beforeNormalization()
-                    ->ifTrue(function ($v) {
+                    ->ifTrue(function($v) {
                         return is_scalar($v) || is_array($v) && !ArrayUtils::isArrayAssoc($v);
                     })
-                    ->then(function ($v) {
+                    ->then(function($v) {
                         $type = is_scalar($v) ? ActionArgumentTypes::TYPE_SCALAR : ActionArgumentTypes::TYPE_ARRAY;
                         return [
                             'type'  => $type,
@@ -302,10 +302,10 @@ 
                     })
                 ->end()
                 ->validate()
-                    ->ifTrue(function ($v) {
+                    ->ifTrue(function($v) {
                         return is_array($v) && $v['type'] == ActionArgumentTypes::TYPE_ARRAY;
                     })
-                    ->then(function ($v) {
+                    ->then(function($v) {
                         // recursive processing of array values
                         $treeBuilder = new TreeBuilder();
                         $node = $treeBuilder->root('value');
@@ -319,7 +319,7 @@ 
                 ->end()
             ->end()
             ->validate()
-                ->ifTrue(function ($v) {
+                ->ifTrue(function($v) {
                     return ArrayUtils::isArrayAssoc($v, false);
                 })
                 // To provide cross-platform arguments handling we are not supporting here assoc arrays
@@ -366,7 +366,7 @@ 
              'See https://en.wikipedia.org/wiki/ISO_8601#Durations for format description')
             ->validate()
                 ->always()
-                ->then(function ($v) {
+                ->then(function($v) {
                     try {
                         new DateInterval($v);
 
@@ -407,7 +407,7 @@ 
                     ->prototype('array')
                         ->beforeNormalization()
                             ->ifString()
-                            ->then(function ($v) { return ['expression' => $v]; })
+                            ->then(function($v) { return ['expression' => $v]; })
                         ->end()
                         ->children()
                             ->scalarNode('expression')
@@ -438,7 +438,7 @@ 
             ->beforeNormalization()
                 ->always()
                 ->then(
-                    function ($v) {
+                    function($v) {
                         if (isset($v) && is_array($v)) {
                             foreach ($v as $key => $value) {
                                 unset($v[$key]);

Trigger/Event/ExpressionListener.php

Spacing +1 added lines, -1 removed lines

@@ -73,7 +73,7 @@
         $expression = $this->supportedEventsConfig[$eventName][$workflowContext->getWorkflow()->getName()]['expression'];
 
         $this->executeSafely(
-            function () use ($expression, $event, $workflowContext) {
+            function() use ($expression, $event, $workflowContext) {
                 $this->actionLanguage->evaluate($expression, ['event' => $event, 'workflowContext' => $workflowContext]);
             },
             $eventName,

Trigger/Event/ActionListener.php

Spacing +1 added lines, -1 removed lines

@@ -80,7 +80,7 @@
 
         foreach ($actions as $action) {
             $this->executeSafely(
-                function () use ($workflowContext, $action) {
+                function() use ($workflowContext, $action) {
                     $this->actionExecutor->execute($workflowContext, $action->getName(), $action->getArguments());
                 },
                 $eventName,