GlobalTradingTechnologies / workflow-extensions-bundle

Schedule/ScheduledTransition.php

Doc Comments +1 added lines, -1 removed lines

@@ -64,7 +64,7 @@
     /**
      * Returns offset date interval
      *
-     * @return DateInterval
+     * @return string
      */
     public function getOffset()
     {

Tests/Functional/Kernel/BaseTestKernel.php

Doc Comments +1 added lines, -1 removed lines

@@ -111,7 +111,7 @@
     /**
      * Returns base bundle list
      *
-     * @return array
+     * @return \Symfony\Bundle\FrameworkBundle\FrameworkBundle[]
      */
     protected function getBaseBundles()
     {

Spacing +3 added lines, -3 removed lines

@@ -65,14 +65,14 @@ 
         $this->setRootDir($rootDir);
 
         $this->configDir = realpath($configDir);
-        if (!is_dir($this->configDir . '/' . $testCase)) {
+        if (!is_dir($this->configDir.'/'.$testCase)) {
             throw new \InvalidArgumentException(sprintf('The test case "%s" does not exist.', $testCase));
         }
         $this->testCase = $testCase;
 
         $fs = new Filesystem();
         if (!$fs->isAbsolutePath($rootConfig) &&
-            !file_exists($rootConfig = $this->configDir . '/' . $testCase . '/' . $rootConfig)) {
+            !file_exists($rootConfig = $this->configDir.'/'.$testCase.'/'.$rootConfig)) {
             throw new \InvalidArgumentException(sprintf('The root config "%s" does not exist.', $rootConfig));
         }
         $this->rootConfig = $rootConfig;
@@ -127,7 +127,7 @@ 
     {
         $bundles     = array();
         $baseBundles = $this->getBaseBundles();
-        if (file_exists($filename = $this->configDir . '/' . $this->testCase . '/bundles.php')) {
+        if (file_exists($filename = $this->configDir.'/'.$this->testCase.'/bundles.php')) {
             $bundles = include $filename;
         }
         return array_merge($baseBundles, $bundles);

Tests/Functional/ScheduleCaseTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -96,7 +96,7 @@
 
     /**
      * @param ContainerInterface $container
-     * @param array|string|false $fixturesPath
+     * @param string $fixturesPath
      * @param string $em
      * @param bool|true $append
      * @return array

Spacing +3 added lines, -3 removed lines

@@ -50,7 +50,7 @@ 
 
         // load fixtures
         $fixturesBundle = new ClientBundle();
-        $fixturesPath = $fixturesBundle->getPath() . '/DataFixtures/ORM';
+        $fixturesPath = $fixturesBundle->getPath().'/DataFixtures/ORM';
         $this->loadFixtures($this->client->getContainer(), $fixturesPath);
     }
 
@@ -67,8 +67,8 @@ 
                 "app_name"    => "ScheduleCaseTest",
                 "test_case"   => "ScheduleCase",
                 "root_config" => "config.yml",
-                "config_dir"  => __DIR__ . "/Configuration",
-                "root_dir"    => __DIR__ . "/Configuration/ScheduleCase",
+                "config_dir"  => __DIR__."/Configuration",
+                "root_dir"    => __DIR__."/Configuration/ScheduleCase",
                 "environment" => "test",
                 "debug"       => false
             )

TransitionApplier.php

Doc Comments +1 added lines, -1 removed lines

@@ -64,7 +64,7 @@
      *
      * @param object $subject      subject
      * @param string $workflowName workflow name
-     * @param string $transitions  transition to be applied
+     * @param string $transition  transition to be applied
      */
     public function applyTransition($subject, $workflowName, $transition)
     {

Tests/Guard/ExpressionGuardTest.php

Spacing +2 added lines, -2 removed lines

@@ -76,7 +76,7 @@ 
         $event->expects(self::never())->method("setBlocked");
 
         $guard->registerGuardExpression("eventName", "workflow", "expression");
-        $guard->guardTransition($event ,"eventName");
+        $guard->guardTransition($event, "eventName");
     }
 
     /**
@@ -113,7 +113,7 @@ 
         $logger->expects($this->exactly($loggerInvocationCount))->method("debug");
 
         $guard->registerGuardExpression("eventName", "workflow", $expression);
-        $guard->guardTransition($event ,"eventName");
+        $guard->guardTransition($event, "eventName");
     }
 
     public function expressionProvider()

Tests/Schedule/TransitionSchedulerTest.php

Spacing +7 added lines, -7 removed lines

@@ -69,10 +69,10 @@ 
         $transition = new ScheduledTransition('t1', 'PT1S');
 
         $transitionTriggerJobArgs = [
-            '--transition='   . $transition->getTransitionName(),
-            '--workflow='     . $workflowName,
-            '--subjectClass=' . $subjectClass,
-            '--subjectId='    . $subjectId,
+            '--transition='.$transition->getTransitionName(),
+            '--workflow='.$workflowName,
+            '--subjectClass='.$subjectClass,
+            '--subjectId='.$subjectId,
         ];
 
         Carbon::setTestNow(Carbon::now());
@@ -82,14 +82,14 @@ 
         /** @var $em \PHPUnit_Framework_MockObject_MockObject|ObjectManager */
         $em->expects(self::exactly(2))->method('persist')->withConsecutive(
             [self::callback(
-                function (Job $job) use ($transitionTriggerJobArgs, $executeJobAfter) {
+                function(Job $job) use ($transitionTriggerJobArgs, $executeJobAfter) {
                     return
                         $job->getArgs() == $transitionTriggerJobArgs &&
                         $job->getExecuteAfter() == $executeJobAfter;
                 }
             )],
             [self::callback(
-                function (ScheduledJob $job) use ($subjectClass, $subjectId, $transition, $workflowName) {
+                function(ScheduledJob $job) use ($subjectClass, $subjectId, $transition, $workflowName) {
                     return
                         $job->getSubjectClass() == $subjectClass &&
                         $job->getSubjectId() == $subjectId &&
@@ -127,7 +127,7 @@ 
         /** @var $em \PHPUnit_Framework_MockObject_MockObject|ObjectManager */
         $em->expects(self::once())->method('persist')->withConsecutive(
             [self::callback(
-                function (Job $job) use ($newExecuteJobAfter) {
+                function(Job $job) use ($newExecuteJobAfter) {
                     return $job->getExecuteAfter() == $newExecuteJobAfter;
                 }
             )]

Tests/Functional/EventTriggerWithGuardsCaseTest.php

Spacing +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
                 "app_name" => "EventTriggerWithGuardsCaseTest",
                 "test_case" => "EventTriggerWithGuardsCase",
                 "root_config" => "config.yml",
-                "config_dir" => __DIR__ . "/Configuration",
+                "config_dir" => __DIR__."/Configuration",
                 "environment" => "test",
                 "debug" => false
             )

Schedule/TransitionScheduler.php

Spacing +4 added lines, -4 removed lines

@@ -141,10 +141,10 @@
     {
         $transitionTriggerJob = new Job('workflow:transition:trigger',
             [
-                '--transition='   . $scheduledTransition->getTransitionName(),
-                '--workflow='     . $workflowName,
-                '--subjectClass=' . $subjectClass,
-                '--subjectId='    . $subjectId,
+                '--transition='.$scheduledTransition->getTransitionName(),
+                '--workflow='.$workflowName,
+                '--subjectClass='.$subjectClass,
+                '--subjectId='.$subjectId,
             ]
         );
 

DependencyInjection/Configuration.php

Indentation +1 added lines, -1 removed lines

@@ -95,7 +95,7 @@
                                             ->isRequired()
                                             ->cannotBeEmpty()
                                             ->info('Holds period defines offset from time of event catching for transition scheduling. '.
-                                             'See https://en.wikipedia.org/wiki/ISO_8601#Durations for format description')
+                                                'See https://en.wikipedia.org/wiki/ISO_8601#Durations for format description')
                                             ->validate()
                                                 ->always()
                                                 ->then(function ($v) {

Spacing +4 added lines, -4 removed lines

@@ -77,7 +77,7 @@ 
                                 ->defaultValue([])
                                 ->beforeNormalization()
                                     ->ifString()
-                                    ->then(function ($v) { return array($v); })
+                                    ->then(function($v) { return array($v); })
                                 ->end()
                                 ->useAttributeAsKey('name')
                                 ->prototype('scalar')
@@ -98,7 +98,7 @@ 
                                              'See https://en.wikipedia.org/wiki/ISO_8601#Durations for format description')
                                             ->validate()
                                                 ->always()
-                                                ->then(function ($v) {
+                                                ->then(function($v) {
                                                     try {
                                                         new DateInterval($v);
 
@@ -156,7 +156,7 @@ 
                     ->prototype('array')
                         ->beforeNormalization()
                             ->ifString()
-                            ->then(function ($v) { return ['expression' => $v]; })
+                            ->then(function($v) { return ['expression' => $v]; })
                         ->end()
                         ->children()
                             ->scalarNode('expression')
@@ -187,7 +187,7 @@ 
             ->beforeNormalization()
                 ->always()
                 ->then(
-                    function ($v) {
+                    function($v) {
                         if (isset($v) && is_array($v)) {
                             foreach ($v as $key => $value) {
                                 unset($v[$key]);