GermaniaKG / Salesmen

src/SalesmanIdAwareInterface.php

Spacing +1 added lines, -1 removed lines

@@ -10,5 +10,5 @@
      * @var     int|string $salesman_id
      * @return  self
      */
-    public function setSalesmanId( $id );
+    public function setSalesmanId($id);
 }

src/SalesmanIdAwareTrait.php

Braces +3 added lines, -1 removed lines

@@ -15,8 +15,10 @@
     {
         if ($salesman instanceOf SalesmanIdProviderInterface):
             $this->salesman_id = $salesman->getSalesmanId();
-        else:
+        else {
+            :
             $this->salesman_id = $salesman;
+        }
         endif;
 
         return $this;

Spacing +1 added lines, -1 removed lines

@@ -11,7 +11,7 @@
      * @var     int|string|SalesmanIdProviderInterface $salesman
      * @return  self
      */
-    public function setSalesmanId( $salesman )
+    public function setSalesmanId($salesman)
     {
         if ($salesman instanceOf SalesmanIdProviderInterface):
             $this->salesman_id = $salesman->getSalesmanId();

src/SalesmanFilterIterator.php

Spacing +4 added lines, -4 removed lines

@@ -14,7 +14,7 @@ 
      * @param \Traversable $collection      Collection of SalesmanIdProviderInterface
      * @param array|int    $salesman_filter The Salesman ID to filter for
      */
-    public function __construct( \Traversable $collection, $salesman_filter )
+    public function __construct(\Traversable $collection, $salesman_filter)
     {
         // Allow for getSalesmanId
         $this->salesman_filter = ($salesman_filter instanceOf SalesmanIdProviderInterface)
@@ -23,12 +23,12 @@ 
 
         // Cast to array
         if (!is_array($this->salesman_filter)) {
-            $this->salesman_filter = array( $this->salesman_filter );
+            $this->salesman_filter = array($this->salesman_filter);
         }
 
         // Take care of Traversable's two faces,
         // since both IteratorAggregate and Iterator implement Traversable
-        parent::__construct( $collection instanceOf \IteratorAggregate ? $collection->getIterator() : $collection );
+        parent::__construct($collection instanceOf \IteratorAggregate ? $collection->getIterator() : $collection);
 
     }
 
@@ -45,7 +45,7 @@ 
         // Cast to array
         $item_salesman_id = $item->getSalesmanId();
         if (!is_array($item_salesman_id)) {
-            $item_salesman_id = array( $item_salesman_id );
+            $item_salesman_id = array($item_salesman_id);
         }
 
         // Check intersection

src/PdoActiveSalesmen.php

Doc Comments +1 added lines, -1 removed lines

@@ -71,7 +71,7 @@
 
 
     /**
-     * @return Iterator
+     * @return \ArrayIterator
      */
     public function getIterator()
     {

Spacing +9 added lines, -9 removed lines

@@ -14,7 +14,7 @@ 
 
     public $salesmen = array();
 
-    public function __construct (\PDO $pdo, $table, SalesmanInterface $salesman = null)
+    public function __construct(\PDO $pdo, $table, SalesmanInterface $salesman = null)
     {
         $this->table    = $table;
         $this->pdo      = $pdo;
@@ -39,20 +39,20 @@ 
         aussendienst_vorname ASC,
         aussendienst_nummer ASC";
 
-        $this->stmt = $pdo->prepare( $sql );
+        $this->stmt = $pdo->prepare($sql);
 
-        $this->stmt->setFetchMode( \PDO::FETCH_CLASS, $salesman ? get_class($salesman) : Salesman::class );
+        $this->stmt->setFetchMode(\PDO::FETCH_CLASS, $salesman ? get_class($salesman) : Salesman::class);
 
         $bool = $this->stmt->execute();
 
-        $this->salesmen = $this->stmt->fetchAll( \PDO::FETCH_UNIQUE);
+        $this->salesmen = $this->stmt->fetchAll(\PDO::FETCH_UNIQUE);
     }
 
 
     /**
      * @implements ContainerInterface
      */
-    public function has ($aussendienst_nummer) {
+    public function has($aussendienst_nummer) {
         return array_key_exists($aussendienst_nummer, $this->salesmen);
     }
 
@@ -60,10 +60,10 @@ 
     /**
      * @implements ContainerInterface
      */
-    public function get ($aussendienst_nummer) {
+    public function get($aussendienst_nummer) {
         if (!$this->has($aussendienst_nummer)) {
             $msg = sprintf("Could not find Salesman with ADM-Nummer '%s'", $aussendienst_nummer);
-            throw new SalesmanNotFoundException( $msg );
+            throw new SalesmanNotFoundException($msg);
         }
 
         return $this->salesmen[$aussendienst_nummer];
@@ -75,7 +75,7 @@ 
      */
     public function getIterator()
     {
-        return new \ArrayIterator( $this->salesmen );
+        return new \ArrayIterator($this->salesmen);
     }
 
 
@@ -84,6 +84,6 @@ 
      */
     public function count()
     {
-        return count( $this->salesmen );
+        return count($this->salesmen);
     }
 }

src/SalesmanAbstract.php

Spacing +2 added lines, -2 removed lines

@@ -82,7 +82,7 @@ 
      */
     public function getFullName()
     {
-        return trim( join(" ", array_filter([
+        return trim(join(" ", array_filter([
             $this->getFirstName(),
             $this->getLastName()
         ])));
@@ -94,7 +94,7 @@ 
      */
     public function getDisplayName()
     {
-        return trim( join(" ∙ ", array_filter([
+        return trim(join(" ∙ ", array_filter([
             $this->getFullName(),
             $this->getSalesmanId()
         ])));

src/ApplySalesman.php

Spacing +4 added lines, -4 removed lines

@@ -18,7 +18,7 @@ 
     /**
      * @param callable $salesman_factory Callable that takes a Salesman ID that should return a SalesmanInterface instance.
      */
-    public function __construct( callable $salesman_factory, SalesmanInterface $salesman_fallback = null )
+    public function __construct(callable $salesman_factory, SalesmanInterface $salesman_fallback = null)
     {
         $this->salesman_factory  = $salesman_factory;
         $this->salesman_fallback = $salesman_fallback;
@@ -29,7 +29,7 @@ 
      * @param  object $aggregator Object that
      * @return bool
      */
-    public function __invoke( $aggregator )
+    public function __invoke($aggregator)
     {
 
         // Default value
@@ -44,10 +44,10 @@ 
 
         // If salesman_id is available
         if ($aggregator instanceOf SalesmanIdProviderInterface):
-            $aggregator->salesman = $salesman_factory( $aggregator->getSalesmanId(), $this->salesman_fallback );
+            $aggregator->salesman = $salesman_factory($aggregator->getSalesmanId(), $this->salesman_fallback);
 
         elseif (isset($aggregator->salesman_id)):
-            $aggregator->salesman = $salesman_factory( $aggregator->salesman_id, $this->salesman_fallback );
+            $aggregator->salesman = $salesman_factory($aggregator->salesman_id, $this->salesman_fallback);
 
         // Salesman can not be set
         else:

Braces +3 added lines, -1 removed lines

@@ -50,8 +50,10 @@
             $aggregator->salesman = $salesman_factory( $aggregator->salesman_id, $this->salesman_fallback );
 
         // Salesman can not be set
-        else:
+        else {
+            :
             return false;
+        }
         endif;
 
         return true;

src/IteratorApplySalesman.php

Spacing +4 added lines, -4 removed lines

@@ -32,10 +32,10 @@ 
      * @param SalesmanInterface $salesman_fallback Optional SalesmanInterface fallback instance
      * @param callable          $apply             Optional Callable that takes the current item on iteration.
      */
-    public function __construct( callable $salesman_factory, SalesmanInterface $salesman_fallback = null, callable $apply = null )
+    public function __construct(callable $salesman_factory, SalesmanInterface $salesman_fallback = null, callable $apply = null)
     {
         $this->salesman_factory = $salesman_factory;
-        $this->apply = $apply ?: new ApplySalesman( $salesman_factory, $salesman_fallback );
+        $this->apply = $apply ?: new ApplySalesman($salesman_factory, $salesman_fallback);
     }
 
 
@@ -44,7 +44,7 @@ 
      *
      * @see  http://php.net/manual/de/function.iterator-apply.php
      */
-    public function __invoke( \Traversable $iterator )
+    public function __invoke(\Traversable $iterator)
     {
 
         $current = ($iterator instanceOf \IteratorAggregate)
@@ -53,7 +53,7 @@ 
 
         // Perform
         $apply = $this->apply;
-        $apply( $current );
+        $apply($current);
 
         // Must return true for iterator_apply
         return true;