Gendoria / cruftflake

src/Gendoria/CruftFlake/Generator.php

Doc Comments +10 added lines

@@ -159,6 +159,11 @@ 
         return new GeneratorStatus($this->machine, $this->lastTime, $this->sequence, (PHP_INT_SIZE === 4));
     }
 
+    /**
+     * @param double $timestamp
+     * @param integer $machine
+     * @param integer $sequence
+     */
     private function mintId32($timestamp, $machine, $sequence)
     {
         $hi = (int) ($timestamp / pow(2, 10));
@@ -175,6 +180,11 @@ 
         return (string) $value;
     }
 
+    /**
+     * @param double $timestamp
+     * @param integer $machine
+     * @param integer $sequence
+     */
     private function mintId64($timestamp, $machine, $sequence)
     {
         $timestamp = (int) $timestamp;

Indentation +14 added lines, -14 removed lines

@@ -1,19 +1,19 @@
 <?php
 /**
- * Like the Twitter one.
- * 
- * 64 bits:
- * 
- * time - 41 bits (millisecond precision w/ a custom epoch gives us 69 years)
- * configured machine id - 10 bits - gives us up to 1024 machines
- * sequence number - 12 bits - rolls over every 4096 per machine (with protection to avoid rollover in the same ms)
- * 
- * 32 bits + 9 = 41 bits of time
- * 2199023255552 < milliseconds = 2199023255 seconds
- *                                2147483647 < max 31 bit int (signed)
- *
- * @author @davegardnerisme
- */
+     * Like the Twitter one.
+     * 
+     * 64 bits:
+     * 
+     * time - 41 bits (millisecond precision w/ a custom epoch gives us 69 years)
+     * configured machine id - 10 bits - gives us up to 1024 machines
+     * sequence number - 12 bits - rolls over every 4096 per machine (with protection to avoid rollover in the same ms)
+     * 
+     * 32 bits + 9 = 41 bits of time
+     * 2199023255552 < milliseconds = 2199023255 seconds
+     *                                2147483647 < max 31 bit int (signed)
+     *
+     * @author @davegardnerisme
+     */
 
 namespace Gendoria\CruftFlake;
 

Spacing +3 added lines, -3 removed lines

@@ -114,12 +114,12 @@ 
      */
     public function generate()
     {
-        $t = floor($this->timer->getUnixTimestamp() - $this->epoch);
+        $t = floor($this->timer->getUnixTimestamp()-$this->epoch);
         if ($t !== $this->lastTime) {
             if ($t < $this->lastTime) {
                 throw new UnexpectedValueException(
                         'Time moved backwards. We cannot generate IDs for '
-                        .($this->lastTime - $t).' milliseconds'
+                        .($this->lastTime-$t).' milliseconds'
                         );
             } elseif ($t < 0) {
                 throw new UnexpectedValueException(
@@ -186,7 +186,7 @@ 
     private function hexdec($hex)
     {
         $dec = 0;
-        for ($i = strlen($hex) - 1, $e = 1; $i >= 0; $i--, $e = bcmul($e, 16)) {
+        for ($i = strlen($hex)-1, $e = 1; $i >= 0; $i--, $e = bcmul($e, 16)) {
             $factor = self::$hexdec[$hex[$i]];
             $dec = bcadd($dec, bcmul($factor, $e));
         }

src/Gendoria/CruftFlake/Config/ConfigInterface.php

Indentation +6 added lines, -6 removed lines

@@ -1,11 +1,11 @@
 <?php
 /**
- * Cruft flake config interface.
- * 
- * Implement this if you want some other way to configure machines.
- * 
- * @author @davegardnerisme
- */
+     * Cruft flake config interface.
+     * 
+     * Implement this if you want some other way to configure machines.
+     * 
+     * @author @davegardnerisme
+     */
 
 namespace Gendoria\CruftFlake\Config;
 

src/Gendoria/CruftFlake/Config/FixedConfig.php

Indentation +8 added lines, -8 removed lines

@@ -1,13 +1,13 @@
 <?php
 /**
- * Fixed configuration.
- * 
- * This is designed to be used where each machine **knows** what its machine
- * ID is - eg: via some kind of automatically deployed configuration
- * (puppet etc.)
- * 
- * @author @davegardnerisme
- */
+     * Fixed configuration.
+     * 
+     * This is designed to be used where each machine **knows** what its machine
+     * ID is - eg: via some kind of automatically deployed configuration
+     * (puppet etc.)
+     * 
+     * @author @davegardnerisme
+     */
 
 namespace Gendoria\CruftFlake\Config;
 

src/Gendoria/CruftFlake/Config/ZooKeeperConfig.php

Spacing +1 added lines, -1 removed lines

@@ -102,7 +102,7 @@
         for ($i = 0; $i < 1024, $machineId === null; ++$i) {
             $machineNode = $this->machineToNode($i);
             if (in_array($machineNode, $children)) {
-                continue;   // already used
+                continue; // already used
             }
 
             // attempt to claim

src/Gendoria/CruftFlake/Timer/Timer.php

Indentation +4 added lines, -4 removed lines

@@ -1,9 +1,9 @@
 <?php
 /**
- * Cruft flake timer.
- * 
- * @author @davegardnerisme
- */
+     * Cruft flake timer.
+     * 
+     * @author @davegardnerisme
+     */
 
 namespace Gendoria\CruftFlake\Timer;
 

Doc Comments +1 added lines, -1 removed lines

@@ -14,7 +14,7 @@
      * 
      * (Number of whole milliseconds that have passed since 1970-01-01
      * 
-     * @return int
+     * @return double
      */
     public function getUnixTimestamp()
     {

src/Gendoria/CruftFlake/Timer/TimerInterface.php

Indentation +6 added lines, -6 removed lines

@@ -1,11 +1,11 @@
 <?php
 /**
- * Cruft flake timer interface.
- * 
- * Implement this if you want some other way to provide time.
- * 
- * @author @davegardnerisme
- */
+     * Cruft flake timer interface.
+     * 
+     * Implement this if you want some other way to provide time.
+     * 
+     * @author @davegardnerisme
+     */
 
 namespace Gendoria\CruftFlake\Timer;
 

src/Gendoria/CruftFlake/Zmq/ZmqServer.php

Indentation +4 added lines, -4 removed lines

@@ -1,9 +1,9 @@
 <?php
 /**
- * ZeroMQ interface for cruftflake.
- * 
- * @author @davegardnerisme
- */
+     * ZeroMQ interface for cruftflake.
+     * 
+     * @author @davegardnerisme
+     */
 
 namespace Gendoria\CruftFlake\Zmq;
 

src/Gendoria/CruftFlake/ServerInterface.php

Doc Comments +1 added lines

@@ -15,6 +15,7 @@
 {
     /**
      * Run CruftFlake server.
+     * @return void
      */
     public function run();
 }