Gendoria / cruftflake

src/Gendoria/CruftFlake/Generator.php

Doc Comments +10 added lines

@@ -159,6 +159,11 @@ 
         return new GeneratorStatus($this->machine, $this->lastTime, $this->sequence, (PHP_INT_SIZE === 4));
     }
 
+    /**
+     * @param double $timestamp
+     * @param integer $machine
+     * @param integer $sequence
+     */
     private function mintId32($timestamp, $machine, $sequence)
     {
         $hi = (int) ($timestamp / pow(2, 10));
@@ -175,6 +180,11 @@ 
         return (string) $value;
     }
 
+    /**
+     * @param double $timestamp
+     * @param integer $machine
+     * @param integer $sequence
+     */
     private function mintId64($timestamp, $machine, $sequence)
     {
         $timestamp = (int) $timestamp;

Indentation +14 added lines, -14 removed lines

@@ -1,19 +1,19 @@
 <?php
 /**
- * Like the Twitter one.
- * 
- * 64 bits:
- * 
- * time - 41 bits (millisecond precision w/ a custom epoch gives us 69 years)
- * configured machine id - 10 bits - gives us up to 1024 machines
- * sequence number - 12 bits - rolls over every 4096 per machine (with protection to avoid rollover in the same ms)
- * 
- * 32 bits + 9 = 41 bits of time
- * 2199023255552 < milliseconds = 2199023255 seconds
- *                                2147483647 < max 31 bit int (signed)
- *
- * @author @davegardnerisme
- */
+     * Like the Twitter one.
+     * 
+     * 64 bits:
+     * 
+     * time - 41 bits (millisecond precision w/ a custom epoch gives us 69 years)
+     * configured machine id - 10 bits - gives us up to 1024 machines
+     * sequence number - 12 bits - rolls over every 4096 per machine (with protection to avoid rollover in the same ms)
+     * 
+     * 32 bits + 9 = 41 bits of time
+     * 2199023255552 < milliseconds = 2199023255 seconds
+     *                                2147483647 < max 31 bit int (signed)
+     *
+     * @author @davegardnerisme
+     */
 
 namespace Gendoria\CruftFlake;
 

Tests/GeneratorTest.php

Doc Comments +7 added lines

@@ -27,12 +27,19 @@
         return new Generator($this->config, $this->timer);
     }
     
+    /**
+     * @param string $id
+     */
     private function assertId($id)
     {
         $this->assertTrue(is_string($id));
         $this->assertTrue(ctype_digit($id));
     }
     
+    /**
+     * @param string $v1
+     * @param string $v2
+     */
     private function assertReallyNotEquals($v1, $v2)
     {
         $this->assertTrue($v1 !== $v2);

Indentation +2 added lines, -2 removed lines

@@ -22,8 +22,8 @@
     private function buildSystemUnderTest()
     {
         $this->config->expects($this->once())
-                     ->method('getMachine')
-                     ->will($this->returnValue($this->machineId));
+                        ->method('getMachine')
+                        ->will($this->returnValue($this->machineId));
         return new Generator($this->config, $this->timer);
     }
     

Spacing +2 added lines, -2 removed lines

@@ -178,7 +178,7 @@ 
         $cf = $this->buildSystemUnderTest();
         
         $ids = array();
-        for ($i=0; $i<4095; $i++) {
+        for ($i = 0; $i < 4095; $i++) {
             $id = $cf->generate();
             $ids[$id] = 1;
         }
@@ -194,7 +194,7 @@ 
         $cf = $this->buildSystemUnderTest();
         
         $ids = array();
-        for ($i=0; $i<4096; $i++) {
+        for ($i = 0; $i < 4096; $i++) {
             $id = $cf->generate();
             $ids[$id] = 1;
         }

Tests/bootstrap.php

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 call_user_func(function() {
-    if ( ! is_file($autoloadFile = __DIR__.'/../vendor/autoload.php')) {
+    if (!is_file($autoloadFile = __DIR__.'/../vendor/autoload.php')) {
         throw new \LogicException('Could not find vendor/autoload.php. Did you forget to run "composer install --dev"?');
     }
     require $autoloadFile;

examples/client.php

Spacing +3 added lines, -3 removed lines

@@ -12,7 +12,7 @@ 
 require __DIR__.'/../vendor/autoload.php';
 
 $opts = getopt('n:p:');
-$n    = isset($opts['n']) ? (int)$opts['n'] : 1;
+$n    = isset($opts['n']) ? (int) $opts['n'] : 1;
 $n    = $n < 0 ? 1 : $n;
 $port = isset($opts['p']) ? $opts['p'] : 5599;
 
@@ -20,7 +20,7 @@ 
 $socket  = new \ZMQSocket($context, \ZMQ::SOCKET_REQ);
 $cf = new Gendoria\CruftFlake\Zmq\ZmqClient($context, $socket);
 
-for ($i=0; $i<$n; $i++) {
+for ($i = 0; $i < $n; $i++) {
     $id = $cf->generateId();
-    echo $id . "\n";
+    echo $id."\n";
 }
\ No newline at end of file

examples/server.php

Indentation +8 added lines, -8 removed lines

@@ -1,14 +1,14 @@
 #!/usr/bin/php
 <?php
 /**
- * Cruft flake - simple ZMQ req/rep loop
- *
- * Usage:
- *
- *  -p      ZeroMQ port to bind to, default 5599
- *  -z      ZooKeeper hostname:port to connect to, eg: localhost:2181
- *  -m      Specify a particular machine ID
- */
+     * Cruft flake - simple ZMQ req/rep loop
+     *
+     * Usage:
+     *
+     *  -p      ZeroMQ port to bind to, default 5599
+     *  -z      ZooKeeper hostname:port to connect to, eg: localhost:2181
+     *  -m      Specify a particular machine ID
+     */
 
 require __DIR__.'/../vendor/autoload.php';
 

src/Gendoria/CruftFlake/Config/ConfigInterface.php

Indentation +6 added lines, -6 removed lines

@@ -1,11 +1,11 @@
 <?php
 /**
- * Cruft flake config interface.
- * 
- * Implement this if you want some other way to configure machines.
- * 
- * @author @davegardnerisme
- */
+     * Cruft flake config interface.
+     * 
+     * Implement this if you want some other way to configure machines.
+     * 
+     * @author @davegardnerisme
+     */
 
 namespace Gendoria\CruftFlake\Config;
 

src/Gendoria/CruftFlake/Config/FixedConfig.php

Indentation +8 added lines, -8 removed lines

@@ -1,13 +1,13 @@
 <?php
 /**
- * Fixed configuration.
- * 
- * This is designed to be used where each machine **knows** what its machine
- * ID is - eg: via some kind of automatically deployed configuration
- * (puppet etc.)
- * 
- * @author @davegardnerisme
- */
+     * Fixed configuration.
+     * 
+     * This is designed to be used where each machine **knows** what its machine
+     * ID is - eg: via some kind of automatically deployed configuration
+     * (puppet etc.)
+     * 
+     * @author @davegardnerisme
+     */
 
 namespace Gendoria\CruftFlake\Config;
 

src/Gendoria/CruftFlake/Config/ZooKeeperConfig.php

Spacing +1 added lines, -1 removed lines

@@ -102,7 +102,7 @@
         for ($i = 0; $i < 1024, $machineId === null; ++$i) {
             $machineNode = $this->machineToNode($i);
             if (in_array($machineNode, $children)) {
-                continue;   // already used
+                continue; // already used
             }
 
             // attempt to claim

src/Gendoria/CruftFlake/Timer/Timer.php

Indentation +4 added lines, -4 removed lines

@@ -1,9 +1,9 @@
 <?php
 /**
- * Cruft flake timer.
- * 
- * @author @davegardnerisme
- */
+     * Cruft flake timer.
+     * 
+     * @author @davegardnerisme
+     */
 
 namespace Gendoria\CruftFlake\Timer;