Test Setup Failed
Push — master ( ba1326...42dcc7 )
by Stefan
05:59
created
core/DeviceConfig.php 1 patch
Spacing   +21 added lines, -21 removed lines patch added patch discarded remove patch
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
     protected function setSupportedEapMethods($eapArray)
86 86
     {
87 87
         $this->supportedEapMethods = $eapArray;
88
-        $this->loggerInstance->debug(4, "This device (" . __CLASS__ . ") supports the following EAP methods: ");
88
+        $this->loggerInstance->debug(4, "This device (".__CLASS__.") supports the following EAP methods: ");
89 89
         $this->loggerInstance->debug(4, $this->supportedEapMethods);
90 90
     }
91 91
 
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
                     break 2;
138 138
                 }
139 139
             }
140
-            $longestSuffix = $candidate . $longestSuffix;
140
+            $longestSuffix = $candidate.$longestSuffix;
141 141
         }
142 142
         return $longestSuffix;
143 143
     }
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
             throw new Exception("No EAP type available.");
176 176
         }
177 177
         $this->attributes = $this->getProfileAttributes($profile);
178
-        $this->deviceUUID = common\Entity::uuid('', 'CAT' . $profile->institution . "-" . $profile->identifier . "-" . $this->device_id);
178
+        $this->deviceUUID = common\Entity::uuid('', 'CAT'.$profile->institution."-".$profile->identifier."-".$this->device_id);
179 179
 
180 180
 
181 181
         // if we are instantiating a Silverbullet profile AND have been given
@@ -200,8 +200,8 @@  discard block
 block discarded – undo
200 200
         // create temporary directory, its full path will be saved in $this->FPATH;
201 201
         $tempDir = \core\common\Entity::createTemporaryDirectory($purpose);
202 202
         $this->FPATH = $tempDir['dir'];
203
-        mkdir($tempDir['dir'] . '/tmp');
204
-        chdir($tempDir['dir'] . '/tmp');
203
+        mkdir($tempDir['dir'].'/tmp');
204
+        chdir($tempDir['dir'].'/tmp');
205 205
         $caList = [];
206 206
         $x509 = new \core\common\X509();
207 207
         if (isset($this->attributes['eap:ca_file'])) {
@@ -233,7 +233,7 @@  discard block
 block discarded – undo
233 233
 
234 234
         $this->attributes['internal:consortia'] = $this->getConsortia();
235 235
         
236
-        if (isset($this->attributes['media:openroaming']) && substr($this->attributes['media:openroaming'][0],0,6) == "always" ) {
236
+        if (isset($this->attributes['media:openroaming']) && substr($this->attributes['media:openroaming'][0], 0, 6) == "always") {
237 237
             $this->attributes['internal:openroaming'] = TRUE;
238 238
         }
239 239
         // alternatively: if DeviceConfig was called after a user hitting the
@@ -250,7 +250,7 @@  discard block
 block discarded – undo
250 250
         $this->support_url_substitute = sprintf(_("your local %s support page"), \config\ConfAssistant::CONSORTIUM['display_name']);
251 251
 
252 252
         if ($this->signer && $this->options['sign']) {
253
-            $this->sign = ROOT . '/signer/' . $this->signer;
253
+            $this->sign = ROOT.'/signer/'.$this->signer;
254 254
         }
255 255
         $this->installerBasename = $this->getInstallerBasename();
256 256
         common\Entity::outOfThePotatoes();
@@ -310,10 +310,10 @@  discard block
 block discarded – undo
310 310
      */
311 311
     protected function findSourceFile($file)
312 312
     {
313
-        if (is_file($this->module_path . '/Files/' . $this->device_id . '/' . $file)) {
314
-            return $this->module_path . '/Files/' . $this->device_id . '/' . $file;
315
-        } elseif (is_file($this->module_path . '/Files/' . $file)) {
316
-            return $this->module_path . '/Files/' . $file;
313
+        if (is_file($this->module_path.'/Files/'.$this->device_id.'/'.$file)) {
314
+            return $this->module_path.'/Files/'.$this->device_id.'/'.$file;
315
+        } elseif (is_file($this->module_path.'/Files/'.$file)) {
316
+            return $this->module_path.'/Files/'.$file;
317 317
         } else {
318 318
             $this->loggerInstance->debug(2, "requested file $file does not exist\n");
319 319
             return FALSE;
@@ -437,19 +437,19 @@  discard block
 block discarded – undo
437 437
      */
438 438
     private function getInstallerBasename()
439 439
     {
440
-        $baseName = $this->customTranslit(\config\ConfAssistant::CONSORTIUM['name']) . "-" . $this->getDeviceId();
440
+        $baseName = $this->customTranslit(\config\ConfAssistant::CONSORTIUM['name'])."-".$this->getDeviceId();
441 441
         if (isset($this->attributes['profile:customsuffix'][1])) {
442 442
             // this string will end up as a filename on a filesystem, so always
443 443
             // take a latin-based language variant if available
444 444
             // and then scrub non-ASCII just in case
445
-            return $baseName . $this->customTranslit($this->attributes['profile:customsuffix'][1]);
445
+            return $baseName.$this->customTranslit($this->attributes['profile:customsuffix'][1]);
446 446
         }
447 447
         // Okay, no custom suffix. 
448 448
         // Use the configured inst name and apply shortening heuristics
449 449
         // if an instshortname is set, base on that, otherwise, the normal instname
450 450
         $attribToUse = (isset($this->attributes['general:instshortname']) ? 'general:instshortname' : 'general:instname');
451 451
         $lang_pointer = \config\Master::LANGUAGES[$this->languageInstance->getLang()]['latin_based'] == TRUE ? 0 : 1;
452
-        $this->loggerInstance->debug(5, "getInstallerBasename1:" . $this->attributes[$attribToUse][$lang_pointer] . "\n");
452
+        $this->loggerInstance->debug(5, "getInstallerBasename1:".$this->attributes[$attribToUse][$lang_pointer]."\n");
453 453
         $inst = $this->customTranslit($this->attributes[$attribToUse][$lang_pointer]);
454 454
         $this->loggerInstance->debug(4, "getInstallerBasename2:$inst\n");
455 455
         $Inst_a = explode('_', $inst);
@@ -464,10 +464,10 @@  discard block
 block discarded – undo
464 464
             if (!empty($this->attributes['profile:name']) && !empty($this->attributes['profile:name'][$lang_pointer])) {
465 465
                 $profTemp = $this->customTranslit($this->attributes['profile:name'][$lang_pointer]);
466 466
                 $prof = preg_replace('/_+$/', '', $profTemp);
467
-                return $baseName . $inst . '-' . $prof;
467
+                return $baseName.$inst.'-'.$prof;
468 468
             }
469 469
         }
470
-        return $baseName . $inst;
470
+        return $baseName.$inst;
471 471
     }
472 472
 
473 473
     /**
@@ -653,7 +653,7 @@  discard block
 block discarded – undo
653 653
                 $ext = 'unsupported';
654 654
             }
655 655
             $this->loggerInstance->debug(5, "saveLogoFile: $mime : $ext\n");
656
-            $fileName = 'logo-' . $type . $iterator . '.' . $ext;
656
+            $fileName = 'logo-'.$type.$iterator.'.'.$ext;
657 657
             $fileHandle = fopen($fileName, "w");
658 658
             if (!$fileHandle) {
659 659
                 $this->loggerInstance->debug(2, "saveLogoFile failed for: $fileName\n");
@@ -680,13 +680,13 @@  discard block
 block discarded – undo
680 680
         $mime = $finfo->buffer($blob);
681 681
         $ext = isset($this->mime_extensions[$mime]) ? $this->mime_extensions[$mime] : 'usupported';
682 682
         $this->loggerInstance->debug(5, "saveInfoFile: $mime : $ext\n");
683
-        $fileHandle = fopen('local-info.' . $ext, "w");
683
+        $fileHandle = fopen('local-info.'.$ext, "w");
684 684
         if ($fileHandle === FALSE) {
685 685
             throw new Exception("problem opening the file");
686 686
         }
687 687
         fwrite($fileHandle, $blob);
688 688
         fclose($fileHandle);
689
-        return(['name' => 'local-info.' . $ext, 'mime' => $ext]);
689
+        return(['name' => 'local-info.'.$ext, 'mime' => $ext]);
690 690
     }
691 691
 
692 692
     /**
@@ -740,9 +740,9 @@  discard block
 block discarded – undo
740 740
     {
741 741
         $outerId = NULL;
742 742
         if (isset($this->attributes['internal:use_anon_outer']) && $this->attributes['internal:use_anon_outer'][0] == "1" && isset($this->attributes['internal:realm'])) {
743
-            $outerId = "@" . $this->attributes['internal:realm'][0];
743
+            $outerId = "@".$this->attributes['internal:realm'][0];
744 744
             if (isset($this->attributes['internal:anon_local_value'])) {
745
-                $outerId = $this->attributes['internal:anon_local_value'][0] . $outerId;
745
+                $outerId = $this->attributes['internal:anon_local_value'][0].$outerId;
746 746
             }
747 747
         }
748 748
         return $outerId;
Please login to merge, or discard this patch.
devices/apple_mobileconfig/MobileconfigSuperclass.php 1 patch
Spacing   +50 added lines, -50 removed lines patch added patch discarded remove patch
@@ -179,15 +179,15 @@  discard block
 block discarded – undo
179 179
       <key>PayloadDescription</key>
180 180
          <string>$tagline</string>
181 181
       <key>PayloadDisplayName</key>
182
-         <string>" . \config\ConfAssistant::CONSORTIUM['display_name'] . "</string>
182
+         <string>".\config\ConfAssistant::CONSORTIUM['display_name']."</string>
183 183
       <key>PayloadIdentifier</key>
184
-         <string>" . self::IPHONE_PAYLOAD_PREFIX . ".$this->massagedConsortium.$this->massagedCountry.$this->massagedInst.$this->massagedProfile.$this->lang</string>
184
+         <string>" . self::IPHONE_PAYLOAD_PREFIX.".$this->massagedConsortium.$this->massagedCountry.$this->massagedInst.$this->massagedProfile.$this->lang</string>
185 185
       <key>PayloadOrganization</key>
186
-         <string>" . htmlspecialchars(iconv("UTF-8", "UTF-8//IGNORE", $this->attributes['general:instname'][0]), ENT_XML1, 'UTF-8') . ( $this->attributes['internal:profile_count'][0] > 1 ? " (" . htmlspecialchars(iconv("UTF-8", "UTF-8//IGNORE", $this->attributes['profile:name'][0]), ENT_XML1, 'UTF-8') . ")" : "") . "</string>
186
+         <string>".htmlspecialchars(iconv("UTF-8", "UTF-8//IGNORE", $this->attributes['general:instname'][0]), ENT_XML1, 'UTF-8').($this->attributes['internal:profile_count'][0] > 1 ? " (".htmlspecialchars(iconv("UTF-8", "UTF-8//IGNORE", $this->attributes['profile:name'][0]), ENT_XML1, 'UTF-8').")" : "")."</string>
187 187
       <key>PayloadType</key>
188 188
          <string>Configuration</string>
189 189
       <key>PayloadUUID</key>
190
-         <string>" . \core\common\Entity::uuid('', self::IPHONE_PAYLOAD_PREFIX . $this->massagedConsortium . $this->massagedCountry . $this->massagedInst . $this->massagedProfile) . "</string>
190
+         <string>" . \core\common\Entity::uuid('', self::IPHONE_PAYLOAD_PREFIX.$this->massagedConsortium.$this->massagedCountry.$this->massagedInst.$this->massagedProfile)."</string>
191 191
       <key>PayloadVersion</key>
192 192
          <integer>1</integer>";
193 193
         \core\common\Entity::outOfThePotatoes();
@@ -219,21 +219,21 @@  discard block
 block discarded – undo
219 219
     {
220 220
         \core\common\Entity::intoThePotatoes();
221 221
         if (isset($this->attributes['support:info_file'])) {
222
-            return MobileconfigSuperclass::BUFFER_CONSENT_PRE . htmlspecialchars(iconv("UTF-8", "UTF-8//TRANSLIT", $this->attributes['support:info_file'][0]), ENT_XML1, 'UTF-8') . MobileconfigSuperclass::BUFFER_CONSENT_POST;
222
+            return MobileconfigSuperclass::BUFFER_CONSENT_PRE.htmlspecialchars(iconv("UTF-8", "UTF-8//TRANSLIT", $this->attributes['support:info_file'][0]), ENT_XML1, 'UTF-8').MobileconfigSuperclass::BUFFER_CONSENT_POST;
223 223
         }
224 224
         if ($this->attributes['internal:verify_userinput_suffix'][0] != 0) {
225 225
             if ($this->attributes['internal:hint_userinput_suffix'][0] != 0) {
226
-                $retval = MobileconfigSuperclass::BUFFER_CONSENT_PRE . sprintf(_("Important Notice: your username MUST end exactly with '...@%s' !"), $this->attributes['internal:realm'][0]) . MobileconfigSuperclass::BUFFER_CONSENT_POST;
226
+                $retval = MobileconfigSuperclass::BUFFER_CONSENT_PRE.sprintf(_("Important Notice: your username MUST end exactly with '...@%s' !"), $this->attributes['internal:realm'][0]).MobileconfigSuperclass::BUFFER_CONSENT_POST;
227 227
                 \core\common\Entity::outOfThePotatoes();
228 228
                 return $retval;
229 229
             } else { 
230 230
             if (strlen($this->attributes['internal:realm'][0]) > 0) {
231 231
                 /// note space between variable and exclamation mark - makes sure users don't mistakenly think the exclamation mark is part of the required username!
232
-                $retval = MobileconfigSuperclass::BUFFER_CONSENT_PRE . sprintf(_("Important Notice: your username MUST contain an '@' and end with ...%s !"), $this->attributes['internal:realm'][0]) . MobileconfigSuperclass::BUFFER_CONSENT_POST;
232
+                $retval = MobileconfigSuperclass::BUFFER_CONSENT_PRE.sprintf(_("Important Notice: your username MUST contain an '@' and end with ...%s !"), $this->attributes['internal:realm'][0]).MobileconfigSuperclass::BUFFER_CONSENT_POST;
233 233
                 \core\common\Entity::outOfThePotatoes();
234 234
                 return $retval;
235 235
             }
236
-            $retval = MobileconfigSuperclass::BUFFER_CONSENT_PRE . _("Important Notice: your username MUST be in the form of xxx@yyy where the yyy is a common suffix identifying your Identity Provider. Please find out what to use there and enter the username in the correct format.") . MobileconfigSuperclass::BUFFER_CONSENT_POST;
236
+            $retval = MobileconfigSuperclass::BUFFER_CONSENT_PRE._("Important Notice: your username MUST be in the form of xxx@yyy where the yyy is a common suffix identifying your Identity Provider. Please find out what to use there and enter the username in the correct format.").MobileconfigSuperclass::BUFFER_CONSENT_POST;
237 237
             \core\common\Entity::outOfThePotatoes();
238 238
             return $retval;
239 239
             }
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
257 257
         // also escape htmlspecialchars
258 258
         // not all names and profiles have a name, so be prepared
259 259
 
260
-        $this->loggerInstance->debug(5, "List of available attributes: " . var_export($this->attributes, TRUE));
260
+        $this->loggerInstance->debug(5, "List of available attributes: ".var_export($this->attributes, TRUE));
261 261
 
262 262
         $this->instName = $this->attributes['general:instname'][0] ?? _("Unnamed Organisation");
263 263
         $this->profileName = $this->attributes['profile:name'][0] ?? _("Unnamed Profile");
@@ -299,7 +299,7 @@  discard block
 block discarded – undo
299 299
 
300 300
         file_put_contents('installer_profile', $outputXml);
301 301
 
302
-        $fileName = $this->installerBasename . '.mobileconfig';
302
+        $fileName = $this->installerBasename.'.mobileconfig';
303 303
 
304 304
         if (!$this->sign) {
305 305
             rename("installer_profile", $fileName);
@@ -307,7 +307,7 @@  discard block
 block discarded – undo
307 307
             return $fileName;
308 308
         }
309 309
         // still here? Then we are signing.
310
-        $signing = system($this->sign . " installer_profile '$fileName' > /dev/null");
310
+        $signing = system($this->sign." installer_profile '$fileName' > /dev/null");
311 311
         if ($signing === FALSE) {
312 312
             $this->loggerInstance->debug(2, "Signing the mobileconfig installer $fileName FAILED!\n");
313 313
         }
@@ -326,19 +326,19 @@  discard block
 block discarded – undo
326 326
         \core\common\Entity::intoThePotatoes();
327 327
         $ssidCount = count($this->attributes['internal:SSID']);
328 328
         $certCount = count($this->attributes['internal:CAs'][0]);
329
-        $out = "<p>" . _("For best results, please use the built-in browser (Safari) to open the configuration file.") . "</p>";
329
+        $out = "<p>"._("For best results, please use the built-in browser (Safari) to open the configuration file.")."</p>";
330 330
         $out .= "<p>";
331 331
         $out .= _("The profile will install itself after you click (or tap) the button. You will be asked for confirmation/input at several points:");
332 332
         $out .= "<ul>";
333
-        $out .= "<li>" . _("to install the profile") . "</li>";
334
-        $out .= "<li>" . ngettext("to accept the server certificate authority", "to accept the server certificate authorities", $certCount);
333
+        $out .= "<li>"._("to install the profile")."</li>";
334
+        $out .= "<li>".ngettext("to accept the server certificate authority", "to accept the server certificate authorities", $certCount);
335 335
         if ($certCount > 1) {
336
-            $out .= " " . sprintf(_("(%d times)"), $certCount);
336
+            $out .= " ".sprintf(_("(%d times)"), $certCount);
337 337
         }
338 338
         $out .= "</li>";
339
-        $out .= "<li>" . _("to enter the username and password you have been given by your organisation");
339
+        $out .= "<li>"._("to enter the username and password you have been given by your organisation");
340 340
         if ($ssidCount > 1) {
341
-            $out .= " " . sprintf(_("(%d times each, because %s is installed for %d SSIDs)"), $ssidCount, \config\ConfAssistant::CONSORTIUM['display_name'], $ssidCount);
341
+            $out .= " ".sprintf(_("(%d times each, because %s is installed for %d SSIDs)"), $ssidCount, \config\ConfAssistant::CONSORTIUM['display_name'], $ssidCount);
342 342
         }
343 343
         $out .= "</li>";
344 344
         $out .= "</ul>";
@@ -378,7 +378,7 @@  discard block
 block discarded – undo
378 378
                <key>ServiceProviderRoamingEnabled</key>
379 379
                <true/>
380 380
                <key>DisplayedOperatorName</key>
381
-               <string>" . $oiName . "</string>";
381
+               <string>" . $oiName."</string>";
382 382
         // if we don't know the realm, omit the entire DomainName key
383 383
         if (isset($this->attributes['internal:realm'])) {
384 384
             $retval .= "<key>DomainName</key>
@@ -391,7 +391,7 @@  discard block
 block discarded – undo
391 391
                 <array>";
392 392
 
393 393
         foreach ($consortiumOi as $oneCons) {
394
-            $retval .= "<string>" . strtoupper($oneCons) . "</string>";
394
+            $retval .= "<string>".strtoupper($oneCons)."</string>";
395 395
         }
396 396
 
397 397
         $retval .= "</array>";
@@ -429,7 +429,7 @@  discard block
 block discarded – undo
429 429
                   <dict>
430 430
                       <key>AcceptEAPTypes</key>
431 431
                          <array>
432
-                            <integer>" . $eapType['OUTER'] . "</integer>
432
+                            <integer>" . $eapType['OUTER']."</integer>
433 433
                          </array>
434 434
                       <key>EAPFASTProvisionPAC</key>
435 435
                             <true />
@@ -442,7 +442,7 @@  discard block
 block discarded – undo
442 442
 ";
443 443
         if ($realm !== NULL) {
444 444
             $retval .= "<key>OuterIdentity</key>
445
-                                    <string>" . htmlspecialchars($realm, ENT_XML1, 'UTF-8') . "</string>
445
+                                    <string>" . htmlspecialchars($realm, ENT_XML1, 'UTF-8')."</string>
446 446
 ";
447 447
         }
448 448
         $retval .= "<key>PayloadCertificateAnchorUUID</key>
@@ -466,11 +466,11 @@  discard block
 block discarded – undo
466 466
         $retval .= "
467 467
                          </array>";
468 468
         if ($eapType['INNER'] == \core\common\EAP::NE_SILVERBULLET) {
469
-            $retval .= "<key>UserName</key><string>" . $this->clientCert["certObject"]->username . "</string>";
469
+            $retval .= "<key>UserName</key><string>".$this->clientCert["certObject"]->username."</string>";
470 470
         }
471 471
         $retval .= "
472 472
                       <key>TTLSInnerAuthentication</key>
473
-                         <string>" . ($eapType['INNER'] == \core\common\EAP::NE_PAP ? "PAP" : "MSCHAPv2") . "</string>
473
+                         <string>" . ($eapType['INNER'] == \core\common\EAP::NE_PAP ? "PAP" : "MSCHAPv2")."</string>
474 474
                    </dict>";
475 475
         return $retval;
476 476
     }
@@ -490,9 +490,9 @@  discard block
 block discarded – undo
490 490
             // characters are still reversed, invert on use!
491 491
             $buffer .= "<string>Manual</string>
492 492
                   <key>ProxyServer</key>
493
-                  <string>" . strrev($serverAndPort[1]) . "</string>
493
+                  <string>" . strrev($serverAndPort[1])."</string>
494 494
                   <key>ProxyServerPort</key>
495
-                  <integer>" . strrev($serverAndPort[0]) . "</integer>
495
+                  <integer>" . strrev($serverAndPort[0])."</integer>
496 496
                   <key>ProxyPACFallbackAllowed</key>
497 497
                   <false/>";
498 498
         } else {
@@ -522,7 +522,7 @@  discard block
 block discarded – undo
522 522
                     throw new Exception("SSID must be a string!");
523 523
                 }
524 524
                 $escapedSSID = htmlspecialchars($toBeConfigured, ENT_XML1, 'UTF-8');
525
-                $payloadIdentifier = "wifi." . $this->serial;
525
+                $payloadIdentifier = "wifi.".$this->serial;
526 526
                 $payloadShortName = sprintf(_("%s - SSID %s"), $prettyName, $escapedSSID);
527 527
                 $payloadName = sprintf(_("%s configuration for network name %s"), $prettyName, $escapedSSID);
528 528
                 $encryptionTypeString = "WPA";
@@ -552,9 +552,9 @@  discard block
 block discarded – undo
552 552
                 if (count($toBeConfigured) == 0) {
553 553
                     return "";
554 554
                 }
555
-                $payloadIdentifier = "hs20.".implode('-',$toBeConfigured);
555
+                $payloadIdentifier = "hs20.".implode('-', $toBeConfigured);
556 556
                 $payloadShortName = sprintf(_("%s - RCOI"), $prettyName);
557
-                $payloadName = sprintf(_("%s configuration (Passpoint RCOI)"),$prettyName);
557
+                $payloadName = sprintf(_("%s configuration (Passpoint RCOI)"), $prettyName);
558 558
                 $encryptionTypeString = "WPA";
559 559
                 $setupModesString = "";
560 560
                 $wifiNetworkIdentification = $this->passPointBlock($toBeConfigured, $prettyName);
@@ -573,11 +573,11 @@  discard block
 block discarded – undo
573 573
                <key>PayloadDisplayName</key>
574 574
                   <string>$payloadShortName</string>
575 575
                <key>PayloadIdentifier</key>
576
-                  <string>" . self::IPHONE_PAYLOAD_PREFIX . ".$this->massagedConsortium.$this->massagedCountry.$this->massagedInst.$this->massagedProfile.$this->lang.$payloadIdentifier</string>
576
+                  <string>".self::IPHONE_PAYLOAD_PREFIX.".$this->massagedConsortium.$this->massagedCountry.$this->massagedInst.$this->massagedProfile.$this->lang.$payloadIdentifier</string>
577 577
                <key>PayloadOrganization</key>
578
-                  <string>" . $this->massagedConsortium . ".1x-config.org</string>
578
+                  <string>".$this->massagedConsortium.".1x-config.org</string>
579 579
                <key>PayloadType</key>
580
-                  <string>com.apple." . ($blocktype == MobileconfigSuperclass::NETWORK_BLOCK_TYPE_WIRED ? "firstactiveethernet" : "wifi") . ".managed</string>";
580
+                  <string>com.apple." . ($blocktype == MobileconfigSuperclass::NETWORK_BLOCK_TYPE_WIRED ? "firstactiveethernet" : "wifi").".managed</string>";
581 581
         $retval .= $this->proxySettings();
582 582
         $retval .= $setupModesString;
583 583
         if ($eapType['INNER'] == \core\common\EAP::NE_SILVERBULLET) {
@@ -589,7 +589,7 @@  discard block
 block discarded – undo
589 589
         }
590 590
         $retval .= "
591 591
                <key>PayloadUUID</key>
592
-                  <string>" . \core\common\Entity::uuid() . "</string>
592
+                  <string>" . \core\common\Entity::uuid()."</string>
593 593
                <key>PayloadVersion</key>
594 594
                   <integer>1</integer>
595 595
                   $wifiNetworkIdentification</dict>";
@@ -619,15 +619,15 @@  discard block
 block discarded – undo
619 619
 	<key>IsHotspot</key>
620 620
 	<false/>
621 621
 	<key>PayloadDescription</key>
622
-	<string>" . sprintf(_("This SSID should not be used after bootstrapping %s"), \config\ConfAssistant::CONSORTIUM['display_name']) . "</string>
622
+	<string>" . sprintf(_("This SSID should not be used after bootstrapping %s"), \config\ConfAssistant::CONSORTIUM['display_name'])."</string>
623 623
 	<key>PayloadDisplayName</key>
624
-	<string>" . _("Disabled WiFi network") . "</string>
624
+	<string>" . _("Disabled WiFi network")."</string>
625 625
 	<key>PayloadIdentifier</key>
626
-	<string>" . self::IPHONE_PAYLOAD_PREFIX . ".$this->massagedConsortium.$this->massagedCountry.$this->massagedInst.$this->massagedProfile.$this->lang.wifi.disabled.$this->removeSerial</string>
626
+	<string>" . self::IPHONE_PAYLOAD_PREFIX.".$this->massagedConsortium.$this->massagedCountry.$this->massagedInst.$this->massagedProfile.$this->lang.wifi.disabled.$this->removeSerial</string>
627 627
 	<key>PayloadType</key>
628 628
 	<string>com.apple.wifi.managed</string>
629 629
 	<key>PayloadUUID</key>
630
-	<string>" . \core\common\Entity::uuid() . "</string>
630
+	<string>".\core\common\Entity::uuid()."</string>
631 631
 	<key>PayloadVersion</key>
632 632
 	<real>1</real>";
633 633
         $retval .= $this->proxySettings();
@@ -707,12 +707,12 @@  discard block
 block discarded – undo
707 707
         $mimeBlob = base64_encode($binaryBlob);
708 708
         $mimeFormatted = chunk_split($mimeBlob, 52, "\r\n");
709 709
         $payloadUUID = \core\common\Entity::uuid('', $mimeBlob);
710
-        $retArray = ["block" => "<dict>" .
710
+        $retArray = ["block" => "<dict>".
711 711
             // we don't include the import password. It's displayed on screen, and should be input by the user.
712 712
             // <key>Password</key>
713 713
             //   <string>" . $this->clientCert['password'] . "</string>
714 714
             "<key>PayloadCertificateFileName</key>
715
-                     <string>" . $this->massagedConsortium . ".pfx</string>
715
+                     <string>" . $this->massagedConsortium.".pfx</string>
716 716
                   <key>PayloadContent</key>
717 717
                      <data>
718 718
 $mimeFormatted
@@ -720,7 +720,7 @@  discard block
 block discarded – undo
720 720
                   <key>PayloadDescription</key>
721 721
                      <string>MIME Base-64 encoded PKCS#12 Client Certificate</string>
722 722
                   <key>PayloadDisplayName</key>
723
-                     <string>" . _("User certificate") . "</string>
723
+                     <string>"._("User certificate")."</string>
724 724
                   <key>PayloadIdentifier</key>
725 725
                      <string>com.apple.security.pkcs12.$payloadUUID</string>
726 726
                   <key>PayloadType</key>
@@ -730,7 +730,7 @@  discard block
 block discarded – undo
730 730
                   <key>PayloadVersion</key>
731 731
                      <integer>1</integer>
732 732
                 </dict>",
733
-            "UUID" => $payloadUUID,];
733
+            "UUID" => $payloadUUID, ];
734 734
         \core\common\Entity::outOfThePotatoes();
735 735
         return $retArray;
736 736
     }
@@ -748,7 +748,7 @@  discard block
 block discarded – undo
748 748
         }
749 749
         $expiryTime = new \DateTime($this->clientCert['certObject']->expiry);
750 750
         return "<key>RemovalDate</key>
751
-        <date>" . $expiryTime->format("Y-m-d") . "T" . $expiryTime->format("H:i:s") . "Z</date>";
751
+        <date>" . $expiryTime->format("Y-m-d")."T".$expiryTime->format("H:i:s")."Z</date>";
752 752
     }
753 753
 
754 754
     /**
@@ -770,27 +770,27 @@  discard block
 block discarded – undo
770 770
             $stream = "
771 771
             <dict>
772 772
                <key>PayloadCertificateFileName</key>
773
-               <string>" . $ca['uuid'] . ".der</string>
773
+               <string>" . $ca['uuid'].".der</string>
774 774
                <key>PayloadContent</key>
775 775
                <data>
776
-" . $trimmedPem . "</data>
776
+" . $trimmedPem."</data>
777 777
                <key>PayloadDescription</key>
778
-               <string>" . sprintf(_("The %s Certification Authority"), \core\common\Entity::$nomenclature_inst) . "</string>
778
+               <string>" . sprintf(_("The %s Certification Authority"), \core\common\Entity::$nomenclature_inst)."</string>
779 779
                <key>PayloadDisplayName</key>
780 780
                <string>" . 
781 781
                     /// example: "Identity Provider CA #1 (Root)"
782
-                    sprintf(_("%s CA #%d (%s)" ), 
782
+                    sprintf(_("%s CA #%d (%s)"), 
783 783
                             \core\common\Entity::$nomenclature_inst, 
784
-                            count($this->CAsAccountedFor)+1, 
785
-                            ($ca['root'] ? _("Root") : _("Intermediate"))) . 
784
+                            count($this->CAsAccountedFor) + 1, 
785
+                            ($ca['root'] ? _("Root") : _("Intermediate"))). 
786 786
               "</string>
787 787
                <key>PayloadIdentifier</key>
788
-               <string>" . self::IPHONE_PAYLOAD_PREFIX . ".$this->massagedConsortium.$this->massagedCountry.$this->massagedInst.$this->massagedProfile.credential.$this->caSerial</string>
788
+               <string>" . self::IPHONE_PAYLOAD_PREFIX.".$this->massagedConsortium.$this->massagedCountry.$this->massagedInst.$this->massagedProfile.credential.$this->caSerial</string>
789 789
                <key>PayloadOrganization</key>
790
-               <string>" . $this->massagedConsortium . ".1x-config.org</string>
790
+               <string>".$this->massagedConsortium.".1x-config.org</string>
791 791
                <key>PayloadType</key>
792 792
                <string>com.apple.security.root</string>
793
-               <key>PayloadUUID</key><string>" . $ca['uuid'] . "</string>
793
+               <key>PayloadUUID</key><string>" . $ca['uuid']."</string>
794 794
                <key>PayloadVersion</key>
795 795
                <integer>1</integer>
796 796
             </dict>";
Please login to merge, or discard this patch.