Passed
Push — master ( 786596...2cdad9 )
by Stefan
13:57
created
web/lib/admin/OptionParser.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
 ?>
27 27
 <?php
28 28
 
29
-require_once dirname(dirname(dirname(dirname(__FILE__)))) . "/config/_config.php";
29
+require_once dirname(dirname(dirname(dirname(__FILE__))))."/config/_config.php";
30 30
 
31 31
 /**
32 32
  * This class parses HTML field input from POST and FILES and extracts valid and authorized options to be set.
@@ -344,14 +344,14 @@  discard block
 block discarded – undo
344 344
                     case \core\Options::TYPECODE_TEXT:
345 345
                     case \core\Options::TYPECODE_COORDINATES:
346 346
                     case \core\Options::TYPECODE_INTEGER:
347
-                        $varName = "$objId-" . $validators[$optioninfo['type']]['field'];
347
+                        $varName = "$objId-".$validators[$optioninfo['type']]['field'];
348 348
                         if (!empty($listOfEntries[$varName])) {
349 349
                             $content = call_user_func_array([$this->validator, $validators[$optioninfo['type']]['function']], array_merge([$listOfEntries[$varName]], $validators[$optioninfo['type']]['extraarg']));
350 350
                             break;
351 351
                         }
352 352
                         continue 2;
353 353
                     case \core\Options::TYPECODE_BOOLEAN:
354
-                        $varName = "$objId-" . \core\Options::TYPECODE_BOOLEAN;
354
+                        $varName = "$objId-".\core\Options::TYPECODE_BOOLEAN;
355 355
                         if (!empty($listOfEntries[$varName])) {
356 356
                             $contentValid = $this->validator->boolean($listOfEntries[$varName]);
357 357
                             if ($contentValid) {
@@ -364,24 +364,24 @@  discard block
 block discarded – undo
364 364
                         }
365 365
                         continue 2;
366 366
                     case \core\Options::TYPECODE_STRING:
367
-                        if (!empty($listOfEntries["$objId-" . \core\Options::TYPECODE_STRING])) {
367
+                        if (!empty($listOfEntries["$objId-".\core\Options::TYPECODE_STRING])) {
368 368
                             switch ($objValue) {
369 369
                                 case "media:consortium_OI":
370
-                                    $content = $this->validator->consortiumOI($listOfEntries["$objId-" . \core\Options::TYPECODE_STRING]);
370
+                                    $content = $this->validator->consortiumOI($listOfEntries["$objId-".\core\Options::TYPECODE_STRING]);
371 371
                                     if ($content === FALSE) {
372 372
                                         $bad[] = $objValue;
373 373
                                         continue 3;
374 374
                                     }
375 375
                                     break;
376 376
                                 case "media:remove_SSID":
377
-                                    $content = $this->validator->string($listOfEntries["$objId-" . \core\Options::TYPECODE_STRING]);
377
+                                    $content = $this->validator->string($listOfEntries["$objId-".\core\Options::TYPECODE_STRING]);
378 378
                                     if ($content == "eduroam") {
379 379
                                         $bad[] = $objValue;
380 380
                                         continue 3;
381 381
                                     }
382 382
                                     break;
383 383
                                 case "media:force_proxy":
384
-                                    $content = $this->validator->string($listOfEntries["$objId-" . \core\Options::TYPECODE_STRING]);
384
+                                    $content = $this->validator->string($listOfEntries["$objId-".\core\Options::TYPECODE_STRING]);
385 385
                                     $serverAndPort = explode(':', strrev($content), 2);
386 386
                                     if (count($serverAndPort) != 2) {
387 387
                                         $bad[] = $objValue;
@@ -394,40 +394,40 @@  discard block
 block discarded – undo
394 394
                                     }
395 395
                                     break;
396 396
                                 case "support:url":
397
-                                    $content = $this->validator->string($listOfEntries["$objId-" . \core\Options::TYPECODE_STRING]);
398
-                                    if (preg_match("/^http/",$content) != 1) {
397
+                                    $content = $this->validator->string($listOfEntries["$objId-".\core\Options::TYPECODE_STRING]);
398
+                                    if (preg_match("/^http/", $content) != 1) {
399 399
                                         $bad[] = $objValue;
400 400
                                         continue 3;
401 401
                                     }
402 402
                                     break;
403 403
                                 case "support:email":
404
-                                    $content = $this->validator->email($listOfEntries["$objId-" . \core\Options::TYPECODE_STRING]);
404
+                                    $content = $this->validator->email($listOfEntries["$objId-".\core\Options::TYPECODE_STRING]);
405 405
                                     if ($content === FALSE) {
406 406
                                         $bad[] = $objValue;
407 407
                                         continue 3;
408 408
                                     }
409 409
                                     break;
410 410
                                 case "managedsp:operatorname":
411
-                                    $content = $listOfEntries["$objId-" . \core\Options::TYPECODE_STRING];
411
+                                    $content = $listOfEntries["$objId-".\core\Options::TYPECODE_STRING];
412 412
                                     if (!preg_match("/^1.*\..*/", $content)) {
413 413
                                         $bad[] = $objValue;
414 414
                                         continue 3;
415 415
                                     }
416 416
                                     break;
417 417
                                 default:
418
-                                    $content = $this->validator->string($listOfEntries["$objId-" . \core\Options::TYPECODE_STRING]);
418
+                                    $content = $this->validator->string($listOfEntries["$objId-".\core\Options::TYPECODE_STRING]);
419 419
                                     break;
420 420
                             }
421 421
                             break;
422 422
                         }
423 423
                         continue 2;
424 424
                     case \core\Options::TYPECODE_FILE:
425
-                        if (!empty($listOfEntries["$objId-" . \core\Options::TYPECODE_STRING])) { // was already in, by ROWID reference, extract
425
+                        if (!empty($listOfEntries["$objId-".\core\Options::TYPECODE_STRING])) { // was already in, by ROWID reference, extract
426 426
                             // ROWID means it's a multi-line string (simple strings are inline in the form; so allow whitespace)
427
-                            $content = $this->validator->string(urldecode($listOfEntries["$objId-" . \core\Options::TYPECODE_STRING]), TRUE);
427
+                            $content = $this->validator->string(urldecode($listOfEntries["$objId-".\core\Options::TYPECODE_STRING]), TRUE);
428 428
                             break;
429
-                        } else if (isset($listOfEntries["$objId-" . \core\Options::TYPECODE_FILE]) && ($listOfEntries["$objId-" . \core\Options::TYPECODE_FILE] != "")) { // let's do the download
430
-                            $rawContent = \core\common\OutsideComm::downloadFile("file:///" . $listOfEntries["$objId-" . \core\Options::TYPECODE_FILE]);
429
+                        } else if (isset($listOfEntries["$objId-".\core\Options::TYPECODE_FILE]) && ($listOfEntries["$objId-".\core\Options::TYPECODE_FILE] != "")) { // let's do the download
430
+                            $rawContent = \core\common\OutsideComm::downloadFile("file:///".$listOfEntries["$objId-".\core\Options::TYPECODE_FILE]);
431 431
 
432 432
                             if ($rawContent === FALSE || !$this->checkUploadSanity($objValue, $rawContent)) {
433 433
                                 $bad[] = $objValue;
@@ -438,7 +438,7 @@  discard block
 block discarded – undo
438 438
                         }
439 439
                         continue 2;
440 440
                     default:
441
-                        throw new Exception("Internal Error: Unknown option type " . $objValue . "!");
441
+                        throw new Exception("Internal Error: Unknown option type ".$objValue."!");
442 442
                 }
443 443
                 // lang can be NULL here, if it's not a multilang attribute, or a ROWID reference. Never mind that.
444 444
                 $retval[] = ["$objValue" => ["lang" => $lang, "content" => $content]];
Please login to merge, or discard this patch.