Passed
Push — release_2_1 ( 84cf16...142ae1 )
by Stefan
10:55
created
web/admin/overview_federation.php 1 patch
Spacing   +36 added lines, -36 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
  *          <base_url>/copyright.php after deploying the software
20 20
  */
21 21
 
22
-require_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
22
+require_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
23 23
 
24 24
 $deco = new \web\lib\admin\PageDecoration();
25 25
 $uiElements = new web\lib\admin\UIElements();
@@ -50,16 +50,16 @@  discard block
 block discarded – undo
50 50
     <div class="infobox">
51 51
         <h2><?php $tablecaption = _("Your Personal Information"); echo $tablecaption; ?></h2>
52 52
         <table>
53
-            <caption><?php echo $tablecaption;?></caption>
53
+            <caption><?php echo $tablecaption; ?></caption>
54 54
             <tr>
55
-                <th class="wai-invisible" scope="col"><?php echo _("Property Type");?></th>
56
-                <th class="wai-invisible" scope="col"><?php echo _("Language if applicable");?></th>
57
-                <th class="wai-invisible" scope="col"><?php echo _("Property Value");?></th>
55
+                <th class="wai-invisible" scope="col"><?php echo _("Property Type"); ?></th>
56
+                <th class="wai-invisible" scope="col"><?php echo _("Language if applicable"); ?></th>
57
+                <th class="wai-invisible" scope="col"><?php echo _("Property Value"); ?></th>
58 58
             </tr>            
59 59
             <?php echo $uiElements->infoblock($user->getAttributes(), "user", "User"); ?>
60 60
             <tr>
61 61
                 <td>
62
-                    <?php echo "" . _("Unique Identifier") ?>
62
+                    <?php echo ""._("Unique Identifier") ?>
63 63
                 </td>
64 64
                 <td>
65 65
                 </td>
@@ -71,14 +71,14 @@  discard block
 block discarded – undo
71 71
     </div>
72 72
 
73 73
     <form action='overview_certificates.php' method='GET' accept-charset='UTF-8'>
74
-        <button type='submit'><?php echo sprintf(_('RADIUS/TLS Certificate management'));?></button>
74
+        <button type='submit'><?php echo sprintf(_('RADIUS/TLS Certificate management')); ?></button>
75 75
     </form>
76 76
 
77 77
     <?php
78 78
     $mgmt = new \core\UserManagement();
79 79
 
80 80
     if (!$user->isFederationAdmin()) {
81
-        echo "<p>" . sprintf(_("You are not a %s manager."), $uiElements->nomenclatureFed) . "</p>";
81
+        echo "<p>".sprintf(_("You are not a %s manager."), $uiElements->nomenclatureFed)."</p>";
82 82
         echo $deco->footer();
83 83
         exit(0);
84 84
     }
@@ -92,16 +92,16 @@  discard block
 block discarded – undo
92 92
                 <?php $tablecaption2 = sprintf(_("%s Properties: %s"), $uiElements->nomenclatureFed, $thefed->name); echo $tablecaption2; ?>
93 93
             </h2>
94 94
             <table>
95
-            <caption><?php echo $tablecaption2;?></caption>
95
+            <caption><?php echo $tablecaption2; ?></caption>
96 96
             <tr>
97
-                <th class="wai-invisible" scope="col"><?php echo _("Property Type");?></th>
98
-                <th class="wai-invisible" scope="col"><?php echo _("Language if applicable");?></th>
99
-                <th class="wai-invisible" scope="col"><?php echo _("Property Value");?></th>
97
+                <th class="wai-invisible" scope="col"><?php echo _("Property Type"); ?></th>
98
+                <th class="wai-invisible" scope="col"><?php echo _("Language if applicable"); ?></th>
99
+                <th class="wai-invisible" scope="col"><?php echo _("Property Value"); ?></th>
100 100
             </tr>
101 101
                 <!-- fed properties -->
102 102
                 <tr>
103 103
                     <td>
104
-                        <?php echo "" . _("Country") ?>
104
+                        <?php echo ""._("Country") ?>
105 105
                     </td>
106 106
                     <td>
107 107
                     </td>
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
                     default:
183 183
                         throw new Exception("Error: unknown encryption status of invitation!?!");
184 184
                 }
185
-                echo $uiElements->boxRemark(ngettext("The invitation email was sent successfully.", "All invitation emails were sent successfully.", $counter) . " " . $cryptText, _("Sent successfully."));
185
+                echo $uiElements->boxRemark(ngettext("The invitation email was sent successfully.", "All invitation emails were sent successfully.", $counter)." ".$cryptText, _("Sent successfully."));
186 186
                 break;
187 187
             case "FAILURE":
188 188
                 echo $uiElements->boxError(_("No invitation email could be sent!"), _("Sending failure!"));
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
                     default:
203 203
                         throw new Exception("Error: unknown encryption status of invitation!?!");
204 204
                 }
205
-                echo $uiElements->boxWarning(sprintf(_("Some invitation emails were sent successfully (%s in total), the others failed."), $counter) . " " . $cryptText, _("Partial success."));
205
+                echo $uiElements->boxWarning(sprintf(_("Some invitation emails were sent successfully (%s in total), the others failed."), $counter)." ".$cryptText, _("Partial success."));
206 206
                 break;
207 207
             case "INVALIDSYNTAX":
208 208
                 echo $uiElements->boxError(_("The invitation email address was malformed, no invitation was sent!"), _("The invitation email address was malformed, no invitation was sent!"));
@@ -218,27 +218,27 @@  discard block
 block discarded – undo
218 218
     } else {
219 219
         $link = 'http://';
220 220
     }
221
-    $link .= $_SERVER['SERVER_NAME'] . $_SERVER['SCRIPT_NAME'];
221
+    $link .= $_SERVER['SERVER_NAME'].$_SERVER['SCRIPT_NAME'];
222 222
     $link = htmlspecialchars($link);
223 223
     if (\config\Master::FUNCTIONALITY_LOCATIONS['CONFASSISTANT_RADIUS'] == 'LOCAL' && \config\Master::FUNCTIONALITY_LOCATIONS['DIAGNOSTICS'] == 'LOCAL') {
224 224
         echo "<table><tr>
225
-                        <td>" . sprintf(_("Diagnose reachability and connection parameters of any %s %s"), \config\ConfAssistant::CONSORTIUM['display_name'], $uiElements->nomenclatureIdP) . "</td>
225
+                        <td>" . sprintf(_("Diagnose reachability and connection parameters of any %s %s"), \config\ConfAssistant::CONSORTIUM['display_name'], $uiElements->nomenclatureIdP)."</td>
226 226
                         <td><form method='post' action='../diag/action_realmcheck.php' accept-charset='UTF-8'>
227 227
                               <input type='hidden' name='comefrom' id='comefrom' value='$link'/>
228
-                              <button id='realmcheck' style='cursor:pointer;' type='submit'>" . _("Go!") . "</button>
228
+                              <button id='realmcheck' style='cursor:pointer;' type='submit'>"._("Go!")."</button>
229 229
                             </form>
230 230
                         </td>
231 231
                     </tr>
232 232
                     </table>";
233 233
     }
234 234
     if (\config\ConfAssistant::CONSORTIUM['name'] == 'eduroam') {
235
-        $helptext = "<h3>" . sprintf(_("Need help? Refer to the <a href='%s'>%s manual</a>"), "https://wiki.geant.org/x/qJg7Bw", $uiElements->nomenclatureFed) . "</h3>";
235
+        $helptext = "<h3>".sprintf(_("Need help? Refer to the <a href='%s'>%s manual</a>"), "https://wiki.geant.org/x/qJg7Bw", $uiElements->nomenclatureFed)."</h3>";
236 236
     } else {
237 237
         $helptext = "";
238 238
     }
239 239
     ?>
240 240
     <table class='user_overview' style='border:0px; width:unset'>
241
-        <caption><?php echo _("Participant Details");?></caption>
241
+        <caption><?php echo _("Participant Details"); ?></caption>
242 242
         <tr>
243 243
             <th scope='col' style="width:13em"><?php echo _("Configured / Visible / OpenRoaming"); ?></th>
244 244
             <th scope='col'><?php echo sprintf(_("%s Name"), $uiElements->nomenclatureParticipant); ?></th>
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
             $pending_invites = $mgmt->listPendingInvitations();
248 248
 
249 249
             if (\config\Master::DB['enforce-external-sync']) {
250
-                echo "<th scope='col'>" . sprintf(_("%s Database Sync Status"), \config\ConfAssistant::CONSORTIUM['display_name']) . "</th>";
250
+                echo "<th scope='col'>".sprintf(_("%s Database Sync Status"), \config\ConfAssistant::CONSORTIUM['display_name'])."</th>";
251 251
             }
252 252
             ?>
253 253
             <th scope='col'>
@@ -262,7 +262,7 @@  discard block
 block discarded – undo
262 262
         foreach ($feds as $onefed) {
263 263
             $thefed = new \core\Federation(strtoupper($onefed['value']));
264 264
             /// nomenclature for 'federation', federation name, nomenclature for 'inst'
265
-            echo "<tr><td colspan='8'><strong>" . sprintf(_("The following %s are in your %s %s:"), $uiElements->nomenclatureParticipant, $uiElements->nomenclatureFed, '<span style="color:green">' . $thefed->name . '</span>') . "</strong></td></tr>";
265
+            echo "<tr><td colspan='8'><strong>".sprintf(_("The following %s are in your %s %s:"), $uiElements->nomenclatureParticipant, $uiElements->nomenclatureFed, '<span style="color:green">'.$thefed->name.'</span>')."</strong></td></tr>";
266 266
 
267 267
             // extract only pending invitations for *this* fed
268 268
             $display_pendings = FALSE;
@@ -287,9 +287,9 @@  discard block
 block discarded – undo
287 287
                 // deployment status; need to dive into profiles for this
288 288
                 // show happy eyeballs if at least one profile is configured/showtime                    
289 289
                 echo "<td>";
290
-                echo ($idp_instance->maxProfileStatus() >= \core\IdP::PROFILES_CONFIGURED ? "C" : "-" ) 
290
+                echo ($idp_instance->maxProfileStatus() >= \core\IdP::PROFILES_CONFIGURED ? "C" : "-") 
291 291
                         . " " 
292
-                        . ($idp_instance->maxProfileStatus() >= \core\IdP::PROFILES_SHOWTIME ? "V" : "-" )
292
+                        . ($idp_instance->maxProfileStatus() >= \core\IdP::PROFILES_SHOWTIME ? "V" : "-")
293 293
                         . " "
294 294
                         . "<span style='color:";
295 295
                 switch ($idp_instance->maxOpenRoamingStatus()) {
@@ -324,23 +324,23 @@  discard block
 block discarded – undo
324 324
                     }
325 325
                 }
326 326
                 echo "<td style='vertical-align:top;'>
327
-                         <input type='hidden' name='inst' value='" . $index . "'>" . $idp_instance->name . (empty($listOfSilverbulletRealms) ? "" : "<ul><li>" ) . implode("</li><li>", $listOfSilverbulletRealms) . (empty($listOfSilverbulletRealms) ? "" : "</li><ul>" ) . "
327
+                         <input type='hidden' name='inst' value='" . $index."'>".$idp_instance->name.(empty($listOfSilverbulletRealms) ? "" : "<ul><li>").implode("</li><li>", $listOfSilverbulletRealms).(empty($listOfSilverbulletRealms) ? "" : "</li><ul>")."
328 328
                       </td>";
329 329
                 // external DB sync, if configured as being necessary
330 330
                 if (\config\Master::DB['enforce-external-sync']) {
331 331
                     echo "<td style='display: ruby;'>";
332 332
                     if ($readonly === FALSE) {
333
-                        echo "<form method='post' action='inc/manageDBLink.inc.php?inst_id=" . $idp_instance->identifier . "' onsubmit='popupRedirectWindow(this); return false;' accept-charset='UTF-8'>
334
-                                    <button type='submit'>" . _("Manage DB Link") . "</button></form>&nbsp;&nbsp;";
333
+                        echo "<form method='post' action='inc/manageDBLink.inc.php?inst_id=".$idp_instance->identifier."' onsubmit='popupRedirectWindow(this); return false;' accept-charset='UTF-8'>
334
+                                    <button type='submit'>" . _("Manage DB Link")."</button></form>&nbsp;&nbsp;";
335 335
                     }
336 336
                     switch ($idp_instance->getExternalDBSyncState()) {
337 337
                         case \core\IdP::EXTERNAL_DB_SYNCSTATE_NOTSUBJECTTOSYNCING:
338 338
                             break;
339 339
                         case \core\IdP::EXTERNAL_DB_SYNCSTATE_SYNCED:
340
-                            echo "<div class='acceptable'>" . _("Linked") . "</div>";
340
+                            echo "<div class='acceptable'>"._("Linked")."</div>";
341 341
                             break;
342 342
                         case \core\IdP::EXTERNAL_DB_SYNCSTATE_NOT_SYNCED:
343
-                            echo "<div class='notacceptable'>" . _("NOT linked") . "</div>";
343
+                            echo "<div class='notacceptable'>"._("NOT linked")."</div>";
344 344
 
345 345
 
346 346
                             break;
@@ -353,9 +353,9 @@  discard block
 block discarded – undo
353 353
                 echo "<td style='vertical-align: top;'>";
354 354
                 if ($readonly === FALSE) {
355 355
                     echo "<div style='white-space: nowrap;'>
356
-                                  <form method='post' action='inc/manageAdmins.inc.php?inst_id=" . $index . "' onsubmit='popupRedirectWindow(this); return false;' accept-charset='UTF-8'>
356
+                                  <form method='post' action='inc/manageAdmins.inc.php?inst_id=" . $index."' onsubmit='popupRedirectWindow(this); return false;' accept-charset='UTF-8'>
357 357
                                       <button type='submit'>" .
358
-                    _("Add/Remove Administrators") . "
358
+                    _("Add/Remove Administrators")."
359 359
                                       </button>
360 360
                                   </form>
361 361
                                 </div>";
@@ -368,7 +368,7 @@  discard block
 block discarded – undo
368 368
                 echo "<tr>
369 369
                             <td colspan='2'>
370 370
                                <strong>" .
371
-                sprintf(_("Pending invitations in the %s:"), $uiElements->nomenclatureFed) . "
371
+                sprintf(_("Pending invitations in the %s:"), $uiElements->nomenclatureFed)."
372 372
                                </strong>
373 373
                             </td>
374 374
                          </tr>";
@@ -376,16 +376,16 @@  discard block
 block discarded – undo
376 376
                     if (strtoupper($oneinvite['country']) == strtoupper($thefed->tld)) {
377 377
                         echo "<tr>
378 378
                                     <td>" .
379
-                        $oneinvite['name'] . "
379
+                        $oneinvite['name']."
380 380
                                     </td>
381 381
                                     <td>" .
382
-                        $oneinvite['mail'] . "
382
+                        $oneinvite['mail']."
383 383
                                     </td>
384 384
                                     <td colspan=2>";
385 385
                         if ($readonly === FALSE) {
386 386
                             echo "<form method='post' action='overview_federation.php' accept-charset='UTF-8'>
387
-                                <input type='hidden' name='invitation_id' value='" . $oneinvite['token'] . "'/>
388
-                                <button class='delete' type='submit' name='submitbutton' value='" . web\lib\common\FormElements::BUTTON_DELETE . "'>" . _("Revoke Invitation") . "</button> "
387
+                                <input type='hidden' name='invitation_id' value='" . $oneinvite['token']."'/>
388
+                                <button class='delete' type='submit' name='submitbutton' value='" . web\lib\common\FormElements::BUTTON_DELETE."'>"._("Revoke Invitation")."</button> "
389 389
                             . sprintf(_("(expires %s)"), $oneinvite['expiry'])
390 390
                             . "</form>";
391 391
                         }
Please login to merge, or discard this patch.