Test Failed
Push — master ( 4f846d...3b7bab )
by Tomasz
11:17
created
web/admin/overview_org.php 1 patch
Spacing   +52 added lines, -52 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
  */
27 27
 ?>
28 28
 <?php
29
-require_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
29
+require_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
30 30
 
31 31
 function displaySilverbulletPropertyWidget(&$theProfile, $readonly, &$uiElements) {
32 32
     ?>
@@ -43,14 +43,14 @@  discard block
 block discarded – undo
43 43
                 <ul style='margin:1px'>
44 44
                     <?php
45 45
                     foreach ($completeness as $missing_attrib) {
46
-                        echo "<li>" . $uiElements->displayName($missing_attrib) . "</li>";
46
+                        echo "<li>".$uiElements->displayName($missing_attrib)."</li>";
47 47
                     }
48 48
                     ?>
49 49
                 </ul>
50 50
             </div>
51 51
             <?php
52 52
         } else {
53
-            echo sprintf(_("You can create up to %d users."), $maxusers[0]['value']) . "<br/>" . sprintf(_("Their credentials will carry the name <strong>%s</strong>."), $theProfile->realm);
53
+            echo sprintf(_("You can create up to %d users."), $maxusers[0]['value'])."<br/>".sprintf(_("Their credentials will carry the name <strong>%s</strong>."), $theProfile->realm);
54 54
         }
55 55
         ?>
56 56
         <br/>
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
         if ($readonly === FALSE) {
60 60
             ?>
61 61
             <form action='edit_silverbullet.php?inst_id=<?php echo $theProfile->institution; ?>&amp;profile_id=<?php echo $theProfile->identifier; ?>' method='POST'>
62
-                <button <?php echo ( is_array($completeness) ? "disabled" : "" ); ?> type='submit' name='sb_action' value='sb_edit'><?php echo _("Manage User Base"); ?></button>
62
+                <button <?php echo (is_array($completeness) ? "disabled" : ""); ?> type='submit' name='sb_action' value='sb_edit'><?php echo _("Manage User Base"); ?></button>
63 63
             </form>
64 64
             <?php
65 65
         }
@@ -95,21 +95,21 @@  discard block
 block discarded – undo
95 95
                 $has_overrides = TRUE;
96 96
             }
97 97
         }
98
-        $buffer_eaptypediv = "<div style='margin-bottom:40px; float:left;'>" . _("<strong>EAP Types</strong> (in order of preference):") . "<br/>";
98
+        $buffer_eaptypediv = "<div style='margin-bottom:40px; float:left;'>"._("<strong>EAP Types</strong> (in order of preference):")."<br/>";
99 99
         $typelist = $theProfile->getEapMethodsinOrderOfPreference();
100 100
         $allcomplete = TRUE;
101 101
         foreach ($typelist as $eaptype) {
102 102
             $buffer_eaptypediv .= $eaptype->getPrintableRep();
103 103
             $completeness = $theProfile->isEapTypeDefinitionComplete($eaptype);
104 104
             if ($completeness === true) {
105
-                $buffer_eaptypediv .= " <div class='acceptable'>" . _("OK") . "</div>";
105
+                $buffer_eaptypediv .= " <div class='acceptable'>"._("OK")."</div>";
106 106
             } else {
107 107
                 $buffer_eaptypediv .= " <div class='notacceptable'>";
108 108
                 $buffer_eaptypediv .= _("Information needed!");
109 109
                 if (is_array($completeness)) {
110 110
                     $buffer_eaptypediv .= "<ul style='margin:1px'>";
111 111
                     foreach ($completeness as $missing_attrib) {
112
-                        $buffer_eaptypediv .= "<li>" . $uiElements->displayName($missing_attrib) . "</li>";
112
+                        $buffer_eaptypediv .= "<li>".$uiElements->displayName($missing_attrib)."</li>";
113 113
                     }
114 114
                     $buffer_eaptypediv .= "</ul>";
115 115
                 }
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
             foreach ($attribs as $attrib) {
122 122
                 if ($attrib['level'] == \core\Options::LEVEL_METHOD && !preg_match("/^internal:/", $attrib['name']) && !$justOnce) {
123 123
                     $justOnce = TRUE;
124
-                    $buffer_eaptypediv .= "<img src='../resources/images/icons/Tabler/square-rounded-letter-e-blue.svg' alt='" . _("Options on EAP Method/Device level are in effect.") . "'>";
124
+                    $buffer_eaptypediv .= "<img src='../resources/images/icons/Tabler/square-rounded-letter-e-blue.svg' alt='"._("Options on EAP Method/Device level are in effect.")."'>";
125 125
                 }
126 126
             }
127 127
             $buffer_eaptypediv .= "<br/>";
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
         if ($theProfile->isRedirected()) {
148 148
             $iconData = $uiElements->iconData('PROFILES_REDIRECTED');
149 149
             $iconData['text'] = _("Profile redirected");
150
-            $buffer_headline .= "<br/>" . $uiElements->catIcon(($iconData));
150
+            $buffer_headline .= "<br/>".$uiElements->catIcon(($iconData));
151 151
             
152 152
         } 
153 153
         
@@ -155,15 +155,15 @@  discard block
 block discarded – undo
155 155
         switch ($certStatus) {
156 156
             case core\AbstractProfile::CERT_STATUS_OK:
157 157
                 $iconData = $uiElements->iconData('CERT_STATUS_OK');
158
-                $buffer_headline .= "<br/>" . $uiElements->catIcon(($iconData));
158
+                $buffer_headline .= "<br/>".$uiElements->catIcon(($iconData));
159 159
                 break;
160 160
             case core\AbstractProfile::CERT_STATUS_WARN:
161 161
                 $iconData = $uiElements->iconData('CERT_STATUS_WARN');
162
-                $buffer_headline .= "<br/>" . $uiElements->catIcon(($iconData));                
162
+                $buffer_headline .= "<br/>".$uiElements->catIcon(($iconData));                
163 163
                 break;
164 164
             case core\AbstractProfile::CERT_STATUS_ERROR:
165 165
                 $iconData = $uiElements->iconData('CERT_STATUS_ERROR');
166
-                $buffer_headline .= "<br/>" . $uiElements->catIcon(($iconData));
166
+                $buffer_headline .= "<br/>".$uiElements->catIcon(($iconData));
167 167
                 break;            
168 168
         }
169 169
         $buffer_headline .= "</div>";
@@ -189,11 +189,11 @@  discard block
 block discarded – undo
189 189
                 if (\config\Master::FUNCTIONALITY_LOCATIONS['DIAGNOSTICS'] == "LOCAL") {
190 190
                     $diagUrl = "../diag/";
191 191
                 } else {
192
-                    $diagUrl = \config\Master::FUNCTIONALITY_LOCATIONS['DIAGNOSTICS'] . "/diag/";
192
+                    $diagUrl = \config\Master::FUNCTIONALITY_LOCATIONS['DIAGNOSTICS']."/diag/";
193 193
                 }
194 194
                 ?>
195
-                <form action='<?php echo $diagUrl . "action_realmcheck.php?inst_id=" . $theProfile->institution . "&profile_id=" . $theProfile->identifier ?>' method='post' accept-charset='UTF-8'>
196
-                    <input type='hidden' name='comefrom' value='<?php echo htmlspecialchars($link . $_SERVER['SCRIPT_NAME']); ?>'/>
195
+                <form action='<?php echo $diagUrl."action_realmcheck.php?inst_id=".$theProfile->institution."&profile_id=".$theProfile->identifier ?>' method='post' accept-charset='UTF-8'>
196
+                    <input type='hidden' name='comefrom' value='<?php echo htmlspecialchars($link.$_SERVER['SCRIPT_NAME']); ?>'/>
197 197
                     <button type='submit' name='profile_action' value='check' <?php echo ($has_realm ? "" : "disabled='disabled'"); ?> title='<?php echo _("The realm can only be checked if you configure the realm!"); ?>'>
198 198
                         <?php echo _("Check realm reachability"); ?>
199 199
                     </button>
@@ -241,9 +241,9 @@  discard block
 block discarded – undo
241 241
                 ?>
242 242
                 <div style='display: flex;'>
243 243
                     <?php
244
-                    $idpLevelUrl = $link . dirname(dirname($_SERVER['SCRIPT_NAME'])) . "?idp=" . $theProfile->institution;
245
-                    $displayurl = $idpLevelUrl . "&amp;profile=" . $theProfile->identifier;
246
-                    $QRurl = $idpLevelUrl . "&profile=" . $theProfile->identifier;
244
+                    $idpLevelUrl = $link.dirname(dirname($_SERVER['SCRIPT_NAME']))."?idp=".$theProfile->institution;
245
+                    $displayurl = $idpLevelUrl."&amp;profile=".$theProfile->identifier;
246
+                    $QRurl = $idpLevelUrl."&profile=".$theProfile->identifier;
247 247
                     $qrCode = new \chillerlan\QRCode\QRCode(new \chillerlan\QRCode\QROptions([
248 248
                                 'outputType' => \chillerlan\QRCode\QRCode::OUTPUT_IMAGE_PNG,
249 249
                                 'eccLevel' => \chillerlan\QRCode\QRCode::ECC_H,
@@ -255,9 +255,9 @@  discard block
 block discarded – undo
255 255
                     if (empty($rawQr)) {
256 256
                         throw new Exception("Something went seriously wrong during QR code generation!");
257 257
                     }
258
-                    $uri = "data:image/png;base64," . base64_encode($uiElements->pngInjectConsortiumLogo($rawQr, web\lib\admin\UIElements::QRCODE_PIXELS_PER_SYMBOL));
258
+                    $uri = "data:image/png;base64,".base64_encode($uiElements->pngInjectConsortiumLogo($rawQr, web\lib\admin\UIElements::QRCODE_PIXELS_PER_SYMBOL));
259 259
                     $size = getimagesize($uri);
260
-                    echo "<img width='" . ($size[0] / 4) . "' height='" . ($size[1] / 4) . "' src='$uri' alt='QR-code'/>";
260
+                    echo "<img width='".($size[0] / 4)."' height='".($size[1] / 4)."' src='$uri' alt='QR-code'/>";
261 261
 
262 262
                     //echo "<nobr>$displayurl</nobr></a>";
263 263
                     echo "<p>$displayurl</p></a>";
@@ -301,7 +301,7 @@  discard block
 block discarded – undo
301 301
             <h2><?php
302 302
                 switch ($deploymentObject->consortium) {
303 303
                     case "eduroam":
304
-                        $displayname = config\ConfAssistant::CONSORTIUM['name'] . " " . core\DeploymentManaged::PRODUCTNAME;
304
+                        $displayname = config\ConfAssistant::CONSORTIUM['name']." ".core\DeploymentManaged::PRODUCTNAME;
305 305
                         break;
306 306
                     case "OpenRoaming":
307 307
                         $displayname = "OpenRoaming ANP";
@@ -309,7 +309,7 @@  discard block
 block discarded – undo
309 309
                     default:
310 310
                         throw new Exception("We are supposed to operate on a roaming consortium we don't know.");
311 311
                 }
312
-                echo $displayname . " (<span style='color:" . ( $deploymentObject->status == \core\AbstractDeployment::INACTIVE ? "red;'>" . _("inactive") : "green;'>" . _("active") ) . "</span>)";
312
+                echo $displayname." (<span style='color:".($deploymentObject->status == \core\AbstractDeployment::INACTIVE ? "red;'>"._("inactive") : "green;'>"._("active"))."</span>)";
313 313
                 ?></h2>
314 314
             <table>
315 315
                 <caption><?php echo _("Deployment Details"); ?></caption>
@@ -323,13 +323,13 @@  discard block
 block discarded – undo
323 323
                     <td><strong><?php echo _("Your primary RADIUS server") ?></strong><br/>
324 324
                         <?php
325 325
                         if ($deploymentObject->host1_v4 !== NULL) {
326
-                            echo _("IPv4") . ": " . $deploymentObject->host1_v4;
326
+                            echo _("IPv4").": ".$deploymentObject->host1_v4;
327 327
                         }
328 328
                         if ($deploymentObject->host1_v4 !== NULL && $deploymentObject->host1_v6 !== NULL) {
329 329
                             echo "<br/>";
330 330
                         }
331 331
                         if ($deploymentObject->host1_v6 !== NULL) {
332
-                            echo _("IPv6") . ": " . $deploymentObject->host1_v6;
332
+                            echo _("IPv6").": ".$deploymentObject->host1_v6;
333 333
                         }
334 334
                         ?>
335 335
                     </td>
@@ -337,9 +337,9 @@  discard block
 block discarded – undo
337 337
                     <td><?php echo $deploymentObject->port1; ?></td>
338 338
                     <td>
339 339
                         <?php
340
-                        echo "<img src='" . $radiusMessages[$deploymentObject->radius_status_1]['icon'] .
341
-                        "' alt='" . $radiusMessages[$deploymentObject->radius_status_1]['text'] .
342
-                        "' title='" . $radiusMessages[$deploymentObject->radius_status_1]['text'] . "' class='cat-icon'>";
340
+                        echo "<img src='".$radiusMessages[$deploymentObject->radius_status_1]['icon'].
341
+                        "' alt='".$radiusMessages[$deploymentObject->radius_status_1]['text'].
342
+                        "' title='".$radiusMessages[$deploymentObject->radius_status_1]['text']."' class='cat-icon'>";
343 343
                         ?>
344 344
                     </td>
345 345
                 </tr>
@@ -347,22 +347,22 @@  discard block
 block discarded – undo
347 347
                     <td><strong><?php echo _("Your backup RADIUS server") ?><br/></strong>
348 348
                         <?php
349 349
                         if ($deploymentObject->host2_v4 !== NULL) {
350
-                            echo _("IPv4") . ": " . $deploymentObject->host2_v4;
350
+                            echo _("IPv4").": ".$deploymentObject->host2_v4;
351 351
                         }
352 352
                         if ($deploymentObject->host2_v4 !== NULL && $deploymentObject->host2_v6 !== NULL) {
353 353
                             echo "<br/>";
354 354
                         }
355 355
                         if ($deploymentObject->host2_v6 !== NULL) {
356
-                            echo _("IPv6") . ": " . $deploymentObject->host2_v6;
356
+                            echo _("IPv6").": ".$deploymentObject->host2_v6;
357 357
                         }
358 358
                         ?></td>
359 359
                     <td><?php echo _("RADIUS port number: ") ?></td>
360 360
                     <td><?php echo $deploymentObject->port2; ?></td>
361 361
                     <td>
362 362
                         <?php
363
-                        echo "<img src='" . $radiusMessages[$deploymentObject->radius_status_2]['icon'] .
364
-                        "' alt='" . $radiusMessages[$deploymentObject->radius_status_2]['text'] .
365
-                        "' title='" . $radiusMessages[$deploymentObject->radius_status_2]['text'] . "' class='cat-icon'>";
363
+                        echo "<img src='".$radiusMessages[$deploymentObject->radius_status_2]['icon'].
364
+                        "' alt='".$radiusMessages[$deploymentObject->radius_status_2]['text'].
365
+                        "' title='".$radiusMessages[$deploymentObject->radius_status_2]['text']."' class='cat-icon'>";
366 366
                         ?>
367 367
                     </td>
368 368
                 </tr>
@@ -414,12 +414,12 @@  discard block
 block discarded – undo
414 414
                             if (array_key_exists('FAILURE', $res) && $res['FAILURE'] > 0) {
415 415
                                 echo '<br>';
416 416
                                 if ($res['FAILURE'] == 2) {
417
-                                    echo ' <span style="color: red;">' . _("Activation failure.") . '</span>';
417
+                                    echo ' <span style="color: red;">'._("Activation failure.").'</span>';
418 418
                                 } else {
419 419
                                     if (isset($_GET['res'][1]) && $_GET['res']['1'] == 'FAILURE') {
420
-                                        echo ' <span style="color: red;">' . _("Activation failure for your primary RADIUS server.") . '</span>';
420
+                                        echo ' <span style="color: red;">'._("Activation failure for your primary RADIUS server.").'</span>';
421 421
                                     } else {
422
-                                        echo ' <span style="color: red;">' . _("Activation failure for your backup RADIUS server.") . '</span>';
422
+                                        echo ' <span style="color: red;">'._("Activation failure for your backup RADIUS server.").'</span>';
423 423
                                     }
424 424
                                 }
425 425
                             }
@@ -454,12 +454,12 @@  discard block
 block discarded – undo
454 454
                                 if ($res['FAILURE'] > 0) {
455 455
                                     echo '<br>';
456 456
                                     if ($res['FAILURE'] == 2) {
457
-                                        echo ' <span style="color: red;">' . _("Failure during deactivation, your request is queued for handling") . '</span>';
457
+                                        echo ' <span style="color: red;">'._("Failure during deactivation, your request is queued for handling").'</span>';
458 458
                                     } else {
459 459
                                         if (isset($_GET['res'][1]) && $_GET['res']['1'] == 'FAILURE') {
460
-                                            echo ' <span style="color: red;">' . _("Deactivation failure for your primary RADIUS server, your request is queued.") . '</span>';
460
+                                            echo ' <span style="color: red;">'._("Deactivation failure for your primary RADIUS server, your request is queued.").'</span>';
461 461
                                         } else {
462
-                                            echo ' <span style="color: red;">' . _("Deactivation failure for your backup RADIUS server, your request is queued.") . '</span>';
462
+                                            echo ' <span style="color: red;">'._("Deactivation failure for your backup RADIUS server, your request is queued.").'</span>';
463 463
                                         }
464 464
                                     }
465 465
                                 }
@@ -480,24 +480,24 @@  discard block
 block discarded – undo
480 480
         </div>
481 481
         <div style='width:20px;'></div> <!-- QR code space, reserved -->
482 482
         <div style='display: table-cell; min-width:200px;'>
483
-            <?php $tablecaption = _("Hotspot Usage Statistics");?>
483
+            <?php $tablecaption = _("Hotspot Usage Statistics"); ?>
484 484
             <h1><?php echo $tablecaption; ?></h1>
485
-            <h2><?php echo _("5 most recent authentications");?></h2>
486
-            <p><?php echo _("(AP Identifier is a /-separated tuple of NAS-Identifier/NAS-IP-Address/NAS-IPv6-Address/Called-Station-Id)");?></p>
485
+            <h2><?php echo _("5 most recent authentications"); ?></h2>
486
+            <p><?php echo _("(AP Identifier is a /-separated tuple of NAS-Identifier/NAS-IP-Address/NAS-IPv6-Address/Called-Station-Id)"); ?></p>
487 487
             <table class='authrecord'>
488
-    <caption><?php echo $tablecaption;?></caption>
488
+    <caption><?php echo $tablecaption; ?></caption>
489 489
     <tr style='text-align: left;'>
490
-        <th scope="col"><strong><?php echo _("Timestamp (UTC)");?></strong></th>
491
-        <th scope="col"><strong><?php echo _("Realm");?></strong></th>
492
-        <th scope="col"><strong><?php echo _("MAC Address");?></strong></th>
493
-        <th scope="col"><strong><?php echo _("Chargeable-User-Identity");?></strong></th>
494
-        <th scope="col"><strong><?php echo _("Result");?></strong></th>
495
-        <th scope="col"><strong><?php echo _("AP Identifier");?></strong></th>
490
+        <th scope="col"><strong><?php echo _("Timestamp (UTC)"); ?></strong></th>
491
+        <th scope="col"><strong><?php echo _("Realm"); ?></strong></th>
492
+        <th scope="col"><strong><?php echo _("MAC Address"); ?></strong></th>
493
+        <th scope="col"><strong><?php echo _("Chargeable-User-Identity"); ?></strong></th>
494
+        <th scope="col"><strong><?php echo _("Result"); ?></strong></th>
495
+        <th scope="col"><strong><?php echo _("AP Identifier"); ?></strong></th>
496 496
     </tr>
497 497
     <?php
498
-    $userAuthData = $deploymentObject->retrieveStatistics(0,5);
498
+    $userAuthData = $deploymentObject->retrieveStatistics(0, 5);
499 499
     foreach ($userAuthData as $oneRecord) {
500
-        echo "<tr class='".($oneRecord['result'] == "OK" ? "auth-success" : "auth-fail" )."'>"
500
+        echo "<tr class='".($oneRecord['result'] == "OK" ? "auth-success" : "auth-fail")."'>"
501 501
                 . "<td>".$oneRecord['activity_time']."</td>"
502 502
                 . "<td>".$oneRecord['realm']."</td>"
503 503
                 . "<td>".$oneRecord['mac']."</td>"
@@ -660,7 +660,7 @@  discard block
 block discarded – undo
660 660
             }
661 661
             ?>
662 662
         </h2>
663
-    <?php if(count($profiles_for_this_idp) > 1 && $readonly === FALSE && $editMode === 'fullaccess') { ?>
663
+    <?php if (count($profiles_for_this_idp) > 1 && $readonly === FALSE && $editMode === 'fullaccess') { ?>
664 664
                     <form method='post' action='sort_profiles.php?inst_id=<?php echo $my_inst->identifier; ?>' accept-charset='UTF-8'>
665 665
                         <div>
666 666
                             <button type='submit' name='profile_sorting'>
@@ -728,7 +728,7 @@  discard block
 block discarded – undo
728 728
                         <div>
729 729
                             <input type="hidden" name="consortium" value="eduroam"/>
730 730
                             <button type='submit' <?php echo ($hasMail > 0 ? "" : "disabled"); ?> name='profile_action' value='new'>
731
-                                <?php echo sprintf(_("Add %s deployment ..."), \config\ConfAssistant::CONSORTIUM['name'] . " " . \core\DeploymentManaged::PRODUCTNAME); ?>
731
+                                <?php echo sprintf(_("Add %s deployment ..."), \config\ConfAssistant::CONSORTIUM['name']." ".\core\DeploymentManaged::PRODUCTNAME); ?>
732 732
                             </button>
733 733
                             <span style='color: red;'>
734 734
                             <?php if ($hasMail == 0) { 
Please login to merge, or discard this patch.
web/admin/duplicate_profile.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@
 block discarded – undo
27 27
 ?>
28 28
 
29 29
 <?php
30
-require_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
30
+require_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
31 31
 
32 32
 $deco = new \web\lib\admin\PageDecoration();
33 33
 $validator = new \web\lib\common\InputValidation();
Please login to merge, or discard this patch.
web/admin/duplicate_profile_result.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
 ?>
30 30
 
31 31
 <?php
32
-require_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
32
+require_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
33 33
 
34 34
 $deco = new \web\lib\admin\PageDecoration();
35 35
 $validator = new \web\lib\common\InputValidation();
@@ -101,13 +101,13 @@  discard block
 block discarded – undo
101 101
     } 
102 102
 }
103 103
 
104
-$newProfileName =  $validator->string($_POST['new_profile'], true);
104
+$newProfileName = $validator->string($_POST['new_profile'], true);
105 105
 $origProfileName = $validator->string($_POST['orig_profile_name'], true);
106 106
 $handle = \core\DBConnection::handle("INST");
107 107
 
108 108
 $result = runSelect($my_profile->identifier, $fields, 'profile', $handle);
109 109
 $row = $result->fetch_assoc();
110
-$row['showtime']= 0;
110
+$row['showtime'] = 0;
111 111
 $row['preference'] = 1000;
112 112
 copyRow($row, $fields, 'profile', $handle);
113 113
 $newProfileId = $handle->lastID();
Please login to merge, or discard this patch.