Passed
Push — release_2_0 ( 03c63b...4774b0 )
by Stefan
06:32
created
web/lib/user/TextTemplates.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
 const DOWNLOAD_REDIRECT_CONTINUE = 1054;
50 50
 const SB_GO_AWAY = 1060;
51 51
 const SB_FRONTPAGE_BIGDOWNLOADBUTTON = 1061;
52
-const SB_FRONTPAGE_ROLLER_CUSTOMBUILT= 1062;
52
+const SB_FRONTPAGE_ROLLER_CUSTOMBUILT = 1062;
53 53
 
54 54
 
55 55
 /**
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
         $this->templates[WELCOME_ABOARD_BACKTODOWNLOADS] = _("Back to downloads");
89 89
         $this->templates[EDUROAM_WELCOME_ADVERTISING] = sprintf(_("we would like to warmly welcome you among the several million users of %s! From now on, you will be able to use internet access resources on thousands of universities, research centres and other places all over the globe. All of this completely free of charge!"), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name']);
90 90
         $this->templates[HEADING_TOPLEVEL_GREET] = sprintf(_("Welcome to %s"), CONFIG['APPEARANCE']['productname']);
91
-        $this->templates[HEADING_TOPLEVEL_PURPOSE] = sprintf(_("Connect your device to %s"),CONFIG_CONFASSISTANT['CONSORTIUM']['display_name']);
91
+        $this->templates[HEADING_TOPLEVEL_PURPOSE] = sprintf(_("Connect your device to %s"), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name']);
92 92
         $this->templates[FRONTPAGE_ROLLER_EASY] = sprintf(_("%s installation made easy:"), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name']);
93 93
         $this->templates[FRONTPAGE_ROLLER_CUSTOMBUILT] = _("Custom built for your organisation");
94 94
         $this->templates[FRONTPAGE_BIGDOWNLOADBUTTON] = sprintf(_("Click here to download your %s installer"), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'], CONFIG_CONFASSISTANT['CONSORTIUM']['display_name']);
Please login to merge, or discard this patch.
web/skins/modern/Divs.php 1 patch
Spacing   +32 added lines, -32 removed lines patch added patch discarded remove patch
@@ -49,11 +49,11 @@  discard block
 block discarded – undo
49 49
         $location = $this->Gui->skinObject->findResourceUrl("IMAGES", "consortium_logo.png");
50 50
         if ($location !== FALSE) {
51 51
             $retval .= "<div id='cat_logo'>
52
-            <a href='" . CONFIG_CONFASSISTANT['CONSORTIUM']['homepage'] . "'><img id='logo_img' src='$location' alt='Consortium Logo'/></a>
52
+            <a href='" . CONFIG_CONFASSISTANT['CONSORTIUM']['homepage']."'><img id='logo_img' src='$location' alt='Consortium Logo'/></a>
53 53
             <span>Configuration Assistant Tool</span>
54 54
             </div>";
55 55
         }
56
-        $retval .= "<div id='motd'>" . (isset(CONFIG['APPEARANCE']['MOTD']) ? CONFIG['APPEARANCE']['MOTD'] : '&nbsp') . "</div>";
56
+        $retval .= "<div id='motd'>".(isset(CONFIG['APPEARANCE']['MOTD']) ? CONFIG['APPEARANCE']['MOTD'] : '&nbsp')."</div>";
57 57
         $loc2 = $this->Gui->skinObject->findResourceUrl("IMAGES", "icons/menu.png");
58 58
         if ($loc2 !== FALSE) {
59 59
             $retval .= "<img id='hamburger' src='$loc2' alt='Menu'/>";
@@ -71,13 +71,13 @@  discard block
 block discarded – undo
71 71
     public function div_user_welcome() {
72 72
         $retval = "
73 73
 <div id='user_welcome'> <!-- this information is shown just before the download -->
74
-    <strong>" . $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_PAGEHEADING] . "</strong>
74
+    <strong>" . $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_PAGEHEADING]."</strong>
75 75
     <p>
76 76
     <span id='download_info'>
77 77
     <!-- the empty href is dynamically exchanged with the actual path by jQuery at runtime -->
78
-        " . $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_DOWNLOAD] . "
78
+        " . $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_DOWNLOAD]."
79 79
     </span>
80
-    <p>" . $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_HEADING] . "
80
+    <p>" . $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_HEADING]."
81 81
     <br/>
82 82
     <br/>";
83 83
         switch (CONFIG_CONFASSISTANT['CONSORTIUM']['name']) {
@@ -87,11 +87,11 @@  discard block
 block discarded – undo
87 87
         }
88 88
         $retval .= "
89 89
     </p>
90
-    <p>" . $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_USAGE] . "
91
-    <p>" . $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_PROBLEMS] . "
90
+    <p>" . $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_USAGE]."
91
+    <p>" . $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_PROBLEMS]."
92 92
     </p>
93 93
     <p>
94
-    <a href='javascript:back_to_downloads()'><strong>" . $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_BACKTODOWNLOADS] . "</strong></a>
94
+    <a href='javascript:back_to_downloads()'><strong>" . $this->Gui->textTemplates->templates[user\WELCOME_ABOARD_BACKTODOWNLOADS]."</strong></a>
95 95
     </p>
96 96
 </div> <!-- id='user_welcomer_page' -->
97 97
 ";
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
     public function div_silverbullet() {
102 102
         $retval = "
103 103
 <div id='silverbullet'>"
104
-                . $this->Gui->textTemplates->templates[user\SB_GO_AWAY] .
104
+                . $this->Gui->textTemplates->templates[user\SB_GO_AWAY].
105 105
                 "</div>
106 106
     ";
107 107
         return $retval;
@@ -110,10 +110,10 @@  discard block
 block discarded – undo
110 110
     public function div_top_welcome() {
111 111
         return "
112 112
 <div id='welcome_top1'>
113
-    " . $this->Gui->textTemplates->templates[user\HEADING_TOPLEVEL_GREET] . "
113
+    " . $this->Gui->textTemplates->templates[user\HEADING_TOPLEVEL_GREET]."
114 114
 </div>
115 115
 <div id='top_invite'>
116
-    " . $this->Gui->textTemplates->templates[user\HEADING_TOPLEVEL_PURPOSE] . "
116
+    " . $this->Gui->textTemplates->templates[user\HEADING_TOPLEVEL_PURPOSE]."
117 117
 </div>";
118 118
     }
119 119
 
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
         $retval = "
122 122
 <div id='roller'>
123 123
     <div id='slides'>
124
-        <span id='line1'>" . $this->Gui->textTemplates->templates[user\FRONTPAGE_ROLLER_EASY] . "</span>
124
+        <span id='line1'>" . $this->Gui->textTemplates->templates[user\FRONTPAGE_ROLLER_EASY]."</span>
125 125
         <span id='line2'></span>
126 126
         <span id='line3'></span>
127 127
         <span id='line4'>";
@@ -176,9 +176,9 @@  discard block
 block discarded – undo
176 176
     public function div_profiles() {
177 177
         return "
178 178
 <div id='profiles'> <!-- this is the profile selection filled during run time -->
179
-    <div id='profiles_h' class='sub_h'>" . $this->Gui->textTemplates->templates[user\PROFILE_SELECTION] . "
179
+    <div id='profiles_h' class='sub_h'>" . $this->Gui->textTemplates->templates[user\PROFILE_SELECTION]."
180 180
     </div>" .
181
-                "<select id='profile_list'></select><div id='profile_desc' class='profile_desc'></div>" .
181
+                "<select id='profile_list'></select><div id='profile_desc' class='profile_desc'></div>".
182 182
                 "</div>";
183 183
     }
184 184
 
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
192 192
     public function div_institution($selectButton = TRUE) {
193 193
         $retval = "<div id='institution_name'>
194 194
     <span id='inst_name_span'></span> <div id='inst_extra_text'></div><!-- this will be filled with the IdP name -->" .
195
-                ($selectButton ? "<a  id='select_another' class='signin' href=\"\">" . $this->Gui->textTemplates->templates[user\INSTITUTION_SELECTION] . "</a>" : "") .
195
+                ($selectButton ? "<a  id='select_another' class='signin' href=\"\">".$this->Gui->textTemplates->templates[user\INSTITUTION_SELECTION]."</a>" : "").
196 196
                 "</div>";
197 197
         $retval .= $this->emptyImage('idp_logo', 'IdP Logo');
198 198
         return $retval;
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
     public function div_otherinstallers() {
207 207
         $retval = "
208 208
 <div class='sub_h'>
209
-    <div id='other_installers'>" . $this->Gui->textTemplates->templates[user\DOWNLOAD_CHOOSE] . "
209
+    <div id='other_installers'>" . $this->Gui->textTemplates->templates[user\DOWNLOAD_CHOOSE]."
210 210
          <table id='device_list' style='padding:0px;'>";
211 211
 
212 212
         foreach ($this->Gui->listDevices(isset($_REQUEST['hidden']) ? $_REQUEST['hidden'] : 0) as $group => $deviceGroup) {
@@ -214,18 +214,18 @@  discard block
 block discarded – undo
214 214
             $deviceIndex = 0;
215 215
 
216 216
             $imgTag = "";
217
-            $imgLocation = $this->Gui->skinObject->findResourceUrl("IMAGES", "vendorlogo/" . $group . ".png");
217
+            $imgLocation = $this->Gui->skinObject->findResourceUrl("IMAGES", "vendorlogo/".$group.".png");
218 218
             if ($imgLocation !== FALSE) {
219
-                $imgTag = '<img src="' . $imgLocation . '" alt="' . $group . ' Device" title="' . $group . ' Device">';
219
+                $imgTag = '<img src="'.$imgLocation.'" alt="'.$group.' Device" title="'.$group.' Device">';
220 220
             }
221
-            $retval .= '<tbody><tr><td class="vendor" rowspan="' . $groupIndex . '">' . $imgTag . '</td>';
221
+            $retval .= '<tbody><tr><td class="vendor" rowspan="'.$groupIndex.'">'.$imgTag.'</td>';
222 222
             foreach ($deviceGroup as $d => $D) {
223 223
                 if ($deviceIndex) {
224 224
                     $retval .= '<tr>';
225 225
                 }
226
-                $retval .= "<td><button id='" . $d . "'>" . $D['display'] . "</button>"
227
-                        . "<div class='device_info' id='info_" . $d . "'></div></td>"
228
-                        . "<td><button class='more_info_b' id='info_b_" . $d . "'>i</button></td></tr>\n";
226
+                $retval .= "<td><button id='".$d."'>".$D['display']."</button>"
227
+                        . "<div class='device_info' id='info_".$d."'></div></td>"
228
+                        . "<td><button class='more_info_b' id='info_b_".$d."'>i</button></td></tr>\n";
229 229
                 $deviceIndex++;
230 230
             }
231 231
             $retval .= "</tbody>";
@@ -239,15 +239,15 @@  discard block
 block discarded – undo
239 239
     }
240 240
 
241 241
     public function div_guess_os($operatingSystem) {
242
-        $vendorlogo = $this->Gui->skinObject->findResourceUrl("IMAGES", "vendorlogo/" . $operatingSystem['group'] . ".png");
242
+        $vendorlogo = $this->Gui->skinObject->findResourceUrl("IMAGES", "vendorlogo/".$operatingSystem['group'].".png");
243 243
         $vendorstyle = "";
244 244
         if ($vendorlogo !== FALSE) {
245
-            $vendorstyle = "style='background-image:url(\"" . $vendorlogo . "\")'";
245
+            $vendorstyle = "style='background-image:url(\"".$vendorlogo."\")'";
246 246
         }
247 247
         $deleteIcon = $this->Gui->skinObject->findResourceUrl("IMAGES", "icons/delete_32.png");
248 248
         $deleteImg = "";
249 249
         if ($deleteIcon !== FALSE) {
250
-            $deleteImg = "<img id='cross_icon_" . $operatingSystem['device'] . "' src='$deleteIcon' >";
250
+            $deleteImg = "<img id='cross_icon_".$operatingSystem['device']."' src='$deleteIcon' >";
251 251
         }
252 252
         return "
253 253
 <div class='sub_h' id='guess_os'>
@@ -255,23 +255,23 @@  discard block
 block discarded – undo
255 255
     <table id='browser'>
256 256
         <tr>
257 257
             <td>
258
-                <button class='large_button guess_os' $vendorstyle id='g_" . $operatingSystem['device'] . "'>
258
+                <button class='large_button guess_os' $vendorstyle id='g_".$operatingSystem['device']."'>
259 259
                     $deleteImg
260
-                    <div class='download_button_text_1' id='download_button_header_" . $operatingSystem['device'] . "'> " . $this->Gui->textTemplates->templates[user\DOWNLOAD_MESSAGE] . "
260
+                    <div class='download_button_text_1' id='download_button_header_".$operatingSystem['device']."'> ".$this->Gui->textTemplates->templates[user\DOWNLOAD_MESSAGE]."
261 261
                     </div>
262 262
                     <div class='download_button_text'>" .
263
-                $operatingSystem['display'] . "
263
+                $operatingSystem['display']."
264 264
                     </div>
265 265
                 </button>
266
-                <div class='device_info' id='info_g_" . $operatingSystem['device'] . "'></div>
266
+                <div class='device_info' id='info_g_" . $operatingSystem['device']."'></div>
267 267
           </td>
268 268
           <td style='vertical-align:top'>
269
-               <button class='more_info_b large_button' id='g_info_b_" . $operatingSystem['device'] . "'>i</button>
269
+               <button class='more_info_b large_button' id='g_info_b_" . $operatingSystem['device']."'>i</button>
270 270
           </td>
271 271
       </tr>
272 272
     </table> <!-- id='browser' -->
273 273
     <div class='sub_h'>
274
-       <a href='javascript:other_installers()'>" . $this->Gui->textTemplates->templates[user\DOWNLOAD_CHOOSE] . "</a>
274
+       <a href='javascript:other_installers()'>" . $this->Gui->textTemplates->templates[user\DOWNLOAD_CHOOSE]."</a>
275 275
     </div>
276 276
 </div> <!-- id='guess_os' -->";
277 277
     }
@@ -287,7 +287,7 @@  discard block
 block discarded – undo
287 287
             </td>";
288 288
 
289 289
         if (!empty(CONFIG['APPEARANCE']['privacy_notice_url'])) {
290
-            $retval .= "<td><a href='" . CONFIG['APPEARANCE']['privacy_notice_url'] . "'>" . sprintf(_("%s Privacy Notice"), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name']) . "</a></td>";
290
+            $retval .= "<td><a href='".CONFIG['APPEARANCE']['privacy_notice_url']."'>".sprintf(_("%s Privacy Notice"), CONFIG_CONFASSISTANT['CONSORTIUM']['display_name'])."</a></td>";
291 291
         }
292 292
         $retval .= "<td>";
293 293
         if (CONFIG_CONFASSISTANT['CONSORTIUM']['name'] == "eduroam" && isset(CONFIG_CONFASSISTANT['CONSORTIUM']['deployment-voodoo']) && CONFIG_CONFASSISTANT['CONSORTIUM']['deployment-voodoo'] == "Operations Team") {
Please login to merge, or discard this patch.