Inspection of "Add OpenRoaming Deployment button disabled" - GEANT/CAT - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 2c4441...b906e3 )

by Maja

created 2022-05-18 10:47 UTC

Status

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -26,7 +26,7 @@  discard block
 block discarded – undo
  */
 ?>
 <?php
-require_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
+require_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
 
 $deco = new \web\lib\admin\PageDecoration();
 $validator = new \web\lib\common\InputValidation();
@@ -40,10 +40,10 @@  discard block
 block discarded – undo
             ( $_POST['consortium'] == "OpenRoaming" && count($myfed->getAttributes("fed:openroaming")) > 0 )
             )
     ) {*/
-    if (isset($_POST['consortium']) &&  $_POST['consortium'] == "eduroam")
+    if (isset($_POST['consortium']) && $_POST['consortium'] == "eduroam")
     {
         $my_inst->newDeployment(\core\AbstractDeployment::DEPLOYMENTTYPE_MANAGED, $_POST['consortium']);
-        header("Location: overview_org.php?inst_id=" . $my_inst->identifier);
+        header("Location: overview_org.php?inst_id=".$my_inst->identifier);
         exit(0);
     } else {
         throw new Exception("Desired consortium for Managed SP needs to be specified, and allowed!");
@@ -100,19 +100,19 @@  discard block
 block discarded – undo
                 if (isset($_POST['agreement']) && $_POST['agreement'] == "true") {
                     $deployment->addAttribute("hiddenmanagedsp:tou_accepted", NULL, 1);
                 }
-                header("Location: overview_org.php?inst_id=" . $my_inst->identifier);
+                header("Location: overview_org.php?inst_id=".$my_inst->identifier);
                 exit(0);
             case web\lib\common\FormElements::BUTTON_DELETE:
                 $response = $deployment->setRADIUSconfig();
                 if (in_array('OK', $response)) {
                     $deployment->deactivate();
                 }
-                header("Location: overview_org.php?inst_id=" . $my_inst->identifier . '&' . urldecode(http_build_query($response)));
+                header("Location: overview_org.php?inst_id=".$my_inst->identifier.'&'.urldecode(http_build_query($response)));
                 exit(0);
             case web\lib\common\FormElements::BUTTON_REMOVESP:
                 error_log("MGW Remove deployment ".serialize($deployment));
                 $deployment->remove();
-                header("Location: overview_org.php?inst_id=" . $my_inst->identifier);
+                header("Location: overview_org.php?inst_id=".$my_inst->identifier);
                 exit(0);
             case web\lib\common\FormElements::BUTTON_ACTIVATE:
                 if (count($deployment->getAttributes("hiddenmanagedsp:tou_accepted")) > 0) {
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
                     if (in_array('OK', $response)) {
                         $deployment->activate();
                     }
-                    header("Location: overview_org.php?inst_id=" . $my_inst->identifier . '&' . urldecode(http_build_query($response)));
+                    header("Location: overview_org.php?inst_id=".$my_inst->identifier.'&'.urldecode(http_build_query($response)));
                     exit(0);
                 } else {
                     throw new Exception("Activate button pushed without acknowledged ToUs!");
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
                 } else {
                     $response = ['NOOP', 'NOOP'];
                 }
-                header("Location: overview_org.php?inst_id=" . $my_inst->identifier . '&' . urldecode(http_build_query($response)));
+                header("Location: overview_org.php?inst_id=".$my_inst->identifier.'&'.urldecode(http_build_query($response)));
                 exit(0);
             default:
                 throw new Exception("Unknown button action requested!");
@@ -158,10 +158,10 @@  discard block
 block discarded – undo
     if (isset($_POST['command'])) {
         switch ($_POST['command']) {
         case web\lib\common\FormElements::BUTTON_CLOSE:
-            header("Location: overview_org.php?inst_id=" . $my_inst->identifier);
+            header("Location: overview_org.php?inst_id=".$my_inst->identifier);
             exit(0);
         default:
-            header("Location: overview_org.php?inst_id=" . $my_inst->identifier);
+            header("Location: overview_org.php?inst_id=".$my_inst->identifier);
             exit(0);
         }
     }
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
     echo $uiElements->instLevelInfoBoxes($my_inst);
     $deploymentOptions = $deployment->getAttributes();
     echo "<form enctype='multipart/form-data' action='edit_hotspot.php?inst_id=$my_inst->identifier&amp;deployment_id=$deployment->identifier' method='post' accept-charset='UTF-8'>
-                <input type='hidden' name='MAX_FILE_SIZE' value='" . \config\Master::MAX_UPLOAD_SIZE . "'>";
+                <input type='hidden' name='MAX_FILE_SIZE' value='".\config\Master::MAX_UPLOAD_SIZE."'>";
     $optionDisplay = new \web\lib\admin\OptionDisplay($deploymentOptions, \core\Options::LEVEL_PROFILE);
     ?>
     <fieldset class='option_container' id='managedsp_override'>
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
                 <!-- input for VLAN identifier for home users-->
                 <td>
                     <span id='vlan_label'>
-                        <?php echo sprintf(_("VLAN tag for own users%s:"), ($vlan === NULL ? "" : " " . _("(unset with '0')"))); ?>
+                        <?php echo sprintf(_("VLAN tag for own users%s:"), ($vlan === NULL ? "" : " "._("(unset with '0')"))); ?>
                     </span>
                 </td>
                 <td>
@@ -242,7 +242,7 @@  discard block
 block discarded – undo
     </fieldset>
 
     <?php
-    echo "<p><button type='submit' name='submitbutton' value='" . web\lib\common\FormElements::BUTTON_SAVE . "'>" . _("Save data") . "</button><button type='button' class='delete' name='abortbutton' value='abort' onclick='javascript:window.location = \"overview_org.php?inst_id=$my_inst->identifier\"'>" . _("Discard changes") . "</button></p></form>";
+    echo "<p><button type='submit' name='submitbutton' value='".web\lib\common\FormElements::BUTTON_SAVE."'>"._("Save data")."</button><button type='button' class='delete' name='abortbutton' value='abort' onclick='javascript:window.location = \"overview_org.php?inst_id=$my_inst->identifier\"'>"._("Discard changes")."</button></p></form>";
     echo $deco->footer();
 
     
\ No newline at end of file

Please login to merge, or discard this patch.

		@@ -26,7 +26,7 @@ discard block
		block discarded – undo
26	26	*/
27	27	?>
28	28	<?php
29		-require_once dirname(dirname(dirname(__FILE__))) . "/config/_config.php";
	29	+require_once dirname(dirname(dirname(__FILE__)))."/config/_config.php";
30	30
31	31	$deco = new \web\lib\admin\PageDecoration();
32	32	$validator = new \web\lib\common\InputValidation();
		@@ -40,10 +40,10 @@ discard block
		block discarded – undo
40	40	( $_POST['consortium'] == "OpenRoaming" && count($myfed->getAttributes("fed:openroaming")) > 0 )
41	41	)
42	42	) {*/
43		- if (isset($_POST['consortium']) && $_POST['consortium'] == "eduroam")
	43	+ if (isset($_POST['consortium']) && $_POST['consortium'] == "eduroam")
44	44	{
45	45	$my_inst->newDeployment(\core\AbstractDeployment::DEPLOYMENTTYPE_MANAGED, $_POST['consortium']);
46		- header("Location: overview_org.php?inst_id=" . $my_inst->identifier);
	46	+ header("Location: overview_org.php?inst_id=".$my_inst->identifier);
47	47	exit(0);
48	48	} else {
49	49	throw new Exception("Desired consortium for Managed SP needs to be specified, and allowed!");
		@@ -100,19 +100,19 @@ discard block
		block discarded – undo
100	100	if (isset($_POST['agreement']) && $_POST['agreement'] == "true") {
101	101	$deployment->addAttribute("hiddenmanagedsp:tou_accepted", NULL, 1);
102	102	}
103		- header("Location: overview_org.php?inst_id=" . $my_inst->identifier);
	103	+ header("Location: overview_org.php?inst_id=".$my_inst->identifier);
104	104	exit(0);
105	105	case web\lib\common\FormElements::BUTTON_DELETE:
106	106	$response = $deployment->setRADIUSconfig();
107	107	if (in_array('OK', $response)) {
108	108	$deployment->deactivate();
109	109	}
110		- header("Location: overview_org.php?inst_id=" . $my_inst->identifier . '&' . urldecode(http_build_query($response)));
	110	+ header("Location: overview_org.php?inst_id=".$my_inst->identifier.'&'.urldecode(http_build_query($response)));
111	111	exit(0);
112	112	case web\lib\common\FormElements::BUTTON_REMOVESP:
113	113	error_log("MGW Remove deployment ".serialize($deployment));
114	114	$deployment->remove();
115		- header("Location: overview_org.php?inst_id=" . $my_inst->identifier);
	115	+ header("Location: overview_org.php?inst_id=".$my_inst->identifier);
116	116	exit(0);
117	117	case web\lib\common\FormElements::BUTTON_ACTIVATE:
118	118	if (count($deployment->getAttributes("hiddenmanagedsp:tou_accepted")) > 0) {
		@@ -120,7 +120,7 @@ discard block
		block discarded – undo
120	120	if (in_array('OK', $response)) {
121	121	$deployment->activate();
122	122	}
123		- header("Location: overview_org.php?inst_id=" . $my_inst->identifier . '&' . urldecode(http_build_query($response)));
	123	+ header("Location: overview_org.php?inst_id=".$my_inst->identifier.'&'.urldecode(http_build_query($response)));
124	124	exit(0);
125	125	} else {
126	126	throw new Exception("Activate button pushed without acknowledged ToUs!");
		@@ -149,7 +149,7 @@ discard block
		block discarded – undo
149	149	} else {
150	150	$response = ['NOOP', 'NOOP'];
151	151	}
152		- header("Location: overview_org.php?inst_id=" . $my_inst->identifier . '&' . urldecode(http_build_query($response)));
	152	+ header("Location: overview_org.php?inst_id=".$my_inst->identifier.'&'.urldecode(http_build_query($response)));
153	153	exit(0);
154	154	default:
155	155	throw new Exception("Unknown button action requested!");
		@@ -158,10 +158,10 @@ discard block
		block discarded – undo
158	158	if (isset($_POST['command'])) {
159	159	switch ($_POST['command']) {
160	160	case web\lib\common\FormElements::BUTTON_CLOSE:
161		- header("Location: overview_org.php?inst_id=" . $my_inst->identifier);
	161	+ header("Location: overview_org.php?inst_id=".$my_inst->identifier);
162	162	exit(0);
163	163	default:
164		- header("Location: overview_org.php?inst_id=" . $my_inst->identifier);
	164	+ header("Location: overview_org.php?inst_id=".$my_inst->identifier);
165	165	exit(0);
166	166	}
167	167	}
		@@ -188,7 +188,7 @@ discard block
		block discarded – undo
188	188	echo $uiElements->instLevelInfoBoxes($my_inst);
189	189	$deploymentOptions = $deployment->getAttributes();
190	190	echo "<form enctype='multipart/form-data' action='edit_hotspot.php?inst_id=$my_inst->identifier&deployment_id=$deployment->identifier' method='post' accept-charset='UTF-8'>
191		- <input type='hidden' name='MAX_FILE_SIZE' value='" . \config\Master::MAX_UPLOAD_SIZE . "'>";
	191	+ <input type='hidden' name='MAX_FILE_SIZE' value='".\config\Master::MAX_UPLOAD_SIZE."'>";
192	192	$optionDisplay = new \web\lib\admin\OptionDisplay($deploymentOptions, \core\Options::LEVEL_PROFILE);
193	193	?>
194	194	<fieldset class='option_container' id='managedsp_override'>
		@@ -222,7 +222,7 @@ discard block
		block discarded – undo
222	222	<!-- input for VLAN identifier for home users-->
223	223	<td>
224	224	<span id='vlan_label'>
225		- <?php echo sprintf(_("VLAN tag for own users%s:"), ($vlan === NULL ? "" : " " . _("(unset with '0')"))); ?>
	225	+ <?php echo sprintf(_("VLAN tag for own users%s:"), ($vlan === NULL ? "" : " "._("(unset with '0')"))); ?>
226	226	</span>
227	227	</td>
228	228	<td>
		@@ -242,7 +242,7 @@ discard block
		block discarded – undo
242	242	</fieldset>
243	243
244	244	<?php
245		- echo "<p><button type='submit' name='submitbutton' value='" . web\lib\common\FormElements::BUTTON_SAVE . "'>" . _("Save data") . "</button><button type='button' class='delete' name='abortbutton' value='abort' onclick='javascript:window.location = \"overview_org.php?inst_id=$my_inst->identifier\"'>" . _("Discard changes") . "</button></p></form>";
	245	+ echo "<p><button type='submit' name='submitbutton' value='".web\lib\common\FormElements::BUTTON_SAVE."'>"._("Save data")."</button><button type='button' class='delete' name='abortbutton' value='abort' onclick='javascript:window.location = \"overview_org.php?inst_id=$my_inst->identifier\"'>"._("Discard changes")."</button></p></form>";
246	246	echo $deco->footer();
247	247
248	248
249	249	\ No newline at end of file

GEANT / CAT

Push — master ( 2c4441...b906e3 )

Status

Category

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch